Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Orlando (Orlando Cazalet-Hyams)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2019, 8:58 AM (235 w, 1 d)

Recent Activity

Fri, Sep 22

Orlando added a comment to D153990: [DebugInfo][RemoveDIs] Add prototype storage classes for non-instruction variable debug-info.

Code changes LGTM pending inline comments. I haven't looked at the tests yet.

Fri, Sep 22, 9:43 AM · debug-info, Restricted Project, Restricted Project
Orlando accepted D153777: [ADT][DebugInfo][RemoveDIs] Permit extra flags in ilist_iterator's for communicating debug-info facts.

LGTM (pending clang-formatting if not already, plus a few nits).

Fri, Sep 22, 8:30 AM · debug-info, Restricted Project, Restricted Project

Tue, Sep 12

Orlando added a comment to D159485: [DebugInfo][RemoveDIs] Use getStableDebugLoc when picking IRBuilder source locations.

Thanks @scott.linder

Tue, Sep 12, 8:07 AM · Restricted Project, Restricted Project

Mon, Sep 11

Orlando accepted D159485: [DebugInfo][RemoveDIs] Use getStableDebugLoc when picking IRBuilder source locations.

(forgot to hit Accept)

Mon, Sep 11, 7:28 AM · Restricted Project, Restricted Project
Orlando added a comment to D159485: [DebugInfo][RemoveDIs] Use getStableDebugLoc when picking IRBuilder source locations.

LGTM, including agreeing with your assessment of and changes to llvm/test/CodeGen/AMDGPU/llvm.dbg.value.ll (comments from @arsenm or @scott.linder to confirm would still be welcome of course, if either of you have the bandwidth)

Mon, Sep 11, 7:26 AM · Restricted Project, Restricted Project

Fri, Sep 8

Orlando accepted D152545: [NFC][DebugInfo][RemoveDIs] Provide an iterator-taking split-block method.

LGTM (with formatting nits)

Fri, Sep 8, 2:00 AM · Restricted Project, Restricted Project
Orlando accepted D152543: [NFC][DebugInfo][RemoveDIs] Prefer iterators over instruction pointers in instcombine.

LGTM

Fri, Sep 8, 1:43 AM · Restricted Project, Restricted Project
Orlando accepted D152537: [NFC][DebugInfo][RemoveDIs] Prefer insert-with-iterator over instruction pointers when inserting into blocks.

There are a load of getFirstNonPHI() -> getFirstInsertionPt() that I think should be getFirstNonPHI() -> getFirstNonPHIIt() (marked inlined) based on the discussion in D152468, otherwise LGTM.

Fri, Sep 8, 1:40 AM · Restricted Project, Restricted Project
Orlando added a comment to D152468: [NFC][DebugInfo][RemoveDIs] Use iterators over instruction pointers when using IRBuilder in various passes.

Still LGTM

Fri, Sep 8, 12:59 AM · Restricted Project, Restricted Project

Tue, Sep 5

Orlando accepted D152534: [NFC][DebugInfo][RemoveDIs] Use moveBeforePreserving when transforms intend to move dbg.values.

LGTM

Tue, Sep 5, 7:27 AM · Restricted Project, Restricted Project
Orlando accepted D152468: [NFC][DebugInfo][RemoveDIs] Use iterators over instruction pointers when using IRBuilder in various passes.

LGTM (with a few nits)

Tue, Sep 5, 1:12 AM · Restricted Project, Restricted Project

Fri, Sep 1

Orlando added inline comments to D157615: [ExtendLifetimes][1/4] Add "disable-post-ra" function attribute to disable the post-regalloc scheduler.
Fri, Sep 1, 8:50 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Aug 22 2023

Orlando added inline comments to D157615: [ExtendLifetimes][1/4] Add "disable-post-ra" function attribute to disable the post-regalloc scheduler.
Aug 22 2023, 1:16 PM · Restricted Project, Restricted Project, Restricted Project, debug-info
Orlando accepted D158185: [DebugInfo] Process single-location debug values in variadic form when producing DWARF.

LGTM too with some inline nits/questions.

Aug 22 2023, 6:57 AM · Restricted Project, Restricted Project, debug-info

Aug 7 2023

Orlando added a comment to D157158: Do not merge debug locations when sinking instructions.

The result of this change is that debug locations are preserved after sinking. I think this is a situation where the docs specify that we should not preserve the source location of an instruction. Here is an excerpt from the linked doc explaining when we should preserve debug info:

Aug 7 2023, 2:36 AM · Restricted Project, Restricted Project

Jul 28 2023

Orlando added a comment to D153990: [DebugInfo][RemoveDIs] Add prototype storage classes for non-instruction variable debug-info.

I started reviewing this but didn't have time to finish it. For fear of losing my comments I'll post what I've got so far. Note to self: start at Instruction.h.

Jul 28 2023, 9:29 AM · debug-info, Restricted Project, Restricted Project
Orlando added a comment to D156545: [DebugInfo][InstrRef] Don't produce over-sized DW_OP_deref_size expressions for very wide stack spills.

Just a couple of inline nits/questions from me.

Jul 28 2023, 8:26 AM · Restricted Project, Restricted Project

Jul 24 2023

Orlando added a comment to D152534: [NFC][DebugInfo][RemoveDIs] Use moveBeforePreserving when transforms intend to move dbg.values.

The mechanical change itself LGTM.

Jul 24 2023, 7:12 AM · Restricted Project, Restricted Project
Orlando added a comment to D152468: [NFC][DebugInfo][RemoveDIs] Use iterators over instruction pointers when using IRBuilder in various passes.

The changes from getFirstNonPHI to getFirstInsertionPt make me worry that this isn't NFC as it looks like the latter skips past EH instructions.

Jul 24 2023, 6:15 AM · Restricted Project, Restricted Project

Jun 28 2023

Orlando added a comment to D153950: Reset NoPHI MachineFunction property in X86CmovConversion.

The pass inserts a PHI, so needs to reset the NoPHIs property - makes sense. The property reset could be taken out of the loop and put under a conditional if (MIItBegin != MIItEnd) - I'd leave that as optional though, because I imagine it makes very little difference in practice.

Jun 28 2023, 2:41 AM · Restricted Project, Restricted Project
Orlando committed rG63565981a272: Reapply "[DebugInfo][InstrRef] Instrument x86 CMOV conversion to preserve… (authored by jmorse).
Reapply "[DebugInfo][InstrRef] Instrument x86 CMOV conversion to preserve…
Jun 28 2023, 2:40 AM · Restricted Project, Restricted Project
Orlando committed rG03adc5f16fdd: Reset NoPHI MachineFunction property in X86CmovConversion (authored by Orlando).
Reset NoPHI MachineFunction property in X86CmovConversion
Jun 28 2023, 2:40 AM · Restricted Project, Restricted Project
Orlando closed D153950: Reset NoPHI MachineFunction property in X86CmovConversion.
Jun 28 2023, 2:40 AM · Restricted Project, Restricted Project
Orlando added a comment to D145565: [DebugInfo][InstrRef] Instrument x86 CMOV conversion to preserve variable values.

The verifier issue should be fixed in D153950. Slightly surprised that this test is the first to find the issue... grepping for x86-cmov-conversion in llvm/test only shows this new test.

Jun 28 2023, 1:18 AM · Restricted Project, Restricted Project
Orlando requested review of D153950: Reset NoPHI MachineFunction property in X86CmovConversion.
Jun 28 2023, 1:15 AM · Restricted Project, Restricted Project

Jun 27 2023

Orlando committed rG2325e0112ae7: [DebugInfo][InstrRef] Instrument x86 CMOV conversion to preserve variable values (authored by jmorse).
[DebugInfo][InstrRef] Instrument x86 CMOV conversion to preserve variable values
Jun 27 2023, 7:38 AM · Restricted Project, Restricted Project
Orlando closed D145565: [DebugInfo][InstrRef] Instrument x86 CMOV conversion to preserve variable values.
Jun 27 2023, 7:38 AM · Restricted Project, Restricted Project

Jun 13 2023

Orlando added a reverting change for rG9e7f14a8211c: Revert "Reapply D146987 "[Assignment Tracking] Enable by default"": rGde6da6ad55d3: Reapply D146987 "[Assignment Tracking] Enable by default".
Jun 13 2023, 4:45 AM · Restricted Project, Restricted Project
Orlando committed rGde6da6ad55d3: Reapply D146987 "[Assignment Tracking] Enable by default" (authored by Orlando).
Reapply D146987 "[Assignment Tracking] Enable by default"
Jun 13 2023, 4:45 AM · Restricted Project, Restricted Project
Orlando added a comment to D146987: [Assignment Tracking] Enable by default.

Looks like this is causing a crash on current main: https://github.com/llvm/llvm-project/issues/62838

Jun 13 2023, 4:43 AM · Restricted Project, debug-info, Restricted Project
Orlando committed rG772847af2a12: [NFC] Combine several DW_AT_const_value tests (authored by Orlando).
[NFC] Combine several DW_AT_const_value tests
Jun 13 2023, 4:16 AM · Restricted Project, Restricted Project
Orlando closed D152719: [NFC] Combine several DW_AT_const_value tests.
Jun 13 2023, 4:16 AM · Restricted Project, Restricted Project, debug-info

Jun 12 2023

Orlando committed rG9dcae2f524e7: [DebugInfo] Add DW_ATE_complex_float case to assert in isUnsignedDIType (authored by Orlando).
[DebugInfo] Add DW_ATE_complex_float case to assert in isUnsignedDIType
Jun 12 2023, 9:10 AM · Restricted Project, Restricted Project
Orlando closed D151795: [DebugInfo] Add DW_ATE_complex_float case to assert in isUnsignedDIType.
Jun 12 2023, 9:10 AM · Restricted Project, debug-info, Restricted Project
Orlando requested review of D152719: [NFC] Combine several DW_AT_const_value tests.
Jun 12 2023, 9:03 AM · Restricted Project, Restricted Project, debug-info

Jun 9 2023

Orlando updated the diff for D151795: [DebugInfo] Add DW_ATE_complex_float case to assert in isUnsignedDIType.

+ Added more CHECK lines to the test

Jun 9 2023, 12:37 AM · Restricted Project, debug-info, Restricted Project

Jun 8 2023

Orlando added a comment to D151795: [DebugInfo] Add DW_ATE_complex_float case to assert in isUnsignedDIType.

ping

Jun 8 2023, 4:03 AM · Restricted Project, debug-info, Restricted Project

Jun 1 2023

Orlando added inline comments to D151795: [DebugInfo] Add DW_ATE_complex_float case to assert in isUnsignedDIType.
Jun 1 2023, 2:35 AM · Restricted Project, debug-info, Restricted Project
Orlando updated the diff for D151795: [DebugInfo] Add DW_ATE_complex_float case to assert in isUnsignedDIType.

+ address review comments

Jun 1 2023, 2:34 AM · Restricted Project, debug-info, Restricted Project

May 31 2023

Orlando added a comment to D146987: [Assignment Tracking] Enable by default.

Hey, found another error that occurs when building Android that looks to be different from @MaskRay's revert.
...

May 31 2023, 4:36 AM · Restricted Project, debug-info, Restricted Project
Orlando requested review of D151795: [DebugInfo] Add DW_ATE_complex_float case to assert in isUnsignedDIType.
May 31 2023, 4:35 AM · Restricted Project, debug-info, Restricted Project
Orlando committed rGf40e8f14d623: [Assignment Tracking] Ignore stores to a negative offset from an alloca (authored by Orlando).
[Assignment Tracking] Ignore stores to a negative offset from an alloca
May 31 2023, 3:18 AM · Restricted Project, Restricted Project
Orlando closed D151326: [Assignment Tracking] Ignore stores to a negative offset from an alloca.
May 31 2023, 3:17 AM · Restricted Project, debug-info, Restricted Project

May 24 2023

Orlando accepted D150577: [CodeGen] Fix for MachineBasicBlock::rfindDebugLoc(instr_rend()).

That's reasonable, and option 1 still looks good to me given what we've discussed, so LGTM. Thanks!

May 24 2023, 8:43 AM · Restricted Project, Restricted Project
Orlando added a comment to D151326: [Assignment Tracking] Ignore stores to a negative offset from an alloca.

Great, thanks for the review.

May 24 2023, 6:51 AM · Restricted Project, debug-info, Restricted Project
Orlando added a comment to D151326: [Assignment Tracking] Ignore stores to a negative offset from an alloca.

The llvm.org/PR123-style link in the patch summary doesn't seem to work. Perhaps for GitHub-only issues you need to use a direct link like https://github.com/llvm/llvm-project/issues/62838?

May 24 2023, 6:41 AM · Restricted Project, debug-info, Restricted Project
Orlando updated the summary of D151326: [Assignment Tracking] Ignore stores to a negative offset from an alloca.
May 24 2023, 6:32 AM · Restricted Project, debug-info, Restricted Project
Orlando requested review of D151326: [Assignment Tracking] Ignore stores to a negative offset from an alloca.
May 24 2023, 6:13 AM · Restricted Project, debug-info, Restricted Project

May 18 2023

Orlando committed rG6c088972d282: [DebugInfo][SelectionDAG] Do not drop dbg intrinsics with empty metadata locs (authored by Orlando).
[DebugInfo][SelectionDAG] Do not drop dbg intrinsics with empty metadata locs
May 18 2023, 2:10 AM · Restricted Project, Restricted Project
Orlando closed D150767: [DebugInfo][SelectionDAG] Do not drop dbg intrinsics with empty metadata locs.
May 18 2023, 2:09 AM · debug-info, Restricted Project, Restricted Project

May 17 2023

Orlando added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

It might be worth posting your question on discourse in the LLDB subcategory for greater visibility.

May 17 2023, 10:08 AM · Restricted Project, Restricted Project
Orlando added a comment to D150767: [DebugInfo][SelectionDAG] Do not drop dbg intrinsics with empty metadata locs.

Thanks. Yep they are dropped, causing locations terminated by the dbg.value to no longer be terminated; incorrectly extending coverage of the preceding variable location. (EDIT: That's the behaviour without this patch, to be clear).

May 17 2023, 4:11 AM · debug-info, Restricted Project, Restricted Project
Orlando requested review of D150767: [DebugInfo][SelectionDAG] Do not drop dbg intrinsics with empty metadata locs.
May 17 2023, 3:53 AM · debug-info, Restricted Project, Restricted Project

May 16 2023

Orlando added a reviewer for D150577: [CodeGen] Fix for MachineBasicBlock::rfindDebugLoc(instr_rend()): debug-info.

Hi @bjope

Is there a reason that findDebugLoc and rfindDebugLoc call skipDebugInstructionsForward / skipDebugInstructionsBackward rather than next_nodbg / prev_nodbg. It looks like calling the nodbg functions could solve the problem (the end-iterator-dereference) too, with no new code, but I am not certain of that without testing it.

The findDebugLoc and rfindDebugLoc functions are taking the DebugLoc from the MI pointed to by the iterator, if that MI fulfil the requirements. So they kind of do "skip-debug + examine MI + step-iterator", while the findPrev variants do "step-iterator + skip-debug + examine MI". The next_nodbg / prev_nodbg is a short form for doing "step + skip", so in order to use them one would need to rewrite the code a bit more.

It had perhaps been more interesting to have helpers for scanning forward/backward, and doing pre/post increment. That would give four different variants. Now we got two variants that scan forward doing post-increment. And two variants that scan backwards doing pre-increment. I got a bit confused about that for awhile (and it is not that easy to understand what prev/next, first/last, forward/backward etc means when having variants using both iterators and reverse iterators). One idea with the unittests I added is to actuallly show what happens when using those helpers (even if one still would need to add some debug instructions to make those tests even more complete).

May 16 2023, 7:49 AM · Restricted Project, Restricted Project
Orlando added a comment to D143463: [X86] Use the CFA when appropriate for better variable locations around calls..

If you're testing the API you might need -DLLDB_ENABLE_PYTHON=On too which enables the LLDB python bindings. That option is present in the Cmake step of the logs. (Not an LLDB dev, just passing by).

May 16 2023, 5:56 AM · Restricted Project, Restricted Project
Orlando added a comment to D150577: [CodeGen] Fix for MachineBasicBlock::rfindDebugLoc(instr_rend()).

As I understand it, this change means the behaviour of rfindDebugLoc when given instr_rend() is now similar to the existing behaviour of findPrevDebugLoc when given instr_end(). findPrevDebugLoc calls prev_nodbg (code) which decrements the iterator before calling skipDebugInstructionsBackward. I.e. In both cases an end iterator is valid input and will not be dereferenced. (SGTM)

May 16 2023, 4:25 AM · Restricted Project, Restricted Project

May 5 2023

Orlando committed rGf9dba933c6de: [Assignment Tracking] Skip scalable vectors in declare-to-assign pass (authored by Orlando).
[Assignment Tracking] Skip scalable vectors in declare-to-assign pass
May 5 2023, 10:08 AM · Restricted Project, Restricted Project
Orlando closed D149959: [Assignment Tracking] Skip scalable vectors in declare-to-assign pass.
May 5 2023, 10:07 AM · Restricted Project, Restricted Project
Orlando added a comment to D146987: [Assignment Tracking] Enable by default.

That should be fixed with D149959

May 5 2023, 7:14 AM · Restricted Project, debug-info, Restricted Project
Orlando requested review of D149959: [Assignment Tracking] Skip scalable vectors in declare-to-assign pass.
May 5 2023, 7:13 AM · Restricted Project, Restricted Project
Orlando added a comment to D146987: [Assignment Tracking] Enable by default.

Thanks for the reproducer and report! I'll have a patch up for this shortly.

May 5 2023, 6:55 AM · Restricted Project, debug-info, Restricted Project

May 3 2023

Orlando added a comment to D149682: [SelectionDAG][NFCI] Use common logic for identifying MMI vars.

Nice, that's much better!

May 3 2023, 1:42 AM · Restricted Project, Restricted Project

Apr 28 2023

Orlando added a comment to D146987: [Assignment Tracking] Enable by default.

I've just landed this again.

Apr 28 2023, 3:40 AM · Restricted Project, debug-info, Restricted Project
Orlando added a reverting change for rG0ba922f60046: Revert "Reapply D146987 "[Assignment Tracking] Enable by default"": rG8dec295af035: Reapply D146987 "[Assignment Tracking] Enable by default".
Apr 28 2023, 3:39 AM · Restricted Project, Restricted Project
Orlando committed rG8dec295af035: Reapply D146987 "[Assignment Tracking] Enable by default" (authored by Orlando).
Reapply D146987 "[Assignment Tracking] Enable by default"
Apr 28 2023, 3:39 AM · Restricted Project, Restricted Project
Orlando committed rG9391177cbcb0: [Assignment Tracking] Check getTypeSizeInBits result for scalable vector types (authored by Orlando).
[Assignment Tracking] Check getTypeSizeInBits result for scalable vector types
Apr 28 2023, 1:12 AM · Restricted Project, Restricted Project
Orlando added a comment to D149137: [Assignment Tracking] Check getTypeSizeInBits result for scalable vector types.

Thanks!

Apr 28 2023, 1:12 AM · Restricted Project, Restricted Project
Orlando closed D149137: [Assignment Tracking] Check getTypeSizeInBits result for scalable vector types.
Apr 28 2023, 1:12 AM · Restricted Project, Restricted Project

Apr 27 2023

Orlando added reviewers for D149294: Do not optimize debug locations across section boundaries: debug-info, dblaikie, probinson.

This seems sensible and the test looks good. I've added other reviewers who might want to take a look.

Apr 27 2023, 9:39 AM · Restricted Project, Restricted Project, debug-info
Orlando abandoned D140900: [DebugInfo] Print empty MDTuples wrapped in MetadataAsValue inline.

Abandoning this (see previous comment)

Apr 27 2023, 8:03 AM · debug-info, Restricted Project, Restricted Project
Orlando reopened D140900: [DebugInfo] Print empty MDTuples wrapped in MetadataAsValue inline.
Apr 27 2023, 8:02 AM · debug-info, Restricted Project, Restricted Project
Orlando added a comment to D149335: [DebugInfo][InstCombine] Fix missing source and variable locations after foldOpIntoPhi.

Nice catch!

Apr 27 2023, 5:58 AM · Restricted Project, Restricted Project, debug-info
Orlando committed rGbd1109307ad1: [DebugInfo][InstCombine] Fix missing source and variable locations after… (authored by Orlando).
[DebugInfo][InstCombine] Fix missing source and variable locations after…
Apr 27 2023, 5:57 AM · Restricted Project, Restricted Project
Orlando closed D149335: [DebugInfo][InstCombine] Fix missing source and variable locations after foldOpIntoPhi.
Apr 27 2023, 5:56 AM · Restricted Project, Restricted Project, debug-info
Orlando added inline comments to D149137: [Assignment Tracking] Check getTypeSizeInBits result for scalable vector types.
Apr 27 2023, 5:41 AM · Restricted Project, Restricted Project
Orlando updated the diff for D149137: [Assignment Tracking] Check getTypeSizeInBits result for scalable vector types.

+ Address review comment

Apr 27 2023, 5:41 AM · Restricted Project, Restricted Project
Orlando requested review of D149335: [DebugInfo][InstCombine] Fix missing source and variable locations after foldOpIntoPhi.
Apr 27 2023, 5:19 AM · Restricted Project, Restricted Project, debug-info

Apr 26 2023

Orlando added a comment to D146987: [Assignment Tracking] Enable by default.

@jmorse Sorry it took me a bit to set up, but I ran an experiment in our CI that reverted the change that disabled this as default and tried it for x86. It looks like this patch is working OK for us now: https://ci.chromium.org/raw/build/logs.chromium.org/fuchsia/led/paulkirth_google.com/df38ff794f44284ff34f63e5dc1f1d41b25225b1241c14eff15a9f0a4b189afb/+/build.proto?server=chromium-swarm.appspot.com

I'm reasonably confident that should mean you won't run into issues. The caveat here is that I can't easily launch experiments across all combinations of platforms and hardware, so it's possible there may still be an issue. I think that's unlikely given how this has been manifesting, so I'd say you're good to try again in our perspective.

Apr 26 2023, 9:58 AM · Restricted Project, debug-info, Restricted Project
Orlando added a comment to D140990: [DebugInfo] Treat empty metadata operands the same as undef operands in SelectionDAG.

Most curious.... I'm not sure off the top of my head why that'd be the case (either the issue or the fact that D140901 fixies it). SelectionDAG has a load of weird edge cases with debug info handling though. Thanks for looking into this, is there anything I can do to help?

Apr 26 2023, 8:24 AM · Restricted Project, Restricted Project, debug-info
Orlando committed rGac6e177ce60e: [Assignment Tracking] Remove overly defensive AllocaInst assertion (authored by Orlando).
[Assignment Tracking] Remove overly defensive AllocaInst assertion
Apr 26 2023, 3:25 AM · Restricted Project, Restricted Project
Orlando closed D149135: [Assignment Tracking] Remove overly defensive AllocaInst assertion.
Apr 26 2023, 3:25 AM · Restricted Project, Restricted Project
Orlando added a comment to D149135: [Assignment Tracking] Remove overly defensive AllocaInst assertion.

Thanks

Apr 26 2023, 3:22 AM · Restricted Project, Restricted Project
Orlando committed rGb59d672ed489: [Assignment Tracking] Fix faulty assertion inside std::sort predicate (authored by Orlando).
[Assignment Tracking] Fix faulty assertion inside std::sort predicate
Apr 26 2023, 3:15 AM · Restricted Project, Restricted Project
Orlando closed D149045: [Assignment Tracking] Fix faulty assertion inside std::sort predicate.
Apr 26 2023, 3:15 AM · Restricted Project, Restricted Project
Orlando committed rGa0183c205c07: Fix docs bot after D140989 (authored by Orlando).
Fix docs bot after D140989
Apr 26 2023, 2:52 AM · Restricted Project, Restricted Project
Orlando added a comment to D140989: [DebugInfo] Update SourceLevelDebugging.rst to better explain kill locations.

Thanks everyone for reviewing this (and the rest of the stack), sorry it has taken a while to get these landed!

Apr 26 2023, 2:34 AM · debug-info, Restricted Project, Restricted Project
Orlando committed rGa93c42397193: [DebugInfo] Update SourceLevelDebugging.rst to better explain kill locations (authored by Orlando).
[DebugInfo] Update SourceLevelDebugging.rst to better explain kill locations
Apr 26 2023, 2:33 AM · Restricted Project, Restricted Project
Orlando closed D140989: [DebugInfo] Update SourceLevelDebugging.rst to better explain kill locations.
Apr 26 2023, 2:33 AM · debug-info, Restricted Project, Restricted Project
Orlando committed rGc604a2c2c076: Fix buildbots after D140901 (authored by Orlando).
Fix buildbots after D140901
Apr 26 2023, 2:27 AM · Restricted Project, Restricted Project
Orlando committed rG3feea34d77f6: [DebugInfo] Do not delete debug intrinsics with empty metadata operands (authored by Orlando).
[DebugInfo] Do not delete debug intrinsics with empty metadata operands
Apr 26 2023, 1:59 AM · Restricted Project, Restricted Project
Orlando closed D140901: [DebugInfo] Do not delete debug intrinsics with empty metadata operands.
Apr 26 2023, 1:58 AM · Restricted Project, Restricted Project, debug-info
Orlando committed rG2b3c13b7166b: [DebugInfo] Treat empty metadata operands the same as undef operands in… (authored by Orlando).
[DebugInfo] Treat empty metadata operands the same as undef operands in…
Apr 26 2023, 1:04 AM · Restricted Project, Restricted Project
Orlando closed D140990: [DebugInfo] Treat empty metadata operands the same as undef operands in SelectionDAG.
Apr 26 2023, 1:03 AM · Restricted Project, Restricted Project, debug-info

Apr 25 2023

Orlando committed rGee371b2566ee: [DebugInfo] Treat empty metadata operands the same as undef operands (authored by Orlando).
[DebugInfo] Treat empty metadata operands the same as undef operands
Apr 25 2023, 9:18 AM · Restricted Project, Restricted Project
Orlando closed D140902: [DebugInfo] Treat empty metadata operands the same as undef operands.
Apr 25 2023, 9:18 AM · Restricted Project, Restricted Project, debug-info
Orlando committed rG65d71ee3cfa7: [DebugInfo] Replace UndefValue with PoisonValue in DIArgList… (authored by Orlando).
[DebugInfo] Replace UndefValue with PoisonValue in DIArgList…
Apr 25 2023, 8:20 AM · Restricted Project, Restricted Project
Orlando closed D140991: [DebugInfo] Replace UndefValue with PoisonValue in DIArgList::handleChangedOperand.
Apr 25 2023, 8:20 AM · Restricted Project, Restricted Project, debug-info
Orlando added a comment to D140900: [DebugInfo] Print empty MDTuples wrapped in MetadataAsValue inline.

This patch prints the tuple as !{} even if it's distinct, which I thought was reasonable when writing the patch. If a distinct empty tuple is used multiple times or is attached to multiple instructions however it might be useful to have the metadata ID printed, to make debugging easier.

Apr 25 2023, 7:18 AM · debug-info, Restricted Project, Restricted Project
Orlando added a comment to D140900: [DebugInfo] Print empty MDTuples wrapped in MetadataAsValue inline.

Thanks for the heads up @thakis. Looks like there are simply some more tests that need updating to the new formatting, but I've reverted for now as it tripped several bots.

Apr 25 2023, 6:40 AM · debug-info, Restricted Project, Restricted Project
Orlando added a reverting change for rG1e6fe677f8aa: [DebugInfo] Print empty MDTuples wrapped in MetadataAsValue inline: rG72776850ed81: Revert "[DebugInfo] Print empty MDTuples wrapped in MetadataAsValue inline".
Apr 25 2023, 6:38 AM · Restricted Project, Restricted Project