- User Since
- Mar 28 2019, 8:58 AM (12 w, 3 h)
Thanks, I've now resubmitted this patch (1251cac62af5).
Tue, Jun 18
LGTM. Thanks for doing this!
Mon, Jun 17
Wed, Jun 12
No problem at all - reverted with rGa94715639619. I'll take a look at this next week, thank you for the info.
Tue, Jun 11
Tue, May 28
The major change to this previously accepted patch is the modification of "bcmp-debugify-remarks.ll" and "inlined-argument.ll".
Minor changes include spelling corrections in comments and removing some superfluous debug data from the new tests.
May 20 2019
Resubmitted in rL361149.
Reverted with commit 95805bc425b because armv8 build bots are failing.
May 16 2019
Address suggestions and add some const correctness.
May 15 2019
May 14 2019
This update addresses the problems with the original patch that caused the built bot failures
(sorry about that!).
May 7 2019
May 2 2019
Hi, I added a few inline comments, mostly just nits on style.
Apr 30 2019
My take-away from the discussion was this: It is desirable to map the instructions to something in the loop (e.g., not line 0), unless doing so will provide confusing information to the mapping that PGO uses to optimize the relevant branches. Am I correct in saying that this latter issue is of minimal concern in this case?
Apr 29 2019
A summary of the discussion so far:
Apr 18 2019
Are the function attributes in the test necessary? Watching other reviews leads me to believe these are undesirable. Apart from this it LGTMy untrained eyes (I'm new to reviewing!).
Sorry, I missed a couple of failing tests. I've fixed them and updated the diff.
Apr 17 2019
Apr 12 2019
I've made the suggested changes.
Apr 11 2019
Apr 2 2019
Updated a comment with some more info as vsk suggested.
Apr 1 2019
The test has been updated to check for the expected instructions.
I've updated the test to include the source and commands to generate the IR it uses. Please note that I stripped out the call void @llvm.dbg.* lines from the test file by hand so any regenerated IR will look more cluttered.