Page MenuHomePhabricator

Orlando (Orlando Cazalet-Hyams)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2019, 8:58 AM (42 w, 1 d)

Recent Activity

Thu, Jan 16

Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Thanks @djtodoro for looking at this. Sorry for this really delayed response!

Thu, Jan 16, 8:19 AM · Restricted Project, debug-info

Mon, Jan 13

Orlando added inline comments to D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Mon, Jan 13, 7:34 AM · debug-info, Restricted Project

Dec 13 2019

Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Hi, sorry for the slow update.

Dec 13 2019, 8:06 AM · Restricted Project, debug-info

Dec 11 2019

Orlando updated subscribers of D71350: [MachineScheduler] Reorder cfi to avoid PostRA scheduling differences.

As far as I understand it I don't think it is safe to move CFI_INSTRUCTIONs
around like this. CFI_INSTRUCTIONs describe the effect of specific instructions.
We encode where this 'description' starts by the position of the CFI_INSTRUCTION
in the instruction stream. So, if you move the CFI_INSTRUCTION like this you
are changing the meaning.

Dec 11 2019, 6:54 AM · Restricted Project

Dec 6 2019

Orlando added inline comments to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.
Dec 6 2019, 6:29 AM · Restricted Project, debug-info
Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Thanks for taking a look @aprantl.

Dec 6 2019, 3:06 AM · Restricted Project, debug-info

Dec 5 2019

Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Missed one of djtodoro's comments, sorry for the spam!

Dec 5 2019, 6:20 AM · Restricted Project, debug-info
Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

+ Rebase.
+ Address comments from @djtodoro.

Dec 5 2019, 6:15 AM · Restricted Project, debug-info

Nov 27 2019

Orlando added inline comments to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.
Nov 27 2019, 7:04 AM · Restricted Project, debug-info
Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

+ Update dexter test for @jmorse.
+ Small additional change to print().
+ Rebase.
+ Rephrase a small part of the summary.

Nov 27 2019, 6:54 AM · Restricted Project, debug-info

Nov 25 2019

Orlando added a comment to D69999: [DebugInfo] Support for DW_OP_implicit_pointer (IR Verifier and Bitcode).

Adrian said:

Thanks! Let's cycle back to this after the llvm-dev thread that @dblaikie started has been resolved.

Nov 25 2019, 6:33 AM · debug-info, Restricted Project
Orlando committed rG2de23c8364ba: [DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func (authored by Orlando).
[DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func
Nov 25 2019, 3:11 AM
Orlando closed D70604: [DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func.
Nov 25 2019, 3:11 AM · Restricted Project, debug-info
Orlando added a comment to D70604: [DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func.

Thanks for the review, committed in 2de23c8364b.

Nov 25 2019, 3:11 AM · Restricted Project, debug-info

Nov 24 2019

Orlando added a comment to D70260: [DebugInfo] Support for DW_OP_implicit_pointer (salvagDebugInfo improvement)..

Hi @alok. I haven't been following the DW_OP_implicit_pointer discussion too closely, so just some inline nitpick comments/questions from me.

Nov 24 2019, 3:17 PM · Restricted Project, debug-info

Nov 22 2019

Orlando created D70604: [DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func.
Nov 22 2019, 9:58 AM · Restricted Project, debug-info
Orlando added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

LGTM -- though having given only one LGTM before I'd feel more comfortable waiting for +1.

Nov 22 2019, 6:14 AM · Restricted Project

Nov 20 2019

Orlando added inline comments to D70486: Make DebugVariable class available in DebugInfoMetadata.
Nov 20 2019, 4:02 AM · Restricted Project, debug-info
Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

@aprantl wrote https://reviews.llvm.org/D70318#inline-635016:

Nov 20 2019, 3:50 AM · Restricted Project, debug-info
Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Thanks all for the initial reviews.

Nov 20 2019, 2:29 AM · Restricted Project, debug-info

Nov 15 2019

Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

+ Added reviewers

Nov 15 2019, 3:29 AM · Restricted Project, debug-info
Orlando added reviewers for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments: djtodoro, jmorse.
Nov 15 2019, 3:29 AM · Restricted Project, debug-info
Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

+ Improve some comments
+ rename getter/setters as Adrian requested
+ remove some whitespace changes

Nov 15 2019, 2:14 AM · Restricted Project, debug-info
Orlando added inline comments to D70248: Disallow shift operations in debug expressions spanning multiple registers.
Nov 15 2019, 1:08 AM · Restricted Project

Nov 13 2019

Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

More Info about this patch: As far as LDV is concerned undefs and 'blockers' are semantically very similar. However, blockers are not emitted (as DBG_VALUES) because it is unnecessary: They are only added to UserValues with overlapping fragments for any given def, and a def implicitly terminates preceding defs with overlapping fragments [0].

Nov 13 2019, 2:13 AM · Restricted Project, debug-info

Nov 12 2019

Orlando added inline comments to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.
Nov 12 2019, 9:41 AM · Restricted Project, debug-info
Orlando added a comment to D68945: [DebugInfo] Don't translate dbg.addr and similar intrinsics into indirect DBG_VALUEs.

I'm working in this area for pr41992 so I noticed a couple of things (inline comments). I am happy to just add the changes I'm suggesting into my own upcoming patch if you'd like?

Those both sound legit, please do!

Nov 12 2019, 5:51 AM · Restricted Project
Orlando abandoned D66415: [DebugInfo@O2] Fix PR41992: LiveDebugVariables can drop DBG_VALUEs through misinterpreting fragments.

I'm abandoning this because I've created the WIP revision D70121 which handles fragment overlaps.

Nov 12 2019, 5:41 AM · Restricted Project, debug-info
Orlando created D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.
Nov 12 2019, 5:36 AM · Restricted Project, debug-info

Oct 31 2019

Orlando updated subscribers of D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap.
Oct 31 2019, 4:21 AM · Restricted Project, debug-info

Oct 29 2019

Orlando updated subscribers of D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap.

Hi @bjope thank you for pointing this out and providing a workaround. I'll test out your change and investigate further.

Oct 29 2019, 5:29 AM · Restricted Project, debug-info

Oct 17 2019

Orlando added a comment to D68945: [DebugInfo] Don't translate dbg.addr and similar intrinsics into indirect DBG_VALUEs.

I'm working in this area for pr41992 so I noticed a couple of things (inline comments). I am happy to just add the changes I'm suggesting into my own upcoming patch if you'd like?

Oct 17 2019, 1:57 AM · Restricted Project

Oct 16 2019

Orlando added a comment to D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap.

After timing some more self-hosts it looks like my original numbers which looked
too good to be true sadly are just that. The self-host asan build time reduction
seems correct (-3.5%) but the non-asan builds are much less impacted then first
thought (about -1%). These numbers are more in line with my original expectation.

Oct 16 2019, 1:45 AM · Restricted Project, debug-info
Orlando updated the summary of D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap.
Oct 16 2019, 1:45 AM · Restricted Project, debug-info
Orlando committed rG8af5ada09319: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap (authored by Orlando).
[NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap
Oct 16 2019, 1:36 AM
Orlando closed D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap.
Oct 16 2019, 1:36 AM · Restricted Project, debug-info

Oct 11 2019

Orlando updated the diff for D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap.

Addressed comments and fixed Summary (previously it referred to
LiveDebugValues.cpp instead of LiveDebugVariables.cpp).

Oct 11 2019, 5:54 AM · Restricted Project, debug-info

Oct 10 2019

Orlando created D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap.
Oct 10 2019, 10:13 AM · Restricted Project, debug-info
Orlando added a comment to D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap.

The numbers are much better than I expected but I haven't been able to prove
myself wrong after a bunch of testing. So, I've put this patch up for the
community's expert eyes.

Oct 10 2019, 10:13 AM · Restricted Project, debug-info

Sep 20 2019

Orlando added a comment to D66892: [BasicBlockUtils] Add metadata fixing in SplitBlockPredecessors..

I don't feel confident enough in this area to give an official LGTM but If I understand it correctly the patch seems reasonable: move loop metadata from old to new latch when a loop header is split.

Sep 20 2019, 9:15 AM · Restricted Project

Sep 3 2019

Orlando added inline comments to D67097: [DWARF] Check for format mismatch between CU and Range List Table..
Sep 3 2019, 7:31 AM · Restricted Project, debug-info

Aug 22 2019

Orlando added inline comments to D66526: [utils] Add the llvm-locstats tool.
Aug 22 2019, 3:06 AM · Restricted Project, debug-info

Aug 20 2019

Orlando added a comment to D66415: [DebugInfo@O2] Fix PR41992: LiveDebugVariables can drop DBG_VALUEs through misinterpreting fragments.

Thanks for the review!

Aug 20 2019, 7:47 AM · Restricted Project, debug-info

Aug 19 2019

Orlando created D66415: [DebugInfo@O2] Fix PR41992: LiveDebugVariables can drop DBG_VALUEs through misinterpreting fragments.
Aug 19 2019, 5:44 AM · Restricted Project, debug-info

Jun 19 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Thanks, I've now resubmitted this patch (1251cac62af5).

Jun 19 2019, 4:03 AM · debug-info, Restricted Project
Orlando committed rG1251cac62af5: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through… (authored by Orlando).
[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through…
Jun 19 2019, 3:48 AM

Jun 18 2019

Orlando accepted D63499: Add debug location verification for !llvm.loop attachments.

LGTM. Thanks for doing this!

Jun 18 2019, 11:33 AM · Restricted Project, debug-info
Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

There is one thing I don't understand:
It looks like !680 is only used in the !llvm.loop !679 metadata. How can that trigger a !dbg attachment points at wrong subprogram for function verifier failure?

Jun 18 2019, 2:24 AM · debug-info, Restricted Project

Jun 17 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Hi Adrian.

Jun 17 2019, 2:36 AM · debug-info, Restricted Project

Jun 12 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

No problem at all - reverted with rGa94715639619. I'll take a look at this next week, thank you for the info.

Jun 12 2019, 1:41 AM · debug-info, Restricted Project
Orlando committed rGa94715639619: Revert "[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step… (authored by Orlando).
Revert "[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step…
Jun 12 2019, 1:33 AM
Orlando added a reverting change for rG1a0f7a2077b7: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through…: rGa94715639619: Revert "[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step….
Jun 12 2019, 1:33 AM

Jun 11 2019

Orlando committed rG1a0f7a2077b7: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through… (authored by Orlando).
[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through…
Jun 11 2019, 3:36 AM

May 28 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

The major change to this previously accepted patch is the modification of "bcmp-debugify-remarks.ll" and "inlined-argument.ll".
Minor changes include spelling corrections in comments and removing some superfluous debug data from the new tests.

May 28 2019, 1:17 AM · debug-info, Restricted Project

May 20 2019

Orlando updated the diff for D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

The inlined loop metadata part has been separated into D61933 (rL361149) which this patch is now based on.

May 20 2019, 8:37 AM · debug-info, Restricted Project
Orlando added a comment to D61933: [DebugInfo] Update loop metadata for inlined loops.

Resubmitted in rL361149.

May 20 2019, 8:21 AM · Restricted Project, debug-info
Orlando committed rGed67bf8d2f31: Resubmit "[DebugInfo] Update loop metadata for inlined loops" (authored by Orlando).
Resubmit "[DebugInfo] Update loop metadata for inlined loops"
May 20 2019, 6:04 AM
Orlando added a reverting change for rG95805bc425b2: Revert "[DebugInfo] Update loop metadata for inlined loops": rGed67bf8d2f31: Resubmit "[DebugInfo] Update loop metadata for inlined loops".
May 20 2019, 6:04 AM
Orlando added a comment to D61933: [DebugInfo] Update loop metadata for inlined loops.

Reverted with commit 95805bc425b because armv8 build bots are failing.

May 20 2019, 4:31 AM · Restricted Project, debug-info
Orlando committed rG95805bc425b2: Revert "[DebugInfo] Update loop metadata for inlined loops" (authored by Orlando).
Revert "[DebugInfo] Update loop metadata for inlined loops"
May 20 2019, 4:23 AM
Orlando added a reverting change for rG6e8f1a80cd98: [DebugInfo] Update loop metadata for inlined loops: rG95805bc425b2: Revert "[DebugInfo] Update loop metadata for inlined loops".
May 20 2019, 4:23 AM
Orlando committed rG6e8f1a80cd98: [DebugInfo] Update loop metadata for inlined loops (authored by Orlando).
[DebugInfo] Update loop metadata for inlined loops
May 20 2019, 2:41 AM

May 16 2019

Orlando added inline comments to D61933: [DebugInfo] Update loop metadata for inlined loops.
May 16 2019, 2:33 AM · Restricted Project, debug-info
Orlando updated the diff for D61933: [DebugInfo] Update loop metadata for inlined loops.

Address suggestions and add some const correctness.

May 16 2019, 2:28 AM · Restricted Project, debug-info

May 15 2019

Orlando added inline comments to D61933: [DebugInfo] Update loop metadata for inlined loops.
May 15 2019, 9:19 AM · Restricted Project, debug-info
Orlando updated the summary of D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
May 15 2019, 1:45 AM · debug-info, Restricted Project
Orlando created D61933: [DebugInfo] Update loop metadata for inlined loops.
May 15 2019, 1:37 AM · Restricted Project, debug-info

May 14 2019

Orlando requested review of D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
May 14 2019, 8:29 AM · debug-info, Restricted Project
Orlando reopened D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
May 14 2019, 8:23 AM · debug-info, Restricted Project
Orlando updated the diff for D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

This update addresses the problems with the original patch that caused the built bot failures
(sorry about that!).

May 14 2019, 8:19 AM · debug-info, Restricted Project

May 7 2019

Orlando committed rG78a6062c24dc: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through… (authored by Orlando).
[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through…
May 7 2019, 8:36 AM
Orlando committed rG0d0517733713: Test commit access (authored by Orlando).
Test commit access
May 7 2019, 2:33 AM

May 2 2019

Orlando added a comment to D61372: [coroutines] Fix spills of static array allocas.

Hi, I added a few inline comments, mostly just nits on style.

May 2 2019, 3:18 AM · Restricted Project

Apr 30 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

My take-away from the discussion was this: It is desirable to map the instructions to something in the loop (e.g., not line 0), unless doing so will provide confusing information to the mapping that PGO uses to optimize the relevant branches. Am I correct in saying that this latter issue is of minimal concern in this case?

Apr 30 2019, 1:51 AM · debug-info, Restricted Project

Apr 29 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

A summary of the discussion so far:

Apr 29 2019, 6:39 AM · debug-info, Restricted Project

Apr 18 2019

Orlando added a comment to D60858: AMDGPU: Skip debug instructions in assert.

Are the function attributes in the test necessary? Watching other reviews leads me to believe these are undesirable. Apart from this it LGTMy untrained eyes (I'm new to reviewing!).

Apr 18 2019, 3:14 AM
Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

How will this appear to profiling tools using PC sampling and using debug info to map the PC samples back to line numbers in the code?

I brought this up in some offline discussions which all concluded that the impact on profilers would be small and the trade off for better debugging is worth it. The impact on profilers seems like it would be small because the middle block is only visited once after running through the vectorized loop.

I am glad you asked because this concern gives rise to an argument for giving the middle block instructions line 0 instead, and i am interested in hearing other's opinions.

Interesting. The middle block just has the check for whether or not we need to run the remainder loop, right? I can definitely see this as kind of latch-like.

@jmellorcrummey , do you have an opinion on this?

Apr 18 2019, 2:52 AM · debug-info, Restricted Project
Orlando updated the diff for D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Sorry, I missed a couple of failing tests. I've fixed them and updated the diff.

Apr 18 2019, 2:44 AM · debug-info, Restricted Project

Apr 17 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

How will this appear to profiling tools using PC sampling and using debug info to map the PC samples back to line numbers in the code?

Apr 17 2019, 11:09 AM · debug-info, Restricted Project
Orlando updated the summary of D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
Apr 17 2019, 10:23 AM · debug-info, Restricted Project
Orlando created D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
Apr 17 2019, 10:14 AM · debug-info, Restricted Project
Orlando added a watcher for debug-info: Orlando.
Apr 17 2019, 3:20 AM

Apr 12 2019

Orlando updated the diff for D60556: [DebugInfo@O2] Fix pr41175 Dead Store Elimination missing debug loc.

I've made the suggested changes.

Apr 12 2019, 2:03 AM · Restricted Project, debug-info

Apr 11 2019

Orlando created D60556: [DebugInfo@O2] Fix pr41175 Dead Store Elimination missing debug loc.
Apr 11 2019, 2:11 AM · Restricted Project, debug-info

Apr 2 2019

Orlando updated the diff for D59944: [DebugInfo] Fix pr41180 : Loop Vectorization Debugify Failure.

Updated a comment with some more info as vsk suggested.

Apr 2 2019, 2:40 AM · Restricted Project

Apr 1 2019

Orlando updated the diff for D59944: [DebugInfo] Fix pr41180 : Loop Vectorization Debugify Failure.

The test has been updated to check for the expected instructions.

Apr 1 2019, 2:18 AM · Restricted Project
Orlando updated the diff for D59944: [DebugInfo] Fix pr41180 : Loop Vectorization Debugify Failure.

I've updated the test to include the source and commands to generate the IR it uses. Please note that I stripped out the call void @llvm.dbg.* lines from the test file by hand so any regenerated IR will look more cluttered.

Apr 1 2019, 1:11 AM · Restricted Project

Mar 28 2019

Orlando created D59944: [DebugInfo] Fix pr41180 : Loop Vectorization Debugify Failure.
Mar 28 2019, 9:47 AM · Restricted Project