Page MenuHomePhabricator

Orlando (Orlando Cazalet-Hyams)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2019, 8:58 AM (53 w, 5 d)

Recent Activity

Fri, Apr 3

Orlando committed rG9b56cc9361a4: [DebugInfo] Salvage debug info when sinking loop invariant instructions (authored by Orlando).
[DebugInfo] Salvage debug info when sinking loop invariant instructions
Fri, Apr 3, 1:35 AM
Orlando closed D77318: [DebugInfo] Salvage debug info when sinking loop invariant instructions.
Fri, Apr 3, 1:34 AM · Restricted Project, debug-info
Orlando updated subscribers of D77318: [DebugInfo] Salvage debug info when sinking loop invariant instructions.

Thanks everyone, I'll land this shortly.

Fri, Apr 3, 1:02 AM · Restricted Project, debug-info

Thu, Apr 2

Orlando created D77318: [DebugInfo] Salvage debug info when sinking loop invariant instructions.
Thu, Apr 2, 9:44 AM · Restricted Project, debug-info
Orlando added a comment to D77226: [NFC] Fix performance issue in LiveDebugVariables.

Thanks @vsk.

Thu, Apr 2, 2:40 AM · Restricted Project, debug-info
Orlando committed rG550ab58bc106: [NFC] Fix performance issue in LiveDebugVariables (authored by Orlando).
[NFC] Fix performance issue in LiveDebugVariables
Thu, Apr 2, 2:09 AM
Orlando closed D77226: [NFC] Fix performance issue in LiveDebugVariables.
Thu, Apr 2, 2:09 AM · Restricted Project, debug-info

Wed, Apr 1

Orlando created D77226: [NFC] Fix performance issue in LiveDebugVariables.
Wed, Apr 1, 9:20 AM · Restricted Project, debug-info

Fri, Mar 27

Orlando accepted D76926: [Dexter] Add Debugger Controller To Dexter.

Makes sense to separate out these parts. LGTM, but it's a sizeable patch so maybe wait a little and see if anyone else has anything to say before committing.

Fri, Mar 27, 7:37 AM · debug-info
Orlando accepted D76609: [DEXTER] Add support for windows in regression test suite..

LGTM

Fri, Mar 27, 7:37 AM · Restricted Project, debug-info

Thu, Mar 26

Orlando added a comment to D76854: [DebugInfo] Ensure that a demanded bits optimisation in InstCombine does not result in an incorrect debuginfo variable value.

LGTM but since we're on the same team (now, woot!) I'd like to give others a chance to have a look.

Thu, Mar 26, 9:45 AM · Restricted Project, debug-info

Wed, Mar 11

Orlando added inline comments to D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Wed, Mar 11, 10:45 AM · Restricted Project, debug-info
Orlando accepted D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..

LGTM.

Wed, Mar 11, 9:04 AM · Restricted Project, debug-info

Mar 2 2020

Orlando added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

I like the idea of this and think it looks useful, and personally I would say
please do continue to work on it after giving people a chance to reply to this
comment.

Mar 2 2020, 8:41 AM · Restricted Project, debug-info

Feb 28 2020

Orlando added reviewers for D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool: StephenTozer, TWeaver.

Adding Stephen and Tom who have also worked on dexter.

Feb 28 2020, 5:28 AM · Restricted Project, debug-info
Orlando accepted D75235: [debuginfo-tests][dexter] Add a test tool --calculate-average option.

LGTM. Thanks for the patch, It's great to see someone using and contributing to dexter!

Feb 28 2020, 1:33 AM · Restricted Project

Feb 13 2020

Orlando added inline comments to D74548: [debuginfo-tests][Dexter] Downgrade failure to delete working dir to warning not error.
Feb 13 2020, 6:44 AM · Restricted Project
Orlando accepted D74548: [debuginfo-tests][Dexter] Downgrade failure to delete working dir to warning not error.
Feb 13 2020, 6:44 AM · Restricted Project
Orlando added a comment to D74548: [debuginfo-tests][Dexter] Downgrade failure to delete working dir to warning not error.

LGTM

Feb 13 2020, 6:44 AM · Restricted Project
Orlando added inline comments to D74548: [debuginfo-tests][Dexter] Downgrade failure to delete working dir to warning not error.
Feb 13 2020, 5:31 AM · Restricted Project
Orlando accepted D74546: [debuginfo-tests][Dexter] Fix some Windows-unfriendly Dexter behaviours.

LGTM

Feb 13 2020, 5:31 AM · Restricted Project

Feb 12 2020

Orlando added inline comments to D74030: [DebugInfo] Avoid generating duplicate llvm.dbg.value.
Feb 12 2020, 3:28 AM · Restricted Project, debug-info

Feb 11 2020

Orlando added inline comments to D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows.
Feb 11 2020, 8:19 AM · Restricted Project
Orlando committed rG35e0ab647bfc: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo (authored by Orlando).
[DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo
Feb 11 2020, 2:34 AM
Orlando committed rG3aa33fde03d1: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue (authored by Orlando).
[DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue
Feb 11 2020, 2:34 AM
Orlando committed rG1e4079932436: [DebugInfo] Teach LDV how to handle identical variable fragments (authored by Orlando).
[DebugInfo] Teach LDV how to handle identical variable fragments
Feb 11 2020, 2:34 AM
Orlando closed D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo.
Feb 11 2020, 2:34 AM · debug-info, Restricted Project
Orlando closed D74055: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue.
Feb 11 2020, 2:34 AM · debug-info, Restricted Project
Orlando closed D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.
Feb 11 2020, 2:34 AM · debug-info, Restricted Project
Orlando added a comment to D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.

Thanks for reviewing these patches! I will land them now.

Feb 11 2020, 2:22 AM · debug-info, Restricted Project

Feb 7 2020

Orlando updated the diff for D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo.

Address review comments:
+ match() -> matches()

Feb 7 2020, 4:51 AM · debug-info, Restricted Project
Orlando updated the diff for D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo.

+ Rebase

Feb 7 2020, 4:51 AM · debug-info, Restricted Project
Orlando updated the diff for D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.

+ Rebase (see 6531a78ac4b5 caused conflicts) and remove parent.
+ Include bugzilla links in summary.

Feb 7 2020, 4:51 AM · debug-info, Restricted Project
Orlando updated the diff for D74055: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue.

+ Rebase
+ Rename wasIndirect() to getWasIndirect() to match the other changes in this patch.

Feb 7 2020, 4:51 AM · debug-info, Restricted Project
Orlando removed a parent revision for D74053: [DebugInfo] Teach LDV how to handle identical variable fragments: D74052: [DebugInfo] Tidy up DbgValueLocation class.
Feb 7 2020, 4:42 AM · debug-info, Restricted Project
Orlando removed a child revision for D74052: [DebugInfo] Tidy up DbgValueLocation class: D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.
Feb 7 2020, 4:42 AM · debug-info, Restricted Project
Orlando abandoned D74052: [DebugInfo] Tidy up DbgValueLocation class.

Thanks for reviewing this. Unfortunately the changes made in ed29dbaafa49 (D68945) were just reverted in 6531a78ac4b5 so this patch is no longer necessary.

Feb 7 2020, 4:42 AM · debug-info, Restricted Project

Feb 6 2020

Orlando updated the diff for D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.

Thanks for reviewing this @djtodoro

Feb 6 2020, 1:41 AM · debug-info, Restricted Project
Orlando added a comment to D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo.

Thanks for looking at these patches. When they are all ready to land would it be better to land them independently or all together as one?

Feb 6 2020, 1:23 AM · debug-info, Restricted Project

Feb 5 2020

Orlando updated the diff for D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo.

Address comments:

Feb 5 2020, 9:27 AM · debug-info, Restricted Project
Orlando added inline comments to D74052: [DebugInfo] Tidy up DbgValueLocation class.
Feb 5 2020, 9:27 AM · debug-info, Restricted Project
Orlando abandoned D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

I've opened a stack of patches starting at D74052 which implement the 99.99...% fix (handle fully overlapping fragments) discussed above.

Feb 5 2020, 9:09 AM · Restricted Project, debug-info
Orlando added inline comments to D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.
Feb 5 2020, 8:31 AM · debug-info, Restricted Project
Orlando changed the visibility for D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo.
Feb 5 2020, 8:24 AM · debug-info, Restricted Project
Orlando changed the visibility for D74055: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue.
Feb 5 2020, 8:24 AM · debug-info, Restricted Project
Orlando added reviewers for D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo: vsk, aprantl, bjope, djtodoro.
Feb 5 2020, 8:24 AM · debug-info, Restricted Project
Orlando added reviewers for D74055: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue: vsk, aprantl, bjope, djtodoro.
Feb 5 2020, 8:24 AM · debug-info, Restricted Project
Orlando added reviewers for D74053: [DebugInfo] Teach LDV how to handle identical variable fragments: vsk, aprantl, bjope, djtodoro.
Feb 5 2020, 8:22 AM · debug-info, Restricted Project
Orlando updated the summary of D74052: [DebugInfo] Tidy up DbgValueLocation class.
Feb 5 2020, 8:21 AM · debug-info, Restricted Project
Orlando updated the summary of D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.
Feb 5 2020, 8:21 AM · debug-info, Restricted Project
Orlando added a child revision for D74052: [DebugInfo] Tidy up DbgValueLocation class: D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.
Feb 5 2020, 8:21 AM · debug-info, Restricted Project
Orlando added a parent revision for D74053: [DebugInfo] Teach LDV how to handle identical variable fragments: D74052: [DebugInfo] Tidy up DbgValueLocation class.
Feb 5 2020, 8:21 AM · debug-info, Restricted Project
Orlando added a parent revision for D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo: D74055: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue.
Feb 5 2020, 8:21 AM · debug-info, Restricted Project
Orlando added a child revision for D74055: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue: D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo.
Feb 5 2020, 8:21 AM · debug-info, Restricted Project
Orlando added a child revision for D74053: [DebugInfo] Teach LDV how to handle identical variable fragments: D74055: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue.
Feb 5 2020, 8:21 AM · debug-info, Restricted Project
Orlando added a parent revision for D74055: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue: D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.
Feb 5 2020, 8:21 AM · debug-info, Restricted Project
Orlando created D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo.
Feb 5 2020, 8:13 AM · debug-info, Restricted Project
Orlando created D74055: [DebugInfo][NFC] Rename the class DbgValueLocation to DbgVariableValue.
Feb 5 2020, 8:12 AM · debug-info, Restricted Project
Orlando created D74053: [DebugInfo] Teach LDV how to handle identical variable fragments.
Feb 5 2020, 8:12 AM · debug-info, Restricted Project
Orlando created D74052: [DebugInfo] Tidy up DbgValueLocation class.
Feb 5 2020, 8:03 AM · debug-info, Restricted Project

Jan 31 2020

Orlando accepted D73691: [DebugInfo] Re-instate scope trimming in LiveDebugVariables.

Orlando has looked at this more recently and is probably more qualified to review ;)

Jan 31 2020, 6:22 AM · Restricted Project
Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Let me see if I can restate that correctly. So, the problem here is: for the list of user-values tracked by the interval map for the range containing [DV1, DV3], there are two entries: one for {DV1, DV3} (coalesced), and another for {DV2}. This would result in "x" being interpreted as %1 + 4 instead of %0 in that interval (by the debugger)?

Jan 31 2020, 5:56 AM · Restricted Project, debug-info

Jan 30 2020

Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

@vsk this is the situation as far as I understand it. I appreciate that this is
a lot of text; there is a summary at the end. I hope this helps.

Jan 30 2020, 8:23 AM · Restricted Project, debug-info

Jan 29 2020

Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Hi @vsk, thank you for taking a look at this. Please bear with me, getting you some (relatively concise) answers it is taking a little longer than I expected but I am working on it.

Jan 29 2020, 9:30 AM · Restricted Project, debug-info
Orlando added a comment to D73478: [DebugInfo] replaceDbgUsesWithUndef before removing single store alloca.

Hi @djtodoro. I will create new patches.

Jan 29 2020, 2:21 AM · debug-info, Restricted Project
Orlando added a comment to D73478: [DebugInfo] replaceDbgUsesWithUndef before removing single store alloca.

So how did you come to be trying to fix these bugs?

I was specifically looking for cases where debug intrinsics are dropped.

Jan 29 2020, 1:57 AM · debug-info, Restricted Project

Jan 28 2020

Orlando added a comment to D73478: [DebugInfo] replaceDbgUsesWithUndef before removing single store alloca.

Hi @dblaikie, thanks for your comments.

Jan 28 2020, 1:56 AM · debug-info, Restricted Project

Jan 27 2020

Orlando abandoned D73481: [DebugInfo] replaceDbgUsesWithUndef after sroa promotes allocas.

See D73478

Jan 27 2020, 8:12 AM · debug-info, Restricted Project
Orlando abandoned D73479: [DebugInfo] replaceDbgUsesWithUndef when sroa promotes an alloca.

See D73478

Jan 27 2020, 8:12 AM · Restricted Project
Orlando abandoned D73473: [DebugInfo] replaceDbgUsesWithUndef before removing dead alloca.

See D73478.

Jan 27 2020, 8:12 AM · Restricted Project
Orlando abandoned D73478: [DebugInfo] replaceDbgUsesWithUndef before removing single store alloca.

Ok no problem, will do. I'll abandon this, D73473, D73479, and D73481 and combine all the patches which touch the same pass.

Jan 27 2020, 8:11 AM · debug-info, Restricted Project
Orlando created D73481: [DebugInfo] replaceDbgUsesWithUndef after sroa promotes allocas.
Jan 27 2020, 7:53 AM · debug-info, Restricted Project
Orlando created D73479: [DebugInfo] replaceDbgUsesWithUndef when sroa promotes an alloca.
Jan 27 2020, 7:43 AM · Restricted Project
Orlando created D73478: [DebugInfo] replaceDbgUsesWithUndef before removing single store alloca.
Jan 27 2020, 7:34 AM · debug-info, Restricted Project
Orlando created D73473: [DebugInfo] replaceDbgUsesWithUndef before removing dead alloca.
Jan 27 2020, 6:58 AM · Restricted Project

Jan 23 2020

Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Ping. Please see my previous comment for an update on this.

Jan 23 2020, 3:26 AM · Restricted Project, debug-info

Jan 21 2020

Orlando added inline comments to D73054: Prevent explosion of debug intrinsics during jump threading.
Jan 21 2020, 3:58 AM · debug-info, Restricted Project

Jan 16 2020

Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Thanks @djtodoro for looking at this. Sorry for this really delayed response!

Jan 16 2020, 8:19 AM · Restricted Project, debug-info

Jan 13 2020

Orlando added inline comments to D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes..
Jan 13 2020, 7:34 AM · debug-info, Restricted Project

Dec 13 2019

Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Hi, sorry for the slow update.

Dec 13 2019, 8:06 AM · Restricted Project, debug-info

Dec 11 2019

Orlando updated subscribers of D71350: [MachineScheduler] Reorder cfi to avoid PostRA scheduling differences.

As far as I understand it I don't think it is safe to move CFI_INSTRUCTIONs
around like this. CFI_INSTRUCTIONs describe the effect of specific instructions.
We encode where this 'description' starts by the position of the CFI_INSTRUCTION
in the instruction stream. So, if you move the CFI_INSTRUCTION like this you
are changing the meaning.

Dec 11 2019, 6:54 AM · Restricted Project

Dec 6 2019

Orlando added inline comments to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.
Dec 6 2019, 6:29 AM · Restricted Project, debug-info
Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Thanks for taking a look @aprantl.

Dec 6 2019, 3:06 AM · Restricted Project, debug-info

Dec 5 2019

Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Missed one of djtodoro's comments, sorry for the spam!

Dec 5 2019, 6:20 AM · Restricted Project, debug-info
Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

+ Rebase.
+ Address comments from @djtodoro.

Dec 5 2019, 6:15 AM · Restricted Project, debug-info

Nov 27 2019

Orlando added inline comments to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.
Nov 27 2019, 7:04 AM · Restricted Project, debug-info
Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

+ Update dexter test for @jmorse.
+ Small additional change to print().
+ Rebase.
+ Rephrase a small part of the summary.

Nov 27 2019, 6:54 AM · Restricted Project, debug-info

Nov 25 2019

Orlando added a comment to D69999: [DebugInfo] Support for DW_OP_implicit_pointer (IR Verifier and Bitcode).

Adrian said:

Thanks! Let's cycle back to this after the llvm-dev thread that @dblaikie started has been resolved.

Nov 25 2019, 6:33 AM · debug-info, Restricted Project
Orlando committed rG2de23c8364ba: [DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func (authored by Orlando).
[DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func
Nov 25 2019, 3:11 AM
Orlando closed D70604: [DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func.
Nov 25 2019, 3:11 AM · Restricted Project, debug-info
Orlando added a comment to D70604: [DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func.

Thanks for the review, committed in 2de23c8364b.

Nov 25 2019, 3:11 AM · Restricted Project, debug-info

Nov 24 2019

Orlando added a comment to D70260: [DebugInfo] Support for DW_OP_implicit_pointer (salvagDebugInfo improvement)..

Hi @alok. I haven't been following the DW_OP_implicit_pointer discussion too closely, so just some inline nitpick comments/questions from me.

Nov 24 2019, 3:17 PM · Restricted Project, debug-info

Nov 22 2019

Orlando created D70604: [DebugInfo@O2][Utils] Undef instead of delete dbg.values in helper func.
Nov 22 2019, 9:58 AM · Restricted Project, debug-info
Orlando added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

LGTM -- though having given only one LGTM before I'd feel more comfortable waiting for +1.

Nov 22 2019, 6:14 AM · Restricted Project

Nov 20 2019

Orlando added inline comments to D70486: Make DebugVariable class available in DebugInfoMetadata.
Nov 20 2019, 4:02 AM · Restricted Project, debug-info
Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

@aprantl wrote https://reviews.llvm.org/D70318#inline-635016:

Nov 20 2019, 3:50 AM · Restricted Project, debug-info
Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Thanks all for the initial reviews.

Nov 20 2019, 2:29 AM · Restricted Project, debug-info

Nov 15 2019

Orlando added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

+ Added reviewers

Nov 15 2019, 3:29 AM · Restricted Project, debug-info
Orlando added reviewers for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments: djtodoro, jmorse.
Nov 15 2019, 3:29 AM · Restricted Project, debug-info
Orlando updated the diff for D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

+ Improve some comments
+ rename getter/setters as Adrian requested
+ remove some whitespace changes

Nov 15 2019, 2:14 AM · Restricted Project, debug-info