Page MenuHomePhabricator

Orlando (Orlando Cazalet-Hyams)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2019, 8:58 AM (115 w, 2 d)

Recent Activity

Tue, May 25

Orlando committed rG4b55102aff29: [dexter] Change --source-root-dir and add --debugger-use-relative-paths (authored by Orlando).
[dexter] Change --source-root-dir and add --debugger-use-relative-paths
Tue, May 25, 5:29 AM
Orlando closed D100307: [dexter] Change --source-root-dir and add --debugger-use-relative-paths.
Tue, May 25, 5:28 AM · Restricted Project, debug-info
Orlando added a comment to D102917: [LiveDebugVariables] Stop trimming locations of non-inlined vars.

@Orlando Thanks for looking into this!

I can see that in the tests you've updated in this patch some DBG_VALUEs are moved from just outside to inside the prologue.

I think this is the main reason of the improvement. The motivation for this fix was to improve MIR and DBG_VALUE, so it becomes as close as possible to its COPY.

Tue, May 25, 2:26 AM · Restricted Project, debug-info

Mon, May 24

Orlando added a comment to D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.

Apologies for the missing test, here it is! :)

Will be pushing this shortly, thanks a bunch.

# Purpose:
#    Check that non canonical paths resolve correctly on windows.
#
# REQUIRES: system-windows
#
# RUN: %clang "%S/source/test file.cpp" -O0 -g -o %t
# RUN: %dexter_regression_test --binary %t %s | FileCheck %s
# CHECK: test.dex
#
# ./source/test file.cpp
# 1 int main(const int argc, const char * argv[]) {
# 2 int result = argc;
# 3 return result;
# 4 }

DexDeclareFile('./sOuRce\\test filE.cpp')
DexExpectWatchValue('result', 1, on_line=3)
Mon, May 24, 7:49 AM · Restricted Project, debug-info

Fri, May 21

Orlando added a comment to D102917: [LiveDebugVariables] Stop trimming locations of non-inlined vars.

It seems odd that not trimming the locations would have a positive impact on coverage since, IIUC, the only difference should be an increase in bytes covered outside the lexical scope (which is not counted towards "PC ranges covered" as of D85636). I can see that in the tests you've updated in this patch some DBG_VALUEs are moved from just outside to inside the prologue. I have vague memories from my time working on D82129 that LexicalScope::getRanges doesn't include the prologue in any range or something like that. I'm unsure whether that is intended behaviour or not - I would be interested if anyone knows? I think my solution in D82129 was similarly to avoid trimming the location ranges for function-scoped variables.

Fri, May 21, 7:08 AM · Restricted Project, debug-info
Orlando added inline comments to D100307: [dexter] Change --source-root-dir and add --debugger-use-relative-paths.
Fri, May 21, 5:57 AM · Restricted Project, debug-info
Orlando updated the diff for D100307: [dexter] Change --source-root-dir and add --debugger-use-relative-paths.

+ Rebased on the latest version of D99651 (which has been approved now, so should be its final form)

Fri, May 21, 5:57 AM · Restricted Project, debug-info
Orlando committed rG35a7c4b4b1d0: [dexter] Add REQUIRES: lldb to the test label_offset.cpp (authored by Orlando).
[dexter] Add REQUIRES: lldb to the test label_offset.cpp
Fri, May 21, 5:52 AM
Orlando added a comment to D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.

Hi, before this lands you will need to update your dexter tests to use the new label reference syntax added in D101147. You can do so manually, or alternatively use this python script by running python make_label_refs.py debuginfo-tests/feature_tests (please note it will modify files in place). I'm happy for you to amend your commit with that update without bringing it back up here for review.

Fri, May 21, 5:20 AM · Restricted Project, debug-info
Orlando added a comment to D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.

Hi, before this lands you will need to update your dexter tests to use the new label reference syntax added in D101147. You can do so manually, or alternatively use this python script by running python make_label_refs.py debuginfo-tests/feature_tests (please note it will modify files in place). I'm happy for you to amend your commit with that update without bringing it back up here for review.

Fri, May 21, 5:18 AM · Restricted Project, debug-info
Orlando committed rG469833f418e1: [dexter] Add hit_count keyword arg to DexLimitSteps (authored by Orlando).
[dexter] Add hit_count keyword arg to DexLimitSteps
Fri, May 21, 4:52 AM
Orlando closed D101527: [dexter] Add hit_count keyword arg to DexLimitSteps.
Fri, May 21, 4:52 AM · Restricted Project, debug-info
Orlando added a comment to D101527: [dexter] Add hit_count keyword arg to DexLimitSteps.

Thanks both

Fri, May 21, 4:46 AM · Restricted Project, debug-info
Orlando updated the diff for D101527: [dexter] Add hit_count keyword arg to DexLimitSteps.

+ Changed is_one_shot to hit_count. Updated patch title and summary.

Fri, May 21, 2:02 AM · Restricted Project, debug-info
Orlando committed rG2348b5c94319: [dexter] Remove accidentally committed .rej file (authored by Orlando).
[dexter] Remove accidentally committed .rej file
Fri, May 21, 1:11 AM
Orlando added a comment to D101147: [dexter] Change line label reference syntax to enable label-relative offsets (1/2).

Thanks both

Fri, May 21, 1:01 AM · Restricted Project, debug-info
Orlando committed rG98e7911f9517: [dexter] Change line label reference syntax to enable label-relative offsets… (authored by Orlando).
[dexter] Change line label reference syntax to enable label-relative offsets…
Fri, May 21, 12:59 AM
Orlando committed rG723a8ae5dab2: [dexter] Change line label reference syntax to enable label-relative offsets… (authored by Orlando).
[dexter] Change line label reference syntax to enable label-relative offsets…
Fri, May 21, 12:59 AM
Orlando closed D101148: [dexter] Change line label reference syntax to enable label-relative offsets (2/2).
Fri, May 21, 12:59 AM · Restricted Project, debug-info
Orlando closed D101147: [dexter] Change line label reference syntax to enable label-relative offsets (1/2).
Fri, May 21, 12:59 AM · Restricted Project, debug-info

Wed, May 19

Orlando added a comment to D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.

It looks like you've addressed both of our comments (except my suggestion for a non-canonical path spelling test for windows exclusively, which would still be welcomed but isn't critical) so LGTM. I'll leave it to @jmorse to Accept this if he's happy.

Wed, May 19, 4:10 AM · Restricted Project, debug-info

Mon, May 17

Orlando committed rGe35a5492a46d: [dexter] Remove requirement for a condition in DexLimitSteps (authored by Orlando).
[dexter] Remove requirement for a condition in DexLimitSteps
Mon, May 17, 1:15 AM
Orlando added a comment to D101438: [dexter] Remove requirement for a condition in DexLimitSteps.

Thanks @chrisjackson.

Mon, May 17, 1:15 AM · Restricted Project, debug-info
Orlando closed D101438: [dexter] Remove requirement for a condition in DexLimitSteps.
Mon, May 17, 1:14 AM · Restricted Project, debug-info
Orlando added a comment to D101431: [dexter] Remove unnecessary double check on conditional breakpoints.

Thanks @chrisjackson.

Mon, May 17, 1:05 AM · Restricted Project, debug-info
Orlando committed rGa11117a7c0a2: [dexter] Remove unnecessary double check on conditional breakpoints (authored by Orlando).
[dexter] Remove unnecessary double check on conditional breakpoints
Mon, May 17, 1:03 AM
Orlando closed D101431: [dexter] Remove unnecessary double check on conditional breakpoints.
Mon, May 17, 1:03 AM · Restricted Project, debug-info

May 6 2021

Orlando updated the diff for D101431: [dexter] Remove unnecessary double check on conditional breakpoints.

+ Replace two GetID() calls with id in delete_breakpoint.

May 6 2021, 12:26 AM · Restricted Project, debug-info

May 5 2021

Orlando added a comment to D101527: [dexter] Add hit_count keyword arg to DexLimitSteps.

Thanks for taking a look.

May 5 2021, 3:35 AM · Restricted Project, debug-info
Orlando added inline comments to D101431: [dexter] Remove unnecessary double check on conditional breakpoints.
May 5 2021, 3:25 AM · Restricted Project, debug-info
Orlando added a comment to D101527: [dexter] Add hit_count keyword arg to DexLimitSteps.

Alternatively we could a slightly more general keyword arg hit_count=<int> that limits the times the breakpoints can be triggered to any number, rather than just once. I'm not sure we need it right now, but it's more flexible. Does anyone have any opinion on this?

May 5 2021, 3:00 AM · Restricted Project, debug-info

Apr 30 2021

Orlando accepted D101540: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue.

LGTM but please wait a little to see if anyone else has comments on the test, cc @jmorse.

Apr 30 2021, 1:07 AM · Restricted Project, debug-info

Apr 29 2021

Orlando added a comment to D101540: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue.

The change makes sense and LGTM.

Apr 29 2021, 11:41 AM · Restricted Project, debug-info
Orlando updated the diff for D101527: [dexter] Add hit_count keyword arg to DexLimitSteps.

+ Update Commands.md

Apr 29 2021, 9:10 AM · Restricted Project, debug-info
Orlando requested review of D101527: [dexter] Add hit_count keyword arg to DexLimitSteps.
Apr 29 2021, 5:50 AM · Restricted Project, debug-info
Orlando updated the diff for D101438: [dexter] Remove requirement for a condition in DexLimitSteps.

+ Add REQUIRES: system-linux in test (DexLimitSteps has limited support)
+ Rename ConditionalBpRange -> BreakpointRange, cbp -> bpr, *conditional_bp_ranges -> *bp_ranges

Apr 29 2021, 5:07 AM · Restricted Project, debug-info

Apr 28 2021

Orlando requested review of D101438: [dexter] Remove requirement for a condition in DexLimitSteps.
Apr 28 2021, 3:40 AM · Restricted Project, debug-info
Orlando updated the summary of D101431: [dexter] Remove unnecessary double check on conditional breakpoints.
Apr 28 2021, 1:36 AM · Restricted Project, debug-info
Orlando requested review of D101431: [dexter] Remove unnecessary double check on conditional breakpoints.
Apr 28 2021, 1:29 AM · Restricted Project, debug-info

Apr 26 2021

Orlando committed rG40df6bac9c5c: [dexter] Update failing regression test (authored by Orlando).
[dexter] Update failing regression test
Apr 26 2021, 8:42 AM

Apr 23 2021

Orlando committed rG487ab5345920: [dexter] Add keyword argument 'on_line' to DexLabel (authored by Orlando).
[dexter] Add keyword argument 'on_line' to DexLabel
Apr 23 2021, 4:03 AM
Orlando closed D101055: [dexter] Add keyword argument 'on_line' to DexLabel.
Apr 23 2021, 4:03 AM · Restricted Project, debug-info
Orlando updated the summary of D101147: [dexter] Change line label reference syntax to enable label-relative offsets (1/2).
Apr 23 2021, 1:44 AM · Restricted Project, debug-info
Orlando requested review of D101148: [dexter] Change line label reference syntax to enable label-relative offsets (2/2).
Apr 23 2021, 1:44 AM · Restricted Project, debug-info
Orlando requested review of D101147: [dexter] Change line label reference syntax to enable label-relative offsets (1/2).
Apr 23 2021, 1:40 AM · Restricted Project, debug-info

Apr 22 2021

Orlando updated the diff for D101055: [dexter] Add keyword argument 'on_line' to DexLabel.

+ Update Commands.md

Apr 22 2021, 9:25 AM · Restricted Project, debug-info
Orlando added a comment to D100845: [Debugify][Original DI] Test preservation of original debug var intrinsics in optimizations.

I am seeing some false positives for sure (most of these artifital vars locs are being removed after some "constant propagation" passes). We definitely need to investigate how to remove these false positives here (for both, instr and var locations).

Apr 22 2021, 7:55 AM · Restricted Project, debug-info
Orlando requested review of D101055: [dexter] Add keyword argument 'on_line' to DexLabel.
Apr 22 2021, 5:27 AM · Restricted Project, debug-info
Orlando added a comment to D100845: [Debugify][Original DI] Test preservation of original debug var intrinsics in optimizations.

@Orlando Thanks for looking into this.

Hi @djtodoro I am looking at this (slowly, sorry!).

IIUC this checks that the number of debug intrinsics for each non-inlined variable does not decrease after each optimisation pass. There are legitimate reasons for deleting debug intrinsics. RemoveRedundantDbgInstrs, for example, which is called in a few places. With that in mind I think I would prefer the table header "Number of bugs" to change as this number seems to be more of an indicator of possible bugs, rather than proof of their existence.

Sure. That is why we treat it as "WARNING". The same is happening with dropping of dbg location attached to instructions -- there are places where we cannot salvage !dbg, and we treat it as a warning as well (until we add some super cool logic to distinguish what was reasonable drop or opposite).

Apr 22 2021, 3:31 AM · Restricted Project, debug-info

Apr 21 2021

Orlando added a comment to D100845: [Debugify][Original DI] Test preservation of original debug var intrinsics in optimizations.

Hi @djtodoro I am looking at this (slowly, sorry!).

Apr 21 2021, 10:02 AM · Restricted Project, debug-info
Orlando added a comment to D100307: [dexter] Change --source-root-dir and add --debugger-use-relative-paths.

Thanks both for the reviews.

Apr 21 2021, 7:49 AM · Restricted Project, debug-info
Orlando updated the diff for D100307: [dexter] Change --source-root-dir and add --debugger-use-relative-paths.

+Remove unnecessary comment.

Apr 21 2021, 2:27 AM · Restricted Project, debug-info

Apr 20 2021

Orlando added inline comments to D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.
Apr 20 2021, 1:14 AM · Restricted Project, debug-info

Apr 19 2021

Orlando added a comment to D100307: [dexter] Change --source-root-dir and add --debugger-use-relative-paths.

Ping

Apr 19 2021, 3:10 AM · Restricted Project, debug-info
Orlando committed rGbbccdf6f8197: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock (authored by Orlando).
[DebugInfo] Replace debug uses in replaceUsesOutsideBlock
Apr 19 2021, 3:07 AM
Orlando committed rG0ebf9a8e34b6: [DebugInfo] Move the findDbg* functions into DebugInfo.cpp (authored by Orlando).
[DebugInfo] Move the findDbg* functions into DebugInfo.cpp
Apr 19 2021, 2:31 AM
Orlando closed D100632: [DebugInfo] Move the findDbg* functions into DebugInfo.cpp.
Apr 19 2021, 2:31 AM · Restricted Project, debug-info
Orlando added a comment to D100632: [DebugInfo] Move the findDbg* functions into DebugInfo.cpp.

Thanks all.

Apr 19 2021, 1:52 AM · Restricted Project, debug-info

Apr 16 2021

Orlando added a reviewer for D100632: [DebugInfo] Move the findDbg* functions into DebugInfo.cpp: rnk.
Apr 16 2021, 3:17 AM · Restricted Project, debug-info
Orlando added a comment to D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.

Landing this tripped up some build bots (e.g. https://lab.llvm.org/buildbot/#/builders/109/builds/12664). I've created D100632 which should fix the issue iiuc.

Apr 16 2021, 2:56 AM · Restricted Project, debug-info
Orlando requested review of D100632: [DebugInfo] Move the findDbg* functions into DebugInfo.cpp.
Apr 16 2021, 2:53 AM · Restricted Project, debug-info

Apr 15 2021

Orlando added a reverting change for rG96a1e6b7cf72: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock: rG17cec07184d3: Revert "[DebugInfo] Replace debug uses in replaceUsesOutsideBlock".
Apr 15 2021, 8:36 AM
Orlando committed rG17cec07184d3: Revert "[DebugInfo] Replace debug uses in replaceUsesOutsideBlock" (authored by Orlando).
Revert "[DebugInfo] Replace debug uses in replaceUsesOutsideBlock"
Apr 15 2021, 8:36 AM
Orlando added a reverting change for D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock: rG17cec07184d3: Revert "[DebugInfo] Replace debug uses in replaceUsesOutsideBlock".
Apr 15 2021, 8:36 AM · Restricted Project, debug-info
Orlando added a comment to D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.

Thanks!

Apr 15 2021, 8:21 AM · Restricted Project, debug-info
Orlando committed rG96a1e6b7cf72: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock (authored by Orlando).
[DebugInfo] Replace debug uses in replaceUsesOutsideBlock
Apr 15 2021, 8:21 AM
Orlando closed D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.
Apr 15 2021, 8:20 AM · Restricted Project, debug-info
Orlando added a comment to D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.

Thanks! LGTM like this...

(I vote for this simple code change rather than introducing this overloading, but please wait for couple of more days, so we can see if someone else has a different opinion.)

Thanks @djtodoro. Sure, I will leave this up a few days before landing.

Apr 15 2021, 6:07 AM · Restricted Project, debug-info

Apr 13 2021

Orlando added a comment to D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement.

@Orlando, thanks for pointing out the debugify usage for me. I indeed use debugify to generate the test cases. I will update test case soon.

@djtodoro, hope it is useful for the debug information updates! We are developing a static analysis tool based on the how-to-update-debug-info guide provided by the community. Some of the test cases are reduced from the test suite which can trigger the potential buggy code location. Some are generated using fuzzing and debugify.

Apr 13 2021, 6:38 AM · Restricted Project, debug-info
Orlando added inline comments to D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement.
Apr 13 2021, 3:10 AM · Restricted Project, debug-info

Apr 12 2021

Orlando requested review of D100307: [dexter] Change --source-root-dir and add --debugger-use-relative-paths.
Apr 12 2021, 8:14 AM · Restricted Project, debug-info
Orlando added a comment to D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.

Thanks! LGTM like this...

(I vote for this simple code change rather than introducing this overloading, but please wait for couple of more days, so we can see if someone else has a different opinion.)

Apr 12 2021, 7:33 AM · Restricted Project, debug-info

Apr 9 2021

Orlando added inline comments to D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.
Apr 9 2021, 8:26 AM · Restricted Project, debug-info
Orlando added inline comments to D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.
Apr 9 2021, 7:38 AM · Restricted Project, debug-info
Orlando added a comment to D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.

Sanitizer builds were failing due to memory leaks; these were caused by the fact that SDDbgValues are allocated under a BumpPtrAllocator, which does not call destructors. SDDbgValues contained SmallVectors which did not use this allocator, so when the SDDbgValues were cleared they would not call the SmallVector destructor.

This has been resolved by replacing each SmallVector with a std::shared_ptr that uses the BumpPtrAllocator, so there will be no memory allocated outside of this allocator and hence no leaks.

Apr 9 2021, 7:21 AM · Restricted Project, debug-info
Orlando updated subscribers of D100165: [GVNHoist] fix a bug where GVNHoist preserves the debug location when it should be dropped.

You're preserving the location in the case that only one instruction is moved. Interestingly the linked document also says "a transformation should also preserve the debug location of an instruction that is moved between basic blocks, if the destination block already contains an instruction with an identical debug location." suggesting that you should only preserve the location if "an identical one" exists in the pred block. Scanning the block for an identical location sounds excessive. My gut reaction would be to simply add an additional check that the location of the instruction at the insertion point matches the (single) hoisted instruction's location before preserving the location, or alternatively always drop the location (i.e. remove the if guard altogether).

Apr 9 2021, 2:20 AM · Restricted Project

Apr 8 2021

Orlando added inline comments to D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.
Apr 8 2021, 9:41 AM · Restricted Project, debug-info
Orlando updated the diff for D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.

+ Remove tbaa metadata from lit test.
+ Fix clang-tidy warning in unittest.
+ Move the code into a new function replaceDbgUsesOutsideBlock.

Apr 8 2021, 7:27 AM · Restricted Project, debug-info

Apr 6 2021

Orlando added a comment to D99651: [Dexter] Implement DexDeclareFile, a new Dexter command.

LGTM with a few tiny nits, but please wait for a +1 from someone else too.

Apr 6 2021, 6:50 AM · Restricted Project, debug-info
Orlando added a comment to D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.

Thanks for this! The results are amazing.

Apr 6 2021, 6:20 AM · Restricted Project, debug-info
Orlando added a comment to D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.

Ping

Apr 6 2021, 3:42 AM · Restricted Project, debug-info

Mar 23 2021

Orlando added a comment to D98699: [dexter] Fix DexLimitSteps when breakpoint can't be set at requested location.

Hey Orlando! thanks for this. A really nice, solid reimplementation and improvement of the original work. Great code comments too.

thanks again, LGTM.

Mar 23 2021, 4:43 AM · Restricted Project
Orlando committed rGfaf5f1cbbac0: [dexter] Fix DexLimitSteps when breakpoint can't be set at requested location (authored by Orlando).
[dexter] Fix DexLimitSteps when breakpoint can't be set at requested location
Mar 23 2021, 4:39 AM
Orlando closed D98699: [dexter] Fix DexLimitSteps when breakpoint can't be set at requested location.
Mar 23 2021, 4:39 AM · Restricted Project
Orlando added a comment to D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.

I wonder if it would be better update Value::replaceUsesWithIf instead, which would reach more code. Though that shape of that change might need some discussion. For instance, would we pass in the MetadataAsValue-ValueAsMetadata-Value debug uses to the predicate, or alternatively, have a a separate predicate for debug uses? wdyt?

Mar 23 2021, 3:58 AM · Restricted Project, debug-info
Orlando requested review of D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock.
Mar 23 2021, 3:46 AM · Restricted Project, debug-info

Mar 19 2021

Orlando added inline comments to D98699: [dexter] Fix DexLimitSteps when breakpoint can't be set at requested location.
Mar 19 2021, 9:16 AM · Restricted Project

Mar 18 2021

Orlando updated the diff for D98699: [dexter] Fix DexLimitSteps when breakpoint can't be set at requested location.

To my mind, the two attribute names, _conditional_bp_ranges and _conditional_bps are quite similar -- but AFAICT the former is a on-initialization record of where conditional bps should be placed, while the latter is a "live" record of conditional bp handles, is that right? IMO, better to have an indication of this distinction in the name, may I suggest _conditional_bp_handles?

Mar 18 2021, 6:49 AM · Restricted Project

Mar 16 2021

Orlando requested review of D98699: [dexter] Fix DexLimitSteps when breakpoint can't be set at requested location.
Mar 16 2021, 5:19 AM · Restricted Project
Orlando added a comment to D98644: [DebugInfo] Fix incorrect handling of variadic salvaging in Loop Strength Reduce.

FWIW the SelectionDAG fix LGTM. I'll leave the LSR part to someone more familiar with it.

Mar 16 2021, 2:09 AM · debug-info, Restricted Project

Mar 15 2021

Orlando added a comment to D97668: [debuginfo-tests] Add some optnone tests.

Thanks @teemperor. I've added a quick fix in 61d314024dc4 which fixes the immediate issue of passing in None to os.path.exists (it seems like loc.path being None is a valid state in dexter). I don't have a machine running macOS to test on so I'll keep my eye on the bot.

Mar 15 2021, 4:55 AM · Restricted Project, debug-info
Orlando committed rG61d314024dc4: [dexter] Check path != None before calling os.path.exists (authored by Orlando).
[dexter] Check path != None before calling os.path.exists
Mar 15 2021, 4:50 AM

Mar 12 2021

Orlando added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.

The debuginfo should be udpate. It will be implemented in the next patch update.

Mar 12 2021, 4:37 AM · Restricted Project
Orlando added inline comments to D98401: [CodeGen] Fix backward copy propagation with -g.
Mar 12 2021, 4:33 AM · Restricted Project

Mar 11 2021

Orlando updated subscribers of D98401: [CodeGen] Fix backward copy propagation with -g.

please add a unit test

Hi @fhahn did you mean regression/lit test?

Mar 11 2021, 8:51 AM · Restricted Project

Mar 2 2021

Orlando committed rG14be3f0e8848: [debuginfo-tests] Add some optnone tests (authored by Orlando).
[debuginfo-tests] Add some optnone tests
Mar 2 2021, 1:02 AM
Orlando added a comment to D97668: [debuginfo-tests] Add some optnone tests.

Thank you @rnk.

Mar 2 2021, 1:02 AM · Restricted Project, debug-info
Orlando closed D97668: [debuginfo-tests] Add some optnone tests.
Mar 2 2021, 1:01 AM · Restricted Project, debug-info

Mar 1 2021

Orlando requested review of D97668: [debuginfo-tests] Add some optnone tests.
Mar 1 2021, 1:45 AM · Restricted Project, debug-info

Feb 24 2021

Orlando committed rG52bc1c1bd539: [dexter] Force dexter tests to use the host triple (authored by Orlando).
[dexter] Force dexter tests to use the host triple
Feb 24 2021, 3:17 AM