Page MenuHomePhabricator

Orlando (Orlando Cazalet-Hyams)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2019, 8:58 AM (170 w, 6 d)

Recent Activity

Today

Orlando added a comment to D128177: [DebugInfo][InstrRef][NFC] Represent DbgValues with multiple ops in LDV.

LGTM with some minor comments. I'd feel more confident if someone else (/ @jmorse ) took a quick look too, but given this is NFC and conceptually straightforward, I'm happy to approve it.

Thu, Jul 7, 4:49 AM · Restricted Project, debug-info, Restricted Project

Mon, Jun 20

Orlando accepted D128174: [DebugInfo][InstrRef][NFC Update LDV to use generic DBG_VALUE* MI interface.

LGTM

Mon, Jun 20, 3:54 AM · debug-info, Restricted Project, Restricted Project

Thu, Jun 9

Orlando added a comment to D127208: MachineSink debug invariance.

The test LGTM - I'll leave it to @jmorse or @fhahn to accept when a consensus is reached on whether a bounded version of sizeWithoutDebug should be added or not.

Thu, Jun 9, 2:56 AM · Restricted Project, Restricted Project

Wed, Jun 8

Orlando accepted D127101: [Dexter] Catch value error when encountering invalid address.
Wed, Jun 8, 6:12 AM · debug-info, Restricted Project, Restricted Project
Orlando added a comment to D127208: MachineSink debug invariance.

The code changes look good to me, so just waiting for the test before approving now.

Wed, Jun 8, 1:51 AM · Restricted Project, Restricted Project

Jun 7 2022

Orlando added a comment to D127208: MachineSink debug invariance.

Should add a .mir test

Jun 7 2022, 6:06 AM · Restricted Project, Restricted Project
Orlando accepted D126767: [DebugInfo][Docs] Improve code formatting in instruction referencing doc.

Thanks for taking a look @Orlando!

Unlike most historical LLVM docs, this file is using Markdown, which ends up rendered together with the reStructuredText docs by Sphinx. Markdown is recommended for new docs.

With Markdown in mind, please take another look when you have time. 🙂

Jun 7 2022, 3:05 AM · debug-info, Restricted Project, Restricted Project
Orlando added a comment to D127101: [Dexter] Catch value error when encountering invalid address.

I've added an inline suggestion but I'm happy with or without that change, LGTM.

Jun 7 2022, 2:53 AM · debug-info, Restricted Project, Restricted Project
Orlando accepted D127099: [Dexter] Use PurePath to compare paths in Dexter commands.

LGTM

Jun 7 2022, 2:45 AM · Restricted Project, Restricted Project, debug-info
Orlando accepted D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.

LGTM!

Jun 7 2022, 2:17 AM · Restricted Project, Restricted Project, debug-info
Orlando added a comment to D126767: [DebugInfo][Docs] Improve code formatting in instruction referencing doc.

Hi @jryans, thanks for this update. I'm not particularly familiar with reStructuredText formatting so I've just been looking at an existing doc (https://github.com/llvm/llvm-project/blob/main/llvm/docs/LangRef.rst) to guide my review.

Jun 7 2022, 2:02 AM · debug-info, Restricted Project, Restricted Project

May 23 2022

Orlando added inline comments to D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.
May 23 2022, 4:50 AM · Restricted Project, Restricted Project, debug-info
Orlando added a comment to D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.

Just to confirm, does this comment:

Remove unused "zero range" test.

May 23 2022, 3:34 AM · Restricted Project, Restricted Project, debug-info
Orlando added a comment to D124691: [Transforms] Fix a wrong debug info intrinsic call in `mem2reg` pass for ref 128-bit.

It looks like the clang front end emits a size field for reference types. e.g.

May 23 2022, 2:33 AM · debug-info, Restricted Project, Restricted Project

May 17 2022

Orlando accepted D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide.

LGTM with some nits addressed, thanks! I've hit accepted but please leave this up for a day or so in case anyone else has any further comments.

May 17 2022, 9:03 AM · Restricted Project, Restricted Project

May 9 2022

Orlando added inline comments to D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.
May 9 2022, 4:26 AM · Restricted Project, Restricted Project, debug-info
Orlando accepted D123599: [DebugInfo][InstrRef] Describe value sizes when spilt to stack.

The latest change makes sense, LGTM

May 9 2022, 2:01 AM · Restricted Project, Restricted Project

Apr 29 2022

Orlando accepted D124517: [DebugInfo][InstrRef] Use a cache to avoid creating redundant DBG_PHIs.

Makes sense, LGTM. I've added two tiny suggestions inline but I don't mind if you leave the patch as it is.

Apr 29 2022, 12:30 AM · Restricted Project, Restricted Project

Apr 26 2022

Orlando accepted D123599: [DebugInfo][InstrRef] Describe value sizes when spilt to stack.

LGTM. It's great to have the comprehensive test spelling out the expectations for all the combinations of fragment / deref / indirect.

Apr 26 2022, 3:42 AM · Restricted Project, Restricted Project

Apr 22 2022

Orlando added a comment to D124184: [DebugInfo][InstrRef] Describe the size of value referred to by a DBG_PHI.

LGTM

Apr 22 2022, 1:32 AM · Restricted Project, Restricted Project

Apr 20 2022

Orlando updated subscribers of D124098: Don't replace Undef with null value for Constants.
Apr 20 2022, 9:25 AM · Restricted Project, Restricted Project

Apr 13 2022

Orlando added a comment to D123599: [DebugInfo][InstrRef] Describe value sizes when spilt to stack.

/me squints -- looks like the test doesn't cover the case of expressions with fragments, which I'll revise in later. (The patch has a case for that).

Apr 13 2022, 6:34 AM · Restricted Project, Restricted Project

Apr 4 2022

Orlando accepted D123033: [DebugInfo][InstrRef] Avoid a crash from mixed variable location modes.

I wonder if the test IR could be simplified. Would it not be enough to have a function with a single dbg.value and nothing else?

Apr 4 2022, 9:53 AM · Restricted Project, Restricted Project

Mar 17 2022

Orlando added a comment to D120732: [DebugInfo][InstrRef] Prefer stack locations for variables over restored registers.

FWIW the change LGTM mechanically and I think it sounds reasonable (/good).

Mar 17 2022, 2:16 AM · Restricted Project, Restricted Project

Mar 15 2022

Orlando added a comment to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

Hi @yln, the test you added llvm/test/Transforms/LowerGlobalDestructors/lower-global-dtors.ll is failing on some bots, e.g. https://lab.llvm.org/buildbot/#/builders/139/builds/18527 (builder llvm-clang-x86_64-sie-ubuntu-fast). Please can you take a look?

Mar 15 2022, 2:19 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2022

Orlando accepted D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Makes sense to restore NFC-ness of the patch, LGTM with that change.

Mar 10 2022, 12:26 AM · Restricted Project, Restricted Project, debug-info

Mar 9 2022

Orlando added a comment to D121107: [DebugInfo][SROA] Correct debug info for global variables in case of SROA.

Please wait for the other reviewers to be happy, but this LGTM with some nits addressed.

Mar 9 2022, 12:57 AM · Restricted Project, debug-info, Restricted Project

Mar 8 2022

Orlando added a comment to D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Reinstate the check for dbg.value that LSR has changed from single location-op to multi location-op. When LSR makes this change, the single location argument is changed to a DIArglist. This patch now replaces the DIArglist with a single 'undef'. This will prevent the generation of invalid dbg.value that were causing the crash as reported by @Orlando .

Mar 8 2022, 9:09 AM · Restricted Project, Restricted Project, debug-info

Mar 7 2022

Orlando added a comment to D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

The change SGTM but I found a reproducer that causes clang to crash when this patch is applied:

Mar 7 2022, 3:23 AM · Restricted Project, Restricted Project, debug-info
Orlando added a comment to D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules.

Hi, the test add-remove-irrelevant-module-map.m starts failing with this commit on the llvm-clang-x86_64-sie-win builder: https://lab.llvm.org/buildbot/#/builders/216/builds/929. Please can you take a look when you get the chance?

Hi, it's already fixed in https://lab.llvm.org/buildbot/#/builders/216/builds/932.

Mar 7 2022, 2:37 AM · Restricted Project, Restricted Project
Orlando added a comment to D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules.

Hi, the test add-remove-irrelevant-module-map.m starts failing with this commit on the llvm-clang-x86_64-sie-win builder: https://lab.llvm.org/buildbot/#/builders/216/builds/929. Please can you take a look when you get the chance?

Mar 7 2022, 2:31 AM · Restricted Project, Restricted Project

Mar 4 2022

Orlando added a comment to D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

I can clarify the comment. It's my understanding that non-empty DIExpressions must have a DW_OP_stack_value terminator. The expressions generated by the SCEVDbgValueBuilder objects do not have these terminators (as the expressions may be inserted into other expressions). If the pre-LSR expression was empty, once the complete salvaging expression has been generated, then the terminator must be appended.

Mar 4 2022, 9:24 AM · Restricted Project, Restricted Project, debug-info
Orlando accepted D120716: [Dexter] Collate penalties of the same type into a single line for each.

This should improve the readability of the output nicely. LGTM.

Mar 4 2022, 8:40 AM · Restricted Project, Restricted Project
Orlando accepted D121001: [DebugInfo][instr-ref] Accept register-reads after isel in any block.

LGTM

Mar 4 2022, 8:30 AM · Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC]: Restricted Project.

I don't think there are "rules" about tagging patches as NFC (just put NFC somewhere in the title). It's definitely helpful to be able to see at a glance though - two examples: if an NFC patch is causing changes in output there's a bug, and if a patch is NFC it probably doesn't need any tests.

Mar 2 2022, 3:46 AM · Restricted Project, Restricted Project, debug-info

Feb 28 2022

Orlando added a comment to D118774: [DebugInfo][InstrRef][NFC] Use unique_ptr instead of raw pointers for value tables.

Looks good on my side - might be worth checking with @Orlando too before submitting.

Feb 28 2022, 9:23 AM · Restricted Project
Orlando accepted D120658: [Dexter] Optimize breakpoint deletion in Visual Studio.

LGTM

Feb 28 2022, 5:11 AM · Restricted Project

Feb 25 2022

Orlando added a comment to D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Can this be labelled NFC or is there a functional change here that I've missed?

Feb 25 2022, 7:00 AM · Restricted Project, Restricted Project, debug-info
Orlando added a comment to D120035: Notify me when the SIE builders running cross-project-tests fail.

Thanks @gkistanova. I don't think I have commit access to llvm-zorg. Please could you land this for me when you get a spare minute?

Feb 25 2022, 3:16 AM · Restricted Project

Feb 18 2022

Orlando added inline comments to D120035: Notify me when the SIE builders running cross-project-tests fail.
Feb 18 2022, 2:55 AM · Restricted Project

Feb 17 2022

Orlando requested review of D120035: Notify me when the SIE builders running cross-project-tests fail.
Feb 17 2022, 3:40 AM · Restricted Project

Feb 11 2022

Orlando committed rG2bd62e0b040a: [dexter] Don't generate results files by default (authored by Orlando).
[dexter] Don't generate results files by default
Feb 11 2022, 7:49 AM
Orlando closed D119545: [dexter] Don't generate results files by default.
Feb 11 2022, 7:49 AM · Restricted Project
Orlando added a comment to D119545: [dexter] Don't generate results files by default.

LGTM with query; More restructuring to avoid more indentation would be nice, but here we are ._.

Feb 11 2022, 7:41 AM · Restricted Project
Orlando added inline comments to D119545: [dexter] Don't generate results files by default.
Feb 11 2022, 7:40 AM · Restricted Project
Orlando updated the diff for D119545: [dexter] Don't generate results files by default.

+ addressed inline comment

Feb 11 2022, 7:40 AM · Restricted Project
Orlando requested review of D119545: [dexter] Don't generate results files by default.
Feb 11 2022, 6:43 AM · Restricted Project

Feb 10 2022

Orlando committed rG48326df4b5c7: [cross-project-tests] REQUIRES: system-darwin in llgdb-tests/asan-deque.cpp (authored by Orlando).
[cross-project-tests] REQUIRES: system-darwin in llgdb-tests/asan-deque.cpp
Feb 10 2022, 5:55 AM
Orlando committed rGac0f32970d2c: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan (authored by Orlando).
[cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan
Feb 10 2022, 2:49 AM
Orlando closed D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan.
Feb 10 2022, 2:49 AM · Restricted Project, debug-info

Feb 9 2022

Orlando updated the diff for D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan.

+ Improve comment in test
+ Fix description

Feb 9 2022, 9:25 AM · Restricted Project, debug-info
Orlando added inline comments to D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan.
Feb 9 2022, 4:34 AM · Restricted Project, debug-info
Orlando committed rG00b2a9c9da40: [cross-project-tests] Make GDB version string parsing more robust (authored by Orlando).
[cross-project-tests] Make GDB version string parsing more robust
Feb 9 2022, 3:46 AM
Orlando added a reviewer for D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan: StephenTozer.
Feb 9 2022, 3:06 AM · Restricted Project, debug-info
Orlando updated the diff for D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan.

+ Rebase (fix conflicts with D118468)

Feb 9 2022, 3:06 AM · Restricted Project, debug-info
Orlando committed rG5257efdc5b30: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF (authored by Orlando).
[cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF
Feb 9 2022, 2:54 AM
Orlando closed D118468: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF.
Feb 9 2022, 2:54 AM · debug-info, Restricted Project

Feb 8 2022

Orlando accepted D118998: [DebugInfo][InstrRef] Don't fire assertions if broken debug-info is seen.

LGTM. Converting badly-formed variable locations into "no location" rather than crashing the compiler SGTM. Is it worth fixing the defect in the bug report too in a separate patch?

Feb 8 2022, 4:19 AM · Restricted Project

Feb 7 2022

Orlando added inline comments to D118468: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF.
Feb 7 2022, 4:38 AM · debug-info, Restricted Project
Orlando updated the diff for D118468: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF.

+ Make gdb-version-check more robust by checking version string length

Feb 7 2022, 4:36 AM · debug-info, Restricted Project
Orlando added inline comments to D118468: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF.
Feb 7 2022, 4:28 AM · debug-info, Restricted Project
Orlando updated the diff for D118468: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF.

+ Catch-em-all when trying to run gdb
+ Print a message when the XFAIL condition is detected.
+ Fix stderr -> sys.stderr in a print call.

Feb 7 2022, 4:27 AM · debug-info, Restricted Project
Orlando added a comment to D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan.

We've now got a native Linux builder in staging where you can see these tests failing: https://lab.llvm.org/staging/#/builders/205/builds/91

Feb 7 2022, 2:11 AM · Restricted Project, debug-info
Orlando added a comment to D118468: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF.

We've now got a native Linux builder in staging where you can see these tests failing: https://lab.llvm.org/staging/#/builders/205/builds/91

Feb 7 2022, 2:11 AM · debug-info, Restricted Project

Feb 3 2022

Orlando added inline comments to D118774: [DebugInfo][InstrRef][NFC] Use unique_ptr instead of raw pointers for value tables.
Feb 3 2022, 6:43 AM · Restricted Project

Feb 2 2022

Orlando accepted D118460: [DebugInfo][InstrRef] Use a depth-first search to reduce the lifetime of tracking information.

Would it be worth caching getBlocksForScope results? If I'm reading this right it looks like it's called a few times with what should be the same inputs and outputs in a few places in the pass?

Feb 2 2022, 5:36 AM · Restricted Project
Orlando added a comment to D118774: [DebugInfo][InstrRef][NFC] Use unique_ptr instead of raw pointers for value tables.

Nice. I have a few questions / nits but I'm a fan of the change.

Feb 2 2022, 4:15 AM · Restricted Project
Orlando added a reviewer for D118468: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF: jmorse.

Thanks for taking a look @probinson. Adding Jeremy as reviewer.

Feb 2 2022, 2:45 AM · debug-info, Restricted Project
Orlando updated subscribers of D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan.

+ llvm-commits

Feb 2 2022, 2:23 AM · Restricted Project, debug-info
Orlando requested review of D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan.
Feb 2 2022, 1:38 AM · Restricted Project, debug-info

Feb 1 2022

Orlando accepted D118597: [DebugInfo][InstrRef][NFC] Don't build mappings of values to locations for un-needed values.

LGTM

Feb 1 2022, 12:45 AM · Restricted Project

Jan 31 2022

Orlando accepted D118601: [DebugInfo][InstrRef] Add a max-stack-slots-to-track limitation / cut-out.

LGTM

Jan 31 2022, 10:27 AM · Restricted Project
Orlando added inline comments to D118601: [DebugInfo][InstrRef] Add a max-stack-slots-to-track limitation / cut-out.
Jan 31 2022, 10:03 AM · Restricted Project
Orlando added a comment to D118597: [DebugInfo][InstrRef][NFC] Don't build mappings of values to locations for un-needed values.

Nice! I have one question inline but this SGTM.

Jan 31 2022, 8:34 AM · Restricted Project
Orlando added inline comments to D118454: [DebugInfo][InstrRef][NFC] Refactor code portions into own functions, name some useful types.
Jan 31 2022, 8:04 AM · Restricted Project
Orlando added a comment to D118460: [DebugInfo][InstrRef] Use a depth-first search to reduce the lifetime of tracking information.

Once @dblaikie's concerns are addressed, this LGTM.

Jan 31 2022, 7:57 AM · Restricted Project
Orlando accepted D118454: [DebugInfo][InstrRef][NFC] Refactor code portions into own functions, name some useful types.

The clang-format bot isn't happy and I have one nit inline, otherwise LGTM.

Jan 31 2022, 4:59 AM · Restricted Project

Jan 28 2022

Orlando added a comment to D118453: [DebugInfo][InstrRef][NFC] Free resources at an earlier stage, to avoid double accounting.

nit in commit message:

This patch releases some memory from InstrRefBasedLDV earlier that it would otherwise. The underlying problem is:

"earlier that it would" -> "earlier than it would"

Jan 28 2022, 8:54 AM · Restricted Project
Orlando requested review of D118468: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF.
Jan 28 2022, 6:50 AM · debug-info, Restricted Project

Jan 26 2022

Orlando added a comment to D118048: [Dexter] Remove false requirement of lldb for dexter regression tests on Windows.

Folded nit-fixes into the commit, thanks both.

Jan 26 2022, 3:34 AM · Restricted Project, debug-info
Orlando committed rGde3f81557ae3: [Dexter] Remove false requirement of lldb for dexter regression tests on Windows (authored by Orlando).
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Jan 26 2022, 3:34 AM
Orlando closed D118048: [Dexter] Remove false requirement of lldb for dexter regression tests on Windows.
Jan 26 2022, 3:34 AM · Restricted Project, debug-info

Jan 24 2022

Orlando requested review of D118048: [Dexter] Remove false requirement of lldb for dexter regression tests on Windows.
Jan 24 2022, 8:18 AM · Restricted Project, debug-info

Jan 21 2022

Orlando accepted D117891: [DebugInfo][InstrRef] Don't check liveness of any debug instruction operand.

LGTM

Jan 21 2022, 7:54 AM · Restricted Project
Orlando committed rGb6a41fddcfd3: [DWARF][DebugInfo] Fix off-by-one error in size of DW_TAG_base_type types (authored by Orlando).
[DWARF][DebugInfo] Fix off-by-one error in size of DW_TAG_base_type types
Jan 21 2022, 3:38 AM
Orlando closed D117124: [DWARF][DebugInfo] Fix off-by-one error in size of DW_TAG_base_type types.
Jan 21 2022, 3:38 AM · debug-info, Restricted Project

Jan 18 2022

Orlando abandoned D115325: [DWARF] Fix PR51087 Extraneous enum record in DWARF with type units.
Jan 18 2022, 2:28 AM · debug-info, Restricted Project
Orlando reopened D115325: [DWARF] Fix PR51087 Extraneous enum record in DWARF with type units.

That clears up a lot of my confusion.

Jan 18 2022, 2:28 AM · debug-info, Restricted Project

Jan 17 2022

Orlando added a comment to D115325: [DWARF] Fix PR51087 Extraneous enum record in DWARF with type units.

Sorry it's taken me a while to get back to you on this - thanks for all that info. Here is a summary of the situation as far as I understand it:

Jan 17 2022, 8:58 AM · debug-info, Restricted Project

Jan 13 2022

Orlando updated the diff for D117124: [DWARF][DebugInfo] Fix off-by-one error in size of DW_TAG_base_type types.

+ Fix comment in test: -g -> -gdwarf-5

Jan 13 2022, 2:10 AM · debug-info, Restricted Project
Orlando added inline comments to D117124: [DWARF][DebugInfo] Fix off-by-one error in size of DW_TAG_base_type types.
Jan 13 2022, 2:03 AM · debug-info, Restricted Project
Orlando updated the diff for D117124: [DWARF][DebugInfo] Fix off-by-one error in size of DW_TAG_base_type types.

Thanks for taking a look @probinson.

Jan 13 2022, 2:03 AM · debug-info, Restricted Project

Jan 12 2022

Orlando requested review of D117124: [DWARF][DebugInfo] Fix off-by-one error in size of DW_TAG_base_type types.
Jan 12 2022, 8:54 AM · debug-info, Restricted Project

Jan 10 2022

Orlando added a comment to D115449: [Dexter] Allow DexUnreachable to be specified in supplementary .dex files.

(Still LGTM)

Jan 10 2022, 4:02 AM · Restricted Project

Jan 6 2022

Orlando added a comment to D115325: [DWARF] Fix PR51087 Extraneous enum record in DWARF with type units.

Hrm :/ I'm not super enthusiastic about either direction. I'm starting to wonder whether this general direction is viable - that some DWARF consumers might not find types that are in type units but aren't referenced from the CUs at all.

Do you have a measure of the debug info size improvement of this direction? If it doesn't end up counting for much, maybe it's not worth trying to create this possibly novel debug info?

Jan 6 2022, 5:09 AM · debug-info, Restricted Project

Jan 5 2022

Orlando accepted D115449: [Dexter] Allow DexUnreachable to be specified in supplementary .dex files.

Please can you update Commands.md too? LGTM with nit, thanks.

Jan 5 2022, 12:00 AM · Restricted Project

Jan 4 2022

Orlando added a comment to D115325: [DWARF] Fix PR51087 Extraneous enum record in DWARF with type units.

Thanks very much for the reproducer and revert @dblaikie.

Jan 4 2022, 9:09 AM · debug-info, Restricted Project

Dec 17 2021

Orlando added a comment to rG54586582d3e1: [NFC] Fix type-units-maybe-unused-types.ll from D115325 (78d15a112cbd).

There's a mistake in the commit message, I meant "Example of failing bot: https://lab.llvm.org/buildbot/#/builders/123/builds/7772".

Dec 17 2021, 3:48 AM
Orlando committed rG54586582d3e1: [NFC] Fix type-units-maybe-unused-types.ll from D115325 (78d15a112cbd) (authored by Orlando).
[NFC] Fix type-units-maybe-unused-types.ll from D115325 (78d15a112cbd)
Dec 17 2021, 3:44 AM
Orlando added a comment to D115325: [DWARF] Fix PR51087 Extraneous enum record in DWARF with type units.

I appear to have broken a bot here https://lab.llvm.org/buildbot/#/builders/105/builds/18850, looking now.

Dec 17 2021, 2:37 AM · debug-info, Restricted Project