Page MenuHomePhabricator

Orlando (Orlando Cazalet-Hyams)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2019, 8:58 AM (12 w, 3 h)

Recent Activity

Yesterday

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Thanks, I've now resubmitted this patch (1251cac62af5).

Wed, Jun 19, 4:03 AM · debug-info, Restricted Project
Orlando committed rG1251cac62af5: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through… (authored by Orlando).
[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through…
Wed, Jun 19, 3:48 AM

Tue, Jun 18

Orlando accepted D63499: Add debug location verification for !llvm.loop attachments.

LGTM. Thanks for doing this!

Tue, Jun 18, 11:33 AM · Restricted Project, debug-info
Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

There is one thing I don't understand:
It looks like !680 is only used in the !llvm.loop !679 metadata. How can that trigger a !dbg attachment points at wrong subprogram for function verifier failure?

Tue, Jun 18, 2:24 AM · debug-info, Restricted Project

Mon, Jun 17

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Hi Adrian.

Mon, Jun 17, 2:36 AM · debug-info, Restricted Project

Wed, Jun 12

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

No problem at all - reverted with rGa94715639619. I'll take a look at this next week, thank you for the info.

Wed, Jun 12, 1:41 AM · debug-info, Restricted Project
Orlando committed rGa94715639619: Revert "[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step… (authored by Orlando).
Revert "[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step…
Wed, Jun 12, 1:33 AM
Orlando added a reverting change for rG1a0f7a2077b7: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through…: rGa94715639619: Revert "[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step….
Wed, Jun 12, 1:33 AM

Tue, Jun 11

Orlando committed rG1a0f7a2077b7: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through… (authored by Orlando).
[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through…
Tue, Jun 11, 3:36 AM

Tue, May 28

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

The major change to this previously accepted patch is the modification of "bcmp-debugify-remarks.ll" and "inlined-argument.ll".
Minor changes include spelling corrections in comments and removing some superfluous debug data from the new tests.

Tue, May 28, 1:17 AM · debug-info, Restricted Project

May 20 2019

Orlando updated the diff for D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

The inlined loop metadata part has been separated into D61933 (rL361149) which this patch is now based on.

May 20 2019, 8:37 AM · debug-info, Restricted Project
Orlando added a comment to D61933: [DebugInfo] Update loop metadata for inlined loops.

Resubmitted in rL361149.

May 20 2019, 8:21 AM · Restricted Project, debug-info
Orlando committed rGed67bf8d2f31: Resubmit "[DebugInfo] Update loop metadata for inlined loops" (authored by Orlando).
Resubmit "[DebugInfo] Update loop metadata for inlined loops"
May 20 2019, 6:04 AM
Orlando added a reverting change for rG95805bc425b2: Revert "[DebugInfo] Update loop metadata for inlined loops": rGed67bf8d2f31: Resubmit "[DebugInfo] Update loop metadata for inlined loops".
May 20 2019, 6:04 AM
Orlando added a comment to D61933: [DebugInfo] Update loop metadata for inlined loops.

Reverted with commit 95805bc425b because armv8 build bots are failing.

May 20 2019, 4:31 AM · Restricted Project, debug-info
Orlando committed rG95805bc425b2: Revert "[DebugInfo] Update loop metadata for inlined loops" (authored by Orlando).
Revert "[DebugInfo] Update loop metadata for inlined loops"
May 20 2019, 4:23 AM
Orlando added a reverting change for rG6e8f1a80cd98: [DebugInfo] Update loop metadata for inlined loops: rG95805bc425b2: Revert "[DebugInfo] Update loop metadata for inlined loops".
May 20 2019, 4:23 AM
Orlando committed rG6e8f1a80cd98: [DebugInfo] Update loop metadata for inlined loops (authored by Orlando).
[DebugInfo] Update loop metadata for inlined loops
May 20 2019, 2:41 AM

May 16 2019

Orlando added inline comments to D61933: [DebugInfo] Update loop metadata for inlined loops.
May 16 2019, 2:33 AM · Restricted Project, debug-info
Orlando updated the diff for D61933: [DebugInfo] Update loop metadata for inlined loops.

Address suggestions and add some const correctness.

May 16 2019, 2:28 AM · Restricted Project, debug-info

May 15 2019

Orlando added inline comments to D61933: [DebugInfo] Update loop metadata for inlined loops.
May 15 2019, 9:19 AM · Restricted Project, debug-info
Orlando updated the summary of D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
May 15 2019, 1:45 AM · debug-info, Restricted Project
Orlando created D61933: [DebugInfo] Update loop metadata for inlined loops.
May 15 2019, 1:37 AM · Restricted Project, debug-info

May 14 2019

Orlando requested review of D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
May 14 2019, 8:29 AM · debug-info, Restricted Project
Orlando reopened D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
May 14 2019, 8:23 AM · debug-info, Restricted Project
Orlando updated the diff for D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

This update addresses the problems with the original patch that caused the built bot failures
(sorry about that!).

May 14 2019, 8:19 AM · debug-info, Restricted Project

May 7 2019

Orlando committed rG78a6062c24dc: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through… (authored by Orlando).
[DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through…
May 7 2019, 8:36 AM
Orlando committed rG0d0517733713: Test commit access (authored by Orlando).
Test commit access
May 7 2019, 2:33 AM

May 2 2019

Orlando added a comment to D61372: [coroutines] Fix spills of static array allocas.

Hi, I added a few inline comments, mostly just nits on style.

May 2 2019, 3:18 AM · Restricted Project

Apr 30 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

My take-away from the discussion was this: It is desirable to map the instructions to something in the loop (e.g., not line 0), unless doing so will provide confusing information to the mapping that PGO uses to optimize the relevant branches. Am I correct in saying that this latter issue is of minimal concern in this case?

Apr 30 2019, 1:51 AM · debug-info, Restricted Project

Apr 29 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

A summary of the discussion so far:

Apr 29 2019, 6:39 AM · debug-info, Restricted Project

Apr 18 2019

Orlando added a comment to D60858: AMDGPU: Skip debug instructions in assert.

Are the function attributes in the test necessary? Watching other reviews leads me to believe these are undesirable. Apart from this it LGTMy untrained eyes (I'm new to reviewing!).

Apr 18 2019, 3:14 AM
Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

How will this appear to profiling tools using PC sampling and using debug info to map the PC samples back to line numbers in the code?

I brought this up in some offline discussions which all concluded that the impact on profilers would be small and the trade off for better debugging is worth it. The impact on profilers seems like it would be small because the middle block is only visited once after running through the vectorized loop.

I am glad you asked because this concern gives rise to an argument for giving the middle block instructions line 0 instead, and i am interested in hearing other's opinions.

Interesting. The middle block just has the check for whether or not we need to run the remainder loop, right? I can definitely see this as kind of latch-like.

@jmellorcrummey , do you have an opinion on this?

Apr 18 2019, 2:52 AM · debug-info, Restricted Project
Orlando updated the diff for D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Sorry, I missed a couple of failing tests. I've fixed them and updated the diff.

Apr 18 2019, 2:44 AM · debug-info, Restricted Project

Apr 17 2019

Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

How will this appear to profiling tools using PC sampling and using debug info to map the PC samples back to line numbers in the code?

Apr 17 2019, 11:09 AM · debug-info, Restricted Project
Orlando updated the summary of D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
Apr 17 2019, 10:23 AM · debug-info, Restricted Project
Orlando created D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
Apr 17 2019, 10:14 AM · debug-info, Restricted Project
Orlando added a watcher for debug-info: Orlando.
Apr 17 2019, 3:20 AM

Apr 12 2019

Orlando updated the diff for D60556: [DebugInfo@O2] Fix pr41175 Dead Store Elimination missing debug loc.

I've made the suggested changes.

Apr 12 2019, 2:03 AM · Restricted Project, debug-info

Apr 11 2019

Orlando created D60556: [DebugInfo@O2] Fix pr41175 Dead Store Elimination missing debug loc.
Apr 11 2019, 2:11 AM · Restricted Project, debug-info

Apr 2 2019

Orlando updated the diff for D59944: [DebugInfo] Fix pr41180 : Loop Vectorization Debugify Failure.

Updated a comment with some more info as vsk suggested.

Apr 2 2019, 2:40 AM · Restricted Project

Apr 1 2019

Orlando updated the diff for D59944: [DebugInfo] Fix pr41180 : Loop Vectorization Debugify Failure.

The test has been updated to check for the expected instructions.

Apr 1 2019, 2:18 AM · Restricted Project
Orlando updated the diff for D59944: [DebugInfo] Fix pr41180 : Loop Vectorization Debugify Failure.

I've updated the test to include the source and commands to generate the IR it uses. Please note that I stripped out the call void @llvm.dbg.* lines from the test file by hand so any regenerated IR will look more cluttered.

Apr 1 2019, 1:11 AM · Restricted Project

Mar 28 2019

Orlando created D59944: [DebugInfo] Fix pr41180 : Loop Vectorization Debugify Failure.
Mar 28 2019, 9:47 AM · Restricted Project