Page MenuHomePhabricator

[clang-tidy] Add bugprone-empty-catch check
Needs ReviewPublic

Authored by PiotrZSL on Fri, Feb 24, 10:15 AM.

Details

Summary

Detects and suggests addressing issues with empty catch statements.

Diff Detail

Event Timeline

PiotrZSL created this revision.Fri, Feb 24, 10:15 AM
Herald added a project: Restricted Project. · View Herald Transcript
PiotrZSL requested review of this revision.Fri, Feb 24, 10:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Feb 24, 10:15 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko added inline comments.
clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp
78

Excessive newline.

clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst
170

Mistake in default value formatting.

PiotrZSL added inline comments.Fri, Feb 24, 12:30 PM
clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst
170

Yy, what mistake ? (empty) not needed, or something else should be used instead of `` ?

clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst
170

Sorry, I mistook (empty) as part of value. May be just say this in words to avoid such confusions?

PiotrZSL marked 3 inline comments as done.Fri, Feb 24, 12:39 PM
PiotrZSL updated this revision to Diff 500274.Fri, Feb 24, 12:40 PM

Fix review comments

PiotrZSL updated this revision to Diff 503365.Wed, Mar 8, 7:33 AM

Ping, Rebase