Passionate test-driven developer
User Details
- User Since
- Jul 15 2013, 12:45 PM (397 w, 2 d)
Jun 12 2020
Yeah, the restriction to the header file is a bug. It was a misconception on my part when I originally wrote the matcher.
Mar 20 2019
Review takes too long to make forward progress; abandoning.
Review process takes too long to make forward progress; abandoning.
Review takes too long to make forward progress; abandoning.
Mar 15 2019
To avoid passing lots of state to/from extracted functions, extract a class instead and use member variables for most of the state
Jan 5 2019
I managed to do some limited testing on the original source file from the bug report in lldb and verified that the correct fix was applied there. I also tried a few other files and verified no false positives.
Uh... I'm developing on Windows, which doesn't have a solution for generating compile_commands.json, so I can't easily test this on the entire clang codebase. I will test on a source file based on the original bug report.
No really, update from review comments :)
Update from review comments
Update from review comments
Update from review comments
I really want to get these reviewed quickly. Otherwise, I will run out of available time to complete them and get them submitted.
I really want to get these reviewed quickly. Otherwise, I will run out of available time to complete them and get them submitted.
Jan 4 2019
Extract Function try_run
No, really, fix typo in id
Fix typo in id
Fix typo in id
Jan 3 2019
clang-format
May 1 2018
Other than a few minor nits, ship it.
Apr 23 2018
Jan 19 2017
Jan 18 2017
Don't do this without introducing an option to turn it off.
Apr 6 2016
That we've had to fix this twice now tells me that our collective memory is forgetful :).
There are some APIs where a series of strings are passed as a single char * with NUL separators between the strings and the last string is indicated by two NUL characters in a row. For instance, see the MSDN documentation for the lpDependencies argument to [[ https://msdn.microsoft.com/en-us/library/windows/desktop/ms682450(v=vs.85).aspx | CreateService ]]. Such strings literals in the code look like:
Apr 4 2016
As it stands currently, you can't commit a header with CHECK-MESSAGES and CHECK-FIXES lines and have them verified.
Mar 30 2016
I'm sorry to be such a nag and I know you're busy, but....
Can you summarize the improvements in docs/ReleaseNotes.rst, please?
Can you summarize the improvements in docs/ReleaseNotes.rst please?
Can you summarize this check in docs/ReleaseNotes.rst in the clang-tidy section, please?
Maybe you need to rebase first? I haven't used arc.
Please summarize the improvements in docs/ReleaseNotes.rst in the clang tidy section.
Please summarize this check in docs/ReleaseNotes.rst in the clang-tidy section.
Please summarize this check in docs/ReleaseNotes.rst.
You can submit the release notes changes in a new patch.
Can you add a synopsis of this new check to docs/ReleaseNotes.rst please?
Mar 29 2016
Mar 28 2016
Can you add something to the docs/ReleaseNotes.rst for this new check, please?
Squeak
Mar 27 2016
Remove brace initializers from test code.
Mar 26 2016
Update release notes
Mar 22 2016
Looks like I forgot to remove brace initializers from the test files. I will fix that.
Mar 18 2016
test/clang-tidy/misc-unused-parameters.cpp currently does a hack to verify headers by committing the manually fixed header and diffing it:
Update from comments.
Update documentation to reflect changes in the implementation.
Update from review comments.
Sort check names in list
Mar 17 2016
LGTM
Mar 16 2016
There is utility in the definition of a function in saying that an argument is const int i instead of int i. The const-ness declares the intent that this local variable is not going to be modified. However, there is that oddity in C++ that allows a declaration to say void f(int i); and the implementation to say void f(const int i) { ... }.
Mar 14 2016
Mar 10 2016
Another week without reviews...
I do not have commit access, so I will need someone to commit this for me.
Mar 2 2016
I need to update from review comments and upload a new diff.
Discarding due to inaction by reviewers.
Discarding due to inaction by reviewers.
Discarding due to inaction by reviewers.
Discarding due to inaction by reviewers.
Squeak. This has been waiting on review for over two weeks....
Mar 1 2016
Squeak
Feb 26 2016
Feb 22 2016
Feb 20 2016
Other than a few nits, LGTM.
make check-all passes in release
Feb 19 2016
I do not have commit access, so someone else will need to commit this. Let me know if it needs rebasing.