Page MenuHomePhabricator

LegalizeAdulthood (Richard)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2013, 12:45 PM (313 w, 6 d)

Recent Activity

Mar 20 2019

LegalizeAdulthood abandoned D7982: Add readability-duplicate-include check to clang-tidy.

Review takes too long to make forward progress; abandoning.

Mar 20 2019, 12:53 PM
LegalizeAdulthood abandoned D17482: [clang-tidy] Allow tests to verify changes made to header files.

Review process takes too long to make forward progress; abandoning.

Mar 20 2019, 12:53 PM
LegalizeAdulthood abandoned D18509: clang-tidy: add_new_check.py stubs out release notes.

Review takes too long to make forward progress; abandoning.

Mar 20 2019, 12:53 PM
LegalizeAdulthood added inline comments to D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions.
Mar 20 2019, 12:42 PM · Restricted Project
LegalizeAdulthood added a comment to D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

@LegalizeAdulthood your stuck on the commit right things right? If you want I can commit for you (maybe even later) as you said you are limited on time.

Mar 20 2019, 12:33 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py.
Mar 20 2019, 10:59 AM · Restricted Project

Mar 15 2019

LegalizeAdulthood retitled D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py from [clang-tidy] Refactor: Compose Method on check_clang_tidy.py to [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py.
Mar 15 2019, 12:35 AM · Restricted Project
LegalizeAdulthood updated the diff for D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py.

To avoid passing lots of state to/from extracted functions, extract a class instead and use member variables for most of the state

Mar 15 2019, 12:34 AM · Restricted Project

Jan 5 2019

LegalizeAdulthood added a comment to D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

I managed to do some limited testing on the original source file from the bug report in lldb and verified that the correct fix was applied there. I also tried a few other files and verified no false positives.

Jan 5 2019, 5:14 PM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

Uh... I'm developing on Windows, which doesn't have a solution for generating compile_commands.json, so I can't easily test this on the entire clang codebase. I will test on a source file based on the original bug report.

Jan 5 2019, 4:04 PM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions.

No really, update from review comments :)

Jan 5 2019, 4:00 PM · Restricted Project
LegalizeAdulthood updated the diff for D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions.

Update from review comments

Jan 5 2019, 3:57 PM · Restricted Project
LegalizeAdulthood added inline comments to D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions.
Jan 5 2019, 3:56 PM · Restricted Project
LegalizeAdulthood added a comment to D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

Did you check if the changes actually fix the problematic behaviour? Did you run it over any project and did the code-transformation break the code, false positives, ...?

Otherwise LGTM

Jan 5 2019, 2:31 PM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions.

Update from review comments

Jan 5 2019, 2:26 PM · Restricted Project
LegalizeAdulthood added inline comments to D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions.
Jan 5 2019, 2:18 PM · Restricted Project
LegalizeAdulthood updated the diff for D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

Update from review comments

Jan 5 2019, 2:06 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.
Jan 5 2019, 2:06 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.
Jan 5 2019, 9:36 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

I really want to get these reviewed quickly. Otherwise, I will run out of available time to complete them and get them submitted.

Jan 5 2019, 9:28 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py.

I really want to get these reviewed quickly. Otherwise, I will run out of available time to complete them and get them submitted.

Jan 5 2019, 9:28 AM · Restricted Project

Jan 4 2019

LegalizeAdulthood updated the diff for D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py.

Extract Function try_run

Jan 4 2019, 5:34 PM · Restricted Project
LegalizeAdulthood created D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py.
Jan 4 2019, 5:12 PM · Restricted Project
LegalizeAdulthood retitled D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions from Handle case/default statements when simplifying boolean expressions to [clang-tidy] Handle case/default statements when simplifying boolean expressions.
Jan 4 2019, 2:06 PM · Restricted Project
LegalizeAdulthood updated the diff for D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

No, really, fix typo in id

Jan 4 2019, 10:50 AM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

Fix typo in id

Jan 4 2019, 10:45 AM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

Fix typo in id

Jan 4 2019, 10:42 AM · Restricted Project, Restricted Project
LegalizeAdulthood created D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.
Jan 4 2019, 10:42 AM · Restricted Project, Restricted Project

Jan 3 2019

LegalizeAdulthood updated the diff for D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions.

clang-format

Jan 3 2019, 5:36 PM · Restricted Project
LegalizeAdulthood created D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions.
Jan 3 2019, 5:33 PM · Restricted Project

May 1 2018

LegalizeAdulthood added inline comments to D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals.
May 1 2018, 10:39 AM · Restricted Project
LegalizeAdulthood accepted D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals.

Other than a few minor nits, ship it.

May 1 2018, 10:22 AM · Restricted Project

Apr 23 2018

LegalizeAdulthood added inline comments to D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals.
Apr 23 2018, 12:37 PM · Restricted Project

Jan 19 2017

LegalizeAdulthood added a comment to D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer..

Don't do this without introducing an option to turn it off.

To clarify my reasoning:
You imposing your subjective idea of goodness on the code, i.e. style. Other people will have different ideas about what they want from the code. So, to quote the X Window System Maxim, provide tools not rules. Allow people to say whether or not they want the raw string literal in this case.

I agree. Which mode do you think should be the default?

Jan 19 2017, 10:33 AM · Restricted Project
LegalizeAdulthood added a comment to D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer..

Don't do this without introducing an option to turn it off.

Jan 19 2017, 10:27 AM · Restricted Project

Jan 18 2017

LegalizeAdulthood added a comment to D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer..

Don't do this without introducing an option to turn it off.

Jan 18 2017, 10:18 AM · Restricted Project

Apr 6 2016

LegalizeAdulthood added a comment to D18852: [clang-tidy] fix a crash with -fdelayed-template-parsing in UnnecessaryValueParamCheck..

That we've had to fix this twice now tells me that our collective memory is forgetful :).

Apr 6 2016, 7:47 PM
LegalizeAdulthood added a comment to D18783: [clang-tidy] add new checker for string literal with NUL character..

There are some APIs where a series of strings are passed as a single char * with NUL separators between the strings and the last string is indicated by two NUL characters in a row. For instance, see the MSDN documentation for the lpDependencies argument to CreateService. Such strings literals in the code look like:

Apr 6 2016, 9:46 AM
LegalizeAdulthood added inline comments to D18745: [clang-tidy] Adds modernize-use-bool-literals check..
Apr 6 2016, 9:36 AM

Apr 4 2016

LegalizeAdulthood added a comment to D17482: [clang-tidy] Allow tests to verify changes made to header files.

My main concern is that this change makes the already complicated and unobvious testing mechanism [...]

Apr 4 2016, 8:37 AM
LegalizeAdulthood added a comment to D17482: [clang-tidy] Allow tests to verify changes made to header files.

As it stands currently, you can't commit a header with CHECK-MESSAGES and CHECK-FIXES lines and have them verified.

Apr 4 2016, 8:25 AM
LegalizeAdulthood added a comment to D18509: clang-tidy: add_new_check.py stubs out release notes.

With this change, won't you need to update 2 different repos: clang and extra? Is it possible to update both with a single Phabricator patch?

Apr 4 2016, 8:23 AM

Mar 30 2016

LegalizeAdulthood added inline comments to D18608: note for top-level consts in function decls tidy.
Mar 30 2016, 2:33 PM
LegalizeAdulthood added inline comments to D18582: [Clang-tidy] Update release notes with list of checks added since 3.8.
Mar 30 2016, 2:23 PM
LegalizeAdulthood added inline comments to D18608: note for top-level consts in function decls tidy.
Mar 30 2016, 2:16 PM
LegalizeAdulthood added a comment to D17482: [clang-tidy] Allow tests to verify changes made to header files.

I'm sorry to be such a nag and I know you're busy, but....

Mar 30 2016, 2:13 PM
LegalizeAdulthood added inline comments to D18509: clang-tidy: add_new_check.py stubs out release notes.
Mar 30 2016, 2:07 PM
LegalizeAdulthood added a comment to D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable..

Can you summarize the improvements in docs/ReleaseNotes.rst, please?

Mar 30 2016, 10:00 AM
LegalizeAdulthood added inline comments to D18582: [Clang-tidy] Update release notes with list of checks added since 3.8.
Mar 30 2016, 9:59 AM
LegalizeAdulthood added a comment to D18475: [clang-tidy] Add more detection rules for redundant c_str calls..

Can you summarize the improvements in docs/ReleaseNotes.rst please?

Mar 30 2016, 9:56 AM
LegalizeAdulthood added a comment to D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list..

Can you summarize this check in docs/ReleaseNotes.rst in the clang-tidy section, please?

Mar 30 2016, 9:55 AM
LegalizeAdulthood added a comment to D18408: readability check for const params in declarations.

Maybe you need to rebase first? I haven't used arc.

Mar 30 2016, 9:54 AM
LegalizeAdulthood added a comment to D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse.

Please summarize the improvements in docs/ReleaseNotes.rst in the clang tidy section.

Mar 30 2016, 9:53 AM
LegalizeAdulthood added a comment to D18136: boost-use-to-string check.

Please summarize this check in docs/ReleaseNotes.rst in the clang-tidy section.

Mar 30 2016, 9:52 AM
LegalizeAdulthood added a comment to D18265: [clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature.

Please summarize this check in docs/ReleaseNotes.rst.

Mar 30 2016, 9:49 AM
LegalizeAdulthood added a comment to D18408: readability check for const params in declarations.

You can submit the release notes changes in a new patch.

Mar 30 2016, 9:45 AM
LegalizeAdulthood added a comment to D17811: [clang-tidy] Add check to detect dangling references in value handlers..

Can you add a synopsis of this new check to docs/ReleaseNotes.rst please?

Mar 30 2016, 9:44 AM

Mar 29 2016

LegalizeAdulthood added inline comments to D7982: Add readability-duplicate-include check to clang-tidy.
Mar 29 2016, 12:58 AM

Mar 28 2016

LegalizeAdulthood added a comment to D17491: Add performance check to flag function parameters of expensive to copy types that can be safely converted to const references..

Can you add something to the docs/ReleaseNotes.rst for this new check, please?

Mar 28 2016, 8:16 PM
LegalizeAdulthood added a comment to D17482: [clang-tidy] Allow tests to verify changes made to header files.

Squeak

Mar 28 2016, 8:14 PM

Mar 27 2016

LegalizeAdulthood retitled D18509: clang-tidy: add_new_check.py stubs out release notes from to clang-tidy: add_new_check.py stubs out release notes.
Mar 27 2016, 10:16 PM
LegalizeAdulthood closed D16529: [clang-tidy] Add modernize-raw-string-literal check.
Mar 27 2016, 9:49 AM
LegalizeAdulthood updated the diff for D16529: [clang-tidy] Add modernize-raw-string-literal check.

Remove brace initializers from test code.

Mar 27 2016, 8:36 AM

Mar 26 2016

LegalizeAdulthood updated the diff for D16529: [clang-tidy] Add modernize-raw-string-literal check.

Update release notes

Mar 26 2016, 10:35 PM
LegalizeAdulthood closed D18263: [clang-tools-extra] Add release notes documentation.
Mar 26 2016, 10:31 PM

Mar 22 2016

LegalizeAdulthood added a comment to D16529: [clang-tidy] Add modernize-raw-string-literal check.

Looks like I forgot to remove brace initializers from the test files. I will fix that.

Mar 22 2016, 10:34 AM
LegalizeAdulthood added inline comments to D15332: new clang-tidy checker readability-non-const-parameter.
Mar 22 2016, 10:33 AM

Mar 18 2016

LegalizeAdulthood added a comment to D17482: [clang-tidy] Allow tests to verify changes made to header files.

test/clang-tidy/misc-unused-parameters.cpp currently does a hack to verify headers by committing the manually fixed header and diffing it:

Mar 18 2016, 10:07 PM
LegalizeAdulthood added a comment to D17482: [clang-tidy] Allow tests to verify changes made to header files.

Can you [...] say how many times this feature is going to be used, if it gets added to the testing script?

Mar 18 2016, 10:04 PM
LegalizeAdulthood added a comment to D17482: [clang-tidy] Allow tests to verify changes made to header files.

Sorry for leaving this without attention for a while.

I'm somewhat concerned about this change. It's adding a certain level of complexity, but doesn't cover some less trivial cases like handling of multiple headers.

Mar 18 2016, 10:02 PM
LegalizeAdulthood updated the diff for D16529: [clang-tidy] Add modernize-raw-string-literal check.

Update from comments.
Update documentation to reflect changes in the implementation.

Mar 18 2016, 9:59 PM
LegalizeAdulthood updated the diff for D18263: [clang-tools-extra] Add release notes documentation.

Update from review comments.

Mar 18 2016, 8:56 PM
LegalizeAdulthood added a comment to D18191: [clang-tidy] Add check for function parameters that are const& to builtin types.

There is utility in the definition of a function in saying that an argument is const int i instead of int i. The const-ness declares the intent that this local variable is not going to be modified. However, there is that oddity in C++ that allows a declaration to say void f(int i); and the implementation to say void f(const int i) { ... }.

I think I would like the fixit to preserve the const-ness of the argument while still stripping it of it's reference.

The usual pattern for that is to have the definition use const, and the declaration not, since it's an implementation detail if the passed parameter is modified. And, unfortunately, I'm stuck with one compiler that mangles those two differently, causing link errors.

Having void foo(const int i) in a declaration makes me suspicious, since the const is meaningless.

I could make this an option? If the option is set, emit 'const type' if the Decl hasBody?

Mar 18 2016, 2:21 PM
LegalizeAdulthood added inline comments to D18136: boost-use-to-string check.
Mar 18 2016, 1:45 PM
LegalizeAdulthood added inline comments to D18263: [clang-tools-extra] Add release notes documentation.
Mar 18 2016, 12:12 AM
LegalizeAdulthood updated the diff for D18263: [clang-tools-extra] Add release notes documentation.

Sort check names in list

Mar 18 2016, 12:11 AM
LegalizeAdulthood retitled D18263: [clang-tools-extra] Add release notes documentation from to [clang-tools-extra] Add release notes documentation.
Mar 18 2016, 12:08 AM

Mar 17 2016

LegalizeAdulthood added a comment to D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing..

LGTM

Mar 17 2016, 9:09 AM

Mar 16 2016

LegalizeAdulthood added inline comments to D18191: [clang-tidy] Add check for function parameters that are const& to builtin types.
Mar 16 2016, 9:32 AM
LegalizeAdulthood added a comment to D18191: [clang-tidy] Add check for function parameters that are const& to builtin types.

There is utility in the definition of a function in saying that an argument is const int i instead of int i. The const-ness declares the intent that this local variable is not going to be modified. However, there is that oddity in C++ that allows a declaration to say void f(int i); and the implementation to say void f(const int i) { ... }.

Mar 16 2016, 9:29 AM

Mar 14 2016

LegalizeAdulthood added inline comments to D18136: boost-use-to-string check.
Mar 14 2016, 9:40 AM

Mar 10 2016

LegalizeAdulthood added a comment to D17482: [clang-tidy] Allow tests to verify changes made to header files.

Another week without reviews...

Mar 10 2016, 1:18 PM
LegalizeAdulthood added a comment to D16529: [clang-tidy] Add modernize-raw-string-literal check.

I do not have commit access, so I will need someone to commit this for me.

Mar 10 2016, 1:18 PM

Mar 2 2016

LegalizeAdulthood added a comment to D7982: Add readability-duplicate-include check to clang-tidy.

I need to update from review comments and upload a new diff.

Mar 2 2016, 12:01 PM
LegalizeAdulthood abandoned D10005: Refactor: Simplify boolean expressions in tools/llvm-objdump.

Discarding due to inaction by reviewers.

Mar 2 2016, 9:38 AM
LegalizeAdulthood abandoned D9977: Refactor: Simplify boolean conditional return statements in llvm/lib/MC/MCParser.

Discarding due to inaction by reviewers.

Mar 2 2016, 9:38 AM
LegalizeAdulthood abandoned D10013: Refactor: Simplify boolean conditional return statements in lib/Driver.

Discarding due to inaction by reviewers.

Mar 2 2016, 9:38 AM
LegalizeAdulthood abandoned D9985: Refactor: Simplify boolean conditional return statements in lib/Target/R600.

Discarding due to inaction by reviewers.

Mar 2 2016, 9:38 AM
LegalizeAdulthood added a comment to D16529: [clang-tidy] Add modernize-raw-string-literal check.

Squeak. This has been waiting on review for over two weeks....

Mar 2 2016, 9:37 AM

Mar 1 2016

LegalizeAdulthood added a comment to D17482: [clang-tidy] Allow tests to verify changes made to header files.

Squeak

Mar 1 2016, 1:07 PM

Feb 26 2016

LegalizeAdulthood added inline comments to D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics..
Feb 26 2016, 1:08 PM

Feb 22 2016

LegalizeAdulthood added inline comments to D17446: ASTMatchers: add new statement/decl matchers.
Feb 22 2016, 10:07 AM
LegalizeAdulthood added a comment to D17484: [clang-tidy] introduce modernize-deprecated-headers check.

Thank you for this check! Mostly looks good, but there are a number of style nits.

The most important question to this check is that the standard doesn't guarantee that the C++ headers declare all the same functions in the global namespace (at least, this is how I understand the section of the standard you quoted).

Feb 22 2016, 9:45 AM

Feb 20 2016

LegalizeAdulthood added a comment to D17484: [clang-tidy] introduce modernize-deprecated-headers check.

Other than a few nits, LGTM.

Feb 20 2016, 5:40 PM
LegalizeAdulthood added a comment to D9979: Refactor: Simplify boolean conditional return statements in lib/Target/AArch64.

make check-all passes in release

Feb 20 2016, 10:57 AM
LegalizeAdulthood updated the diff for D9979: Refactor: Simplify boolean conditional return statements in lib/Target/AArch64.
Feb 20 2016, 10:57 AM
LegalizeAdulthood updated D17482: [clang-tidy] Allow tests to verify changes made to header files.
Feb 20 2016, 8:13 AM
LegalizeAdulthood retitled D17482: [clang-tidy] Allow tests to verify changes made to header files from to [clang-tidy] Allow tests to verify changes made to header files.
Feb 20 2016, 8:13 AM

Feb 19 2016

LegalizeAdulthood added a comment to D9979: Refactor: Simplify boolean conditional return statements in lib/Target/AArch64.

I do not have commit access, so someone else will need to commit this. Let me know if it needs rebasing.

Feb 19 2016, 9:23 AM
LegalizeAdulthood abandoned D9971: Refactor: Simplify boolean conditional return statements in llvm/lib/CodeGen/SelectionDAG.
Feb 19 2016, 9:23 AM