Page MenuHomePhabricator

LegalizeAdulthood (Richard)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2013, 12:45 PM (505 w, 3 h)

Passionate test-driven developer

I have commit access to clang-tidy.

Recent Activity

Wed, Mar 1

LegalizeAdulthood updated LegalizeAdulthood.
Wed, Mar 1, 2:13 PM

Sep 24 2022

LegalizeAdulthood accepted D134590: [clang-tidy] Fix a false positive in readability-simplify-boolean-expr.

LGTM

Sep 24 2022, 9:15 AM · Restricted Project, Restricted Project

Jul 3 2022

LegalizeAdulthood committed rGf7a80c3d08d4: [clang-tidy] Properly forward clang-tidy output when running tests (authored by nicovank).
[clang-tidy] Properly forward clang-tidy output when running tests
Jul 3 2022, 3:31 PM · Restricted Project, Restricted Project
LegalizeAdulthood closed D127807: [clang-tidy] Properly forward clang-tidy output when running tests.
Jul 3 2022, 3:31 PM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D127807: [clang-tidy] Properly forward clang-tidy output when running tests.

I will submit it

Jul 3 2022, 3:24 PM · Restricted Project, Restricted Project
LegalizeAdulthood committed rGa65a3bffd31f: [clang-tidy] Don't treat invalid branches as identical (authored by ishaangandhi).
[clang-tidy] Don't treat invalid branches as identical
Jul 3 2022, 2:51 PM · Restricted Project, Restricted Project
LegalizeAdulthood closed D128402: [clang-tidy] Don't treat invalid branches as identical.
Jul 3 2022, 2:51 PM · Restricted Project, Restricted Project

Jul 1 2022

LegalizeAdulthood added inline comments to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
Jul 1 2022, 1:50 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
Jul 1 2022, 1:49 PM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

You forgot to add "Differential Revison: https://reviews.llvm.org/DXXXXXX" in the commit message, which is how Phabricator identifies the differential to close. I don't think it has anything to do with rebasing.

Jul 1 2022, 1:46 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Jul 1 2022, 1:42 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D128511: [clang-tidy] Make the cert/uppercase-literal-suffix-integer fully hermetic..
Jul 1 2022, 1:40 PM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D127807: [clang-tidy] Properly forward clang-tidy output when running tests.

Thanks for this, like Nathan James this has been pestering me for a while :)

Jul 1 2022, 10:49 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

Please provide the name and email address you wish to use on the commit and I will submit.

Jul 1 2022, 10:46 AM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D128402: [clang-tidy] Don't treat invalid branches as identical.
Jul 1 2022, 10:45 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

I can submit after you address additional comments by Nathan James.

Jul 1 2022, 10:44 AM · Restricted Project, Restricted Project

Jun 29 2022

LegalizeAdulthood requested changes to D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.

Clang-tidy tests and docs have been moved to subdirectories by module, please rebase to main:HEAD

Jun 29 2022, 8:30 AM · Restricted Project, Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init.

Please add a summary of the fix to the release notes for this check.

Jun 29 2022, 8:27 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`.

This whole check seems weird to me. I mean, almost every use of a standard container could throw std::bad_alloc but we don't insist on a local catch for bad_alloc at every possible throwing call site.

Jun 29 2022, 8:23 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext.
Jun 29 2022, 8:19 AM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128402: [clang-tidy] Don't treat invalid branches as identical.

I can submit after you address additional comments by Nathan James.

Jun 29 2022, 8:17 AM · Restricted Project, Restricted Project

Jun 27 2022

LegalizeAdulthood added a comment to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

I pushed this change, but for some reason phabricator doesn't show it and close the review... I wonder if it's because I rebased it?

Jun 27 2022, 9:36 AM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D128402: [clang-tidy] Don't treat invalid branches as identical.

LGTM

Jun 27 2022, 9:35 AM · Restricted Project, Restricted Project

Jun 25 2022

LegalizeAdulthood committed rGb2cb7e81f897: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when… (authored by jspam).
[clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when…
Jun 25 2022, 3:19 PM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

Well, it must have been unrelated to your change or some weird interaction on my machine because I rebased and ran check-clang-extra again and it passed this time.

Jun 25 2022, 2:49 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Jun 25 2022, 1:27 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128372: [Clang-Tidy] Empty Check.
Jun 25 2022, 1:16 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128402: [clang-tidy] Don't treat invalid branches as identical.

Rebase against main to get updated docs

Jun 25 2022, 1:13 PM · Restricted Project, Restricted Project

Jun 24 2022

LegalizeAdulthood requested changes to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

I get a test failure when I run with your change:

Jun 24 2022, 11:17 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

I see :) Yes, looks like Git's rename detection did its job.

Thanks for the review. Could you or someone else please merge this for me? Author: Joachim Priesner <llvm-project-704996@jspam.de>

Jun 24 2022, 9:54 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker .
Jun 24 2022, 9:53 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

OK, I've pushed the link fix and the sorting fix to main so if you rebase again, it should just show your changes to the release notes.

Jun 24 2022, 9:49 AM · Restricted Project, Restricted Project
LegalizeAdulthood committed rG5e97788a3eca: [clang-tidy] Update release notes (NFC) (authored by LegalizeAdulthood).
[clang-tidy] Update release notes (NFC)
Jun 24 2022, 9:49 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Jun 24 2022, 9:37 AM · Restricted Project, Restricted Project

Jun 23 2022

LegalizeAdulthood accepted D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

LGTM

Jun 23 2022, 10:51 AM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128402: [clang-tidy] Don't treat invalid branches as identical.
Jun 23 2022, 10:50 AM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 23 2022, 10:49 AM · Restricted Project, Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 23 2022, 10:48 AM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 23 2022, 10:47 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

@LegalizeAdulthood Not sure what exactly you mean by "fold your changes into checkers/cppcoreguidelines/virtual-class-destructor.cpp". The only rebase conflict was in VirtualClassDestructorCheck.cpp. Please let me know if there is still something to do.

Jun 23 2022, 10:44 AM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 23 2022, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128372: [Clang-Tidy] Empty Check.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 23 2022, 10:39 AM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker .

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 23 2022, 10:38 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Jun 23 2022, 10:37 AM · Restricted Project, Restricted Project

Jun 22 2022

LegalizeAdulthood requested changes to D117593: [clang-tidy] Change google-explicit-constructor to ignore conversions and operators marked `explicit(false)`.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 22 2022, 3:06 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 22 2022, 3:06 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 22 2022, 2:13 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D126735: [clang-tidy] Silence modernize-redundant-void-arg in the case of vexing parses.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 22 2022, 2:13 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 22 2022, 2:12 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D124918: [clang-tidy] Add a new check for non-trivial unused variables..

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 22 2022, 2:11 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 22 2022, 2:11 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init.

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 22 2022, 2:10 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

Clang-Tidy tests and docs have moved to module subdirectories.

Jun 22 2022, 2:09 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Tests and docs have moved to subdirectories by module name.

Jun 22 2022, 2:06 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

Please rebase this and fold your changes into checkers/cppcoreguidelines/virtual-class-destructor.cpp

Jun 22 2022, 1:59 PM · Restricted Project, Restricted Project
LegalizeAdulthood committed rG89a1d03e2b37: [clang-tidy] Organize test files into subdirectories by module (NFC) (authored by LegalizeAdulthood).
[clang-tidy] Organize test files into subdirectories by module (NFC)
Jun 22 2022, 11:14 AM · Restricted Project, Restricted Project
LegalizeAdulthood closed D128072: [clang-tidy] Organize test files into subdirectories by module (NFC).
Jun 22 2022, 11:13 AM · Restricted Project, Restricted Project
LegalizeAdulthood committed rGb967a9755064: [clang-tidy] Fix documentation (NFC) (authored by LegalizeAdulthood).
[clang-tidy] Fix documentation (NFC)
Jun 22 2022, 9:49 AM · Restricted Project, Restricted Project

Jun 21 2022

LegalizeAdulthood added a comment to D128072: [clang-tidy] Organize test files into subdirectories by module (NFC).

This sounds like a sensible direction to me. I spot-checked the changes and they all seem reasonable. Giving my LG, but please wait a bit before landing in case someone else has the chance to spot check as well.

Jun 21 2022, 8:00 AM · Restricted Project, Restricted Project

Jun 17 2022

LegalizeAdulthood requested review of D128072: [clang-tidy] Organize test files into subdirectories by module (NFC).
Jun 17 2022, 10:28 AM · Restricted Project, Restricted Project

Jun 16 2022

LegalizeAdulthood committed rG6e566bc5523f: [clang-tidy] Organize check doc files into subdirectories (NFC) (authored by LegalizeAdulthood).
[clang-tidy] Organize check doc files into subdirectories (NFC)
Jun 16 2022, 3:06 PM · Restricted Project, Restricted Project
LegalizeAdulthood closed D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).
Jun 16 2022, 3:06 PM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

Search engines isn't really an issue, its more people who are using older versions of llvm that try and go to the documentation which turns out is a dead link.
Having said that, I still think the lack of a redirect shouldn't block this change.

Aren't we archiving old versions of the documentation, though?

We do:

https://releases.llvm.org/12.0.0/tools/clang/tools/extra/docs/
https://releases.llvm.org/11.0.0/tools/clang/tools/extra/docs/
and so on.

Giving my LG more officially now to unblock this, but I'd still appreciate some extra eyes on the Python changes.

Jun 16 2022, 10:48 AM · Restricted Project, Restricted Project

Jun 15 2022

LegalizeAdulthood added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

Ping. All review comments should be addressed in the latest diff.

Jun 15 2022, 1:37 PM · Restricted Project, Restricted Project

Jun 10 2022

LegalizeAdulthood added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

Search engines isn't really an issue, its more people who are using older versions of llvm that try and go to the documentation which turns out is a dead link.
Having said that, I still think the lack of a redirect shouldn't block this change.

Jun 10 2022, 11:15 AM · Restricted Project, Restricted Project

Jun 9 2022

LegalizeAdulthood added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

It would also be nice if there was a redirect that would dynamically translate the old links to new links.

You can do that with .htaccess, but I don't know if that's considered acceptable in clang documentation.

FWIW, I don't have any idea if this is or isn't acceptable.

Jun 9 2022, 2:11 PM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).
  • Update add_new_check.py to write out module subdir link in generated header
  • Update all links in check headers
Jun 9 2022, 7:44 AM · Restricted Project, Restricted Project
LegalizeAdulthood abandoned D118711: [hack] Build a tree of preprocessing directives.
Jun 9 2022, 4:55 AM · Restricted Project, Restricted Project
Herald added a project to D118711: [hack] Build a tree of preprocessing directives: Restricted Project.

I'm discarding this review, as it was just for comment purposes, until I have a proper implementation to discuss.

Jun 9 2022, 4:55 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

Gentle ping

My previous point about the links in the header files not being updated hasn't been addressed.

Jun 9 2022, 4:54 AM · Restricted Project, Restricted Project

Jun 8 2022

LegalizeAdulthood added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

Gentle ping

Jun 8 2022, 8:43 PM · Restricted Project, Restricted Project

Jun 2 2022

LegalizeAdulthood added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).
Jun 2 2022, 11:58 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

Can I ask what the motivation is for this change?

Jun 2 2022, 6:24 AM · Restricted Project, Restricted Project

Jun 1 2022

LegalizeAdulthood added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

I know this is a rather huge diff, but the part that needs to be reviewed is the python script changes.

Jun 1 2022, 10:15 PM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).
  • Update add_new_check.py for the case when adding a new check, not just updating the docs
  • Rebase ReleaseNotes.rst
Jun 1 2022, 10:14 PM · Restricted Project, Restricted Project
LegalizeAdulthood committed rGb418ef5cb90b: [clang-tidy] Reject invalid enum initializers in C files (authored by LegalizeAdulthood).
[clang-tidy] Reject invalid enum initializers in C files
Jun 1 2022, 9:57 PM · Restricted Project, Restricted Project
LegalizeAdulthood closed D125622: [clang-tidy] Reject invalid enum initializers in C files.
Jun 1 2022, 9:57 PM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D125622: [clang-tidy] Reject invalid enum initializers in C files.

Update from review comments

Jun 1 2022, 9:25 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D125622: [clang-tidy] Reject invalid enum initializers in C files.
Jun 1 2022, 8:30 PM · Restricted Project, Restricted Project

May 27 2022

LegalizeAdulthood updated the diff for D125622: [clang-tidy] Reject invalid enum initializers in C files.
  • Add C++ test case for acceptable operator, initializer
May 27 2022, 5:55 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D125622: [clang-tidy] Reject invalid enum initializers in C files.
May 27 2022, 5:52 PM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D125622: [clang-tidy] Reject invalid enum initializers in C files.
  • Update from review comments
  • Disallow operator, unless inside parentheses
May 27 2022, 5:43 PM · Restricted Project, Restricted Project

May 26 2022

LegalizeAdulthood requested review of D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).
May 26 2022, 12:18 PM · Restricted Project, Restricted Project

May 23 2022

LegalizeAdulthood added inline comments to D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples.
May 23 2022, 8:33 PM · Restricted Project, Restricted Project
LegalizeAdulthood committed rG89e663c4f83a: [clang-tidy] Improve add_new_check.py to recognize more checks (authored by LegalizeAdulthood).
[clang-tidy] Improve add_new_check.py to recognize more checks
May 23 2022, 8:49 AM · Restricted Project, Restricted Project
LegalizeAdulthood closed D126134: [clang-tidy] Improve add_new_check.py to recognize more checks.
May 23 2022, 8:48 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D126134: [clang-tidy] Improve add_new_check.py to recognize more checks.
May 23 2022, 8:17 AM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D126134: [clang-tidy] Improve add_new_check.py to recognize more checks.

Update from review comments

May 23 2022, 8:15 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D126134: [clang-tidy] Improve add_new_check.py to recognize more checks.
May 23 2022, 8:05 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D126134: [clang-tidy] Improve add_new_check.py to recognize more checks.

Another observation:
If some new pattern comes up and fixits aren't recognized for a check, it might be better
to switch to a whitelist for checks with fixits rather than going crazier on the file scraping.

May 23 2022, 7:59 AM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D126162: [clang-tidy] Extend SimplifyBooleanExpr demorgan support..

LGTM

May 23 2022, 7:50 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D126134: [clang-tidy] Improve add_new_check.py to recognize more checks.
May 23 2022, 7:40 AM · Restricted Project, Restricted Project

May 21 2022

LegalizeAdulthood requested review of D126134: [clang-tidy] Improve add_new_check.py to recognize more checks.
May 21 2022, 4:38 PM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D125771: [clang-tidy] Add a useful note about -std=c++11-or-later.
May 21 2022, 1:01 PM · Restricted Project, Restricted Project

May 20 2022

LegalizeAdulthood added inline comments to D125771: [clang-tidy] Add a useful note about -std=c++11-or-later.
May 20 2022, 1:59 PM · Restricted Project, Restricted Project
Herald added a project to D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter: Restricted Project.

Are we waiting on some sort of benchmark before accepting/rejecting this change?

May 20 2022, 10:22 AM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D117409: [clang-tidy] Move IncludeInserter into ClangTidyContext.

If the only thing holding this up is my comments about following the Law of Demeter, I don't think that should block submitting this change.

May 20 2022, 10:20 AM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks.

LGTM

May 20 2022, 10:16 AM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers.

LGTM
Address one nit and ship.

May 20 2022, 10:12 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers.
May 20 2022, 10:12 AM · Restricted Project, Restricted Project