Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

LegalizeAdulthood (Richard)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2013, 12:45 PM (531 w, 4 d)

Passionate test-driven developer

I have commit access to clang-tidy.

Recent Activity

Apr 10 2023

LegalizeAdulthood resigned from D147955: [clang-tidy] Extend CheckOptions to support grouping checks options.
Apr 10 2023, 12:49 PM · Restricted Project, Restricted Project

Mar 31 2023

LegalizeAdulthood resigned from D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance.
Mar 31 2023, 8:47 AM · Restricted Project, Restricted Project

Mar 29 2023

LegalizeAdulthood resigned from D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check.
Mar 29 2023, 9:06 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D56644: [clang-tidy] readability-container-size-empty handle std::string length().
Mar 29 2023, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
LegalizeAdulthood resigned from D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check.
Mar 29 2023, 9:00 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples.
Mar 29 2023, 9:00 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D117593: [clang-tidy] Change google-explicit-constructor to ignore conversions and operators marked `explicit(false)`.
Mar 29 2023, 8:59 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check.
Mar 29 2023, 8:59 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D124446: [clang-tidy] Add the misc-discarded-return-value check.
Mar 29 2023, 8:58 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D126077: Fix stack crash in classIsDerivedFrom triggered by clang-tidy.
Mar 29 2023, 8:57 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a reviewer for D126735: [clang-tidy] Silence modernize-redundant-void-arg in the case of vexing parses: njames93.
Mar 29 2023, 8:55 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`.
Mar 29 2023, 8:49 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`.

This whole check seems weird to me. I mean, almost every use of a standard container could throw std::bad_alloc but we don't insist on a local catch for bad_alloc at every possible throwing call site.

Why would we assume that every call site of stoi or stod must have an exception handler immediately around it? It's perfectly acceptable for an application to handle this at an outer scope that can't be detected by clang-tidy.

Makes sense, I implemented this check here because some projects in ByteDance used stoi with missing exception handlers caused an online crash, I think this is a relatively common problem. Perhaps only report diagnostics for stoi calls in nothrow functions?

Mar 29 2023, 8:48 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator.
Mar 29 2023, 8:46 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer..
Mar 29 2023, 8:45 AM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D130005: [clang-tidy] Prettify GlobList before serializing Options.
Mar 29 2023, 8:43 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D130665: [clang-tidy] Fix false negative in readability-convert-member-functions-to-static.
Mar 29 2023, 8:28 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D131318: [clang-tidy] Add llvm-derefencing-dyn-cast check.
Mar 29 2023, 8:28 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax.
Mar 29 2023, 8:27 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D131517: [clang-tidy] readability-implicit-bool-conversion: support implicit conversion to std::optional<bool>.
Mar 29 2023, 8:27 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D131939: [clang-tidy] Add performance-expensive-flat-container-operation check.
Mar 29 2023, 8:25 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D131985: clang-tidy: strip useless parens from `return` statements.
Mar 29 2023, 8:25 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D132294: [clang-tidy] Add check of sprintf with fixed size buffer.
Mar 29 2023, 8:23 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D132804: [clang-tidy] Add option to ignore CRTP overrides in convert-member-functions-to-static.
Mar 29 2023, 8:23 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D133102: [clang-tidy] Extend simplify-boolean-expr check.

For example, LLVM coding standards recommends using early exits: https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code

Mar 29 2023, 8:22 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.
Mar 29 2023, 8:21 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D133371: [clang-tidy][WIP] create API for extracting option types..
Mar 29 2023, 8:20 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D133436: Ground work for cuda-related checks in clang-tidy.
Mar 29 2023, 8:20 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check.
Mar 29 2023, 8:20 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D133804: Cuda Check for ignored return errors from api calls to cuda.
Mar 29 2023, 8:19 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.
Mar 29 2023, 8:19 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D133956: Cuda Check for ignored errors after calling a CUDA kernel.
Mar 29 2023, 8:19 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls.
Mar 29 2023, 8:18 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D134592: [clang-tidy] Add option to control floating point binary operators in readability-simplify-boolean-expr.
Mar 29 2023, 8:18 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`.
Mar 29 2023, 8:17 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D135822: [clang-tidy] Add option `RewriteVoidReturnType` to `modernize-use-trailing-return-type`.
Mar 29 2023, 8:17 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check.
Mar 29 2023, 8:15 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D137302: [clang-tidy] Add modernize-type-traits check.
Mar 29 2023, 8:11 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹.
Mar 29 2023, 8:11 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D137782: [clang-tidy]bugprone-fold-init-type.
Mar 29 2023, 8:09 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D138031: Add clang-tidy check for missing move constructors.
Mar 29 2023, 8:08 AM · Restricted Project, Restricted Project, Restricted Project
LegalizeAdulthood resigned from D138035: Fix clang-tidy util findNextTokenSkippingComments.
Mar 29 2023, 8:08 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression..
Mar 29 2023, 8:07 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`.
Mar 29 2023, 8:07 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result.
Mar 29 2023, 8:07 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`.
Mar 29 2023, 8:06 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D144036: [clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check.
Mar 29 2023, 8:06 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D144135: [clang-tidy] Add performance-enum-size check.
Mar 29 2023, 8:06 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D144347: [clang-tidy] Add readability-forward-usage check.
Mar 29 2023, 8:05 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D144429: [clang-tidy] Add bugprone-chained-comparison check.
Mar 29 2023, 8:05 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D144522: [clang-tidy] Add readability-operators-representation check.
Mar 29 2023, 8:04 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D144748: [clang-tidy] Add bugprone-empty-catch check.
Mar 29 2023, 8:03 AM · Restricted Project, Restricted Project, Restricted Project
LegalizeAdulthood resigned from D144828: [clang-tidy] Add misc-header-include-cycle check.
Mar 29 2023, 8:03 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape.
Mar 29 2023, 8:00 AM · Restricted Project, Restricted Project

Mar 28 2023

LegalizeAdulthood resigned from D146712: [clang-tidy] Add portability-non-portable-integer-constant check.
Mar 28 2023, 1:23 PM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert.
Mar 28 2023, 1:22 PM · Restricted Project, Restricted Project

Mar 22 2023

LegalizeAdulthood added inline comments to D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name.
Mar 22 2023, 3:15 PM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D130181: [clang-tidy] Add readability-use-early-exits check.

I'm not certain that the result of the transformation is more "readable"; is this check intended to aid conformance to a style guide?

Mar 22 2023, 10:45 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D130630: [clang-tidy] Add readability-nested-ifs check.

How does this check interact with macros that expand to if statements?

Mar 22 2023, 10:40 AM · Restricted Project, Restricted Project
LegalizeAdulthood resigned from D72940: Add a support for clang tidy to import another configurations files from .clang-tidy.

No action taken, removing myself as a reviewer

Mar 22 2023, 10:33 AM · Restricted Project, Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D63324: [clang-tidy] Replace memcpy by std::copy.
Mar 22 2023, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D18191: [clang-tidy] Add check for function parameters that are const& to builtin types: Restricted Project.
Mar 22 2023, 10:29 AM · Restricted Project
Herald added a project to D16286: [clang-tidy] Readability check for redundant parenthesis in return expression.: Restricted Project.
Mar 22 2023, 10:28 AM · Restricted Project
Herald added a project to D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL: Restricted Project.
Mar 22 2023, 10:27 AM · Restricted Project

Mar 1 2023

LegalizeAdulthood updated LegalizeAdulthood.
Mar 1 2023, 2:13 PM

Sep 24 2022

LegalizeAdulthood accepted D134590: [clang-tidy] Fix a false positive in readability-simplify-boolean-expr.

LGTM

Sep 24 2022, 9:15 AM · Restricted Project, Restricted Project

Jul 3 2022

LegalizeAdulthood committed rGf7a80c3d08d4: [clang-tidy] Properly forward clang-tidy output when running tests (authored by nicovank).
[clang-tidy] Properly forward clang-tidy output when running tests
Jul 3 2022, 3:31 PM · Restricted Project, Restricted Project
LegalizeAdulthood closed D127807: [clang-tidy] Properly forward clang-tidy output when running tests.
Jul 3 2022, 3:31 PM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D127807: [clang-tidy] Properly forward clang-tidy output when running tests.

I will submit it

Jul 3 2022, 3:24 PM · Restricted Project, Restricted Project
LegalizeAdulthood committed rGa65a3bffd31f: [clang-tidy] Don't treat invalid branches as identical (authored by ishaangandhi).
[clang-tidy] Don't treat invalid branches as identical
Jul 3 2022, 2:51 PM · Restricted Project, Restricted Project
LegalizeAdulthood closed D128402: [clang-tidy] Don't treat invalid branches as identical.
Jul 3 2022, 2:51 PM · Restricted Project, Restricted Project

Jul 1 2022

LegalizeAdulthood added inline comments to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
Jul 1 2022, 1:50 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
Jul 1 2022, 1:49 PM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

You forgot to add "Differential Revison: https://reviews.llvm.org/DXXXXXX" in the commit message, which is how Phabricator identifies the differential to close. I don't think it has anything to do with rebasing.

Jul 1 2022, 1:46 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Jul 1 2022, 1:42 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D128511: [clang-tidy] Make the cert/uppercase-literal-suffix-integer fully hermetic..
Jul 1 2022, 1:40 PM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D127807: [clang-tidy] Properly forward clang-tidy output when running tests.

Thanks for this, like Nathan James this has been pestering me for a while :)

Jul 1 2022, 10:49 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

Please provide the name and email address you wish to use on the commit and I will submit.

Jul 1 2022, 10:46 AM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D128402: [clang-tidy] Don't treat invalid branches as identical.
Jul 1 2022, 10:45 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

I can submit after you address additional comments by Nathan James.

Jul 1 2022, 10:44 AM · Restricted Project, Restricted Project

Jun 29 2022

LegalizeAdulthood requested changes to D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.

Clang-tidy tests and docs have been moved to subdirectories by module, please rebase to main:HEAD

Jun 29 2022, 8:30 AM · Restricted Project, Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init.

Please add a summary of the fix to the release notes for this check.

Jun 29 2022, 8:27 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`.

This whole check seems weird to me. I mean, almost every use of a standard container could throw std::bad_alloc but we don't insist on a local catch for bad_alloc at every possible throwing call site.

Jun 29 2022, 8:23 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext.
Jun 29 2022, 8:19 AM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128402: [clang-tidy] Don't treat invalid branches as identical.

I can submit after you address additional comments by Nathan James.

Jun 29 2022, 8:17 AM · Restricted Project, Restricted Project

Jun 27 2022

LegalizeAdulthood added a comment to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

I pushed this change, but for some reason phabricator doesn't show it and close the review... I wonder if it's because I rebased it?

Jun 27 2022, 9:36 AM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D128402: [clang-tidy] Don't treat invalid branches as identical.

LGTM

Jun 27 2022, 9:35 AM · Restricted Project, Restricted Project

Jun 25 2022

LegalizeAdulthood committed rGb2cb7e81f897: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when… (authored by jspam).
[clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when…
Jun 25 2022, 3:19 PM · Restricted Project, Restricted Project
LegalizeAdulthood accepted D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

Well, it must have been unrelated to your change or some weird interaction on my machine because I rebased and ran check-clang-extra again and it passed this time.

Jun 25 2022, 2:49 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Jun 25 2022, 1:27 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128372: [Clang-Tidy] Empty Check.
Jun 25 2022, 1:16 PM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128402: [clang-tidy] Don't treat invalid branches as identical.

Rebase against main to get updated docs

Jun 25 2022, 1:13 PM · Restricted Project, Restricted Project

Jun 24 2022

LegalizeAdulthood requested changes to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

I get a test failure when I run with your change:

Jun 24 2022, 11:17 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

I see :) Yes, looks like Git's rename detection did its job.

Thanks for the review. Could you or someone else please merge this for me? Author: Joachim Priesner <llvm-project-704996@jspam.de>

Jun 24 2022, 9:54 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker .
Jun 24 2022, 9:53 AM · Restricted Project, Restricted Project
LegalizeAdulthood added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

OK, I've pushed the link fix and the sorting fix to main so if you rebase again, it should just show your changes to the release notes.

Jun 24 2022, 9:49 AM · Restricted Project, Restricted Project
LegalizeAdulthood committed rG5e97788a3eca: [clang-tidy] Update release notes (NFC) (authored by LegalizeAdulthood).
[clang-tidy] Update release notes (NFC)
Jun 24 2022, 9:49 AM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Jun 24 2022, 9:37 AM · Restricted Project, Restricted Project

Jun 23 2022

LegalizeAdulthood accepted D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro.

LGTM

Jun 23 2022, 10:51 AM · Restricted Project, Restricted Project
LegalizeAdulthood requested changes to D128402: [clang-tidy] Don't treat invalid branches as identical.
Jun 23 2022, 10:50 AM · Restricted Project, Restricted Project