Details

Reviewers

njames93
aaron.ballman
carlosgalvezp
LegalizeAdulthood

Summary

Finds enum type definitions that could use smaller integral type as a base.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

PiotrZSL created this revision.Feb 15 2023, 1:57 PM

Herald added a reviewer: njames93. · View Herald TranscriptFeb 15 2023, 1:57 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: carlosgalvezp, xazax.hun. · View Herald Transcript

Removed change in list.rst that is related to cppcoreguidelines-avoid-capture-default-when-capturing-this.
Looks like that check have fixes but didnt mark fixes in that file.

Fix typo in documentation.

Harbormaster completed remote builds in B213992: Diff 497804.Feb 15 2023, 3:10 PM

Fix tests on windows (they use int as base for enums, when on linux unsigned int is used)

Harbormaster completed remote builds in B214009: Diff 497826.Feb 15 2023, 3:56 PM

Eugene.Zelenko added a subscriber: Eugene.Zelenko.Feb 15 2023, 3:57 PM

Eugene.Zelenko added inline comments.

clang-tools-extra/clang-tidy/performance/EnumSizeCheck.cpp
100	Please do not use `auto` unless type is explicitly spelled in same function or iterator.
101	I don't think that literal boolean operators are part of LLVM coding guidelines.
104	Ditto.
121	Ditto.