This addresses the regression from https://reviews.llvm.org/D141778#inline-1369900
This builds upon the NFC refactoring of D141877, and enhances the xform
to support the uniform shifts by immediate, but only for unary shuffles
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
60,090 ms | x64 debian > libFuzzer.libFuzzer::fuzzer-leak.test | |
60,060 ms | x64 debian > libFuzzer.libFuzzer::minimize_crash.test |
Event Timeline
Comment Actions
Thanks for looking at this!
llvm/lib/Target/X86/X86ISelLowering.cpp | ||
---|---|---|
40436 | Instead of checking for ISD::TargetConstant specifically, could you use a helper to indicate whether to ignore a specific operandno for specific opcodes - that would allow us to extend this to the non-immediate versions of the sse shifts as well. |
Instead of checking for ISD::TargetConstant specifically, could you use a helper to indicate whether to ignore a specific operandno for specific opcodes - that would allow us to extend this to the non-immediate versions of the sse shifts as well.