This is an archive of the discontinued LLVM Phabricator instance.

Differential D141567

[Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses.
ClosedPublic

Authored by raghavendhra on Jan 11 2023, 10:44 PM.

Details

Reviewers
jdoerfert
kiranchandramohan
kiranktp
TIFitis
peixin
NimishMishra
clementval
abidmalikwaterloo
Commits
rGb2fb93d6818e: [Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses.
Summary

In Parser, move some clauses of OMP TARGET UPDATE to allowedOnceClauses so that restrictions will be imposed.

Diff Detail

Unit TestsFailed

TimeTest
61,670 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded::vloxseg.c
61,660 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded::vluxseg.c
61,270 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded::vloxseg.c
61,670 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded::vluxseg.c
60,630 msx64 debian > Clang.Driver::fsanitize.c
View Full Test Results (8 Failed)

Event Timeline

raghavendhra created this revision.Jan 11 2023, 10:44 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 11 2023, 10:44 PM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
raghavendhra requested review of this revision.Jan 11 2023, 10:44 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJan 11 2023, 10:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, sstefan1, jdoerfert. · View Herald Transcript
raghavendhra added reviewers: kiranchandramohan, kiranktp, TIFitis, peixin, NimishMishra, clementval, abidmalikwaterloo.Jan 11 2023, 10:51 PM
raghavendhra added subscribers: domada, dpalermo, jsjodin, RogerV-AMD.
Harbormaster completed remote builds in B207281: Diff 488484.Jan 12 2023, 12:43 AM
raghavendhra updated this revision to Diff 489615.Jan 16 2023, 11:39 AM

Rebasing the patch.

Herald added a subscriber: sunshaoce. · View Herald TranscriptJan 16 2023, 11:39 AM
Harbormaster completed remote builds in B208095: Diff 489615.Jan 16 2023, 12:19 PM
kiranchandramohan accepted this revision.Jan 17 2023, 3:48 AM

LG.

This revision is now accepted and ready to land.Jan 17 2023, 3:48 AM
This revision was landed with ongoing or failed builds.Jan 17 2023, 6:43 AM
Closed by commit rGb2fb93d6818e: [Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses. (authored by raghavendhra). · Explain Why
This revision was automatically updated to reflect the committed changes.
raghavendhra added a commit: rGb2fb93d6818e: [Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses..

Revision Contents

PathSize
flang/
test/
Semantics/
OpenMP/
8 lines
llvm/
include/
llvm/
Frontend/
OpenMP/
8 lines

Diff 489615

flang/test/Semantics/OpenMP/omp-device-constructs.f90

Show First 20 Lines • Show All 156 Lines • ▼ Show 20 Linesprogram main
!$omp target exit data map(delete:a) !$omp target exit data map(delete:a)
!ERROR: At most one DEVICE clause can appear on the TARGET EXIT DATA directive !ERROR: At most one DEVICE clause can appear on the TARGET EXIT DATA directive
!$omp target exit data map(from:a) device(0) device(1) !$omp target exit data map(from:a) device(0) device(1)
!ERROR: Only the FROM, RELEASE, DELETE map types are permitted for MAP clauses on the TARGET EXIT DATA directive !ERROR: Only the FROM, RELEASE, DELETE map types are permitted for MAP clauses on the TARGET EXIT DATA directive
!$omp target exit data map(to:a) !$omp target exit data map(to:a)
!$omp target update if(.true.) device(1) to(a) from(b) depend(inout:c) nowait
!ERROR: At most one IF clause can appear on the TARGET UPDATE directive
!$omp target update to(a) if(.true.) if(.false.)
!ERROR: At most one DEVICE clause can appear on the TARGET UPDATE directive
!$omp target update device(0) device(1) from(b)
!$omp target !$omp target
!ERROR: `DISTRIBUTE` region has to be strictly nested inside `TEAMS` region. !ERROR: `DISTRIBUTE` region has to be strictly nested inside `TEAMS` region.
!$omp distribute !$omp distribute
do i = 1, N do i = 1, N
a = 3.14 a = 3.14
enddo enddo
!$omp end distribute !$omp end distribute
!$omp end target !$omp end target
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines

llvm/include/llvm/Frontend/OpenMP/OMP.td

Show First 20 Lines • Show All 782 Lines • ▼ Show 20 Lines let allowedOnceClauses = [
VersionedClause<OMPC_Schedule>, VersionedClause<OMPC_Schedule>,
VersionedClause<OMPC_Collapse>, VersionedClause<OMPC_Collapse>,
VersionedClause<OMPC_Ordered>, VersionedClause<OMPC_Ordered>,
VersionedClause<OMPC_NoWait> VersionedClause<OMPC_NoWait>
]; ];
} }
def OMP_TargetUpdate : Directive<"target update"> { def OMP_TargetUpdate : Directive<"target update"> {
let allowedClauses = [ let allowedClauses = [
VersionedClause<OMPC_If>,
VersionedClause<OMPC_Device>,
VersionedClause<OMPC_To>, VersionedClause<OMPC_To>,
VersionedClause<OMPC_From>, VersionedClause<OMPC_From>,
VersionedClause<OMPC_NoWait>,
VersionedClause<OMPC_Depend> VersionedClause<OMPC_Depend>
]; ];
let allowedOnceClauses = [
VersionedClause<OMPC_Device>,
VersionedClause<OMPC_If>,
VersionedClause<OMPC_NoWait>
];
} }
def OMP_ParallelFor : Directive<"parallel for"> { def OMP_ParallelFor : Directive<"parallel for"> {
let allowedClauses = [ let allowedClauses = [
VersionedClause<OMPC_If>, VersionedClause<OMPC_If>,
VersionedClause<OMPC_NumThreads>, VersionedClause<OMPC_NumThreads>,
VersionedClause<OMPC_Default>, VersionedClause<OMPC_Default>,
VersionedClause<OMPC_ProcBind>, VersionedClause<OMPC_ProcBind>,
VersionedClause<OMPC_Private>, VersionedClause<OMPC_Private>,
▲ Show 20 Lines • Show All 1,261 Lines • Show Last 20 Lines