This is an archive of the discontinued LLVM Phabricator instance.

[NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'
ClosedPublic

Authored by eopXD on Dec 20 2022, 4:48 AM.

Details

Summary

The naming here is strange since the value may still be updated.

Diff Detail

Event Timeline

eopXD created this revision.Dec 20 2022, 4:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2022, 4:48 AM
eopXD requested review of this revision.Dec 20 2022, 4:48 AM
eopXD added a comment.Dec 20 2022, 4:50 AM

Just throwing out the question here, I would be happy to rename it to anything else that makes sense rather than the current.

Could you rebase with D140361?

eopXD updated this revision to Diff 484758.Dec 22 2022, 1:20 AM

Rebase upon latest main.

eopXD retitled this revision from [NFC][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs' to [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'.Dec 25 2022, 10:51 PM
khchen accepted this revision.Dec 26 2022, 6:10 AM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 26 2022, 6:10 AM
eopXD updated this revision to Diff 485310.Dec 26 2022, 8:52 AM

Rebae to latest main.

eopXD updated this revision to Diff 485311.Dec 26 2022, 8:57 AM

Change: Recover mis-deleted lines.

eopXD updated this revision to Diff 485312.Dec 26 2022, 9:02 AM

Recover mis-deleted lines.

kito-cheng accepted this revision.Dec 26 2022, 6:32 PM