These checks show optimized instructions if an operand is known to be
(partially) zero.
Change-Id: Ie2f6d0d3ee9d5b279d1f4c1dd0787492e39cc77a
Differential D140208
[AMDGPU] Improved wide multiplies OutOfCache on Dec 16 2022, 5:00 AM. Authored by
Details These checks show optimized instructions if an operand is known to be Change-Id: Ie2f6d0d3ee9d5b279d1f4c1dd0787492e39cc77a
Diff Detail
Event Timeline
Comment Actions I guess we could get the same improvement by running the binop_right_to_zero combine post-legalization? Comment Actions Somethign went wrong during applying the patch. Could you please have a look?
Comment Actions It seems like this is breaking the LegalizerHelper.h / the LegalizerHelperTest: LegalizerHelper Helper(*MF, Info, Observer, B); Comment Actions Improved tests with better naming. This comment was removed by OutOfCache. Comment Actions
Comment Actions Improved tests with better naming. Comment Actions Fixing constructor issues by moving the default parameter to the header. The default parameter for the new LegalizerHelper constructor has to be set Comment Actions Fixing constructor issues by moving the default parameter to the header. The default parameter for the new LegalizerHelper constructor has to be set Comment Actions
Fixed clang-format issue. Comment Actions
Fixed clang-format for good. Comment Actions A few nits / questions, otherwise LGTM.
Comment Actions Thanks, this already looks good to me. I do have a small number of comments inline still.
Comment Actions
Comment Actions Can you please add some MIR test cases in addition to your LLVM IR tests? You already put some example code in the discussion, but I believe a test that shows the transformation on a GMIR level could be helpful. Other than that, it looks good to me. Comment Actions Added MIR Tests for gfx10 and gfx11.
Comment Actions Remove gfx11 from MIR tests
|
Did you run clang-format on this? Usually it chooses a different layout.