__cpucfg is required by Linux [1].
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Linux only requires __cpucfg among the ones you just added. Please amend the patch summary so it's more accurate.
Otherwise LGTM, thanks!
| llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp | ||
|---|---|---|
| 799 | #undef ASRT_LE_GT_CASE afterwards? | |
Comment Actions
Thanks for your review, I will modify the summary.
| llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp | ||
|---|---|---|
| 799 | Thanks! I will modify it. And there are other similar problems in this file, which I will modify later. | |
Comment Actions
LGTM except a small nit.
| llvm/lib/Target/LoongArch/LoongArchISelLowering.h | ||
|---|---|---|
| 91 | Better to leave some comment like line 82? | |
| llvm/lib/Target/LoongArch/LoongArchISelLowering.h | ||
|---|---|---|
| 91 | Thanks, I'll add comments. | |
Better to leave some comment like line 82?