Page MenuHomePhabricator

gonglingqin (Gong LingQin)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2021, 11:17 PM (66 w, 5 d)

Recent Activity

Feb 12 2023

gonglingqin accepted D143846: [LoongArch] Add baseline tests for `addu16i.d` codegen. NFC.

Thanks!

Feb 12 2023, 8:00 PM · Restricted Project, Restricted Project
gonglingqin accepted D143710: [LoongArch] Make use of addu16i.d for adds with suitable immediates.

LGTM. Thanks!

Feb 12 2023, 7:56 PM · Restricted Project, Restricted Project

Feb 9 2023

gonglingqin committed rG9d8a7f780c5d: [LoongArch] Implement the convertSelectOfConstantsToMath hook (authored by gonglingqin).
[LoongArch] Implement the convertSelectOfConstantsToMath hook
Feb 9 2023, 10:30 PM · Restricted Project, Restricted Project
gonglingqin closed D143621: [LoongArch] Implement the convertSelectOfConstantsToMath hook.
Feb 9 2023, 10:29 PM · Restricted Project, Restricted Project

Feb 8 2023

gonglingqin requested review of D143621: [LoongArch] Implement the convertSelectOfConstantsToMath hook.
Feb 8 2023, 6:46 PM · Restricted Project, Restricted Project
gonglingqin committed rGe5489f726405: [LoongArch] Add baseline tests for translating the selection of constants into… (authored by gonglingqin).
[LoongArch] Add baseline tests for translating the selection of constants into…
Feb 8 2023, 5:51 PM · Restricted Project, Restricted Project
gonglingqin committed rG653d823ad22b: [LoongArch] Merge the 12bit constant address into the offset field of the… (authored by gonglingqin).
[LoongArch] Merge the 12bit constant address into the offset field of the…
Feb 8 2023, 12:58 AM · Restricted Project, Restricted Project
gonglingqin closed D143470: [LoongArch] Merge the 12bit constant address into the offset field of the instruction.
Feb 8 2023, 12:58 AM · Restricted Project, Restricted Project

Feb 7 2023

gonglingqin updated the diff for D143470: [LoongArch] Merge the 12bit constant address into the offset field of the instruction.

Update tests to use opaque pointers.

Feb 7 2023, 1:11 AM · Restricted Project, Restricted Project
gonglingqin added a comment to D143470: [LoongArch] Merge the 12bit constant address into the offset field of the instruction.

Seems good; you could rewrite these tests in opaque pointers afterwards as well.

Feb 7 2023, 12:40 AM · Restricted Project, Restricted Project
gonglingqin requested review of D143470: [LoongArch] Merge the 12bit constant address into the offset field of the instruction.
Feb 7 2023, 12:19 AM · Restricted Project, Restricted Project

Feb 6 2023

gonglingqin committed rG30424191815f: [LoongArch] Add baseline tests for optimizations that merge offsets into… (authored by gonglingqin).
[LoongArch] Add baseline tests for optimizations that merge offsets into…
Feb 6 2023, 3:37 AM · Restricted Project, Restricted Project

Feb 2 2023

gonglingqin committed rGfd68c7d223fd: [LoongArch] Override TargetLowering::hasAndNotCompare() (authored by gonglingqin).
[LoongArch] Override TargetLowering::hasAndNotCompare()
Feb 2 2023, 10:28 PM · Restricted Project, Restricted Project
gonglingqin closed D143037: [LoongArch] Override TargetLowering::hasAndNotCompare().
Feb 2 2023, 10:28 PM · Restricted Project, Restricted Project

Feb 1 2023

gonglingqin committed rGd6f1c85edb36: [LoongArch] Implement TargetLowering::isLegalAddressingMode() hook (authored by gonglingqin).
[LoongArch] Implement TargetLowering::isLegalAddressingMode() hook
Feb 1 2023, 10:16 PM · Restricted Project, Restricted Project
gonglingqin closed D142874: [LoongArch] Implement TargetLowering::isLegalAddressingMode() hook.
Feb 1 2023, 10:16 PM · Restricted Project, Restricted Project

Jan 31 2023

gonglingqin updated the diff for D142874: [LoongArch] Implement TargetLowering::isLegalAddressingMode() hook.

Address xen0n's comments.

Jan 31 2023, 6:20 PM · Restricted Project, Restricted Project
gonglingqin added inline comments to D142874: [LoongArch] Implement TargetLowering::isLegalAddressingMode() hook.
Jan 31 2023, 6:19 PM · Restricted Project, Restricted Project
gonglingqin requested review of D143037: [LoongArch] Override TargetLowering::hasAndNotCompare().
Jan 31 2023, 5:14 PM · Restricted Project, Restricted Project
gonglingqin committed rGc63ba01e9b99: [LoongArch] Add baseline test for (X & Y) == Y and (X & Y) != Y (authored by gonglingqin).
[LoongArch] Add baseline test for (X & Y) == Y and (X & Y) != Y
Jan 31 2023, 3:54 AM · Restricted Project, Restricted Project

Jan 30 2023

gonglingqin added inline comments to D142874: [LoongArch] Implement TargetLowering::isLegalAddressingMode() hook.
Jan 30 2023, 3:51 AM · Restricted Project, Restricted Project
gonglingqin requested review of D142874: [LoongArch] Implement TargetLowering::isLegalAddressingMode() hook.
Jan 30 2023, 12:55 AM · Restricted Project, Restricted Project

Jan 11 2023

gonglingqin committed rGad551c1335ba: [LoongArch] Fixed llvm/test/CodeGen/LoongArch/intrinsic.ll test failure when… (authored by gonglingqin).
[LoongArch] Fixed llvm/test/CodeGen/LoongArch/intrinsic.ll test failure when…
Jan 11 2023, 12:23 AM · Restricted Project, Restricted Project

Jan 6 2023

gonglingqin committed rG2c174a53d50b: [LoongArch] Move illegal ImmArg tests to llvm/test/Verifier (authored by gonglingqin).
[LoongArch] Move illegal ImmArg tests to llvm/test/Verifier
Jan 6 2023, 8:28 PM · Restricted Project, Restricted Project

Dec 22 2022

gonglingqin committed rGe726703c27c4: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w (authored by gonglingqin).
[Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w
Dec 22 2022, 3:46 AM · Restricted Project, Restricted Project
gonglingqin closed D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w.
Dec 22 2022, 3:45 AM · Restricted Project, Restricted Project
gonglingqin committed rGaeb8f911b169: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg (authored by gonglingqin).
[Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg
Dec 22 2022, 3:17 AM · Restricted Project, Restricted Project, Restricted Project
gonglingqin closed D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg.
Dec 22 2022, 3:17 AM · Restricted Project, Restricted Project, Restricted Project

Dec 20 2022

gonglingqin updated the diff for D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w.

Address @SixWeining's comment.

Dec 20 2022, 10:25 PM · Restricted Project, Restricted Project
gonglingqin added inline comments to D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w.
Dec 20 2022, 10:18 PM · Restricted Project, Restricted Project
gonglingqin updated the diff for D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg.

Add comment.

Dec 20 2022, 10:09 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin added inline comments to D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg.
Dec 20 2022, 10:07 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin committed rG9aa5de974629: [LoongArch] Break MUL into SLLI and SUB or ADD (authored by gonglingqin).
[LoongArch] Break MUL into SLLI and SUB or ADD
Dec 20 2022, 3:47 AM · Restricted Project, Restricted Project
gonglingqin closed D140282: [LoongArch] Break MUL into SLLI and SUB or ADD.
Dec 20 2022, 3:47 AM · Restricted Project, Restricted Project

Dec 18 2022

gonglingqin requested review of D140282: [LoongArch] Break MUL into SLLI and SUB or ADD.
Dec 18 2022, 10:56 PM · Restricted Project, Restricted Project

Dec 15 2022

gonglingqin committed rG4bb85698d69c: [LoongArch] Undef the macro after using it. NFC. (authored by gonglingqin).
[LoongArch] Undef the macro after using it. NFC.
Dec 15 2022, 12:11 AM · Restricted Project, Restricted Project

Dec 13 2022

gonglingqin committed rGb49d3e50e353: [OpenMP][Test] Make the output error message consistent with the comment (authored by gonglingqin).
[OpenMP][Test] Make the output error message consistent with the comment
Dec 13 2022, 6:09 PM · Restricted Project, Restricted Project
gonglingqin closed D139803: [OpenMP][Test] Make the output error message consistent with the comment.
Dec 13 2022, 6:08 PM · Restricted Project, Restricted Project
gonglingqin requested review of D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w.
Dec 13 2022, 5:52 PM · Restricted Project, Restricted Project
gonglingqin committed rG9a0831afa03a: [OpenMP] Skip extra blank line when parsing /proc/cpuinfo on LoongArch64 (authored by gonglingqin).
[OpenMP] Skip extra blank line when parsing /proc/cpuinfo on LoongArch64
Dec 13 2022, 4:17 AM · Restricted Project, Restricted Project
gonglingqin closed D139802: [OpenMP] Skip extra blank line when parsing /proc/cpuinfo on LoongArch64.
Dec 13 2022, 4:17 AM · Restricted Project, Restricted Project

Dec 12 2022

gonglingqin updated the diff for D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg.

Address @xen0n's comments.

Dec 12 2022, 11:43 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin updated the summary of D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg.
Dec 12 2022, 11:41 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin added a comment to D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg.

Linux only requires __cpucfg among the ones you just added. Please amend the patch summary so it's more accurate.

Otherwise LGTM, thanks!

Dec 12 2022, 11:40 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin requested review of D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg.
Dec 12 2022, 11:26 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin committed rG9853c0263efc: [LoongArch] Test CodeGen/LoongArch/intrinsic-la32.c with -O2. NFC. (authored by gonglingqin).
[LoongArch] Test CodeGen/LoongArch/intrinsic-la32.c with -O2. NFC.
Dec 12 2022, 1:23 AM · Restricted Project, Restricted Project
gonglingqin updated the diff for D139802: [OpenMP] Skip extra blank line when parsing /proc/cpuinfo on LoongArch64.

Address @xen0n's comments.

Dec 12 2022, 12:42 AM · Restricted Project, Restricted Project
gonglingqin added inline comments to D139802: [OpenMP] Skip extra blank line when parsing /proc/cpuinfo on LoongArch64.
Dec 12 2022, 12:40 AM · Restricted Project, Restricted Project

Dec 11 2022

gonglingqin retitled D139802: [OpenMP] Skip extra blank line when parsing /proc/cpuinfo on LoongArch64 from [OpenMP] Add LoongArch64 support in kmp_affinity.cpp to [OpenMP] Skip extra blank line when parsing /proc/cpuinfo in kmp_affinity.cpp on LoongArch64.
Dec 11 2022, 6:47 PM · Restricted Project, Restricted Project
gonglingqin added a comment to D139802: [OpenMP] Skip extra blank line when parsing /proc/cpuinfo on LoongArch64.

About the title, how about make it more specfic. Like "[OpenMP] Skip extra blank line when parsing /proc/cpuinfo in kmp_affinity.cpp on LoongArch64".

Dec 11 2022, 6:46 PM · Restricted Project, Restricted Project
gonglingqin requested review of D139803: [OpenMP][Test] Make the output error message consistent with the comment.
Dec 11 2022, 6:40 PM · Restricted Project, Restricted Project
gonglingqin requested review of D139802: [OpenMP] Skip extra blank line when parsing /proc/cpuinfo on LoongArch64.
Dec 11 2022, 6:29 PM · Restricted Project, Restricted Project

Dec 9 2022

gonglingqin committed rG048612050a2f: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr (authored by gonglingqin).
[Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr
Dec 9 2022, 10:11 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin closed D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr.
Dec 9 2022, 10:10 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin committed rG9a5e5402cf80: [LoongArch] Add testcases for privileged intrinsic macros (authored by gonglingqin).
[LoongArch] Add testcases for privileged intrinsic macros
Dec 9 2022, 7:39 PM · Restricted Project, Restricted Project
gonglingqin closed D139397: [LoongArch] Add testcases for privileged intrinsic macros.
Dec 9 2022, 7:39 PM · Restricted Project, Restricted Project

Dec 8 2022

gonglingqin requested review of D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr.
Dec 8 2022, 1:44 AM · Restricted Project, Restricted Project, Restricted Project
gonglingqin committed rG579f3f0606c3: [LoongArch] Rename the test file and separate the tests on LA32 and LA64. NFC. (authored by gonglingqin).
[LoongArch] Rename the test file and separate the tests on LA32 and LA64. NFC.
Dec 8 2022, 12:27 AM · Restricted Project, Restricted Project

Dec 7 2022

gonglingqin committed rG685bbe65f5c3: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg (authored by gonglingqin).
[Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg
Dec 7 2022, 10:26 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin closed D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg.
Dec 7 2022, 10:25 PM · Restricted Project, Restricted Project, Restricted Project

Dec 6 2022

gonglingqin updated the diff for D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg.

Add testcases for macros.

Dec 6 2022, 1:01 AM · Restricted Project, Restricted Project, Restricted Project
gonglingqin requested review of D139397: [LoongArch] Add testcases for privileged intrinsic macros.
Dec 6 2022, 12:20 AM · Restricted Project, Restricted Project

Dec 4 2022

gonglingqin added inline comments to D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg.
Dec 4 2022, 8:40 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin updated the diff for D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg.

Address @xen0n's comments.

Dec 4 2022, 8:05 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin added a comment to D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg.

You'll also need the IOCSR intrinsics too for building Linux. Since they're very similar to some of the CSR intrinsics you added here, do you plan to add support for them later here or in a separate follow-up change?

Dec 4 2022, 8:02 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin requested review of D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg.
Dec 4 2022, 7:45 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin added inline comments to D137532: [LoongArch] Implement the TargetLowering::getRegisterByName hook.
Dec 4 2022, 7:09 PM · Restricted Project, Restricted Project

Dec 2 2022

gonglingqin committed rG4633599c3460: [LoongArch] Extract out and reuse getValueType(). NFC. (authored by gonglingqin).
[LoongArch] Extract out and reuse getValueType(). NFC.
Dec 2 2022, 12:37 AM · Restricted Project, Restricted Project

Nov 30 2022

gonglingqin committed rG624401612c3a: [LoongArch] Add remaining intrinsics for CRC check instructions (authored by gonglingqin).
[LoongArch] Add remaining intrinsics for CRC check instructions
Nov 30 2022, 5:48 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin closed D138418: [LoongArch] Add remaining intrinsics for CRC check instructions.
Nov 30 2022, 5:47 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin committed rG5f9b4d8bad22: [LoongArch] Add codegen support for atomicrmw min/max operation on LA64 (authored by gonglingqin).
[LoongArch] Add codegen support for atomicrmw min/max operation on LA64
Nov 30 2022, 1:54 AM · Restricted Project, Restricted Project
gonglingqin closed D138177: [LoongArch] Add codegen support for atomicrmw min/max operation on LA64.
Nov 30 2022, 1:53 AM · Restricted Project, Restricted Project

Nov 28 2022

gonglingqin committed rGa2d10bda1870: [LoongArch] Add atomic ordering information for binary atomic operations (authored by gonglingqin).
[LoongArch] Add atomic ordering information for binary atomic operations
Nov 28 2022, 4:08 AM · Restricted Project, Restricted Project
gonglingqin closed D138481: [LoongArch] Add atomic ordering information for binary atomic operations.
Nov 28 2022, 4:08 AM · Restricted Project, Restricted Project

Nov 27 2022

gonglingqin added inline comments to D138177: [LoongArch] Add codegen support for atomicrmw min/max operation on LA64.
Nov 27 2022, 5:33 PM · Restricted Project, Restricted Project

Nov 23 2022

gonglingqin committed rGeca62f92045c: [LoongArch] Diagnose the behavior of reading and writing registers that do not… (authored by gonglingqin).
[LoongArch] Diagnose the behavior of reading and writing registers that do not…
Nov 23 2022, 6:43 PM · Restricted Project, Restricted Project
gonglingqin closed D138008: [LoongArch] Diagnose the behavior of reading and writing registers that do not conform to the hardware register size.
Nov 23 2022, 6:42 PM · Restricted Project, Restricted Project
gonglingqin accepted D138469: [LoongArch] Use tablegen size for getInstSizeInBytes.

LGTM.

Nov 23 2022, 12:35 AM · Restricted Project, Restricted Project

Nov 22 2022

gonglingqin updated the diff for D138418: [LoongArch] Add remaining intrinsics for CRC check instructions.

Address @xen0n's comments.

Nov 22 2022, 11:41 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin added inline comments to D138418: [LoongArch] Add remaining intrinsics for CRC check instructions.
Nov 22 2022, 11:39 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin updated the diff for D138418: [LoongArch] Add remaining intrinsics for CRC check instructions.

Address @SixWeining's comments.

Nov 22 2022, 10:57 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin added inline comments to D138418: [LoongArch] Add remaining intrinsics for CRC check instructions.
Nov 22 2022, 10:56 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin updated the diff for D138418: [LoongArch] Add remaining intrinsics for CRC check instructions.

Address @SixWeining's comments.

Nov 22 2022, 6:15 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin updated the summary of D138481: [LoongArch] Add atomic ordering information for binary atomic operations.
Nov 22 2022, 2:45 AM · Restricted Project, Restricted Project
gonglingqin added inline comments to D138481: [LoongArch] Add atomic ordering information for binary atomic operations.
Nov 22 2022, 2:44 AM · Restricted Project, Restricted Project
gonglingqin added inline comments to D138481: [LoongArch] Add atomic ordering information for binary atomic operations.
Nov 22 2022, 2:16 AM · Restricted Project, Restricted Project
gonglingqin requested review of D138481: [LoongArch] Add atomic ordering information for binary atomic operations.
Nov 22 2022, 1:25 AM · Restricted Project, Restricted Project
gonglingqin committed rG0cf2286cb8f8: [LoongArch] Fix issue on CMake Xcode build configuration (authored by gonglingqin).
[LoongArch] Fix issue on CMake Xcode build configuration
Nov 22 2022, 1:00 AM · Restricted Project, Restricted Project
gonglingqin closed D138403: [LoongArch] Fix issue on CMake Xcode build configuration.
Nov 22 2022, 12:59 AM · Restricted Project, Restricted Project

Nov 21 2022

gonglingqin committed rG801c77bbfabe: [LoongArch] Support when the depth of __builtin_frame_address is greater than… (authored by gonglingqin).
[LoongArch] Support when the depth of __builtin_frame_address is greater than…
Nov 21 2022, 11:51 PM · Restricted Project, Restricted Project
gonglingqin closed D138084: [LoongArch] Support when the depth of __builtin_frame_address is greater than zero.
Nov 21 2022, 11:51 PM · Restricted Project, Restricted Project
gonglingqin requested review of D138418: [LoongArch] Add remaining intrinsics for CRC check instructions.
Nov 21 2022, 4:37 AM · Restricted Project, Restricted Project, Restricted Project
gonglingqin added a comment to D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin.

Can you use https://reviews.llvm.org/D138403 to solve this problem?

Thanks for letting me know. I'll give it a try.

Nov 21 2022, 1:49 AM · Restricted Project, Restricted Project, Restricted Project
gonglingqin added a comment to D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin.

I get the following error:

CMake Error: Could not create named generator Xcode

Sorry, I forgot to mention that Xcode is only available on macOS.

But when I change Xcode to Ninja, no error output is generated.

Indeed. Ninja works fine for me as well. The problem is I kind of need both Xcode and Ninja in my workflow (Xcode for editing, Ninja for building).

Do you have any suggestions for reproducing the bugs you mentioned?

I think the following steps should be able to reproduce the error messages I'm seeing (It's a bit long):

  1. Install macOS 12.6 or newer. (I'm currently on 12.6, but newer versions such as 12.6.1 and 13 (the latest) should produce the same error messages.)
  1. Install Xcode 14.1 and/or the Xcode command line tools
    • Xcode can be installed via this link (generally recommended), or from the Mac App Store via this link.
      • The first link downloads a .xip file which can take a long time to decompress. This step can be sped up significantly by decompressing the file using this tool.
    • The command line tools can be installed via this link, via the following commands, or by launching Xcode after it's installed. (I don't remember it clearly, but I think you probably can skip this step and have Homebrew install it for you in step 3)

      sudo rm -rf /Library/Developer/CommandLineTools

      sudo xcode-select --install
  1. Install LLVM's dependencies via Homebrew
    • First we need to install brew using the following command

      /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
    • Then install Cmake and Python with brew. (I'm not sure if Python is really needed)

      brew install cmake python
  1. Clone LLVM and create the build directory.
  2. Generate Xcode project using CMake.

    cmake -G "Xcode" -DCMAKE_BUILD_TYPE=Debug -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_ENABLE_IDE=ON -DLLVM_CCACHE_BUILD=ON path/to/llvm

    Flags other than -G "Xcode" probably are optional for the purpose of reproducing the error messages.
Nov 21 2022, 1:48 AM · Restricted Project, Restricted Project, Restricted Project
gonglingqin updated the summary of D138403: [LoongArch] Fix issue on CMake Xcode build configuration.
Nov 21 2022, 12:31 AM · Restricted Project, Restricted Project
gonglingqin added a comment to D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin.

Hi, this seems to be causing some problems when generating Xcode project.

When I try to generate the Xcode project with the following command:

cmake -G "Xcode" -DCMAKE_BUILD_TYPE=Debug -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_ENABLE_IDE=ON -DLLVM_CCACHE_BUILD=ON ../../llvm

I get the following error:

CMake Error in /path/to/llvm-project/clang/lib/Headers/CMakeLists.txt:

The custom command generating

  /path/to/llvm-project/build/Xcode-Debug/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/16/include/larchintrin.h

is attached to multiple targets:

  clang-resource-headers
  loongarch-resource-headers

but none of these is a common dependency of the other(s).  This is not
allowed by the Xcode "new build system".

CMake Error in /path/to/llvm-project/third-party/benchmark/CMakeLists.txt:

The custom command generating

  /path/to/llvm-project/build/Xcode-Debug/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/16/include/larchintrin.h

is attached to multiple targets:

  clang-resource-headers
  loongarch-resource-headers

but none of these is a common dependency of the other(s).  This is not
allowed by the Xcode "new build system".
Nov 21 2022, 12:17 AM · Restricted Project, Restricted Project, Restricted Project
gonglingqin added a reviewer for D138403: [LoongArch] Fix issue on CMake Xcode build configuration: WowbaggersLiquidLunch.
Nov 21 2022, 12:14 AM · Restricted Project, Restricted Project
gonglingqin requested review of D138403: [LoongArch] Fix issue on CMake Xcode build configuration.
Nov 21 2022, 12:11 AM · Restricted Project, Restricted Project

Nov 20 2022

gonglingqin added a comment to D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin.

Hi, this seems to be causing some problems when generating Xcode project.

When I try to generate the Xcode project with the following command:

cmake -G "Xcode" -DCMAKE_BUILD_TYPE=Debug -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_ENABLE_IDE=ON -DLLVM_CCACHE_BUILD=ON ../../llvm

I get the following error:

CMake Error in /path/to/llvm-project/clang/lib/Headers/CMakeLists.txt:

The custom command generating

  /path/to/llvm-project/build/Xcode-Debug/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/16/include/larchintrin.h

is attached to multiple targets:

  clang-resource-headers
  loongarch-resource-headers

but none of these is a common dependency of the other(s).  This is not
allowed by the Xcode "new build system".

CMake Error in /path/to/llvm-project/third-party/benchmark/CMakeLists.txt:

The custom command generating

  /path/to/llvm-project/build/Xcode-Debug/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/16/include/larchintrin.h

is attached to multiple targets:

  clang-resource-headers
  loongarch-resource-headers

but none of these is a common dependency of the other(s).  This is not
allowed by the Xcode "new build system".

Thank you for your input. Correct me if I'm wrong, when I create a new build directory and execute the following command:

cmake -G "Xcode" -DCMAKE_BUILD_TYPE=Debug -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_ENABLE_IDE=ON -DLLVM_CCACHE_BUILD=ON ../../llvm

I get the following error:

Nov 20 2022, 10:44 PM · Restricted Project, Restricted Project, Restricted Project
gonglingqin committed rGf6d411f557b8: [LoongArch] Make function name in error message consistent with the user input. (authored by gonglingqin).
[LoongArch] Make function name in error message consistent with the user input.
Nov 20 2022, 7:28 PM · Restricted Project, Restricted Project