InstCombine: Fold out is_fpclass inf checks from test mask for known finite sources
ClosedPublic
Actions

Authored by arsenm on Nov 30 2022, 6:58 AM.

Details

Reviewers

sepavloff
spatel
kpn
andrew.w.kaylor
efriedma
cameron.mcinally
jcranmer-intel
jyknight

Summary

Make the partner transform already done for nnan sources.

Diff Detail

Event Timeline

arsenm created this revision.Nov 30 2022, 6:58 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 6:58 AM

Herald added a subscriber: hiraditya. · View Herald Transcript

arsenm requested review of this revision.Nov 30 2022, 6:58 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 6:58 AM

Herald added a subscriber: wdng. · View Herald Transcript

arsenm added a parent revision: D137811: InstCombine: Perform basic isnan combines on llvm.is.fpclass.Nov 30 2022, 6:58 AM

Harbormaster completed remote builds in B200266: Diff 478938.Nov 30 2022, 6:59 AM

arsenm added a child revision: D139032: InstCombine: Handle folding some negated is_fpclass mask test cases.Nov 30 2022, 10:10 AM

LGTM

This revision is now accepted and ready to land.Nov 30 2022, 10:53 PM

jcranmer-intel accepted this revision.Dec 2 2022, 2:14 PM

Also handle negated case

Harbormaster completed remote builds in B202397: Diff 481864.Dec 10 2022, 8:57 AM

Don't bother with replaceOperand for the constant, it doesn't need to go to the worklist

Harbormaster completed remote builds in B202736: Diff 482332.Dec 12 2022, 6:45 PM

5ccbd07dd607bac8a05016d80e3fa34f2d393279

Herald added a subscriber: StephenFan. · View Herald TranscriptFeb 5 2023, 5:08 AM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Transforms/

InstCombine/

InstCombineCalls.cpp

12 lines

test/

Transforms/

InstCombine/

is_fpclass.ll

22 lines

Diff 482332

View Options

llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp