Page MenuHomePhabricator

JanekvO (Janek van Oirschot)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2020, 8:29 AM (110 w, 4 d)

Recent Activity

Yesterday

JanekvO added a comment to D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.

Sorry, haven't gotten github access yet: could you (or somebody in AMDGPU group) land this for me? 😅

Mon, Nov 28, 12:38 PM · Restricted Project, Restricted Project
JanekvO updated the diff for D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
  • Remove dead code and tests
Mon, Nov 28, 12:17 PM · Restricted Project, Restricted Project

Fri, Nov 25

JanekvO updated the diff for D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
  • Remove patfrag dependency for is_fpclass
  • Add dedicated patterns
  • Remove globalisel manual selection and depend on selectiondag tablegen
  • Address comments
Fri, Nov 25, 8:05 AM · Restricted Project, Restricted Project

Fri, Nov 18

JanekvO added inline comments to D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
Fri, Nov 18, 6:57 AM · Restricted Project, Restricted Project

Tue, Nov 15

JanekvO updated the diff for D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
  • Remove fpsem operand construction in irtranslator for G_IS_FPCLASS
Tue, Nov 15, 4:22 AM · Restricted Project, Restricted Project

Mon, Nov 14

JanekvO updated subscribers of D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
Mon, Nov 14, 5:37 AM · Restricted Project, Restricted Project
JanekvO updated the diff for D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
  • Remove IS_FPCLASS amdgpu f16 legalization, split tests into f16 and not f16 cases, temporarily disable gfx7 glisel tests
  • Rebase
Mon, Nov 14, 5:30 AM · Restricted Project, Restricted Project

Fri, Nov 11

JanekvO added inline comments to D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
Fri, Nov 11, 11:06 AM · Restricted Project, Restricted Project
JanekvO added inline comments to D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
Fri, Nov 11, 6:15 AM · Restricted Project, Restricted Project

Tue, Nov 8

JanekvO added inline comments to D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
Tue, Nov 8, 7:48 AM · Restricted Project, Restricted Project
JanekvO updated the diff for D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
  • SelectionDAG fpclass vector support
  • GlobalISel llvm.is.fpclass support for AMDGPU
  • Address comments, add custom half promotion for gfx7
Tue, Nov 8, 7:31 AM · Restricted Project, Restricted Project

Thu, Nov 3

JanekvO retitled D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU from [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support for AMDGPU to [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
Thu, Nov 3, 10:20 AM · Restricted Project, Restricted Project
JanekvO updated the diff for D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
  • SelectionDAG fpclass vector support
  • GlobalISel llvm.is.fpclass support for AMDGPU
  • rebase
Thu, Nov 3, 7:25 AM · Restricted Project, Restricted Project

Oct 10 2022

JanekvO planned changes to D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
Oct 10 2022, 7:14 AM · Restricted Project, Restricted Project

Oct 7 2022

JanekvO requested review of D135447: [AMDGPU] Add llvm.is.fpclass intrinsic to existing SelectionDAG fp class support and introduce GlobalISel implementation for AMDGPU.
Oct 7 2022, 7:24 AM · Restricted Project, Restricted Project

Apr 25 2022

JanekvO added inline comments to D122672: [CodeGen][ARM] Enable Swing Module Scheduling for ARM.
Apr 25 2022, 7:37 AM · Restricted Project, Restricted Project

Nov 23 2020

JanekvO added inline comments to D91724: [HardwareLoops] Change order of SCEV expression construction for InitLoopCount..
Nov 23 2020, 9:11 AM · Restricted Project
JanekvO updated the diff for D91724: [HardwareLoops] Change order of SCEV expression construction for InitLoopCount..

Sorry, one more try to diff against the right branch

Nov 23 2020, 8:52 AM · Restricted Project
JanekvO updated the diff for D91724: [HardwareLoops] Change order of SCEV expression construction for InitLoopCount..

Diff against HEAD

Nov 23 2020, 8:51 AM · Restricted Project
JanekvO updated the diff for D91724: [HardwareLoops] Change order of SCEV expression construction for InitLoopCount..

Rename ExitCount to TripCount and move SCAV expression construction outside of HardwareLoops pass into isHardwareLoopCandidate.

Nov 23 2020, 8:50 AM · Restricted Project

Nov 19 2020

JanekvO added a comment to D91724: [HardwareLoops] Change order of SCEV expression construction for InitLoopCount..

Out of curiosity, did you try performing the +1 in HardwareLoopInfo::isHardwareLoopCandidate instead? Looking back through the code, I think it would be more clear to rename 'ExitCount' to 'TripCount' and perform this addition outside of the pass.

Nov 19 2020, 6:35 AM · Restricted Project

Nov 18 2020

JanekvO requested review of D91724: [HardwareLoops] Change order of SCEV expression construction for InitLoopCount..
Nov 18 2020, 10:28 AM · Restricted Project

Oct 19 2020

JanekvO added a comment to D89564: Provide correct return type and additional description for llvm.test.set.loop.iterations.* in langref.

Thanks for the review @samparker
Also, I don't have commit access so could anybody else land this as soon as it's good to go?

Oct 19 2020, 4:12 AM · Restricted Project
JanekvO updated the diff for D89564: Provide correct return type and additional description for llvm.test.set.loop.iterations.* in langref.

Rebase and change description to more accurately specify the result of the intrinsic.

Oct 19 2020, 4:09 AM · Restricted Project

Oct 16 2020

JanekvO requested review of D89564: Provide correct return type and additional description for llvm.test.set.loop.iterations.* in langref.
Oct 16 2020, 10:17 AM · Restricted Project