Page MenuHomePhabricator

[OHOS] Add support for OpenHarmony
Needs ReviewPublic

Authored by kpdev42 on Nov 17 2022, 5:27 AM.

Details

Reviewers
echristo
Summary

Add support for OpenHarmony OS

General OpenHarmony OS discussion on discourse thread "[RFC] Add support for OpenHarmony OS"
https://discourse.llvm.org/t/rfc-add-support-for-openharmony-os/66656

Diff Detail

Event Timeline

kpdev42 created this revision.Nov 17 2022, 5:27 AM
kpdev42 requested review of this revision.Nov 17 2022, 5:27 AM
kpdev42 updated this revision to Diff 476198.Nov 17 2022, 11:48 AM
kpdev42 edited the summary of this revision. (Show Details)
kpdev42 removed a reviewer: chandlerc.

Remove tls-related changes
Add link to dicourse thread

Ping) Any thoughts, questions?

xen0n added a subscriber: xen0n.Dec 6 2022, 12:09 AM

Please include context with the diff (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

(Phab doesn't have the full repo backing each diff so the context lets us see what the surrounding code is)

arsenm added a subscriber: arsenm.Thu, Jan 26, 8:44 AM

I'm generally of the opinion that anything and everything can go into Triple

llvm/include/llvm/ADT/Triple.h
742

As someone who's never heard of this operating system, this helper name isn't particularly enlightening

arsenm added inline comments.Thu, Jan 26, 8:48 AM
llvm/test/Transforms/SafeStack/AArch64/unreachable.ll
6

New tests should use opaque pointers (has this one somehow missed conversion?)

jrtc27 added inline comments.Thu, Jan 26, 8:55 AM
llvm/include/llvm/ADT/Triple.h
250

Keep blank line

270

Keep blank line

742

What if I give aarch64-liteos-gnu?

llvm/include/llvm/BinaryFormat/MinidumpConstants.def
118

What's with the 0x8206 gap?

llvm/test/Transforms/SafeStack/AArch64/abi.ll
2

These diffs don't belong here, the tests pass without them