Page MenuHomePhabricator
Differential D138202

[OHOS] Add support for OpenHarmony
Needs ReviewPublic
Actions

Authored by kpdev42 on Nov 17 2022, 5:27 AM.

Details

Reviewers
echristo
Summary

Add support for OpenHarmony OS

General OpenHarmony OS discussion on discourse thread "[RFC] Add support for OpenHarmony OS"
https://discourse.llvm.org/t/rfc-add-support-for-openharmony-os/66656

Diff Detail

Event Timeline

kpdev42 created this revision.Nov 17 2022, 5:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2022, 5:27 AM
Herald added subscribers: frasercrmck, luismarques, apazos and 21 others. · View Herald Transcript
kpdev42 requested review of this revision.Nov 17 2022, 5:27 AM
Herald added subscribers: pcwang-thead, MaskRay. · View Herald TranscriptNov 17 2022, 5:27 AM
Harbormaster completed remote builds in B198189: Diff 476096.Nov 17 2022, 6:32 AM
kpdev42 updated this revision to Diff 476198.Nov 17 2022, 11:48 AM
kpdev42 edited the summary of this revision. (Show Details)
kpdev42 removed a reviewer: chandlerc.

Remove tls-related changes
Add link to dicourse thread

Harbormaster completed remote builds in B198264: Diff 476198.Nov 17 2022, 11:48 AM
kpdev42 added a comment.Nov 21 2022, 2:52 AM

Ping) Any thoughts, questions?

xen0n added a subscriber: xen0n.Dec 6 2022, 12:09 AM
kpdev42 added a comment.Dec 8 2022, 1:54 AM

Ping

kpdev42 added a comment.Dec 23 2022, 5:40 AM

ping

DavidSpickett added a subscriber: DavidSpickett.Thu, Jan 26, 3:27 AM

Please include context with the diff (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

(Phab doesn't have the full repo backing each diff so the context lets us see what the surrounding code is)

arsenm added a subscriber: arsenm.Thu, Jan 26, 8:44 AM

I'm generally of the opinion that anything and everything can go into Triple

llvm/include/llvm/ADT/Triple.h
742

As someone who's never heard of this operating system, this helper name isn't particularly enlightening

arsenm added inline comments.Thu, Jan 26, 8:48 AM
llvm/test/Transforms/SafeStack/AArch64/unreachable.ll
6

New tests should use opaque pointers (has this one somehow missed conversion?)

jrtc27 added inline comments.Thu, Jan 26, 8:55 AM
llvm/include/llvm/ADT/Triple.h
250

Keep blank line

270

Keep blank line

742

What if I give aarch64-liteos-gnu?

llvm/include/llvm/BinaryFormat/MinidumpConstants.def
118

What's with the 0x8206 gap?

llvm/test/Transforms/SafeStack/AArch64/abi.ll
2

These diffs don't belong here, the tests pass without them

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
ADT/
Triple.h
Triple.h
21 lines
BinaryFormat/
MinidumpConstants.def
MinidumpConstants.def
1 line
lib/
Support/
AArch64TargetParser.cpp
AArch64TargetParser.cpp
2 lines
ARMTargetParser.cpp
ARMTargetParser.cpp
2 lines
Triple.cpp
Triple.cpp
4 lines
Target/
ARM/
ARMSubtarget.h
ARMSubtarget.h
3 lines
ARMTargetMachine.cpp
ARMTargetMachine.cpp
3 lines
test/
CodeGen/
AArch64/
arm64-platform-reg.ll
arm64-platform-reg.ll
1 line
Transforms/
SafeStack/
AArch64/
abi.ll
abi.ll
2 lines
abi_ssp.ll
abi_ssp.ll
2 lines
unreachable.ll
unreachable.ll
2 lines
unittests/
ADT/
TripleTest.cpp
TripleTest.cpp
12 lines

Diff 476198

View Options

llvm/include/llvm/ADT/Triple.h

Loading...
View Options

llvm/include/llvm/BinaryFormat/MinidumpConstants.def

Loading...
View Options

llvm/lib/Support/AArch64TargetParser.cpp

Loading...
View Options

llvm/lib/Support/ARMTargetParser.cpp

Loading...
View Options

llvm/lib/Support/Triple.cpp

Loading...
View Options

llvm/lib/Target/ARM/ARMSubtarget.h

Loading...
View Options

llvm/lib/Target/ARM/ARMTargetMachine.cpp

Loading...
View Options

llvm/test/CodeGen/AArch64/arm64-platform-reg.ll

Loading...
View Options

llvm/test/Transforms/SafeStack/AArch64/abi.ll

Loading...
View Options

llvm/test/Transforms/SafeStack/AArch64/abi_ssp.ll

Loading...
View Options

llvm/test/Transforms/SafeStack/AArch64/unreachable.ll

Loading...
View Options

llvm/unittests/ADT/TripleTest.cpp

Loading...