Page MenuHomePhabricator

[libcxx] Add OHOS support
Needs ReviewPublic

Authored by kpdev42 on Mar 24 2023, 4:42 AM.

Details

Reviewers
phosek
ldionne
thesamesam
Group Reviewers
Restricted Project
Summary

Add support for OpenHarmony OS (OHOS)

OpenHarmony is an open-source project incubated and operated by the OpenAtom Foundation. It targets IoT, and already used on production devices.

General OpenHarmony OS discussion on discourse thread: "Add support for OpenHarmony OS"

LLVM and clang parts of OHOS support: D138202, D145227

~~

Huawei RRI, OS Lab

Diff Detail

Event Timeline

kpdev42 created this revision.Mar 24 2023, 4:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 4:42 AM
Herald added a subscriber: krytarowski. · View Herald Transcript
kpdev42 requested review of this revision.Mar 24 2023, 4:42 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 24 2023, 4:42 AM

As usual: Do you plan to get official support for OpenHarmony in libc++? If that's the case, please take a look at https://libcxx.llvm.org/AddingNewCIJobs.html#addingnewcijobs.

Can you update the commit message to explain what OHOS is and provide a link to its homepage. That would be nice to have as a future reference.

The atomic changes look fine.

kpdev42 edited the summary of this revision. (Show Details)Apr 6 2023, 5:31 AM

Can you update the commit message to explain what OHOS is and provide a link to its homepage. That would be nice to have as a future reference.

Description is updated, please take a look

As usual: Do you plan to get official support for OpenHarmony in libc++? If that's the case, please take a look at https://libcxx.llvm.org/AddingNewCIJobs.html#addingnewcijobs.

Sure, we will try it, thank you

As usual: Do you plan to get official support for OpenHarmony in libc++? If that's the case, please take a look at https://libcxx.llvm.org/AddingNewCIJobs.html#addingnewcijobs.

Sure, we will try it, thank you

That would indeed be great to have.

LGTM, modulo one remark.

libcxx/include/__locale
46

At least I assume that was intended.