Details
Details
- Reviewers
antiagainst nicolasvasilache probinson - Commits
- rGa7fa5febaa43: [Test] Fix CHECK typo.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Nice work!
have you verified that all the modified tests pass? naively it looks like you'd need at least 3 different targets to run them all (windows, webassembly, powerpc)
Comment Actions
Those are target independent tests. I'm able to run and pass those tests in my linux machine.
Comment Actions
LGTM, but you'll want to be ready to jump on any bot failures. That's just the nature of these kinds of changes.