Page MenuHomePhabricator

zequanwu (Zequan Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 31 2020, 4:54 PM (118 w, 13 h)

Recent Activity

Thu, Jun 30

zequanwu committed rG8a790e65f42b: [LLDB][NativePDB] Return LLDB_INVALID_ADDRESS in PdbIndex::MakeVirtualAddress… (authored by zequanwu).
[LLDB][NativePDB] Return LLDB_INVALID_ADDRESS in PdbIndex::MakeVirtualAddress…
Thu, Jun 30, 2:38 PM · Restricted Project

Wed, Jun 29

zequanwu committed rGbd2044c10865: [CodeView] Call llvm::codeview::visitMemberRecordStream with the deserialized… (authored by zequanwu).
[CodeView] Call llvm::codeview::visitMemberRecordStream with the deserialized…
Wed, Jun 29, 5:19 PM · Restricted Project, Restricted Project
zequanwu committed rGbed15f16d685: [gn] Manual port a7d6c3effe93954ecad634eebbcc59fc6856c3d9 (authored by zequanwu).
[gn] Manual port a7d6c3effe93954ecad634eebbcc59fc6856c3d9
Wed, Jun 29, 1:12 PM · Restricted Project, Restricted Project

Fri, Jun 24

zequanwu updated the diff for D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..

address comment.

Fri, Jun 24, 10:16 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

zequanwu added inline comments to D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..
Tue, Jun 21, 1:45 PM · Restricted Project, Restricted Project, Restricted Project
zequanwu updated the diff for D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..

Address comments.

Tue, Jun 21, 1:36 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 15

zequanwu added a comment to D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..

The main thing I am wondering is if it wouldn't be better to (instead of essentially duplicating the DWARFExpression interface in the DWARFExpressionList class) somehow split the process of finding the appropriate expression (for the given PC value or whatever), and the actual evaluation. This would be particularly nice if the arguments can be split in such a way that those that are used for locating the expression are not repeated in the "evaluate" call. Have you considered this?

Then we need to duplicate the code that gets expression data and register kind before every call to DWARFExpression::Evaluate, making it less clean.

Wed, Jun 15, 1:30 PM · Restricted Project, Restricted Project, Restricted Project
zequanwu updated the diff for D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..

Address comments.

Wed, Jun 15, 1:26 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 13

zequanwu added a reverting change for rG3222f95ea8c4: [LLDB][NativePDB] Convert backslash to slash when creating CU and filter out CU…: rG602a951bfe34: Partially revert 3222f95ea8c4de153f908c138cdec178e22acaf4.
Mon, Jun 13, 1:30 PM · Restricted Project
zequanwu committed rG602a951bfe34: Partially revert 3222f95ea8c4de153f908c138cdec178e22acaf4 (authored by zequanwu).
Partially revert 3222f95ea8c4de153f908c138cdec178e22acaf4
Mon, Jun 13, 1:29 PM · Restricted Project
zequanwu committed rG98c2a853eb5e: Minor fix to ae60869908db6e8f45b51bc35d983706e8a296ae (authored by zequanwu).
Minor fix to ae60869908db6e8f45b51bc35d983706e8a296ae
Mon, Jun 13, 12:09 PM · Restricted Project
zequanwu committed rGae60869908db: Minor fix to 3222f95ea8c4de153f908c138cdec178e22acaf4 (authored by zequanwu).
Minor fix to 3222f95ea8c4de153f908c138cdec178e22acaf4
Mon, Jun 13, 12:07 PM · Restricted Project
zequanwu committed rG3222f95ea8c4: [LLDB][NativePDB] Convert backslash to slash when creating CU and filter out CU… (authored by zequanwu).
[LLDB][NativePDB] Convert backslash to slash when creating CU and filter out CU…
Mon, Jun 13, 12:04 PM · Restricted Project

Thu, Jun 9

zequanwu added inline comments to D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..
Thu, Jun 9, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu updated the diff for D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..

Add missing check for Expected.

Thu, Jun 9, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu added inline comments to D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..
Thu, Jun 9, 11:21 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 8

zequanwu committed rGbf1e96d6206e: [MicrosoftDemangle] Set error to true when returning nullptr. (authored by zequanwu).
[MicrosoftDemangle] Set error to true when returning nullptr.
Wed, Jun 8, 5:18 PM · Restricted Project, Restricted Project
zequanwu committed rGd6710023e396: [LLDB][NativePDB] Fix several crashes when parsing debug info. (authored by zequanwu).
[LLDB][NativePDB] Fix several crashes when parsing debug info.
Wed, Jun 8, 4:41 PM · Restricted Project
zequanwu added a comment to D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.

Just noticed that 3 test cases failed. Please fix them before landing.

Wed, Jun 8, 2:07 PM · Restricted Project, Restricted Project
zequanwu accepted D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.

LGTM, thanks.

Wed, Jun 8, 2:06 PM · Restricted Project, Restricted Project

Tue, Jun 7

zequanwu added a reviewer for D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.: teemperor.
Tue, Jun 7, 10:11 AM · Restricted Project, Restricted Project, Restricted Project

May 31 2022

zequanwu added a reviewer for D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.: jingham.
May 31 2022, 12:47 PM · Restricted Project, Restricted Project, Restricted Project

May 25 2022

zequanwu committed rG5c9f3ec4ad5d: [LLDB][NativePDB] Check for missing type info to avoid crash. (authored by zequanwu).
[LLDB][NativePDB] Check for missing type info to avoid crash.
May 25 2022, 1:22 PM · Restricted Project
zequanwu closed D125844: [LLDB][NativePDB] Check for missing type info to avoid crash..
May 25 2022, 1:22 PM · Restricted Project, Restricted Project
zequanwu added a reverting change for rGcfb4e782520c: Revert "[llvm-pdbutil] Add options to only dump symbol record at specified…: rGa648724921b3: Reland "[llvm-pdbutil] Add options to only dump symbol record at specified….
May 25 2022, 9:58 AM · Restricted Project, Restricted Project
zequanwu committed rGa648724921b3: Reland "[llvm-pdbutil] Add options to only dump symbol record at specified… (authored by zequanwu).
Reland "[llvm-pdbutil] Add options to only dump symbol record at specified…
May 25 2022, 9:58 AM · Restricted Project, Restricted Project

May 24 2022

zequanwu added a reviewer for D125844: [LLDB][NativePDB] Check for missing type info to avoid crash.: rnk.
May 24 2022, 9:12 AM · Restricted Project, Restricted Project

May 20 2022

zequanwu committed rG9886046289fa: [CodeView] Combine variable def ranges that are continuous. (authored by zequanwu).
[CodeView] Combine variable def ranges that are continuous.
May 20 2022, 12:12 PM · Restricted Project, Restricted Project
zequanwu closed D125721: [CodeView] Combine variable def ranges that are continuous..
May 20 2022, 12:12 PM · Restricted Project, Restricted Project
zequanwu added inline comments to D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..
May 20 2022, 12:08 PM · Restricted Project, Restricted Project, Restricted Project
zequanwu updated the diff for D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..

Address comments.

May 20 2022, 12:07 PM · Restricted Project, Restricted Project, Restricted Project

May 18 2022

zequanwu updated the diff for D125721: [CodeView] Combine variable def ranges that are continuous..
  • Address comments.
  • Rename LocalVarDefRange to LocalVarDef as it no longer has range info inside.
May 18 2022, 5:13 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..

Add missing sort.

May 18 2022, 2:13 PM · Restricted Project, Restricted Project, Restricted Project
zequanwu updated the summary of D125721: [CodeView] Combine variable def ranges that are continuous..
May 18 2022, 10:51 AM · Restricted Project, Restricted Project

May 17 2022

zequanwu requested review of D125844: [LLDB][NativePDB] Check for missing type info to avoid crash..
May 17 2022, 6:28 PM · Restricted Project, Restricted Project

May 16 2022

zequanwu updated the diff for D125721: [CodeView] Combine variable def ranges that are continuous..

Remove unnecessary includes.

May 16 2022, 2:17 PM · Restricted Project, Restricted Project
zequanwu retitled D125721: [CodeView] Combine variable def ranges that are continuous. from [WIP][CodeView] Combine variable def ranges that are continuous. to [CodeView] Combine variable def ranges that are continuous..
May 16 2022, 2:15 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D125721: [CodeView] Combine variable def ranges that are continuous..

Update test.

May 16 2022, 2:09 PM · Restricted Project, Restricted Project
zequanwu requested review of D125721: [CodeView] Combine variable def ranges that are continuous..
May 16 2022, 1:02 PM · Restricted Project, Restricted Project

May 12 2022

zequanwu retitled D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression. from [WIP][LLDB][NFC] Decouple dwarf location table from DWARFExpression. to [LLDB][NFC] Decouple dwarf location table from DWARFExpression..
May 12 2022, 7:19 PM · Restricted Project, Restricted Project, Restricted Project
zequanwu requested review of D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..
May 12 2022, 6:05 PM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

zequanwu added a comment to D123599: [DebugInfo][InstrRef] Describe value sizes when spilt to stack.

A smaller linker repro (133MB) is at https://drive.google.com/file/d/1nMOBkvu2Ii0ja6MHDPRSjDcvkCrH1rZa/view.

Apr 29 2022, 11:55 AM · Restricted Project, Restricted Project

Apr 28 2022

zequanwu added inline comments to D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available..
Apr 28 2022, 5:20 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available..

Use extra bool variable for is_first_search, because search_offset might be an odd number if parameter byte size in stack is an odd number.

Apr 28 2022, 5:19 PM · Restricted Project, Restricted Project
zequanwu added inline comments to D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available..
Apr 28 2022, 5:04 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available..

Update: address some inline comments.

Apr 28 2022, 5:04 PM · Restricted Project, Restricted Project
zequanwu added a comment to D123599: [DebugInfo][InstrRef] Describe value sizes when spilt to stack.

The compressed linker repro is 4.3GB, so it's hard to upload.
here is better backtrace. Hope that helps:

Assertion failed: !Expr->isComplex(), file ../../llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp, line 907
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Running pass 'Function Pass Manager' on module 'obj/third_party/blink/renderer/platform\platform/open_type_math_support.obj'.
1.      Running pass 'Live DEBUG_VALUE analysis' on function '@"??$GetHarfBuzzMathRecord@Uhb_ot_math_glyph_variant_t@@G@blink@@YA?AV?$Vector@G$0A@VPartitionAllocator@WTF@@@WTF@@PEBVHarfBuzzFace@0@GW4StretchAxis@OpenTypeMathStretchData@0@V?$OnceCallback@$$A6AIPEAUhb_font_t@@IW4hb_direction_t@@IPEAIPEAUhb_ot_math_glyph_variant_t@@@Z@base@@V?$RepeatingCallback@$$A6AGUhb_ot_math_glyph_variant_t@@@Z@7@V?$optional@G@absl@@@Z"'
 #0 0x00007ff79a1f2920 HandleAbort C:\src\llvm-project\llvm\lib\Support\Windows\Signals.inc:418:0
 #1 0x00007ff79da2cf53 raise C:\src\llvm-project\build\debug\minkernel\crts\ucrt\src\appcrt\misc\signal.cpp:547:0
 #2 0x00007ff79da1de3c abort C:\src\llvm-project\build\debug\minkernel\crts\ucrt\src\appcrt\startup\abort.cpp:71:0
 #3 0x00007ff79da1ed79 common_assert_to_stderr_direct C:\src\llvm-project\build\debug\minkernel\crts\ucrt\src\appcrt\startup\assert.cpp:160:0
 #4 0x00007ff79da1f05c common_assert_to_stderr<wchar_t> C:\src\llvm-project\build\debug\minkernel\crts\ucrt\src\appcrt\startup\assert.cpp:179:0
 #5 0x00007ff79da1ebce _wassert C:\src\llvm-project\build\debug\minkernel\crts\ucrt\src\appcrt\startup\assert.cpp:443:0
 #6 0x00007ff79d23175c LiveDebugValues::MLocTracker::emitLoc(class llvm::Optional<class LiveDebugValues::LocIdx>, class llvm::DebugVariable const &, class LiveDebugValues::DbgValueProperties const &) C:\src\llvm-project\llvm\lib\CodeGen\LiveDebugValues\InstrRefBasedImpl.cpp:908:0
 #7 0x00007ff79d256f33 TransferTracker::transferMlocs(class LiveDebugValues::LocIdx, class LiveDebugValues::LocIdx, class llvm::MachineInstrBundleIterator<class llvm::MachineInstr, 0>) C:\src\llvm-project\llvm\lib\CodeGen\LiveDebugValues\InstrRefBasedImpl.cpp:620:0
 #8 0x00007ff79d236839 LiveDebugValues::InstrRefBasedLDV::transferSpillOrRestoreInst::<lambda_0>::operator() C:\src\llvm-project\llvm\lib\CodeGen\LiveDebugValues\InstrRefBasedImpl.cpp:1641:0
 #9 0x00007ff79d23628a LiveDebugValues::InstrRefBasedLDV::transferSpillOrRestoreInst(class llvm::MachineInstr &) C:\src\llvm-project\llvm\lib\CodeGen\LiveDebugValues\InstrRefBasedImpl.cpp:1656:0
#10 0x00007ff79d23755a LiveDebugValues::InstrRefBasedLDV::process(class llvm::MachineInstr &, class std::unique_ptr<class LiveDebugValues::ValueIDNum[], struct std::default_delete<class LiveDebugValues::ValueIDNum[]>> const *, class std::unique_ptr<class LiveDebugValues::ValueIDNum[], struct std::default_delete<class LiveDebugValues::ValueIDNum[]>> const *) C:\src\llvm-project\llvm\lib\CodeGen\LiveDebugValues\InstrRefBasedImpl.cpp:1826:0
#11 0x00007ff79d23e3a4 LiveDebugValues::InstrRefBasedLDV::depthFirstVLocAndEmit::<lambda_0>::operator() C:\src\llvm-project\llvm\lib\CodeGen\LiveDebugValues\InstrRefBasedImpl.cpp:3015:0
#12 0x00007ff79d23e01e LiveDebugValues::InstrRefBasedLDV::depthFirstVLocAndEmit(unsigned int, class llvm::DenseMap<class llvm::LexicalScope const *, class llvm::DILocation const *, struct llvm::DenseMapInfo<class llvm::LexicalScope const *, void>, struct llvm::detail::DenseMapPair<class llvm::LexicalScope const *, class llvm::DILocation const *>> const &, class llvm::DenseMap<class llvm::LexicalScope const *, class llvm::SmallSet<class llvm::DebugVariable, 4, struct std::less<class llvm::DebugVariable>>, struct llvm::DenseMapInfo<class llvm::LexicalScope const *, void>, struct llvm::detail::DenseMapPair<class llvm::LexicalScope const *, class llvm::SmallSet<class llvm::DebugVariable, 4, struct std::less<class llvm::DebugVariable>>>> const &, class llvm::DenseMap<class llvm::LexicalScope const *, class llvm::SmallPtrSet<class llvm::MachineBasicBlock *, 4>, struct llvm::DenseMapInfo<class llvm::LexicalScope const *, void>, struct llvm::detail::DenseMapPair<class llvm::LexicalScope const *, class llvm::SmallPtrSet<class llvm::MachineBasicBlock *, 4>>> &, class llvm::SmallVector<class llvm::SmallVector<struct std::pair<class llvm::DebugVariable, class LiveDebugValues::DbgValue>, 8>, 8> &, class std::unique_ptr<class std::unique_ptr<class LiveDebugValues::ValueIDNum[], struct std::default_delete<class LiveDebugValues::ValueIDNum[]>>[], struct std::default_delete<class std::unique_ptr<class LiveDebugValues::ValueIDNum[], struct std::default_delete<class LiveDebugValues::ValueIDNum[]>>[]>> &, class std::unique_ptr<class std::unique_ptr<class LiveDebugValues::ValueIDNum[], struct std::default_delete<class LiveDebugValues::ValueIDNum[]>>[], struct std::default_delete<class std::unique_ptr<class LiveDebugValues::ValueIDNum[], struct std::default_delete<class LiveDebugValues::ValueIDNum[]>>[]>> &, class llvm::SmallVectorImpl<class LiveDebugValues::VLocTracker> &, class llvm::MachineFunction &, class llvm::DenseMap<class llvm::DebugVariable, unsigned int, struct llvm::DenseMapInfo<class llvm::DebugVariable, void>, struct llvm::detail::DenseMapPair<class llvm::DebugVariable, unsigned int>> &, class llvm::TargetPassConfig const &) C:\src\llvm-project\llvm\lib\CodeGen\LiveDebugValues\InstrRefBasedImpl.cpp:3073:0
#13 0x00007ff79d23f7c9 LiveDebugValues::InstrRefBasedLDV::ExtendRanges(class llvm::MachineFunction &, class llvm::MachineDominatorTree *, class llvm::TargetPassConfig *, unsigned int, unsigned int) C:\src\llvm-project\llvm\lib\CodeGen\LiveDebugValues\InstrRefBasedImpl.cpp:3289:0
#14 0x00007ff79bc5dd02 `anonymous namespace'::LiveDebugValues::runOnMachineFunction C:\src\llvm-project\llvm\lib\CodeGen\LiveDebugValues\LiveDebugValues.cpp:123:0
#15 0x00007ff79a88a70d llvm::MachineFunctionPass::runOnFunction(class llvm::Function &) C:\src\llvm-project\llvm\lib\CodeGen\MachineFunctionPass.cpp:73:0
#16 0x00007ff79ab02e52 llvm::FPPassManager::runOnFunction(class llvm::Function &) C:\src\llvm-project\llvm\lib\IR\LegacyPassManager.cpp:1430:0
#17 0x00007ff79ab0808e llvm::FPPassManager::runOnModule(class llvm::Module &) C:\src\llvm-project\llvm\lib\IR\LegacyPassManager.cpp:1476:0
#18 0x00007ff79ab03810 `anonymous namespace'::MPPassManager::runOnModule C:\src\llvm-project\llvm\lib\IR\LegacyPassManager.cpp:1545:0
#19 0x00007ff79ab032f0 llvm::legacy::PassManagerImpl::run(class llvm::Module &) C:\src\llvm-project\llvm\lib\IR\LegacyPassManager.cpp:535:0
#20 0x00007ff79ab08361 llvm::legacy::PassManager::run(class llvm::Module &) C:\src\llvm-project\llvm\lib\IR\LegacyPassManager.cpp:1672:0
#21 0x00007ff79a4cfda0 codegen C:\src\llvm-project\llvm\lib\LTO\LTOBackend.cpp:392:0
#22 0x00007ff79a4d09ea llvm::lto::thinBackend::<lambda_0>::operator() C:\src\llvm-project\llvm\lib\LTO\LTOBackend.cpp:559:0
#23 0x00007ff79a4d081d llvm::lto::thinBackend(struct llvm::lto::Config const &, unsigned int, class std::function<(unsigned int)>, class llvm::Module &, class llvm::ModuleSummaryIndex const &, class llvm::StringMap<class std::unordered_set<unsigned __int64, struct std::hash<unsigned __int64>, struct std::equal_to<unsigned __int64>, class std::allocator<unsigned __int64>>, class llvm::MallocAllocator> const &, class llvm::DenseMap<unsigned __int64, class llvm::GlobalValueSummary *, struct llvm::DenseMapInfo<unsigned __int64, void>, struct llvm::detail::DenseMapPair<unsigned __int64, class llvm::GlobalValueSummary *>> const &, class llvm::MapVector<class llvm::StringRef, class llvm::BitcodeModule, class llvm::DenseMap<class llvm::StringRef, unsigned int, struct llvm::DenseMapInfo<class llvm::StringRef, void>, struct llvm::detail::DenseMapPair<class llvm::StringRef, unsigned int>>, class std::vector<struct std::pair<class llvm::StringRef, class llvm::BitcodeModule>, class std::allocator<struct std::pair<class llvm::StringRef, class llvm::BitcodeModule>>>> *, class std::vector<unsigned char, class std::allocator<unsigned char>> const &) C:\src\llvm-project\llvm\lib\LTO\LTOBackend.cpp:630:0
#24 0x00007ff799d02c5d `anonymous namespace'::InProcessThinBackend::runThinLTOBackendThread::<lambda_1>::operator() C:\src\llvm-project\llvm\lib\LTO\LTO.cpp:1223:0
#25 0x00007ff799d029aa `anonymous namespace'::InProcessThinBackend::runThinLTOBackendThread C:\src\llvm-project\llvm\lib\LTO\LTO.cpp:1246:0
#26 0x00007ff799d02488 `anonymous namespace'::InProcessThinBackend::start::<lambda_1>::operator() C:\src\llvm-project\llvm\lib\LTO\LTO.cpp:1275:0
#27 0x00007ff799d022b4 std::invoke<`lambda at ../../llvm/lib/LTO/LTO.cpp:1262:9' &,llvm::BitcodeModule &,llvm::ModuleSummaryIndex &,const llvm::StringMap<std::unordered_set<unsigned long long,std::hash<unsigned long long>,std::equal_to<unsigned long long>,std::allocator<unsigned long long> >,llvm::MallocAllocator> &,const llvm::DenseSet<llvm::ValueInfo,llvm::DenseMapInfo<llvm::ValueInfo,void> > &,const std::map<unsigned long long,llvm::GlobalValue::LinkageTypes,std::less<unsigned long long>,std::allocator<std::pair<const unsigned long long,llvm::GlobalValue::LinkageTypes> > > &,const llvm::DenseMap<unsigned long long,llvm::GlobalValueSummary *,llvm::DenseMapInfo<unsigned long long,void>,llvm::detail::DenseMapPair<unsigned long long,llvm::GlobalValueSummary *> > &,llvm::MapVector<llvm::StringRef,llvm::BitcodeModule,llvm::DenseMap<llvm::StringRef,unsigned int,llvm::DenseMapInfo<llvm::StringRef,void>,llvm::detail::DenseMapPair<llvm::StringRef,unsigned int> >,std::vector<std::pair<llvm::StringRef,llvm::BitcodeModule>,std::allocator<std::pair<llvm::StringRef,llvm::BitcodeModule> > > > &> C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\type_traits:1595:0
#28 0x00007ff799d021a6 std::_Invoker_ret<std::_Unforced,0>::_Call<`lambda at ../../llvm/lib/LTO/LTO.cpp:1262:9' &,llvm::BitcodeModule &,llvm::ModuleSummaryIndex &,const llvm::StringMap<std::unordered_set<unsigned long long,std::hash<unsigned long long>,std::equal_to<unsigned long long>,std::allocator<unsigned long long> >,llvm::MallocAllocator> &,const llvm::DenseSet<llvm::ValueInfo,llvm::DenseMapInfo<llvm::ValueInfo,void> > &,const std::map<unsigned long long,llvm::GlobalValue::LinkageTypes,std::less<unsigned long long>,std::allocator<std::pair<const unsigned long long,llvm::GlobalValue::LinkageTypes> > > &,const llvm::DenseMap<unsigned long long,llvm::GlobalValueSummary *,llvm::DenseMapInfo<unsigned long long,void>,llvm::detail::DenseMapPair<unsigned long long,llvm::GlobalValueSummary *> > &,llvm::MapVector<llvm::StringRef,llvm::BitcodeModule,llvm::DenseMap<llvm::StringRef,unsigned int,llvm::DenseMapInfo<llvm::StringRef,void>,llvm::detail::DenseMapPair<llvm::StringRef,unsigned int> >,std::vector<std::pair<llvm::StringRef,llvm::BitcodeModule>,std::allocator<std::pair<llvm::StringRef,llvm::BitcodeModule> > > > &> C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\functional:763:0
#29 0x00007ff799d02100 std::_Call_binder<std::_Unforced,0,1,2,3,4,5,6,`lambda at ../../llvm/lib/LTO/LTO.cpp:1262:9',std::tuple<llvm::BitcodeModule,std::reference_wrapper<llvm::ModuleSummaryIndex>,std::reference_wrapper<const llvm::StringMap<std::unordered_set<unsigned long long,std::hash<unsigned long long>,std::equal_to<unsigned long long>,std::allocator<unsigned long long> >,llvm::MallocAllocator> >,std::reference_wrapper<const llvm::DenseSet<llvm::ValueInfo,llvm::DenseMapInfo<llvm::ValueInfo,void> > >,std::reference_wrapper<const std::map<unsigned long long,llvm::GlobalValue::LinkageTypes,std::less<unsigned long long>,std::allocator<std::pair<const unsigned long long,llvm::GlobalValue::LinkageTypes> > > >,std::reference_wrapper<const llvm::DenseMap<unsigned long long,llvm::GlobalValueSummary *,llvm::DenseMapInfo<unsigned long long,void>,llvm::detail::DenseMapPair<unsigned long long,llvm::GlobalValueSummary *> > >,std::reference_wrapper<llvm::MapVector<llvm::StringRef,llvm::BitcodeModule,llvm::DenseMap<llvm::StringRef,unsigned int,llvm::DenseMapInfo<llvm::StringRef,void>,llvm::detail::DenseMapPair<llvm::StringRef,unsigned int> >,std::vector<std::pair<llvm::StringRef,llvm::BitcodeModule>,std::allocator<std::pair<llvm::StringRef,llvm::BitcodeModule> > > > > >,std::tuple<> > C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\functional:1414:0
#30 0x00007ff799d01f31 std::_Binder<std::_Unforced,`lambda at ../../llvm/lib/LTO/LTO.cpp:1262:9',llvm::BitcodeModule &,std::reference_wrapper<llvm::ModuleSummaryIndex>,std::reference_wrapper<const llvm::StringMap<std::unordered_set<unsigned long long,std::hash<unsigned long long>,std::equal_to<unsigned long long>,std::allocator<unsigned long long> >,llvm::MallocAllocator> >,std::reference_wrapper<const llvm::DenseSet<llvm::ValueInfo,llvm::DenseMapInfo<llvm::ValueInfo,void> > >,std::reference_wrapper<const std::map<unsigned long long,llvm::GlobalValue::LinkageTypes,std::less<unsigned long long>,std::allocator<std::pair<const unsigned long long,llvm::GlobalValue::LinkageTypes> > > >,std::reference_wrapper<const llvm::DenseMap<unsigned long long,llvm::GlobalValueSummary *,llvm::DenseMapInfo<unsigned long long,void>,llvm::detail::DenseMapPair<unsigned long long,llvm::GlobalValueSummary *> > >,std::reference_wrapper<llvm::MapVector<llvm::StringRef,llvm::BitcodeModule,llvm::DenseMap<llvm::StringRef,unsigned int,llvm::DenseMapInfo<llvm::StringRef,void>,llvm::detail::DenseMapPair<llvm::StringRef,unsigned int> >,std::vector<std::pair<llvm::StringRef,llvm::BitcodeModule>,std::allocator<std::pair<llvm::StringRef,llvm::BitcodeModule> > > > > >::operator()<> C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\functional:1452:0
#31 0x00007ff799d01ec3 std::invoke<std::_Binder<std::_Unforced,`lambda at ../../llvm/lib/LTO/LTO.cpp:1262:9',llvm::BitcodeModule &,std::reference_wrapper<llvm::ModuleSummaryIndex>,std::reference_wrapper<const llvm::StringMap<std::unordered_set<unsigned long long,std::hash<unsigned long long>,std::equal_to<unsigned long long>,std::allocator<unsigned long long> >,llvm::MallocAllocator> >,std::reference_wrapper<const llvm::DenseSet<llvm::ValueInfo,llvm::DenseMapInfo<llvm::ValueInfo,void> > >,std::reference_wrapper<const std::map<unsigned long long,llvm::GlobalValue::LinkageTypes,std::less<unsigned long long>,std::allocator<std::pair<const unsigned long long,llvm::GlobalValue::LinkageTypes> > > >,std::reference_wrapper<const llvm::DenseMap<unsigned long long,llvm::GlobalValueSummary *,llvm::DenseMapInfo<unsigned long long,void>,llvm::detail::DenseMapPair<unsigned long long,llvm::GlobalValueSummary *> > >,std::reference_wrapper<llvm::MapVector<llvm::StringRef,llvm::BitcodeModule,llvm::DenseMap<llvm::StringRef,unsigned int,llvm::DenseMapInfo<llvm::StringRef,void>,llvm::detail::DenseMapPair<llvm::StringRef,unsigned int> >,std::vector<std::pair<llvm::StringRef,llvm::BitcodeModule>,std::allocator<std::pair<llvm::StringRef,llvm::BitcodeModule> > > > > > &> C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\type_traits:1585:0
#32 0x00007ff799d01ea3 std::_Invoker_ret<void,1>::_Call<std::_Binder<std::_Unforced,`lambda at ../../llvm/lib/LTO/LTO.cpp:1262:9',llvm::BitcodeModule &,std::reference_wrapper<llvm::ModuleSummaryIndex>,std::reference_wrapper<const llvm::StringMap<std::unordered_set<unsigned long long,std::hash<unsigned long long>,std::equal_to<unsigned long long>,std::allocator<unsigned long long> >,llvm::MallocAllocator> >,std::reference_wrapper<const llvm::DenseSet<llvm::ValueInfo,llvm::DenseMapInfo<llvm::ValueInfo,void> > >,std::reference_wrapper<const std::map<unsigned long long,llvm::GlobalValue::LinkageTypes,std::less<unsigned long long>,std::allocator<std::pair<const unsigned long long,llvm::GlobalValue::LinkageTypes> > > >,std::reference_wrapper<const llvm::DenseMap<unsigned long long,llvm::GlobalValueSummary *,llvm::DenseMapInfo<unsigned long long,void>,llvm::detail::DenseMapPair<unsigned long long,llvm::GlobalValueSummary *> > >,std::reference_wrapper<llvm::MapVector<llvm::StringRef,llvm::BitcodeModule,llvm::DenseMap<llvm::StringRef,unsigned int,llvm::DenseMapInfo<llvm::StringRef,void>,llvm::detail::DenseMapPair<llvm::StringRef,unsigned int> >,std::vector<std::pair<llvm::StringRef,llvm::BitcodeModule>,std::allocator<std::pair<llvm::StringRef,llvm::BitcodeModule> > > > > > &> C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\functional:745:0
#33 0x00007ff799d01c97 std::_Func_impl_no_alloc<std::_Binder<std::_Unforced,`lambda at ../../llvm/lib/LTO/LTO.cpp:1262:9',llvm::BitcodeModule &,std::reference_wrapper<llvm::ModuleSummaryIndex>,std::reference_wrapper<const llvm::StringMap<std::unordered_set<unsigned long long,std::hash<unsigned long long>,std::equal_to<unsigned long long>,std::allocator<unsigned long long> >,llvm::MallocAllocator> >,std::reference_wrapper<const llvm::DenseSet<llvm::ValueInfo,llvm::DenseMapInfo<llvm::ValueInfo,void> > >,std::reference_wrapper<const std::map<unsigned long long,llvm::GlobalValue::LinkageTypes,std::less<unsigned long long>,std::allocator<std::pair<const unsigned long long,llvm::GlobalValue::LinkageTypes> > > >,std::reference_wrapper<const llvm::DenseMap<unsigned long long,llvm::GlobalValueSummary *,llvm::DenseMapInfo<unsigned long long,void>,llvm::detail::DenseMapPair<unsigned long long,llvm::GlobalValueSummary *> > >,std::reference_wrapper<llvm::MapVector<llvm::StringRef,llvm::BitcodeModule,llvm::DenseMap<llvm::StringRef,unsigned int,llvm::DenseMapInfo<llvm::StringRef,void>,llvm::detail::DenseMapPair<llvm::StringRef,unsigned int> >,std::vector<std::pair<llvm::StringRef,llvm::BitcodeModule>,std::allocator<std::pair<llvm::StringRef,llvm::BitcodeModule> > > > > >,void>::_Do_call C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\functional:920:0
#34 0x00007ff799b4fd34 std::_Func_class<void>::operator()(void) const C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\functional:968:0
#35 0x00007ff799d3a5ec `private: static struct std::pair<class std::function<void __cdecl(void)>, class std::future<void>> __cdecl llvm::ThreadPool::createTaskAndFuture(class std::function<void __cdecl(void)>)'::`1'::<lambda_1>::operator()(void) const C:\src\llvm-project\llvm\include\llvm\Support\ThreadPool.h:95:0
#36 0x00007ff799d3a5c3 std::invoke<class `private: static struct std::pair<class std::function<void __cdecl(void)>, class std::future<void>> __cdecl llvm::ThreadPool::createTaskAndFuture(class std::function<void __cdecl(void)>)'::`1'::<lambda_1> &>(class `private: static struct std::pair<class std::function<void __cdecl(void)>, class std::future<void>> __cdecl llvm::ThreadPool::createTaskAndFuture(class std::function<void __cdecl(void)>)'::`1'::<lambda_1> &) C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\type_traits:1585:0
#37 0x00007ff799d3a5a3 std::_Invoker_ret<void, 1>::_Call<class `private: static struct std::pair<class std::function<void __cdecl(void)>, class std::future<void>> __cdecl llvm::ThreadPool::createTaskAndFuture(class std::function<void __cdecl(void)>)'::`1'::<lambda_1> &>(class `private: static struct std::pair<class std::function<void __cdecl(void)>, class std::future<void>> __cdecl llvm::ThreadPool::createTaskAndFuture(class std::function<void __cdecl(void)>)'::`1'::<lambda_1> &) C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\functional:745:0
#38 0x00007ff799d3a2f7 std::_Func_impl_no_alloc<class `private: static struct std::pair<class std::function<void __cdecl(void)>, class std::future<void>> __cdecl llvm::ThreadPool::createTaskAndFuture(class std::function<void __cdecl(void)>)'::`1'::<lambda_1>, void>::_Do_call(void) C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\functional:920:0
#39 0x00007ff799b4fd34 std::_Func_class<void>::operator()(void) const C:\src\llvm-project\chrome-sysroot\VC\Tools\MSVC\14.29.30133\include\functional:968:0
#40 0x00007ff79a5fba7c llvm::ThreadPool::grow::<lambda_0>::operator() C:\src\llvm-project\llvm\lib\Support\ThreadPool.cpp:59:0
#41 0x00007ff79a5fb93f llvm::thread::Apply<`lambda at ../../llvm/lib/Support/ThreadPool.cpp:37:26'> C:\src\llvm-project\llvm\include\llvm\Support\thread.h:43:0
#42 0x00007ff79a5fb8f7 llvm::thread::GenericThreadProxy<std::tuple<`lambda at ../../llvm/lib/Support/ThreadPool.cpp:37:26'> > C:\src\llvm-project\llvm\include\llvm\Support\thread.h:51:0
#43 0x00007ff79a5fb773 llvm::thread::ThreadProxy<std::tuple<`lambda at ../../llvm/lib/Support/ThreadPool.cpp:37:26'> > C:\src\llvm-project\llvm\include\llvm\Support\thread.h:71:0
#44 0x00007ff79da1569e thread_start<unsigned int (__cdecl*)(void *),1> C:\src\llvm-project\build\debug\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp:97:0
#45 0x00007ffdf8087034 (C:\Windows\System32\KERNEL32.DLL+0x17034)
#46 0x00007ffdf8ce2651 (C:\Windows\SYSTEM32\ntdll.dll+0x52651)
Apr 28 2022, 4:50 PM · Restricted Project, Restricted Project
zequanwu added a reverting change for rGa15b66e76d1e: [DebugInfo][InstrRef] Describe value sizes when spilt to stack: rG4fe2ab527940: Revert "[DebugInfo][InstrRef] Describe value sizes when spilt to stack".
Apr 28 2022, 4:18 PM · Restricted Project, Restricted Project
zequanwu committed rG4fe2ab527940: Revert "[DebugInfo][InstrRef] Describe value sizes when spilt to stack" (authored by zequanwu).
Revert "[DebugInfo][InstrRef] Describe value sizes when spilt to stack"
Apr 28 2022, 4:18 PM · Restricted Project, Restricted Project
zequanwu added a reverting change for D123599: [DebugInfo][InstrRef] Describe value sizes when spilt to stack: rG4fe2ab527940: Revert "[DebugInfo][InstrRef] Describe value sizes when spilt to stack".
Apr 28 2022, 4:18 PM · Restricted Project, Restricted Project
zequanwu added a comment to D124317: [llvm-pdbutil] Add options to only dump symbol record at specified offset and its parents or children with spcified depth..

I've reverted this because symbol-offset.test fails under MSAN:

[ 1] ; RUN: llvm-pdbutil yaml2pdb %p/Inputs/symbol-offset.yaml --pdb=%t.pdb [FAIL]
llvm-pdbutil yaml2pdb <REDACTED>/llvm/test/tools/llvm-pdbutil/Inputs/symbol-offset.yaml --pdb=<REDACTED>/tmp/symbol-offset.test/symbol-offset.test.tmp.pdb
==9283==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x55f975e5eb91 in __libcpp_tls_set <REDACTED>/include/c++/v1/__threading_support:428:12
    #1 0x55f975e5eb91 in set_pointer <REDACTED>/include/c++/v1/thread:196:5
    #2 0x55f975e5eb91 in void* std::__msan::__thread_proxy<std::__msan::tuple<std::__msan::unique_ptr<std::__msan::__thread_struct, std::__msan::default_delete<std::__msan::__thread_struct> >, llvm::parallel::detail::(anonymous namespace)::ThreadPoolExecutor::ThreadPoolExecutor(llvm::ThreadPoolStrategy)::'lambda'()::operator()() const::'lambda'()> >(void*) <REDACTED>/include/c++/v1/thread:285:27
    #3 0x7f74a1e55b54 in start_thread (<REDACTED>/libpthread.so.0+0xbb54) (BuildId: 64752de50ebd1a108f4b3f8d0d7e1a13)
    #4 0x7f74a1dc9f7e in clone (<REDACTED>/libc.so.6+0x13cf7e) (BuildId: 7cfed7708e5ab7fcb286b373de21ee76)
Apr 28 2022, 2:35 PM · Restricted Project, Restricted Project
zequanwu added a comment to D123599: [DebugInfo][InstrRef] Describe value sizes when spilt to stack.

Hi, this seems causing crashes on our windows/mac/ios bots: https://bugs.chromium.org/p/chromium/issues/detail?id=1320808

Apr 28 2022, 11:57 AM · Restricted Project, Restricted Project

Apr 27 2022

zequanwu committed rG1043eeaf86ac: [llvm-symbolizer][native-pdb] Don't reset CurLineOffset if NextLineOffset is… (authored by zequanwu).
[llvm-symbolizer][native-pdb] Don't reset CurLineOffset if NextLineOffset is…
Apr 27 2022, 4:08 PM · Restricted Project, Restricted Project
zequanwu committed rGa3b7cb015fd5: [llvm-pdbutil] Add options to only dump symbol record at specified offset and… (authored by zequanwu).
[llvm-pdbutil] Add options to only dump symbol record at specified offset and…
Apr 27 2022, 2:37 PM · Restricted Project, Restricted Project
zequanwu closed D124317: [llvm-pdbutil] Add options to only dump symbol record at specified offset and its parents or children with spcified depth..
Apr 27 2022, 2:37 PM · Restricted Project, Restricted Project
zequanwu committed rGafd639071bb3: [LLDB][NativePDB] Minor fix ParseInlinesite. (authored by zequanwu).
[LLDB][NativePDB] Minor fix ParseInlinesite.
Apr 27 2022, 10:56 AM · Restricted Project

Apr 26 2022

zequanwu added inline comments to D124317: [llvm-pdbutil] Add options to only dump symbol record at specified offset and its parents or children with spcified depth..
Apr 26 2022, 1:45 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D124317: [llvm-pdbutil] Add options to only dump symbol record at specified offset and its parents or children with spcified depth..

Address comments.

Apr 26 2022, 1:45 PM · Restricted Project, Restricted Project

Apr 25 2022

zequanwu committed rG827ff1e576f7: [LLDB][NativePDB] Fix incorrect file index of inlinees introduced by… (authored by zequanwu).
[LLDB][NativePDB] Fix incorrect file index of inlinees introduced by…
Apr 25 2022, 4:07 PM · Restricted Project

Apr 22 2022

zequanwu requested review of D124317: [llvm-pdbutil] Add options to only dump symbol record at specified offset and its parents or children with spcified depth..
Apr 22 2022, 6:46 PM · Restricted Project, Restricted Project

Apr 21 2022

zequanwu planned changes to D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available..

Thanks for the feedback. As you pointed out that stack scanning without symbol file info is fragile due to function pointers in stack and we don't know the parameter size pushed into the stack.

Apr 21 2022, 5:35 PM · Restricted Project, Restricted Project
zequanwu committed rG1921b195765f: [LLDB][NativePDB] Make sure the number of param symbol records is the same as… (authored by zequanwu).
[LLDB][NativePDB] Make sure the number of param symbol records is the same as…
Apr 21 2022, 4:07 PM · Restricted Project
zequanwu requested review of D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available..
Apr 21 2022, 12:35 PM · Restricted Project, Restricted Project

Apr 20 2022

zequanwu committed rG2fa2734690ff: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of… (authored by zequanwu).
[LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of…
Apr 20 2022, 10:33 AM · Restricted Project
zequanwu closed D124061: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order..
Apr 20 2022, 10:33 AM · Restricted Project, Restricted Project

Apr 19 2022

zequanwu requested review of D124061: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order..
Apr 19 2022, 8:15 PM · Restricted Project, Restricted Project

Apr 15 2022

zequanwu committed rGdc100ebfdabf: [LLDB][NativePDB] Followup c50817d1bea4ac51ed776154014630a439176de6 (authored by zequanwu).
[LLDB][NativePDB] Followup c50817d1bea4ac51ed776154014630a439176de6
Apr 15 2022, 12:09 PM · Restricted Project
zequanwu committed rGc50817d1bea4: [LLDB][NativePDB] Don't create inlined function parameters when it's malformed. (authored by zequanwu).
[LLDB][NativePDB] Don't create inlined function parameters when it's malformed.
Apr 15 2022, 11:59 AM · Restricted Project
zequanwu added a comment to D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type.

Hi @zequanwu, your patch's new test seems to be failing on CI (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/). Could you fix it or revert the changes? Thanks!

Apr 15 2022, 10:39 AM · Restricted Project, Restricted Project
zequanwu committed rG2f78f9455f85: [LLDB][NativePDB] Fix subfield_register_simple_type.s test (authored by zequanwu).
[LLDB][NativePDB] Fix subfield_register_simple_type.s test
Apr 15 2022, 10:36 AM · Restricted Project

Apr 14 2022

zequanwu committed rG3dbf524ad75b: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a… (authored by zequanwu).
[LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a…
Apr 14 2022, 11:06 AM · Restricted Project
zequanwu closed D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type.
Apr 14 2022, 11:06 AM · Restricted Project, Restricted Project
zequanwu committed rGef7cba71486d: [LLDB][NativePDB] Fix inline line info in line table (authored by zequanwu).
[LLDB][NativePDB] Fix inline line info in line table
Apr 14 2022, 11:01 AM · Restricted Project
zequanwu closed D123092: [LLDB][NativePDB] Fix inline line info in line table.
Apr 14 2022, 11:01 AM · Restricted Project, Restricted Project
zequanwu added a comment to D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type.

Ping.

Apr 14 2022, 10:12 AM · Restricted Project, Restricted Project
zequanwu added a comment to D123092: [LLDB][NativePDB] Fix inline line info in line table.

Ping.

Apr 14 2022, 10:12 AM · Restricted Project, Restricted Project

Apr 11 2022

zequanwu accepted D123483: [llvm-pdbutil] Fix broken '-modi' option after change D122226..

Thanks for the fix.

Apr 11 2022, 11:40 AM · Restricted Project, Restricted Project

Apr 7 2022

zequanwu committed rG1da67ecefdda: [llvm-symbolizer] Fix line offset for inline site. (authored by zequanwu).
[llvm-symbolizer] Fix line offset for inline site.
Apr 7 2022, 3:18 PM · Restricted Project, Restricted Project
zequanwu closed D123151: [llvm-symbolizer] Fix line offset for inline site..
Apr 7 2022, 3:18 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D123092: [LLDB][NativePDB] Fix inline line info in line table.

Modity inline_sites.test to do non-live test.

Apr 7 2022, 3:13 PM · Restricted Project, Restricted Project
zequanwu added inline comments to D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type.
Apr 7 2022, 10:43 AM · Restricted Project, Restricted Project
zequanwu updated the diff for D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type.

Update.

Apr 7 2022, 10:43 AM · Restricted Project, Restricted Project

Apr 5 2022

zequanwu planned changes to D123092: [LLDB][NativePDB] Fix inline line info in line table.

Plan to apply similar change in D123151 to this patch.

Apr 5 2022, 5:36 PM · Restricted Project, Restricted Project
zequanwu added a comment to D123151: [llvm-symbolizer] Fix line offset for inline site..

what's the situation where the "current line offset is actually for next range"?

In the following example, It has the mapping:
[0x15, 0x20) -> 1
[0x20, 0x31) -> 2
[0x31, 0x3A) -> 3
[0x3A, 0x43) -> 4

Apr 5 2022, 5:00 PM · Restricted Project, Restricted Project
zequanwu requested review of D123151: [llvm-symbolizer] Fix line offset for inline site..
Apr 5 2022, 12:20 PM · Restricted Project, Restricted Project

Apr 4 2022

zequanwu added reviewers for D123092: [LLDB][NativePDB] Fix inline line info in line table: labath, aganea.
Apr 4 2022, 6:24 PM · Restricted Project, Restricted Project
zequanwu added a reviewer for D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type: aganea.
Apr 4 2022, 6:23 PM · Restricted Project, Restricted Project
zequanwu requested review of D123092: [LLDB][NativePDB] Fix inline line info in line table.
Apr 4 2022, 3:21 PM · Restricted Project, Restricted Project

Apr 1 2022

zequanwu requested review of D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type.
Apr 1 2022, 3:45 PM · Restricted Project, Restricted Project
zequanwu committed rGc50eec400c0e: [LLDB] Add require x86 for NativePdb Test. (authored by zequanwu).
[LLDB] Add require x86 for NativePdb Test.
Apr 1 2022, 10:39 AM · Restricted Project
zequanwu added a comment to D121967: [LLDB][NativePDB] Create inline function decls.

Thanks for reviewing.

Apr 1 2022, 10:07 AM · Restricted Project, Restricted Project
zequanwu committed rGc45975cbf96a: [LLDB][NativePDB] Create inline function decls (authored by zequanwu).
[LLDB][NativePDB] Create inline function decls
Apr 1 2022, 10:06 AM · Restricted Project
zequanwu closed D121967: [LLDB][NativePDB] Create inline function decls.
Apr 1 2022, 10:06 AM · Restricted Project, Restricted Project

Mar 31 2022

zequanwu added a reverting change for rG4b2af365b6fa: [LLDB][NativePDB] Minor fix on inline line table.: rG71ec09b33ef4: Revert "[LLDB][NativePDB] Minor fix on inline line table.".
Mar 31 2022, 4:09 PM · Restricted Project
zequanwu committed rG71ec09b33ef4: Revert "[LLDB][NativePDB] Minor fix on inline line table." (authored by zequanwu).
Revert "[LLDB][NativePDB] Minor fix on inline line table."
Mar 31 2022, 4:09 PM · Restricted Project
zequanwu committed rG4b2af365b6fa: [LLDB][NativePDB] Minor fix on inline line table. (authored by zequanwu).
[LLDB][NativePDB] Minor fix on inline line table.
Mar 31 2022, 2:58 PM · Restricted Project
zequanwu added inline comments to D121967: [LLDB][NativePDB] Create inline function decls.
Mar 31 2022, 11:14 AM · Restricted Project, Restricted Project
zequanwu updated the diff for D121967: [LLDB][NativePDB] Create inline function decls.

Update live debugging test to build with no optimization.

Mar 31 2022, 11:14 AM · Restricted Project, Restricted Project

Mar 30 2022

zequanwu added a comment to D121967: [LLDB][NativePDB] Create inline function decls.

Ping.

Mar 30 2022, 4:37 PM · Restricted Project, Restricted Project
zequanwu added a comment to D122226: [llvm-pdbutil] Move InputFile/FormatUtil/LinePrinter to the PDB library..

This causes llvm-pdbutil crashes when modi is neither 0 nor 1, e.g. llvm-pdbutil dump --symbols -modi=2 a.pdb

llvm-pdbutil: ../../llvm/include/llvm/DebugInfo/PDB/Native/InputFile.h:185: llvm::Error llvm::pdb::iterateSymbolGroups(llvm::pdb::InputFile &, const Optional<llvm::pdb::PrintScope> &, CallbackT) [CallbackT = (lambda at ../../llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp:1472:7)]: Assertion `llvm::pdb::Filters.DumpModi == 1' failed.
Mar 30 2022, 4:30 PM · Restricted Project, Restricted Project