Page MenuHomePhabricator

zequanwu (Zequan Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 31 2020, 4:54 PM (35 w, 1 d)

Recent Activity

Yesterday

zequanwu requested review of D92510: [lldb] set created function decl to public access in TypeSystemClang.
Wed, Dec 2, 2:18 PM · Restricted Project

Tue, Dec 1

zequanwu updated the diff for D91673: [PGO] Enable preinline and cleanup when optimize for size.
  • sync NPM with LPM.
  • use PreInlineThreshold flag value instead of hardcode number.
Tue, Dec 1, 4:18 PM · Restricted Project, Restricted Project
zequanwu added a comment to D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.

@zequanwu In the future, please refrain from committing to libc++ or libc++abi unless you have approval of the libcxx or libcxxabi review group. There's a reason why that group is added as a "blocking reviewer", it's because you should wait for it to be green before proceeding.

Tue, Dec 1, 10:31 AM · Restricted Project

Mon, Nov 30

zequanwu committed rG871f96eed379: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler (authored by zequanwu).
[libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler
Mon, Nov 30, 4:37 PM
zequanwu retitled D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler from [libcxxabi] remove checks for __STDCPP_THREADS__ as it is defined by compiler to [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.
Mon, Nov 30, 4:37 PM · Restricted Project
zequanwu closed D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.
Mon, Nov 30, 4:37 PM · Restricted Project
zequanwu updated the diff for D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.

address comment.

Mon, Nov 30, 2:45 PM · Restricted Project
zequanwu added a comment to D91673: [PGO] Enable preinline and cleanup when optimize for size.
In D91673#2401578, @xur wrote:

This is probably OK for -Os (SizeLevel == 1), but we need to be careful with Oz (SizeLevel == 2).
We already know that enabling preinliner in general will reduce size -- as the preinliner is pretty conservative. But there will be cases size will be increased.

I would like more test results (like bootstrap clang) before committing.

Mon, Nov 30, 2:27 PM · Restricted Project, Restricted Project
zequanwu requested review of D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.
Mon, Nov 30, 2:09 PM · Restricted Project
zequanwu added a comment to D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.
In D91747#2423960, @rnk wrote:

If we believe the standard says that the compiler is supposed to set __STDCPP_THREADS__, then I think the libc++ #error needs to be adjusted. libcxxabi, or any other client, should be able to define _LIBCPP_HAS_NO_THREADS, and it should work, even if the compiler thinks they are allowed.

Mon, Nov 30, 1:37 PM · Restricted Project

Sun, Nov 22

zequanwu committed rG15a3ae1ab1a6: [Clang] Add __STDCPP_THREADS__ to standard predefine macros (authored by zequanwu).
[Clang] Add __STDCPP_THREADS__ to standard predefine macros
Sun, Nov 22, 4:06 PM
zequanwu closed D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.
Sun, Nov 22, 4:06 PM · Restricted Project

Fri, Nov 20

zequanwu added inline comments to D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.
Fri, Nov 20, 2:05 PM · Restricted Project
zequanwu updated the diff for D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

Update tests.

Fri, Nov 20, 2:04 PM · Restricted Project
zequanwu updated the diff for D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

Add ThreadModel to LangOptions and remove it from CodegenOption.

Fri, Nov 20, 10:00 AM · Restricted Project

Thu, Nov 19

zequanwu updated the diff for D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

Add a test case.

Thu, Nov 19, 5:07 PM · Restricted Project

Wed, Nov 18

zequanwu requested review of D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.
Wed, Nov 18, 3:29 PM · Restricted Project

Tue, Nov 17

zequanwu updated the diff for D91673: [PGO] Enable preinline and cleanup when optimize for size.

update wrong diff.

Tue, Nov 17, 6:06 PM · Restricted Project, Restricted Project
zequanwu requested review of D91673: [PGO] Enable preinline and cleanup when optimize for size.
Tue, Nov 17, 6:03 PM · Restricted Project, Restricted Project
zequanwu abandoned D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.
Tue, Nov 17, 2:37 PM · Restricted Project
zequanwu abandoned D89917: Revert "SimplifyCFG: Clean up optforfuzzing implementation".
Tue, Nov 17, 2:37 PM · Restricted Project

Tue, Nov 10

zequanwu committed rG78b48426a282: [llvm-cov] Add a test for c75a0a1e (authored by zequanwu).
[llvm-cov] Add a test for c75a0a1e
Tue, Nov 10, 2:26 PM

Fri, Nov 6

zequanwu added inline comments to D89359: [llvm-cov] don't include all source files when provided source files are filtered out.
Fri, Nov 6, 2:54 PM · Restricted Project
zequanwu committed rGc75a0a1e9dc2: [llvm-cov] Fix missing slash in -path-equivalence (authored by zequanwu).
[llvm-cov] Fix missing slash in -path-equivalence
Fri, Nov 6, 2:54 PM

Oct 30 2020

zequanwu committed rG4348e0eee4dd: [lldb][NFC] Refactor getUUID functionality (authored by zequanwu).
[lldb][NFC] Refactor getUUID functionality
Oct 30 2020, 10:45 AM
zequanwu closed D90325: [lldb][NFC] Refactor getUUID functionality.
Oct 30 2020, 10:45 AM · Restricted Project
zequanwu updated the diff for D90325: [lldb][NFC] Refactor getUUID functionality.

Address comments.

Oct 30 2020, 10:44 AM · Restricted Project

Oct 29 2020

zequanwu updated the diff for D90325: [lldb][NFC] Refactor getUUID functionality.

Address comments.

Oct 29 2020, 11:17 AM · Restricted Project

Oct 28 2020

zequanwu updated the diff for D90325: [lldb][NFC] Refactor getUUID functionality.

include correct header

Oct 28 2020, 12:16 PM · Restricted Project
zequanwu requested review of D90325: [lldb][NFC] Refactor getUUID functionality.
Oct 28 2020, 11:24 AM · Restricted Project

Oct 26 2020

zequanwu added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

load-pdb is still failing on the Windows bot. Can you please commit a fix soon or revert the change?

Oct 26 2020, 5:14 PM · Restricted Project
zequanwu committed rG779deb9750a4: [lldb][NativePDB] fix test load-pdb.cpp (authored by zequanwu).
[lldb][NativePDB] fix test load-pdb.cpp
Oct 26 2020, 5:13 PM
zequanwu added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

load-pdb is still failing on the Windows bot. Can you please commit a fix soon or revert the change?

Oct 26 2020, 2:54 PM · Restricted Project
zequanwu added a reverting change for rGa2ac64dd9054: Revert "Ensure that checkInitIsICE is called exactly once for every variable": rGe56e7bd4698d: Revert "Revert "Ensure that checkInitIsICE is called exactly once for every….
Oct 26 2020, 12:09 PM
zequanwu committed rGe56e7bd4698d: Revert "Revert "Ensure that checkInitIsICE is called exactly once for every… (authored by zequanwu).
Revert "Revert "Ensure that checkInitIsICE is called exactly once for every…
Oct 26 2020, 12:09 PM
zequanwu added a reverting change for rG76c009266586: Ensure that checkInitIsICE is called exactly once for every variable: rGa2ac64dd9054: Revert "Ensure that checkInitIsICE is called exactly once for every variable".
Oct 26 2020, 12:00 PM
zequanwu committed rGa2ac64dd9054: Revert "Ensure that checkInitIsICE is called exactly once for every variable" (authored by zequanwu).
Revert "Ensure that checkInitIsICE is called exactly once for every variable"
Oct 26 2020, 12:00 PM
zequanwu added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

It has regressed buildbots:

SymbolFile/NativePDB/load-pdb.cpp
lldb-x86_64-fedora: http://lab.llvm.org:8014/#/builders/14/builds/1006
lldb-x86_64-debian: http://lab.llvm.org:8011/#/builders/68/builds/782
Oct 26 2020, 11:39 AM · Restricted Project
zequanwu committed rG4b83747ab157: [lldb][NativePDB] fix test load-pdb.cpp (authored by zequanwu).
[lldb][NativePDB] fix test load-pdb.cpp
Oct 26 2020, 11:38 AM
zequanwu committed rG242e1e991044: [lldb][PDB] Add ObjectFile PDB plugin (authored by zequanwu).
[lldb][PDB] Add ObjectFile PDB plugin
Oct 26 2020, 10:29 AM
zequanwu closed D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Oct 26 2020, 10:29 AM · Restricted Project
zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.

Address comments.

Oct 26 2020, 10:28 AM · Restricted Project

Oct 25 2020

zequanwu added a comment to rG76c009266586: Ensure that checkInitIsICE is called exactly once for every variable.

Hi, this seems like causing assertion failure: Assertion Result && "Could not evaluate expression"' failed. at https://bugs.chromium.org/p/chromium/issues/detail?id=1142009

Oct 25 2020, 3:14 PM

Oct 23 2020

zequanwu committed rGe92eeaf3c219: [llvm-cov] don't include all source files when provided source files are… (authored by zequanwu).
[llvm-cov] don't include all source files when provided source files are…
Oct 23 2020, 7:32 PM
zequanwu closed D89359: [llvm-cov] don't include all source files when provided source files are filtered out.
Oct 23 2020, 7:32 PM · Restricted Project
zequanwu updated the diff for D89359: [llvm-cov] don't include all source files when provided source files are filtered out.

Fix test cases which failed on Windows.

Oct 23 2020, 7:32 PM · Restricted Project
zequanwu reopened D89359: [llvm-cov] don't include all source files when provided source files are filtered out.
Oct 23 2020, 6:46 PM · Restricted Project
zequanwu added inline comments to D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Oct 23 2020, 12:55 PM · Restricted Project
zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.

Address comments.

Oct 23 2020, 12:54 PM · Restricted Project

Oct 22 2020

zequanwu added inline comments to D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Oct 22 2020, 6:28 PM · Restricted Project
zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.

Address some comments.

Oct 22 2020, 6:28 PM · Restricted Project

Oct 21 2020

zequanwu added inline comments to D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.
Oct 21 2020, 5:14 PM · Restricted Project
zequanwu added a reverting change for rGcdd006eec940: SimplifyCFG: Clean up optforfuzzing implementation: D89917: Revert "SimplifyCFG: Clean up optforfuzzing implementation".
Oct 21 2020, 5:14 PM
zequanwu requested review of D89917: Revert "SimplifyCFG: Clean up optforfuzzing implementation".
Oct 21 2020, 5:14 PM · Restricted Project
zequanwu added a reverting change for rG716f7636e1ec: Revert "SimplifyCFG: Clean up optforfuzzing implementation": rG2f29341114ed: Revert "Revert "SimplifyCFG: Clean up optforfuzzing implementation"".
Oct 21 2020, 5:09 PM
zequanwu committed rG2f29341114ed: Revert "Revert "SimplifyCFG: Clean up optforfuzzing implementation"" (authored by zequanwu).
Revert "Revert "SimplifyCFG: Clean up optforfuzzing implementation""
Oct 21 2020, 5:09 PM
zequanwu added inline comments to D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Oct 21 2020, 5:02 PM · Restricted Project
zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.
  • address comments.
  • add tests.
  • move loadPDBFile from SymbolFileNativePDB.cpp to ObjectFilePDB.cpp and use it to create unique_ptr of PDBFile so that we can move it around.
Oct 21 2020, 5:01 PM · Restricted Project
zequanwu added a reverting change for rGcdd006eec940: SimplifyCFG: Clean up optforfuzzing implementation: rG716f7636e1ec: Revert "SimplifyCFG: Clean up optforfuzzing implementation".
Oct 21 2020, 4:57 PM
zequanwu committed rG716f7636e1ec: Revert "SimplifyCFG: Clean up optforfuzzing implementation" (authored by zequanwu).
Revert "SimplifyCFG: Clean up optforfuzzing implementation"
Oct 21 2020, 4:57 PM
zequanwu added inline comments to D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.
Oct 21 2020, 11:34 AM · Restricted Project

Oct 20 2020

zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.

elaborate CHECK

Oct 20 2020, 5:51 PM · Restricted Project
zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.
  • Add GetArchitecture method, similar to ObjectFilePECOFF
  • Add a test case.
Oct 20 2020, 5:48 PM · Restricted Project
zequanwu updated the diff for D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.

address comment

Oct 20 2020, 5:08 PM · Restricted Project
zequanwu added a comment to D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.

I'd say either revert https://github.com/llvm/llvm-project/commit/cdd006eec9409923f9a56b9026ce2cb72e7b71dc, or in FoldTwoEntryPHINode() check that the option is set and that the OptForFuzzing attribute is not set (same with simplifyCondBranch()). I guess I'd slightly prefer the second option as to not totally revert the original commit.

Oct 20 2020, 4:47 PM · Restricted Project
zequanwu added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

How can I start lldb at specified path so that target symbols add bar.pdb could find the pdb path? (For testing)

Oct 20 2020, 11:26 AM · Restricted Project
zequanwu requested review of D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Oct 20 2020, 11:16 AM · Restricted Project

Oct 16 2020

zequanwu added a comment to D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.

Why is this NPM specific?

This is something the legacy pass did but was not properly ported to the NPM pass.

Right. But why is this PM-specific at all, why aren't the folds themselves guarded with that?

Oct 16 2020, 1:34 PM · Restricted Project
zequanwu updated the diff for D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.

update test.

Oct 16 2020, 1:22 PM · Restricted Project
zequanwu added inline comments to D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.
Oct 16 2020, 1:12 PM · Restricted Project
zequanwu requested review of D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.
Oct 16 2020, 1:11 PM · Restricted Project

Oct 15 2020

zequanwu added a comment to D89359: [llvm-cov] don't include all source files when provided source files are filtered out.

Put a fix here: https://reviews.llvm.org/rG19ae9b6e21e2491debeb910e2c541be9796f1b13

Oct 15 2020, 10:15 PM · Restricted Project
zequanwu committed rG19ae9b6e21e2: [llvm-cov] Fix test cases. (authored by zequanwu).
[llvm-cov] Fix test cases.
Oct 15 2020, 10:14 PM
zequanwu committed rGcd3090819c4e: [llvm-cov] don't include all source files when provided source files are… (authored by zequanwu).
[llvm-cov] don't include all source files when provided source files are…
Oct 15 2020, 6:11 PM
zequanwu closed D89359: [llvm-cov] don't include all source files when provided source files are filtered out.
Oct 15 2020, 6:11 PM · Restricted Project

Oct 14 2020

zequanwu updated the diff for D89359: [llvm-cov] don't include all source files when provided source files are filtered out.
  • Add a test case
  • Fix broken test cases caused by -path-equivalence= not working correctly with . and .. in paths.
Oct 14 2020, 6:01 PM · Restricted Project

Oct 13 2020

zequanwu requested review of D89359: [llvm-cov] don't include all source files when provided source files are filtered out.
Oct 13 2020, 6:55 PM · Restricted Project

Oct 6 2020

zequanwu abandoned D88870: [lldb][NFC] remove unused local variable uuid.

sorry, I didn't notice that.

Oct 6 2020, 10:48 AM · Restricted Project

Oct 5 2020

zequanwu requested review of D88870: [lldb][NFC] remove unused local variable uuid.
Oct 5 2020, 9:59 PM · Restricted Project

Sep 29 2020

zequanwu committed rG6c91e623e537: [CodeGen] emit CG profile for COFF object file (authored by zequanwu).
[CodeGen] emit CG profile for COFF object file
Sep 29 2020, 12:04 PM
zequanwu closed D87811: [CodeGen] emit CG profile for COFF object file.
Sep 29 2020, 12:03 PM · Restricted Project
zequanwu updated the diff for D87811: [CodeGen] emit CG profile for COFF object file.

Will put the refactor part to a separate NFC commit.
Reland this as fix at D88456 seems work. (https://bugs.chromium.org/p/chromium/issues/detail?id=1130780#c18)

Sep 29 2020, 12:02 PM · Restricted Project
zequanwu committed rGa9abe1f7859e: [COFF][CG Profile] set undefined symbol to external (authored by zequanwu).
[COFF][CG Profile] set undefined symbol to external
Sep 29 2020, 9:50 AM
zequanwu closed D88456: [COFF][CG Profile] set undefined symbol to external.
Sep 29 2020, 9:50 AM · Restricted Project

Sep 28 2020

zequanwu added a reviewer for D88456: [COFF][CG Profile] set undefined symbol to external: aeubanks.
Sep 28 2020, 6:46 PM · Restricted Project
zequanwu updated the diff for D87811: [CodeGen] emit CG profile for COFF object file.

Split changes on .cg_profile to another patch D88456.

Sep 28 2020, 5:19 PM · Restricted Project
zequanwu requested review of D88456: [COFF][CG Profile] set undefined symbol to external.
Sep 28 2020, 5:17 PM · Restricted Project
zequanwu added inline comments to D87811: [CodeGen] emit CG profile for COFF object file.
Sep 28 2020, 3:09 PM · Restricted Project
zequanwu updated the diff for D87811: [CodeGen] emit CG profile for COFF object file.

For symbols haven't seen, just set them to external not weak external.

Sep 28 2020, 3:06 PM · Restricted Project
zequanwu reopened D87811: [CodeGen] emit CG profile for COFF object file.
Sep 28 2020, 3:04 PM · Restricted Project
zequanwu abandoned D87648: [Coverage][NFC] Remove skipped region after added into MappingRegions.
Sep 28 2020, 10:41 AM · Restricted Project

Sep 24 2020

zequanwu added a reverting change for rG90242caca207: Revert "[CodeGen] emit CG profile for COFF object file": rG506b6170cb51: Reland [CodeGen] emit CG profile for COFF object file.
Sep 24 2020, 2:40 PM
zequanwu committed rG506b6170cb51: Reland [CodeGen] emit CG profile for COFF object file (authored by zequanwu).
Reland [CodeGen] emit CG profile for COFF object file
Sep 24 2020, 2:40 PM
zequanwu closed D87811: [CodeGen] emit CG profile for COFF object file.
Sep 24 2020, 2:40 PM · Restricted Project

Sep 23 2020

zequanwu updated the diff for D87811: [CodeGen] emit CG profile for COFF object file.

Update. Don't emit CGProfileEntry if function has dll import storage class.

Sep 23 2020, 5:09 PM · Restricted Project
zequanwu committed rGf5435399e823: [CGProfile] don't emit cgprofile entry if called function is dllimport (authored by zequanwu).
[CGProfile] don't emit cgprofile entry if called function is dllimport
Sep 23 2020, 4:57 PM
zequanwu reopened D87811: [CodeGen] emit CG profile for COFF object file.
Sep 23 2020, 4:57 PM · Restricted Project
zequanwu closed D88127: [CGProfile] don't emit cgprofile entry if called function is dllimport.
Sep 23 2020, 4:57 PM · Restricted Project
zequanwu added a comment to D88127: [CGProfile] don't emit cgprofile entry if called function is dllimport.
In D88127#2291320, @rnk wrote:

I'm saying the fix belongs in TargetObjectFileLoweringImpl.cpp, which is the point where we translate from IR to assembly. We can't fix this after producing assembly, because we don't know what symbols are marked dllimport at that point.

Sep 23 2020, 4:20 PM · Restricted Project
zequanwu added a comment to D88127: [CGProfile] don't emit cgprofile entry if called function is dllimport.
In D88127#2291167, @rnk wrote:

However, I would prefer to move the check into CodeGen, so that if we receive some IR that has edges like this, we don't emit an object file that cannot be linked.

Sep 23 2020, 4:08 PM · Restricted Project