Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

zequanwu (Zequan Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 31 2020, 4:54 PM (182 w, 3 d)

Recent Activity

Tue, Sep 26

zequanwu added a reverting change for D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.: rG4d5d9a539058: Revert "[Coverage] Allow Clang coverage to be used with debug info correlation.".
Tue, Sep 26, 6:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu added a reverting change for rG32db121b29f7: [Coverage] Allow Clang coverage to be used with debug info correlation.: rG4d5d9a539058: Revert "[Coverage] Allow Clang coverage to be used with debug info correlation.".
Tue, Sep 26, 6:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu committed rG4d5d9a539058: Revert "[Coverage] Allow Clang coverage to be used with debug info correlation." (authored by zequanwu).
Revert "[Coverage] Allow Clang coverage to be used with debug info correlation."
Tue, Sep 26, 6:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Sep 19

zequanwu committed rG816144bfd2d8: [Coverage] Skip visiting ctor member initializers with invalid source locations. (authored by zequanwu).
[Coverage] Skip visiting ctor member initializers with invalid source locations.
Tue, Sep 19, 11:59 AM · Restricted Project, Restricted Project
zequanwu added a comment to D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

I have seen that MachO sections remain in the header even if the size is zero which seems to be the case here. You could use llvm-objdump to verify that the section exists but the size is zero.

Thanks, I didn't notice that. And this can be easily detected.

Tue, Sep 19, 11:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu added a comment to D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

I feel like either this feature not working well with mac or we should keep __llvm_prf_names section in the binary.

Tue, Sep 19, 11:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu committed rG6bab4008350a: [Profile] Delete coverage-debug-info-correlate.cpp test on mac as debug info… (authored by zequanwu).
[Profile] Delete coverage-debug-info-correlate.cpp test on mac as debug info…
Tue, Sep 19, 10:56 AM · Restricted Project, Restricted Project
zequanwu added a comment to D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

For some unknown reasons, linker still generates __llvm_prf_names section in the final binary on mac even if the object file doesn't have this section. And I cannot use llvm-objdump to get anything from that section.

Tue, Sep 19, 10:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Sep 18

zequanwu committed rG1609a87a830d: [Profile] Pass InstrProfSymtab by reference. (authored by zequanwu).
[Profile] Pass InstrProfSymtab by reference.
Mon, Sep 18, 11:20 AM · Restricted Project, Restricted Project
zequanwu committed rGcb9f66de8b8e: [Profile] Pass InstrProfSymtab instead of IndexedInstrProfReader when creating… (authored by zequanwu).
[Profile] Pass InstrProfSymtab instead of IndexedInstrProfReader when creating…
Mon, Sep 18, 9:44 AM · Restricted Project, Restricted Project

Fri, Sep 15

zequanwu added inline comments to D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..
Fri, Sep 15, 12:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu committed rG37402c34918a: [NFC][Coverage] Rename coverage function attribute name from "Cov Function… (authored by zequanwu).
[NFC][Coverage] Rename coverage function attribute name from "Cov Function…
Fri, Sep 15, 12:23 PM · Restricted Project, Restricted Project
zequanwu added a comment to D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

Looks like this breaks check-clang on mac: http://45.33.8.238/macm1/69297/step_7.txt

Please take a look and revert for now if it takes a while to fix.

Fri, Sep 15, 11:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu committed rG1f33bfc23fb9: Fix test case in 32db121b29f78e4c41116b2a8f1c730f9522b202. (authored by zequanwu).
Fix test case in 32db121b29f78e4c41116b2a8f1c730f9522b202.
Fri, Sep 15, 11:43 AM · Restricted Project, Restricted Project
zequanwu committed rG32db121b29f7: [Coverage] Allow Clang coverage to be used with debug info correlation. (authored by zequanwu).
[Coverage] Allow Clang coverage to be used with debug info correlation.
Fri, Sep 15, 10:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu closed D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..
Fri, Sep 15, 10:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, Sep 14

zequanwu added a comment to D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

It looks like debug-info-correlate-coverage.ll was renamed twice. Is this intended?

Thu, Sep 14, 1:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu updated the diff for D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

Address comments.

Thu, Sep 14, 1:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu updated the diff for D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

Remove profile name section.

Thu, Sep 14, 12:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, Sep 13

zequanwu committed rG5db94120105c: [test] add 'REQUIRES: lld-available' to online-merging-windows.c (authored by zequanwu).
[test] add 'REQUIRES: lld-available' to online-merging-windows.c
Wed, Sep 13, 7:31 AM · Restricted Project, Restricted Project

Tue, Sep 12

zequanwu added a reviewer for D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.: hans.
Tue, Sep 12, 11:05 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Sep 5

zequanwu added a comment to D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

It seems that the __llvm_prf_names is retained in this mode. What is the overhead of this section generally? Can we instead use debug info to lookup function names?

With debug info correlation enabled, __llvm_prf_names section will only contain functions names that are not emitted to the final binary, not even in debug info.

Could we emit those names into the .debug_str section?

Tue, Sep 5, 1:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu added inline comments to D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..
Tue, Sep 5, 10:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu updated the diff for D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

Address comments.

Tue, Sep 5, 10:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Sep 1

zequanwu added inline comments to rGb0b3f82dd3c0: Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element extractions….
Fri, Sep 1, 2:03 PM · Restricted Project, Restricted Project
zequanwu added a reverting change for rGb0b3f82dd3c0: Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element extractions…: rG57595086db5c: fix revert b0b3f82dd3c00cdba891f1ff6ba63abd419d0f18.
Fri, Sep 1, 2:02 PM · Restricted Project, Restricted Project
zequanwu committed rG57595086db5c: fix revert b0b3f82dd3c00cdba891f1ff6ba63abd419d0f18 (authored by zequanwu).
fix revert b0b3f82dd3c00cdba891f1ff6ba63abd419d0f18
Fri, Sep 1, 2:02 PM · Restricted Project, Restricted Project
zequanwu added inline comments to rGb0b3f82dd3c0: Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element extractions….
Fri, Sep 1, 1:56 PM · Restricted Project, Restricted Project
zequanwu added a comment to rG8347d7c15259: Revert "Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element….

Reverted at https://reviews.llvm.org/rGb0b3f82dd3c00cdba891f1ff6ba63abd419d0f18. Verified locally.

Fri, Sep 1, 1:41 PM · Restricted Project, Restricted Project
zequanwu added a reverting change for rG239ab16ec121: [X86] combineCMP - attempt to simplify KSHIFTR mask element extractions when…: rGb0b3f82dd3c0: Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element extractions….
Fri, Sep 1, 1:40 PM · Restricted Project, Restricted Project
zequanwu committed rGb0b3f82dd3c0: Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element extractions… (authored by zequanwu).
Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element extractions…
Fri, Sep 1, 1:40 PM · Restricted Project, Restricted Project
zequanwu added a comment to rG294ad08ecc00: Revert "Revert "InstSimplify: Use correct interested FP classes when….

I see. https://reviews.llvm.org/D157030 adds a dependency on the commits I tried to revert.

Fri, Sep 1, 12:46 PM · Restricted Project, Restricted Project
zequanwu committed rG460bba352118: Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element extractions… (authored by zequanwu).
Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element extractions…
Fri, Sep 1, 12:07 PM · Restricted Project, Restricted Project
zequanwu added a reverting change for rG239ab16ec121: [X86] combineCMP - attempt to simplify KSHIFTR mask element extractions when…: rG460bba352118: Revert "[X86] combineCMP - attempt to simplify KSHIFTR mask element extractions….
Fri, Sep 1, 12:07 PM · Restricted Project, Restricted Project
zequanwu added a reverting change for rGddb3f12c428b: InstSimplify: Start cleaning up simplifyFCmpInst: rG89f0314ee14a: Revert "InstSimplify: Use correct interested FP classes when simplifying fcmp".
Fri, Sep 1, 11:55 AM · Restricted Project, Restricted Project
zequanwu added a reverting change for rG239fb206de35: InstSimplify: Add baseline tests for reported regression: rG89f0314ee14a: Revert "InstSimplify: Use correct interested FP classes when simplifying fcmp".
Fri, Sep 1, 11:55 AM · Restricted Project, Restricted Project
zequanwu added a reverting change for rG0637b00041c7: InstSimplify: Use correct interested FP classes when simplifying fcmp: rG89f0314ee14a: Revert "InstSimplify: Use correct interested FP classes when simplifying fcmp".
Fri, Sep 1, 11:55 AM · Restricted Project, Restricted Project
zequanwu committed rG89f0314ee14a: Revert "InstSimplify: Use correct interested FP classes when simplifying fcmp" (authored by zequanwu).
Revert "InstSimplify: Use correct interested FP classes when simplifying fcmp"
Fri, Sep 1, 11:55 AM · Restricted Project, Restricted Project
zequanwu added a comment to rG239ab16ec121: [X86] combineCMP - attempt to simplify KSHIFTR mask element extractions when….

Here's the reduced IR:

target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
Fri, Sep 1, 11:47 AM · Restricted Project, Restricted Project
zequanwu added a comment to rG239ab16ec121: [X86] combineCMP - attempt to simplify KSHIFTR mask element extractions when….

This causes crashes when building chromium with asan:

Fri, Sep 1, 11:41 AM · Restricted Project, Restricted Project
zequanwu added a comment to D151887: InstSimplify: Start cleaning up simplifyFCmpInst.

Attach reduced IR:

target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
Fri, Sep 1, 10:57 AM · Restricted Project, Restricted Project
zequanwu added a comment to D151887: InstSimplify: Start cleaning up simplifyFCmpInst.

Heads up this causing assertion failure when compiling chromium code:

clang++: /usr/local/google/home/zequanwu/workspace/llvm-project/llvm/lib/Analysis/InstructionSimplify.cpp:4136: llvm::Value *simplifyFCmpInst(unsigned int, llvm::Value *, llvm::Value *, llvm::FastMathFlags, const llvm::SimplifyQuery &, unsigned int): Assertion `!C->isNaN() && "Unexpected NaN constant!"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.      Program arguments: /usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang++ -MMD -MF obj/ui/gfx/color_space/color_space.o.d -DCOLOR_SPACE_IMPLEMENTATION -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -D_LIBCPP_ENABLE_ASSERTIONS=1 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=84fb809dd6dae36d556dc0bb702c6cc2ce9d4b80 -DCR_SYSROOT_KEY=20230611T210420Z-2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56 -DBASE_USE_PERFETTO_CLIENT_LIBRARY=1 -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_DISABLE_LEGACY_SKSURFACE_METHODS -DSK_DISABLE_LEGACY_GRAPHITE_IMAGE_FACTORIES -DSK_DISABLE_LEGACY_GRAPHITE_IMAGE_METHODS -DSK_DISABLE_LEGACY_SKSURFACE_FACTORIES -DSK_DISABLE_LEGACY_SKSURFACE_FLUSH -DSK_DISABLE_LEGACY_SKSURFACE_AS_IMAGE -DSK_DISABLE_LEGACY_SKSURFACE_DISPLAYLIST -DSK_DISABLE_LEGACY_IMAGE_SUBSET_METHODS -DSK_DISABLE_LEGACY_IMAGE_COLORSPACE_METHODS -DSK_DISABLE_LEGACY_IMAGE_RELEASE_PROCS -DSK_DISABLE_LEGACY_GL_BACKEND_SURFACE -DSK_DISABLE_LEGACY_INIT_DECODERS -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_GANESH -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DSK_GL -DSK_VULKAN=1 -DSK_GRAPHITE -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFORM_WAYLAND_KHR -DWEBP_EXTERN=extern -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../third_party/skia -Igen/third_party/skia -I../../third_party/wuffs/src/release/c -I../../third_party/vulkan/include -I../../third_party/vulkan-deps/vulkan-headers/src/include -I../../third_party/wayland/src/src -I../../third_party/wayland/include/src -I../../third_party/libwebp/src/src -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -Wall -Werror -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -fwhole-program-vtables -fcomplete-member-pointers -m64 -msse3 -ffile-compilation-dir=. -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fdata-sections -ffunction-sections -fno-unique-section-names -fno-omit-frame-pointer -g0 -fprofile-generate -fsanitize=cfi-vcall -fsanitize-ignorelist=../../tools/cfi/ignores.txt -fsanitize=cfi-icall -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -isystem../../build/linux/debian_bullseye_amd64-sysroot/usr/include/glib-2.0 -isystem../../build/linux/debian_bullseye_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wno-redundant-parens -DPROTOBUF_ALLOW_DEPRECATED=1 -std=c++20 -Wno-trigraphs -gsimple-template-names -fno-exceptions -fno-rtti -nostdinc++ -isystem../../third_party/libc++/src/include -isystem../../third_party/libc++abi/src/include --sysroot=../../build/linux/debian_bullseye_amd64-sysroot -fvisibility-inlines-hidden -c ../../ui/gfx/color_space.cc -o obj/ui/gfx/color_space/color_space.o
1.      <eof> parser at end of file
2.      Optimizer
 #0 0x0000564f48406a07 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x355da07)
 #1 0x0000564f484046ee llvm::sys::RunSignalHandlers() (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x355b6ee)
 #2 0x0000564f483788a8 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0
 #3 0x00007fbf98c5a540 (/lib/x86_64-linux-gnu/libc.so.6+0x3c540)
 #4 0x00007fbf98ca812c __pthread_kill_implementation ./nptl/pthread_kill.c:44:76
 #5 0x00007fbf98c5a4a2 raise ./signal/../sysdeps/posix/raise.c:27:6
 #6 0x00007fbf98c444b2 abort ./stdlib/abort.c:81:7
 #7 0x00007fbf98c443d5 _nl_load_domain ./intl/loadmsgcat.c:1177:9
 #8 0x00007fbf98c533a2 (/lib/x86_64-linux-gnu/libc.so.6+0x353a2)
 #9 0x0000564f475c0b93 simplifyFCmpInst(unsigned int, llvm::Value*, llvm::Value*, llvm::FastMathFlags, llvm::SimplifyQuery const&, unsigned int) InstructionSimplify.cpp:0:0
#10 0x0000564f4b848df0 llvm::JumpThreadingPass::computeValueKnownInPredecessorsImpl(llvm::Value*, llvm::BasicBlock*, llvm::SmallVectorImpl<std::pair<llvm::Constant*, llvm::BasicBlock*>>&, llvm::jumpthreading::ConstantPreference, llvm::DenseSet<llvm::Value*, llvm::DenseMapInfo<llvm::Value*, void>>&, llvm::Instruction*) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x699fdf0)
#11 0x0000564f4b84ab44 llvm::JumpThreadingPass::processThreadableEdges(llvm::Value*, llvm::BasicBlock*, llvm::jumpthreading::ConstantPreference, llvm::Instruction*) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x69a1b44)
#12 0x0000564f4b8476db llvm::JumpThreadingPass::processBlock(llvm::BasicBlock*) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x699e6db)
#13 0x0000564f4b846713 llvm::JumpThreadingPass::runImpl(llvm::Function&, llvm::AnalysisManager<llvm::Function>*, llvm::TargetLibraryInfo*, llvm::TargetTransformInfo*, llvm::LazyValueInfo*, llvm::AAResults*, std::unique_ptr<llvm::DomTreeUpdater, std::default_delete<llvm::DomTreeUpdater>>, std::optional<llvm::BlockFrequencyInfo*>, std::optional<llvm::BranchProbabilityInfo*>) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x699d713)
#14 0x0000564f4b845dd4 llvm::JumpThreadingPass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x699cdd4)
#15 0x0000564f4861135d llvm::detail::PassModel<llvm::Function, llvm::JumpThreadingPass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x376835d)
#16 0x0000564f47e86ee4 llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x2fddee4)
#17 0x0000564f4626edbd llvm::detail::PassModel<llvm::Function, llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x13c5dbd)
#18 0x0000564f47539b96 llvm::CGSCCToFunctionPassAdaptor::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x2690b96)
#19 0x0000564f46270e0d llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::CGSCCToFunctionPassAdaptor, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x13c7e0d)
#20 0x0000564f47534423 llvm::PassManager<llvm::LazyCallGraph::SCC, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x268b423)
#21 0x0000564f495286dd llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::PassManager<llvm::LazyCallGraph::SCC, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x467f6dd)
#22 0x0000564f47537d58 llvm::DevirtSCCRepeatedPass::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x268ed58)
#23 0x0000564f495428fd llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::DevirtSCCRepeatedPass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x46998fd)
#24 0x0000564f47536418 llvm::ModuleToPostOrderCGSCCPassAdaptor::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x268d418)
#25 0x0000564f495289ad llvm::detail::PassModel<llvm::Module, llvm::ModuleToPostOrderCGSCCPassAdaptor, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x467f9ad)
#26 0x0000564f47e860f4 llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x2fdd0f4)
#27 0x0000564f496672cc llvm::ModuleInlinerWrapperPass::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x47be2cc)
#28 0x0000564f4952eeed llvm::detail::PassModel<llvm::Module, llvm::ModuleInlinerWrapperPass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x4685eed)
#29 0x0000564f47e860f4 llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x2fdd0f4)
#30 0x0000564f4860b22c (anonymous namespace)::EmitAssemblyHelper::RunOptimizationPipeline(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>&, std::unique_ptr<llvm::ToolOutputFile, std::default_delete<llvm::ToolOutputFile>>&) BackendUtil.cpp:0:0
#31 0x0000564f48601770 clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x3758770)
#32 0x0000564f4947117a clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x45c817a)
#33 0x0000564f4a4f0534 clang::ParseAST(clang::Sema&, bool, bool) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x5647534)
#34 0x0000564f48dca780 clang::FrontendAction::Execute() (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x3f21780)
#35 0x0000564f48d3b1af clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x3e921af)
#36 0x0000564f48ea459c clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x3ffb59c)
#37 0x0000564f45f5b4ae cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x10b24ae)
#38 0x0000564f45f582d1 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&, llvm::ToolContext const&) driver.cpp:0:0
#39 0x0000564f48b9d479 void llvm::function_ref<void ()>::callback_fn<clang::driver::CC1Command::Execute(llvm::ArrayRef<std::optional<llvm::StringRef>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>*, bool*) const::$_1>(long) Job.cpp:0:0
#40 0x0000564f483785eb llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x34cf5eb)
#41 0x0000564f48b9ca10 clang::driver::CC1Command::Execute(llvm::ArrayRef<std::optional<llvm::StringRef>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>*, bool*) const (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x3cf3a10)
#42 0x0000564f48b5c52e clang::driver::Compilation::ExecuteCommand(clang::driver::Command const&, clang::driver::Command const*&, bool) const (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x3cb352e)
#43 0x0000564f48b5c7e7 clang::driver::Compilation::ExecuteJobs(clang::driver::JobList const&, llvm::SmallVectorImpl<std::pair<int, clang::driver::Command const*>>&, bool) const (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x3cb37e7)
#44 0x0000564f48b7cce7 clang::driver::Driver::ExecuteCompilation(clang::driver::Compilation&, llvm::SmallVectorImpl<std::pair<int, clang::driver::Command const*>>&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x3cd3ce7)
#45 0x0000564f45f5791e clang_main(int, char**, llvm::ToolContext const&) (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x10ae91e)
#46 0x0000564f45f67861 main (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x10be861)
#47 0x00007fbf98c456ca __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3
#48 0x00007fbf98c45785 call_init ./csu/../csu/libc-start.c:128:20
#49 0x00007fbf98c45785 __libc_start_main ./csu/../csu/libc-start.c:347:5
#50 0x0000564f45f54711 _start (/usr/local/google/home/zequanwu/workspace/llvm-project/build/cmake/bin/clang+++0x10ab711)
Fri, Sep 1, 9:42 AM · Restricted Project, Restricted Project

Aug 29 2023

zequanwu added a comment to D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

It seems that the __llvm_prf_names is retained in this mode. What is the overhead of this section generally? Can we instead use debug info to lookup function names?

Aug 29 2023, 11:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu retitled D157913: [Coverage] Allow Clang coverage to be used with debug info correlation. from [WIP][Coverage] Allow Clang coverage to be used with debug info correlation. to [Coverage] Allow Clang coverage to be used with debug info correlation..
Aug 29 2023, 10:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 28 2023

zequanwu updated the diff for D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

Rebase and correct name section size in profile header.

Aug 28 2023, 2:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu committed rGf52f8e817ea3: [Profile] Allow online merging with debug info correlation. (authored by zequanwu).
[Profile] Allow online merging with debug info correlation.
Aug 28 2023, 1:36 PM · Restricted Project, Restricted Project, Restricted Project
zequanwu closed D157632: [Profile] Allow online merging with debug info correlation..
Aug 28 2023, 1:35 PM · Restricted Project, Restricted Project, Restricted Project
zequanwu added inline comments to D126586: [InstrProf] Single byte counters in coverage.
Aug 28 2023, 11:34 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu committed rGd80992032fd0: Reland "[Profile] Allow online merging with debug info correlation." (authored by zequanwu).
Reland "[Profile] Allow online merging with debug info correlation."
Aug 28 2023, 10:33 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu closed D159000: Reland "[Profile] Allow online merging with debug info correlation.".
Aug 28 2023, 10:33 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu updated the summary of D159000: Reland "[Profile] Allow online merging with debug info correlation.".
Aug 28 2023, 10:30 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu requested review of D159000: Reland "[Profile] Allow online merging with debug info correlation.".
Aug 28 2023, 8:53 AM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2023

zequanwu updated the diff for D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..

Update.
Binary may still contains __llvm_prf_names sections for functions that are not emitted.

Aug 17 2023, 12:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 14 2023

zequanwu committed rGbfc965c54fdb: [Profile] Removed incorrect check introduced by… (authored by zequanwu).
[Profile] Removed incorrect check introduced by…
Aug 14 2023, 1:12 PM · Restricted Project, Restricted Project
zequanwu requested review of D157913: [Coverage] Allow Clang coverage to be used with debug info correlation..
Aug 14 2023, 12:43 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zequanwu committed rGcf2cf195d5fb: [Profile] Allow online merging with debug info correlation. (authored by zequanwu).
[Profile] Allow online merging with debug info correlation.
Aug 14 2023, 12:15 PM · Restricted Project, Restricted Project, Restricted Project
zequanwu closed D157632: [Profile] Allow online merging with debug info correlation..
Aug 14 2023, 12:15 PM · Restricted Project, Restricted Project, Restricted Project
zequanwu updated the diff for D157632: [Profile] Allow online merging with debug info correlation..

Rebase and address comments.

Aug 14 2023, 11:37 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu added a comment to D157632: [Profile] Allow online merging with debug info correlation..

BTW, I noticed something strange with -pgo-function-entry-coverage when merging via llvm-profdata.

This is intentional. The two raw profiles individually store blocks as either covered or not, but when we merge them they get converted to counters and accumulated.
https://github.com/llvm/llvm-project/blob/6a0feb1503e21432e63d93b44357bad43f8026d1/llvm/lib/ProfileData/InstrProf.cpp#L726
Then in PGOUseFunc::populateCoverage() we annotate blocks as alive if their counter value is non-zero.
https://github.com/llvm/llvm-project/blob/1aee2434ce4c9b5785cbc8f72cbbbd64f9e85297/llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp#L1399
My logic was that the indexed profile represents these counters as ints, so we might as well accumulate them. Also, this makes the implementation simpler.

Aug 14 2023, 8:32 AM · Restricted Project, Restricted Project, Restricted Project

Aug 11 2023

zequanwu added a comment to D157632: [Profile] Allow online merging with debug info correlation..

BTW, I noticed something strange with -pgo-function-entry-coverage when merging via llvm-profdata.
In this file compiler-rt/test/profile/Linux/instrprof-debug-info-correlate.c, I ran the following:

// RUN: %clang_pgogen -o %t.cov.normal -mllvm --pgo-function-entry-coverage -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp
// RUN: rm -rf %t.dir && mkdir %t.dir
// RUN: env LLVM_PROFILE_FILE=%t.dir/%m.profraw %run %t.cov.normal
// RUN: env LLVM_PROFILE_FILE=%t.dir/%m.profraw %run %t.cov.normal
// RUN: llvm-profdata merge -o %t.cov.normal.profdata %t.dir/
// RUN: llvm-profdata show --all-functions --counts %t.cov.normal.profdata
// It shows block counts 1.
Counters:
  main:
    Hash: 0x06d15c67b2c35b9c
    Counters: 1
    Block counts: [1]
  _Z3fooi:
    Hash: 0x0209aa3e3852da94
    Counters: 1
    Block counts: [1]
  _Z3bari:
    Hash: 0x0209aa3e1d398548
    Counters: 1
    Block counts: [1]
  _Z6unusedi:
    Hash: 0x0a4d0ad3efffffff
    Counters: 1
    Block counts: [0]
Instrumentation level: IR  entry_first = 0
Functions shown: 4
Total functions: 4
Maximum function count: 1
Maximum internal block count: 0
Aug 11 2023, 9:28 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu added a comment to D157632: [Profile] Allow online merging with debug info correlation..

I've just published https://reviews.llvm.org/D157664, so you'll want to rebase ontop of it if it lands soon. I would also like to see some more tests added to instrprof-merge-error.c to make sure two different binaries can't merge profiles together with --debug-info-correlate. I was thinking the test would be something like this.

// RUN: %clang_pgogen -o %t/a -g -mllvm --debug-info-correlate -mllvm --disable-vp=true %t/main.c
// RUN: %clang_pgogen -o %t/b -g -mllvm --debug-info-correlate -mllvm --disable-vp=true %t/main.c %t/foo.c
// RUN: env LLVM_PROFILE_FILE=%t/default_%m.profdata %run %t/a
// This next line should fail to merge because the counter sections have different sizes
// RUN: env LLVM_PROFILE_FILE=%t/default_%m.profdata %run %t/b

//--- main.c
int main() { return 0; }
//--- foo.c
int foo() { return 4; }
Aug 11 2023, 8:49 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu added inline comments to D157632: [Profile] Allow online merging with debug info correlation..
Aug 11 2023, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu updated the diff for D157632: [Profile] Allow online merging with debug info correlation..

Address comments.

Aug 11 2023, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu added a comment to D157665: [InstrProf] Fix debug-info-correlate test.

I noticed that the profdata files are compared with just diff in compiler-rt/test/profile/Darwin/instrprof-debug-info-correlate.c. Can we do the same here?

Aug 11 2023, 8:25 AM · Restricted Project, Restricted Project
zequanwu accepted D157664: [InstrProf] Report error when merging temporal profiles.

LGTM.

Aug 11 2023, 8:03 AM · Restricted Project, Restricted Project

Aug 10 2023

zequanwu updated the diff for D157632: [Profile] Allow online merging with debug info correlation..

Remove debug includes.

Aug 10 2023, 9:24 AM · Restricted Project, Restricted Project, Restricted Project
zequanwu requested review of D157632: [Profile] Allow online merging with debug info correlation..
Aug 10 2023, 9:22 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2023

zequanwu committed rG8cee8183d4c1: [Profile] Fix 98dec28458172091893e46040d7b5ab745a44b82 (authored by zequanwu).
[Profile] Fix 98dec28458172091893e46040d7b5ab745a44b82
Aug 4 2023, 11:25 AM · Restricted Project, Restricted Project
zequanwu added a reverting change for rG4b08be77c98a: Revert "[Profile] Remove duplicate file locks when enabled continuous mode and…: rG98dec2845817: Reland [Profile] Remove duplicate file locks when enabled continuous mode and….
Aug 4 2023, 11:12 AM · Restricted Project, Restricted Project
zequanwu committed rG98dec2845817: Reland [Profile] Remove duplicate file locks when enabled continuous mode and… (authored by zequanwu).
Reland [Profile] Remove duplicate file locks when enabled continuous mode and…
Aug 4 2023, 11:12 AM · Restricted Project, Restricted Project
zequanwu added inline comments to D156949: [lldb] Update LLDB Code Ownership.
Aug 4 2023, 8:32 AM · Restricted Project, Restricted Project

Aug 3 2023

zequanwu added a reverting change for rG985486dca48b: [Profile] Remove duplicate file locks when enabled continuous mode and online…: rG4b08be77c98a: Revert "[Profile] Remove duplicate file locks when enabled continuous mode and….
Aug 3 2023, 10:12 AM · Restricted Project, Restricted Project
zequanwu committed rG4b08be77c98a: Revert "[Profile] Remove duplicate file locks when enabled continuous mode and… (authored by zequanwu).
Revert "[Profile] Remove duplicate file locks when enabled continuous mode and…
Aug 3 2023, 10:12 AM · Restricted Project, Restricted Project
zequanwu added a reverting change for D154748: [Profile] Remove duplicate file locks when enabled continuous mode and online merging.: rG4b08be77c98a: Revert "[Profile] Remove duplicate file locks when enabled continuous mode and….
Aug 3 2023, 10:12 AM · Restricted Project, Restricted Project

Jul 20 2023

zequanwu requested review of D155875: [Profile] Enable 2 continuous tests on more platforms..
Jul 20 2023, 11:50 AM · Restricted Project, Restricted Project

Jul 11 2023

zequanwu added inline comments to D154748: [Profile] Remove duplicate file locks when enabled continuous mode and online merging..
Jul 11 2023, 2:47 PM · Restricted Project, Restricted Project

Jul 10 2023

zequanwu committed rG985486dca48b: [Profile] Remove duplicate file locks when enabled continuous mode and online… (authored by zequanwu).
[Profile] Remove duplicate file locks when enabled continuous mode and online…
Jul 10 2023, 8:02 AM · Restricted Project, Restricted Project
zequanwu closed D154748: [Profile] Remove duplicate file locks when enabled continuous mode and online merging..
Jul 10 2023, 8:01 AM · Restricted Project, Restricted Project

Jul 7 2023

zequanwu requested review of D154748: [Profile] Remove duplicate file locks when enabled continuous mode and online merging..
Jul 7 2023, 2:16 PM · Restricted Project, Restricted Project

Jun 15 2023

zequanwu added a comment to D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size..

This is still breaking check-clang on windows: http://45.33.8.238/win/79908/step_7.txt

Please take a look and revert for now if it takes a while to fix.

Jun 15 2023, 11:47 AM · Restricted Project, Restricted Project
zequanwu committed rG9d910b107319: Fix test breakage in 879e88693338657aec092db749ddfcb582c65491. (authored by zequanwu).
Fix test breakage in 879e88693338657aec092db749ddfcb582c65491.
Jun 15 2023, 11:47 AM · Restricted Project, Restricted Project
zequanwu added a comment to D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size..
Jun 15 2023, 8:36 AM · Restricted Project, Restricted Project
zequanwu committed rG879e88693338: Reland "[Clang][MS] Remove assertion on BaseOffset can't be smaller than Size." (authored by zequanwu).
Reland "[Clang][MS] Remove assertion on BaseOffset can't be smaller than Size."
Jun 15 2023, 8:35 AM · Restricted Project, Restricted Project

Jun 14 2023

zequanwu committed rG5d54213ee557: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size. (authored by zequanwu).
[Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.
Jun 14 2023, 1:48 PM · Restricted Project, Restricted Project
zequanwu closed D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size..
Jun 14 2023, 1:48 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size..

Address comments.

Jun 14 2023, 11:28 AM · Restricted Project, Restricted Project

Jun 8 2023

zequanwu updated the diff for D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size..

Extend the output and reading of -fdump-record-layouts-simple.
Add a test case.

Jun 8 2023, 3:52 PM · Restricted Project, Restricted Project
zequanwu requested review of D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size..
Jun 8 2023, 2:43 PM · Restricted Project, Restricted Project

Jun 6 2023

zequanwu committed rGcb9a7c22ee67: [LLDB][PDB] Fix age field in UUID in PDB file. (authored by zequanwu).
[LLDB][PDB] Fix age field in UUID in PDB file.
Jun 6 2023, 8:25 AM · Restricted Project
zequanwu closed D152189: [LLDB][PDB] Fix age field in UUID in PDB file..
Jun 6 2023, 8:24 AM · Restricted Project, Restricted Project

Jun 5 2023

zequanwu requested review of D152189: [LLDB][PDB] Fix age field in UUID in PDB file..
Jun 5 2023, 12:23 PM · Restricted Project, Restricted Project

Jun 1 2023

zequanwu added a comment to D151175: [lsan] Invoke hooks on realloc.

It looks like also failing in chromium mac bots. I haven't confirmed, but it's very likely.
Build: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8780155112582797025/+/u/package_clang/stdout?format=raw

FAIL: SanitizerCommon-tsan-x86_64-Darwin :: malloc_hook.cpp (67438 of 71222)
 ******************** TEST 'SanitizerCommon-tsan-x86_64-Darwin :: malloc_hook.cpp' FAILED ********************
 Script:
 --
 : 'RUN: at line 1';      /opt/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/./bin/clang  --driver-mode=g++ -gline-tables-only -fsanitize=thread  -arch x86_64 -stdlib=libc++ -mmacosx-version-min=10.12 -isysroot /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk  -I/opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test -O2 /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/sanitizer_common/TestCases/malloc_hook.cpp -o /opt/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/tsan-x86_64-Darwin/Output/malloc_hook.cpp.tmp &&  /opt/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/tsan-x86_64-Darwin/Output/malloc_hook.cpp.tmp 2>&1 | FileCheck /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/sanitizer_common/TestCases/malloc_hook.cpp
 --
 Exit Code: 2
Jun 1 2023, 10:54 AM · Restricted Project, Restricted Project

May 29 2023

zequanwu committed rGda54bd230aa4: [gn build] (manually) port 9f6250f (authored by zequanwu).
[gn build] (manually) port 9f6250f
May 29 2023, 11:51 AM · Restricted Project, Restricted Project

May 19 2023

zequanwu added a comment to D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path..

Hello and good afternoon from the UK,

I believe this patch has caused failures on the following buildbot:

https://lab.llvm.org/buildbot/#/builders/216/builds/21493

are you able to take a look?

thanks,
Tom W

May 19 2023, 10:35 AM · Restricted Project, Restricted Project
zequanwu committed rGfe69bb64415e: Fix tests failure on 75993812d5c1f269b781c34987748f2a792a579d (authored by zequanwu).
Fix tests failure on 75993812d5c1f269b781c34987748f2a792a579d
May 19 2023, 10:35 AM · Restricted Project, Restricted Project
zequanwu committed rG75993812d5c1: Use windows baskslash on anonymous tag locations if using MSVCFormatting and… (authored by zequanwu).
Use windows baskslash on anonymous tag locations if using MSVCFormatting and…
May 19 2023, 5:45 AM · Restricted Project, Restricted Project
zequanwu closed D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path..
May 19 2023, 5:44 AM · Restricted Project, Restricted Project

May 18 2023

zequanwu added a reviewer for D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.: rnk.
May 18 2023, 10:16 AM · Restricted Project, Restricted Project

May 17 2023

zequanwu updated the summary of D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path..
May 17 2023, 2:14 PM · Restricted Project, Restricted Project
zequanwu updated the summary of D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path..
May 17 2023, 2:14 PM · Restricted Project, Restricted Project