This is an archive of the discontinued LLVM Phabricator instance.

[Test] Fix CHECK typo.
ClosedPublic

Authored by zequanwu on Nov 2 2022, 2:26 PM.

Diff Detail

Event Timeline

zequanwu created this revision.Nov 2 2022, 2:26 PM
zequanwu requested review of this revision.Nov 2 2022, 2:26 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
zequanwu updated this revision to Diff 472833.Nov 2 2022, 7:56 PM

Fix more typos.

Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptNov 2 2022, 7:56 PM

Nice work!
have you verified that all the modified tests pass? naively it looks like you'd need at least 3 different targets to run them all (windows, webassembly, powerpc)

Nice work!
have you verified that all the modified tests pass? naively it looks like you'd need at least 3 different targets to run them all (windows, webassembly, powerpc)

Those are target independent tests. I'm able to run and pass those tests in my linux machine.

probinson accepted this revision.Nov 3 2022, 5:56 PM

LGTM, but you'll want to be ready to jump on any bot failures. That's just the nature of these kinds of changes.

This revision is now accepted and ready to land.Nov 3 2022, 5:56 PM
This revision was automatically updated to reflect the committed changes.