Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D137216

[clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting files
ClosedPublic
Actions

Authored by jansvoboda11 on Nov 1 2022, 5:12 PM.

Details

Reviewers
Bigcheese
dexonsmith
vsapsai
Commits
rGa13122c612a6: [clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting…
Summary

This patch delays some ASTWriter logic until after we've checked whether the source location entry we're serializing as an affecting file or not.

Depends on D137214.

Diff Detail

Event Timeline

jansvoboda11 created this revision.Nov 1 2022, 5:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2022, 5:12 PM
Herald added a subscriber: ributzka. · View Herald Transcript
jansvoboda11 requested review of this revision.Nov 1 2022, 5:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2022, 5:12 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
dexonsmith accepted this revision.Nov 1 2022, 5:23 PM

LGTM.

This revision is now accepted and ready to land.Nov 1 2022, 5:23 PM
Harbormaster completed remote builds in B195595: Diff 472463.Nov 1 2022, 7:07 PM
Closed by commit rGa13122c612a6: [clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting… (authored by jansvoboda11). · Explain WhyNov 1 2022, 7:23 PM
This revision was automatically updated to reflect the committed changes.
jansvoboda11 added a commit: rGa13122c612a6: [clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting….

Revision Contents
Changeset List

PathSize
clang/
lib/
Serialization/
9 lines

Diff 472463

View Options

clang/lib/Serialization/ASTWriter.cpp

Loading...