This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE2] Add the SVE2.1 shift-and-narrow instructions
ClosedPublic

Authored by david-arm on Oct 25 2022, 7:59 AM.

Details

Summary

This patch adds the assembly/disassembly for the following instructions:

sqrshrn : Signed saturating rounding shift right narrow by immediate and interleave
sqrshrun : Signed saturating rounding shift right unsigned narrow by immediate and interleave
uqrshrn : Unsigned saturating rounding shift right narrow by immediate and interleave

The reference can be found here:
https://developer.arm.com/documentation/ddi0602/2022-09

Diff Detail

Event Timeline

david-arm created this revision.Oct 25 2022, 7:59 AM
david-arm requested review of this revision.Oct 25 2022, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2022, 7:59 AM
llvm/lib/Target/AArch64/SVEInstrFormats.td
8701

Much like D136689 can you expose tsz at this level and then hide it with a multiclass?

  • Expose tsz field to the class
david-arm marked an inline comment as done.Oct 27 2022, 12:45 AM
paulwalker-arm accepted this revision.Oct 27 2022, 4:44 PM
paulwalker-arm added inline comments.
llvm/lib/Target/AArch64/SVEInstrFormats.td
8714

Sorry I missed this during my previous review but looking at the decode table opc should be Inst{13-11}.

This revision is now accepted and ready to land.Oct 27 2022, 4:44 PM
david-arm added inline comments.Oct 27 2022, 11:04 PM
llvm/lib/Target/AArch64/SVEInstrFormats.td
8714

Sure I can do that, except I'll be passing in exactly the same bit 11 for all instructions.

paulwalker-arm added inline comments.Oct 28 2022, 2:33 AM
llvm/lib/Target/AArch64/SVEInstrFormats.td
8714

Yep I understand, I just prefer to match the encoding group so there's potentially less work when adding new instructions later.

Matt added a subscriber: Matt.Oct 29 2022, 8:21 AM
This revision was landed with ongoing or failed builds.Oct 31 2022, 6:46 AM
This revision was automatically updated to reflect the committed changes.