This is an archive of the discontinued LLVM Phabricator instance.

Differential D136609

[llvm] Fix minimum Apple Clang requirement
ClosedPublic

Authored by kadircet on Oct 24 2022, 8:16 AM.

Details

Reviewers
thieta
Commits
rGb999ac1af60b: [llvm] Fix minimum Apple Clang requirement
Summary

This was stated as 9.3, but as pointed out in
https://discourse.llvm.org/t/rfc-bump-minimal-requirements-apple-clang-9-3-10-0-0-before-4th-tue-in-january/66156/7?u=kadircet
9.3 doesn't exist, hence this was effectively 10.0.

This patch merely reflects the reality more closely.

Diff Detail

Event Timeline

kadircet created this revision.Oct 24 2022, 8:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 8:16 AM
kadircet requested review of this revision.Oct 24 2022, 8:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 8:16 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
tschuett added a subscriber: tschuett.Oct 24 2022, 9:12 AM

Thanks!

Harbormaster completed remote builds in B193948: Diff 470168.Oct 24 2022, 9:40 AM
jloser added a subscriber: jloser.Oct 24 2022, 9:08 PM

LGTM!

kadircet added a comment.Oct 28 2022, 5:52 AM

ping @thieta , PLMK if I should be adding other reviewers instead

thieta accepted this revision.Oct 28 2022, 5:57 AM

LGTM - this shouldn't be a real change so let's go for it. We can always back it out later if anyone complains. Let this be a week or so in main before using things that depend on Xcode 10.

This revision is now accepted and ready to land.Oct 28 2022, 5:57 AM
This revision was landed with ongoing or failed builds.Oct 28 2022, 6:12 AM
Closed by commit rGb999ac1af60b: [llvm] Fix minimum Apple Clang requirement (authored by kadircet). · Explain Why
This revision was automatically updated to reflect the committed changes.
kadircet added a commit: rGb999ac1af60b: [llvm] Fix minimum Apple Clang requirement.

Revision Contents

PathSize
llvm/
cmake/
modules/
4 lines
docs/
2 lines
2 lines

Diff 471516

llvm/cmake/modules/CheckCompilerVersion.cmake

# Check if the host compiler is new enough. # Check if the host compiler is new enough.
# These versions are updated based on the following policy: # These versions are updated based on the following policy:
# llvm.org/docs/DeveloperPolicy.html#toolchain # llvm.org/docs/DeveloperPolicy.html#toolchain
include(CheckCXXSourceCompiles) include(CheckCXXSourceCompiles)
set(GCC_MIN 7.1) set(GCC_MIN 7.1)
set(GCC_SOFT_ERROR 7.1) set(GCC_SOFT_ERROR 7.1)
set(CLANG_MIN 5.0) set(CLANG_MIN 5.0)
set(CLANG_SOFT_ERROR 5.0) set(CLANG_SOFT_ERROR 5.0)
set(APPLECLANG_MIN 9.3) set(APPLECLANG_MIN 10.0)
set(APPLECLANG_SOFT_ERROR 9.3) set(APPLECLANG_SOFT_ERROR 10.0)
# https://en.wikipedia.org/wiki/Microsoft_Visual_C#Internal_version_numbering # https://en.wikipedia.org/wiki/Microsoft_Visual_C#Internal_version_numbering
# _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7
set(MSVC_MIN 19.27) set(MSVC_MIN 19.27)
set(MSVC_SOFT_ERROR 19.27) set(MSVC_SOFT_ERROR 19.27)
set(LIBSTDCXX_MIN 7) set(LIBSTDCXX_MIN 7)
set(LIBSTDCXX_SOFT_ERROR 7) set(LIBSTDCXX_SOFT_ERROR 7)
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines

llvm/docs/GettingStarted.rst

Show First 20 Lines • Show All 233 Lines • ▼ Show 20 Lines
the C++ language and library reasonably closely. As such, we require a modern the C++ language and library reasonably closely. As such, we require a modern
host C++ toolchain, both compiler and standard library, in order to build LLVM. host C++ toolchain, both compiler and standard library, in order to build LLVM.
LLVM is written using the subset of C++ documented in :doc:`coding LLVM is written using the subset of C++ documented in :doc:`coding
standards<CodingStandards>`. To enforce this language version, we check the most standards<CodingStandards>`. To enforce this language version, we check the most
popular host toolchains for specific minimum versions in our build systems: popular host toolchains for specific minimum versions in our build systems:
* Clang 5.0 * Clang 5.0
* Apple Clang 9.3 * Apple Clang 10.0
* GCC 7.1 * GCC 7.1
* Visual Studio 2019 16.7 * Visual Studio 2019 16.7
Anything older than these toolchains *may* work, but will require forcing the Anything older than these toolchains *may* work, but will require forcing the
build system with a special option and is not really a supported host platform. build system with a special option and is not really a supported host platform.
Also note that older versions of these compilers have often crashed or Also note that older versions of these compilers have often crashed or
miscompiled LLVM. miscompiled LLVM.
▲ Show 20 Lines • Show All 900 Lines • Show Last 20 Lines

llvm/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
the code base. the code base.
The previous "soft" toolchain requirements have now been changed to "hard". The previous "soft" toolchain requirements have now been changed to "hard".
This means that the the following versions are now required to build LLVM This means that the the following versions are now required to build LLVM
and there is no way to suppress this error. and there is no way to suppress this error.
* GCC >= 7.1 * GCC >= 7.1
* Clang >= 5.0 * Clang >= 5.0
* Apple Clang >= 9.3 * Apple Clang >= 10.0
* Visual Studio 2019 >= 16.7 * Visual Studio 2019 >= 16.7
Changes to the LLVM IR Changes to the LLVM IR
---------------------- ----------------------
* The constant expression variants of the following instructions has been * The constant expression variants of the following instructions has been
removed: removed:
▲ Show 20 Lines • Show All 154 Lines • Show Last 20 Lines