Page MenuHomePhabricator

jloser (Joe Loser)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 12 2018, 3:20 PM (101 w, 5 d)

Recent Activity

Jan 10 2020

jloser closed D45677: [libcxx] [test] Fix typo in filesystem test .
Jan 10 2020, 6:46 PM

Dec 21 2019

jloser added a comment to D45677: [libcxx] [test] Fix typo in filesystem test .

Jim, thanks for accepting the review. Do you mind landing this on my behalf? I don't have commit rights. Thanks!

Dec 21 2019, 11:02 AM

Apr 29 2019

jloser added inline comments to D61293: Fix make_from_tuple when given a tuple containing rvalues.
Apr 29 2019, 9:18 PM

Apr 18 2019

jloser added inline comments to D60849: Use const predicate operators in algorithms .
Apr 18 2019, 6:54 PM

Apr 5 2019

jloser added inline comments to D59344: Add contains method to map types.
Apr 5 2019, 7:44 PM
jloser added a comment to D60246: [libc++] Simple contains for associative containers.

Ah right. Yeah, the commit does mention how this patch didn't touch the precalculated hash lookups at all. Now your comment makes sense. :)

Apr 5 2019, 7:43 PM · Restricted Project
Herald updated subscribers of D58987: Make underlying_type SFINAE-friendly.
Apr 5 2019, 7:09 PM
jloser added a comment to D58987: Make underlying_type SFINAE-friendly.

We should mark P0340R3 as complete with this patch. This is done in libcxx/www/cxx2a_status.html.

Apr 5 2019, 7:09 PM
jloser added a comment to D60246: [libc++] Simple contains for associative containers.

@zoecarver no worries; no I have not written one. Why do we need a custom hash implementation? We should be able to support contains with precomputed hashes without a custom hasher.

Apr 5 2019, 5:07 PM · Restricted Project

Apr 4 2019

jloser added inline comments to D59344: Add contains method to map types.
Apr 4 2019, 7:18 AM
Herald updated subscribers of D59344: Add contains method to map types.
Apr 4 2019, 7:15 AM
jloser abandoned D60246: [libc++] Simple contains for associative containers.
Apr 4 2019, 7:15 AM · Restricted Project
jloser added a comment to D60246: [libc++] Simple contains for associative containers.

Sorry, I did not notice https://reviews.llvm.org/D59344 was in flight. That one looks like a superset of these changes, though I think we should only provide the declaration/definitions of contains in the case of #if _LIBCPP_STD_VER > 17. I will post a comment to that effect in https://reviews.llvm.org/D59344.

Apr 4 2019, 7:15 AM · Restricted Project

Apr 3 2019

jloser created D60246: [libc++] Simple contains for associative containers.
Apr 3 2019, 8:53 PM · Restricted Project

Aug 4 2018

jloser added inline comments to D50298: Add unit test for StringLexer.
Aug 4 2018, 3:00 PM

Apr 15 2018

jloser created D45677: [libcxx] [test] Fix typo in filesystem test .
Apr 15 2018, 4:12 PM

Apr 8 2018

jloser added a comment to D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests.

Have you verified that we're not losing test coverage here? That is, are you sure we still have tests for the rvalue overloads in other test files?

Apr 8 2018, 3:00 PM
jloser updated the diff for D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests.

Use v3 rather than an rvalue of 3 in libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp

Apr 8 2018, 2:15 PM
jloser retitled D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests from [libc++] Fix Container::insert(value_type const&) tests to [libcxx] [test] Fix Container::insert(value_type const&) tests.
Apr 8 2018, 1:46 PM

Mar 16 2018

jloser added reviewers for D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests: compnerd, HyeYeon, lvoufo.
Mar 16 2018, 3:45 PM

Mar 13 2018

jloser updated the summary of D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests.
Mar 13 2018, 2:39 PM

Mar 12 2018

jloser created D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests.
Mar 12 2018, 7:51 PM