Page MenuHomePhabricator

jloser (Joe Loser)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 12 2018, 3:20 PM (187 w, 5 d)

Recent Activity

Today

jloser added a comment to D111922: [libc++] P1981: Rename leap to leap_second.

I'm OK with removing this part of the synopsis instead. I'd vote that we remove *all* of the C++20-but-not-yet-implemented chrono parts in the synopsis then, such as time zone database, time zones, exception classes, parsing, etc (basically all of C++20 chrono stuff mentioned in the synopsis).

Sat, Oct 16, 4:25 PM · Restricted Project
jloser added a comment to D111925: [libc++][NFC] Mark LWG3573 as complete.

Thanks for addressing these LWG-issues.

Sat, Oct 16, 4:19 PM · Restricted Project
jloser updated the diff for D111925: [libc++][NFC] Mark LWG3573 as complete.

Guard with TEST_HAS_NO_EXCEPTIONS

Sat, Oct 16, 4:12 PM · Restricted Project
jloser updated the diff for D111925: [libc++][NFC] Mark LWG3573 as complete.

Address Arthur's feedback

Sat, Oct 16, 4:09 PM · Restricted Project

Yesterday

jloser requested review of D111925: [libc++][NFC] Mark LWG3573 as complete.
Fri, Oct 15, 8:31 PM · Restricted Project
jloser requested review of D111922: [libc++] P1981: Rename leap to leap_second.
Fri, Oct 15, 7:56 PM · Restricted Project
jloser added inline comments to D111865: [libc++] Use apple-install-libcxx.sh in the Apple/system CI job.
Fri, Oct 15, 7:19 AM · Restricted Project

Thu, Oct 14

jloser accepted D111838: [libc++] Implement LWG3369, tweak CTAD for std::span..

LGTM - thanks for looking into it.

Thu, Oct 14, 5:29 PM · Restricted Project

Wed, Oct 13

jloser added inline comments to D111644: [libc++] LWG3480: make (recursive)_directory_iterator C++20 ranges.
Wed, Oct 13, 5:39 PM · Restricted Project
jloser updated the diff for D111644: [libc++] LWG3480: make (recursive)_directory_iterator C++20 ranges.

Remove _LIBCPP_TEMPLATE_VIS
Change range_concept_conformance.compile.pass to be UNSUPPORTED: libcpp-has-no-incomplete-ranges

Wed, Oct 13, 5:36 PM · Restricted Project
jloser added inline comments to D110647: [SystemZ][z/OS] Resolve missing table_size symbol.
Wed, Oct 13, 12:19 PM · Restricted Project
jloser added inline comments to D110647: [SystemZ][z/OS] Resolve missing table_size symbol.
Wed, Oct 13, 12:18 PM · Restricted Project
jloser added inline comments to D111644: [libc++] LWG3480: make (recursive)_directory_iterator C++20 ranges.
Wed, Oct 13, 11:27 AM · Restricted Project
jloser updated the diff for D111644: [libc++] LWG3480: make (recursive)_directory_iterator C++20 ranges.

Add _LIBCPP_TEMPLATE_VIS to directory_iterator and recursive_directory_iterator.

Wed, Oct 13, 11:25 AM · Restricted Project
jloser updated the diff for D111644: [libc++] LWG3480: make (recursive)_directory_iterator C++20 ranges.

Test value type, reference type, and const reference types in range concept conformance tests
Fix whitespacing with template<> in synopsis and in tests

Wed, Oct 13, 11:23 AM · Restricted Project
jloser updated the diff for D111644: [libc++] LWG3480: make (recursive)_directory_iterator C++20 ranges.

Remove unneeded <concepts> include from enable_view.compile.pass.cpp

Wed, Oct 13, 7:59 AM · Restricted Project
jloser added inline comments to D111644: [libc++] LWG3480: make (recursive)_directory_iterator C++20 ranges.
Wed, Oct 13, 7:58 AM · Restricted Project
jloser updated the diff for D111644: [libc++] LWG3480: make (recursive)_directory_iterator C++20 ranges.
  • Address Arthur's feedback
  • Don't XFAIL: * the range concept conformance tests for directory_iterator and recursive_directory_iterator. Split them up and adjust the static asserts so the tests pass.
  • Extend testing for enable_view and enable_borrowed range to test ref and const qualified variants
Wed, Oct 13, 7:54 AM · Restricted Project

Tue, Oct 12

jloser updated the diff for D111598: [libc++][docs] Mark LWG3420 complete.

[NFC] Fix commit message

Tue, Oct 12, 7:40 PM · Restricted Project
jloser added inline comments to D111598: [libc++][docs] Mark LWG3420 complete.
Tue, Oct 12, 7:39 PM · Restricted Project
jloser added a comment to D111598: [libc++][docs] Mark LWG3420 complete.

LGTM, but can you confirm we have a test for that? Also, the commit you linked to isn't the right one, 120fa8293e22f760374a5757d081dc674046e0f0 is just moving stuff around. You should fix the commit message.

Tue, Oct 12, 7:39 PM · Restricted Project
jloser updated the diff for D111598: [libc++][docs] Mark LWG3420 complete.

[NFC] Update commit message

Tue, Oct 12, 7:38 PM · Restricted Project
jloser requested review of D111644: [libc++] LWG3480: make (recursive)_directory_iterator C++20 ranges.
Tue, Oct 12, 6:59 AM · Restricted Project

Mon, Oct 11

jloser requested review of D111598: [libc++][docs] Mark LWG3420 complete.
Mon, Oct 11, 7:20 PM · Restricted Project
jloser added a comment to D111501: [libc++][docs] Mark LWG3447 as complete.

LGTM but please look at my comment! Thanks for investigating :)

Mon, Oct 11, 6:41 PM · Restricted Project
jloser added inline comments to D109212: [libc++][NFCI] span: replace enable_if with requires.
Mon, Oct 11, 1:58 PM · Restricted Project
jloser added inline comments to D111516: [libc++][docs] Mark LWG3274 as complete.
Mon, Oct 11, 11:39 AM · Restricted Project
jloser updated the diff for D111516: [libc++][docs] Mark LWG3274 as complete.

[NFC] Align member functions near empty() in span

Mon, Oct 11, 11:38 AM · Restricted Project
jloser added a comment to D111481: [libc++] P2401: conditional noexcept for std::exchange.

ping @Quuxplusone. The test is as you proposed, but wanted your approval before I land this.

Mon, Oct 11, 11:30 AM · Restricted Project
jloser added a comment to D111197: [libc++] Verify span and string_view are trivially copyable.

ping @Quuxplusone @Mordante

Mon, Oct 11, 10:03 AM · Restricted Project
jloser updated the diff for D111516: [libc++][docs] Mark LWG3274 as complete.

Remove XFAIL from test

Mon, Oct 11, 10:02 AM · Restricted Project
jloser added a comment to D111516: [libc++][docs] Mark LWG3274 as complete.

Two small nits, but I'd like to see the CI passing before approving.

Mon, Oct 11, 10:01 AM · Restricted Project
jloser updated the diff for D111516: [libc++][docs] Mark LWG3274 as complete.

[NFC] Remove extra blank line in empty.nodiscard.verify.cpp

Mon, Oct 11, 10:00 AM · Restricted Project
jloser added inline comments to D111516: [libc++][docs] Mark LWG3274 as complete.
Mon, Oct 11, 9:23 AM · Restricted Project
jloser updated the diff for D111516: [libc++][docs] Mark LWG3274 as complete.

Mark span::empty as [[nodiscard]] and add tests.

Mon, Oct 11, 8:00 AM · Restricted Project

Sun, Oct 10

jloser requested review of D111516: [libc++][docs] Mark LWG3274 as complete.
Sun, Oct 10, 5:26 PM · Restricted Project
jloser added inline comments to D111458: [libc++][doc] Use issue labels..
Sun, Oct 10, 5:06 PM · Restricted Project
jloser added a comment to D111512: [libc++] Remove empty namespace std in type_traits. NFCI..

Agreed and I would have been fine committing this without a review,

Sun, Oct 10, 11:34 AM · Restricted Project
jloser requested review of D111512: [libc++] Remove empty namespace std in type_traits. NFCI..
Sun, Oct 10, 11:28 AM · Restricted Project
jloser added inline comments to D111481: [libc++] P2401: conditional noexcept for std::exchange.
Sun, Oct 10, 8:28 AM · Restricted Project
jloser updated the diff for D111481: [libc++] P2401: conditional noexcept for std::exchange.

Add constexpr noexcept to synopsis
Remove runtime call of test_noexcept() in test

Sun, Oct 10, 8:26 AM · Restricted Project

Sat, Oct 9

jloser requested review of D111501: [libc++][docs] Mark LWG3447 as complete.
Sat, Oct 9, 7:46 PM · Restricted Project
jloser updated the diff for D111481: [libc++] P2401: conditional noexcept for std::exchange.

Empty message for static_assert so test works in C++14 mode

Sat, Oct 9, 3:44 PM · Restricted Project
jloser added inline comments to D111481: [libc++] P2401: conditional noexcept for std::exchange.
Sat, Oct 9, 3:14 PM · Restricted Project
jloser updated the diff for D111481: [libc++] P2401: conditional noexcept for std::exchange.

Address Arthur's feedback

Sat, Oct 9, 3:12 PM · Restricted Project
jloser added inline comments to D111481: [libc++] P2401: conditional noexcept for std::exchange.
Sat, Oct 9, 2:14 PM · Restricted Project
jloser updated the diff for D111481: [libc++] P2401: conditional noexcept for std::exchange.

Address review comments

Sat, Oct 9, 2:13 PM · Restricted Project

Fri, Oct 8

jloser requested review of D111481: [libc++] P2401: conditional noexcept for std::exchange.
Fri, Oct 8, 8:28 PM · Restricted Project
jloser added a comment to D111197: [libc++] Verify span and string_view are trivially copyable.

The string_view test passes on all vendors. CI is green. Everyone still OK if I land this as-is then?

Fri, Oct 8, 5:06 PM · Restricted Project
jloser added inline comments to D111197: [libc++] Verify span and string_view are trivially copyable.
Fri, Oct 8, 2:08 PM · Restricted Project
jloser updated the diff for D111197: [libc++] Verify span and string_view are trivially copyable.

Run the tests on all vendors for all relevant standards. Let's see if any fail.

Fri, Oct 8, 2:08 PM · Restricted Project
jloser updated the diff for D111197: [libc++] Verify span and string_view are trivially copyable.

Rebase and mark P2251 complete in Cxx2bPapers.csv

Fri, Oct 8, 2:04 PM · Restricted Project
jloser added inline comments to D111197: [libc++] Verify span and string_view are trivially copyable.
Fri, Oct 8, 8:46 AM · Restricted Project

Thu, Oct 7

jloser added reviewers for D110503: [libc++] Implement P1394r4 for span: range constructor: Mordante, mclow.lists.
Thu, Oct 7, 9:02 AM · Restricted Project
jloser added inline comments to D111197: [libc++] Verify span and string_view are trivially copyable.
Thu, Oct 7, 9:01 AM · Restricted Project
jloser updated the diff for D111197: [libc++] Verify span and string_view are trivially copyable.

Use _LIBCPP_HAS_NO_CHAR8_T

Thu, Oct 7, 9:00 AM · Restricted Project
jloser updated the diff for D111197: [libc++] Verify span and string_view are trivially copyable.

Guard against char8_t not existing

Thu, Oct 7, 7:31 AM · Restricted Project

Wed, Oct 6

jloser updated the diff for D111197: [libc++] Verify span and string_view are trivially copyable.

Address review feedback

Wed, Oct 6, 11:26 AM · Restricted Project
jloser updated the diff for D110503: [libc++] Implement P1394r4 for span: range constructor.

Rebase since D110718 landed

Wed, Oct 6, 11:21 AM · Restricted Project
jloser added a comment to D111197: [libc++] Verify span and string_view are trivially copyable.

We need to mark this paper as implemented in the status page. The Status pages haven't been updated for yesterday's meeting yet - let me do that now and then you can rebase on top.

Wed, Oct 6, 10:48 AM · Restricted Project
jloser added inline comments to D111197: [libc++] Verify span and string_view are trivially copyable.
Wed, Oct 6, 10:30 AM · Restricted Project
jloser added a comment to D110503: [libc++] Implement P1394r4 for span: range constructor.

@Quuxplusone @ldionne this PR should be ready with CI passing on this revision. Feel free to submit follow-up PRs for cleaning up other unrelated (from the purpose of this PR) constructor's SFINAE with nullptr, etc.

Wed, Oct 6, 7:42 AM · Restricted Project
jloser added inline comments to D110503: [libc++] Implement P1394r4 for span: range constructor.
Wed, Oct 6, 7:40 AM · Restricted Project
jloser updated the diff for D110503: [libc++] Implement P1394r4 for span: range constructor.

Fix debug build

Wed, Oct 6, 7:28 AM · Restricted Project
jloser added inline comments to D111166: [libc++][doc] Update paper status..
Wed, Oct 6, 7:21 AM · Restricted Project
jloser added inline comments to D110718: [libc++] Implement P1391 for string_view.
Wed, Oct 6, 7:18 AM · Restricted Project
jloser updated the diff for D110718: [libc++] Implement P1391 for string_view.

Add mixed-const iterator test in deduct.pass.cpp.
Test a sentinel while we're at it in deduct.pass.cpp
Don't rely on deduction guide in from_iterator_sentinel.pass.cpp

Wed, Oct 6, 7:16 AM · Restricted Project
jloser added inline comments to D111197: [libc++] Verify span and string_view are trivially copyable.
Wed, Oct 6, 7:05 AM · Restricted Project
jloser updated the diff for D111197: [libc++] Verify span and string_view are trivially copyable.

Address review feedback

Wed, Oct 6, 7:05 AM · Restricted Project
jloser updated the diff for D110718: [libc++] Implement P1391 for string_view.

If BuildKit is happy with this, I'll land it.

Wed, Oct 6, 6:58 AM · Restricted Project
jloser added inline comments to D110718: [libc++] Implement P1391 for string_view.
Wed, Oct 6, 6:58 AM · Restricted Project
jloser updated the diff for D110718: [libc++] Implement P1391 for string_view.

Add assert for valid range in string_view constructor
Rename sized_sentinel_wrapper to sized_sentinel

Wed, Oct 6, 6:48 AM · Restricted Project

Tue, Oct 5

jloser updated the diff for D111197: [libc++] Verify span and string_view are trivially copyable.

Explicitly include <type_traits> in tests

Tue, Oct 5, 5:00 PM · Restricted Project
jloser requested review of D111197: [libc++] Verify span and string_view are trivially copyable.
Tue, Oct 5, 4:59 PM · Restricted Project
jloser added inline comments to D110718: [libc++] Implement P1391 for string_view.
Tue, Oct 5, 4:23 PM · Restricted Project
jloser updated the diff for D110718: [libc++] Implement P1391 for string_view.

Introduce sized_sentinel_wrapper and use it in from_iterator_sentinel.pass.cpp

Tue, Oct 5, 4:21 PM · Restricted Project
jloser updated the diff for D110503: [libc++] Implement P1394r4 for span: range constructor.

[NFC] Spacing in sized_sentinel_wrapper's operator--

Tue, Oct 5, 4:03 PM · Restricted Project
jloser updated the diff for D110503: [libc++] Implement P1394r4 for span: range constructor.

Add test for constructing span from iterator/sentinel
Add sized_sentinel_wrapper to "test_iterators.h"

Tue, Oct 5, 3:59 PM · Restricted Project
jloser updated the diff for D110503: [libc++] Implement P1394r4 for span: range constructor.

XFAIL: AppleClang-12.0.0 a bunch of span tests.
Fix modules build for use of ranges::size in span

Tue, Oct 5, 3:48 PM · Restricted Project
jloser added a comment to D110872: [runtimes][ci] Run the tests for libunwind in the CI.

Add a bunch of XFAILs. This is really bad, we have like 8 tests and more than half
of them are failing even in some common configurations. We'll need some serious
investigation.

Tue, Oct 5, 2:40 PM · Restricted Project, Restricted Project
jloser added inline comments to D110994: [libc++] Make test_allocator constexpr-friendly for constexpr string/vector.
Tue, Oct 5, 9:41 AM · Restricted Project
jloser added a comment to D110718: [libc++] Implement P1391 for string_view.

ping @ldionne since CI is passing. Are you still happy with this?

Tue, Oct 5, 9:34 AM · Restricted Project
jloser added a comment to D111148: [libc++][test] Use = delete over DELETE_FUNCTION. NFC..

LGTM, but, have you tried just inlining = delete; in all these places? I believe Clang supports it in C++03 mode, and we don't care about other compilers in C++03 mode.

Tue, Oct 5, 7:48 AM · Restricted Project
jloser updated the diff for D111148: [libc++][test] Use = delete over DELETE_FUNCTION. NFC..

Inline = delete; for all usages of DELETE_FUNCTION

Tue, Oct 5, 7:47 AM · Restricted Project
jloser updated the diff for D111148: [libc++][test] Use = delete over DELETE_FUNCTION. NFC..

[NFC] More cleanup in limited_allocator

Tue, Oct 5, 7:05 AM · Restricted Project
jloser updated the diff for D111148: [libc++][test] Use = delete over DELETE_FUNCTION. NFC..

Remove extra private section in limited_allocator since we use DELETE_FUNCTION now.

Tue, Oct 5, 7:03 AM · Restricted Project
jloser updated the diff for D111148: [libc++][test] Use = delete over DELETE_FUNCTION. NFC..

Use DELETE_FUNCTION in test_allocator.h

Tue, Oct 5, 6:56 AM · Restricted Project
jloser updated the diff for D111148: [libc++][test] Use = delete over DELETE_FUNCTION. NFC..

Fix commit message

Tue, Oct 5, 6:55 AM · Restricted Project
jloser requested review of D111148: [libc++][test] Use = delete over DELETE_FUNCTION. NFC..
Tue, Oct 5, 6:40 AM · Restricted Project
jloser updated the diff for D110503: [libc++] Implement P1394r4 for span: range constructor.

Mark empty.pass.cpp as UNSUPPORTED: libcpp-has-no-incomplete-ranges

Tue, Oct 5, 5:51 AM · Restricted Project

Mon, Oct 4

jloser updated the diff for D110503: [libc++] Implement P1394r4 for span: range constructor.

Mark several other span tests as UNSUPPORTED: libcpp-has-no-incomplete-ranges

Mon, Oct 4, 9:13 PM · Restricted Project
jloser updated the diff for D110718: [libc++] Implement P1391 for string_view.

[NFC] Clean up spacing in string_view constructor

Mon, Oct 4, 9:03 PM · Restricted Project
jloser added inline comments to D110718: [libc++] Implement P1391 for string_view.
Mon, Oct 4, 9:00 PM · Restricted Project
jloser updated the diff for D110718: [libc++] Implement P1391 for string_view.

Use local sentinel in from_iterator_sentinel.pass.cpp

Mon, Oct 4, 8:49 PM · Restricted Project
jloser updated the diff for D110718: [libc++] Implement P1391 for string_view.

Prefer parens over braces
Add mixed iterator test in from_iterator_sentinel.pass.cpp

Mon, Oct 4, 4:57 PM · Restricted Project
jloser added inline comments to D110718: [libc++] Implement P1391 for string_view.
Mon, Oct 4, 4:46 PM · Restricted Project
jloser added inline comments to D110718: [libc++] Implement P1391 for string_view.
Mon, Oct 4, 1:51 PM · Restricted Project
jloser updated the diff for D110718: [libc++] Implement P1391 for string_view.

Rebase to trigger CI

Mon, Oct 4, 12:42 PM · Restricted Project
jloser added inline comments to D110718: [libc++] Implement P1391 for string_view.
Mon, Oct 4, 12:42 PM · Restricted Project
jloser updated the diff for D110503: [libc++] Implement P1394r4 for span: range constructor.

Rebase to trigger CI

Mon, Oct 4, 12:40 PM · Restricted Project