- User Since
- Mar 12 2018, 3:20 PM (290 w, 1 d)
Jul 23 2023
So happy to see this finally get written up. I appreciate you doing this! This will be very helpful for new contributors.
Much better name! Thanks.
Jul 15 2023
Looks good - just left a comment on a minor typo. Thanks!
Jun 15 2023
Excited to see this come together!
Jun 4 2023
May 18 2023
May 4 2023
Apr 21 2023
Thanks for the quick fix from the discussion on the issue today.
Apr 18 2023
Thanks for adding this for others. This is the same script I use locally as well that I got from you ages ago.
Apr 3 2023
Big +1 from me. Thanks for doing this.
Mar 29 2023
Mar 20 2023
Feb 21 2023
I can't speak to the correctness of the implementation of findModulesAndOffsets here, but I'd love to see this make progress.
Feb 16 2023
Feb 15 2023
Rebase and mark the paper status as completed
Feb 14 2023
Rebase since the clang-format requirement patch landed
Remove unnecessary constexpr_char_traits.h include
Drop the static_assert tests that verified traits_type mismatches as they are no longer relevant
Feb 13 2023
Undo extra clang-format in from_range.pass.cpp
Feb 6 2023
Seems reasonable to me. We should close https://reviews.llvm.org/D125394 when/if we land your review here.
Feb 5 2023
Feb 3 2023
Feb 2 2023
Feb 1 2023
Update commit message to properly display the #define
Jan 26 2023
Thanks for writing this up for others' benefit! I remember when you first showed me this a long time ago, I was really thankful for helping track down a CI failure.
Jan 17 2023
Update LLVM_DEPRECATED messages to use MutableArrayRef
Jan 16 2023
Jan 15 2023
Jan 10 2023
I landed this as the CI failures are unrelated
Rebase in quest for the green CI
Remove deduction guide from MutableArrayRef: it's not needed. Add a test from both const and non-const MutableArrayRef to show there's no issues, or ambiguous deduction guides like before.
Jan 9 2023
Thanks for the fix! LGTM FWIW.
Add tests for deduction guides and runtime behavior
Add [llvm] to title
LGTM, but I haven't been following as closely this release, so there may be other things I didn't notice in the updated release notes.
Use decltype(auto) in operator* in case the base type is const qualified
@philnik mind if I land this? CI isn't green yet due to unrelated issues.
Rebase and use >= 20 instead of > 17
Jan 8 2023
Dec 20 2022
Sorry for the delay here; this patch LGTM! Thanks.
Dec 18 2022
Prettify commit message formatting
Dec 17 2022
I'm +1 for the direction here; I took a brief look but will look closely either later tonight or tomorrow before I approve. Thanks for doing this!
LGTM with just removing the const. Please add a comment though as we don't have an existing regression test to show this (i.e. prevent someone from adding const back IIUC).