- User Since
- Mar 12 2018, 3:20 PM (101 w, 5 d)
Jan 10 2020
Dec 21 2019
Jim, thanks for accepting the review. Do you mind landing this on my behalf? I don't have commit rights. Thanks!
Apr 29 2019
Apr 18 2019
Apr 5 2019
Ah right. Yeah, the commit does mention how this patch didn't touch the precalculated hash lookups at all. Now your comment makes sense. :)
We should mark P0340R3 as complete with this patch. This is done in libcxx/www/cxx2a_status.html.
@zoecarver no worries; no I have not written one. Why do we need a custom hash implementation? We should be able to support contains with precomputed hashes without a custom hasher.
Apr 4 2019
Sorry, I did not notice https://reviews.llvm.org/D59344 was in flight. That one looks like a superset of these changes, though I think we should only provide the declaration/definitions of contains in the case of #if _LIBCPP_STD_VER > 17. I will post a comment to that effect in https://reviews.llvm.org/D59344.
Apr 3 2019
Aug 4 2018
Apr 15 2018
Apr 8 2018
Use v3 rather than an rvalue of 3 in libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp