Page MenuHomePhabricator

[clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`
Needs ReviewPublic

Authored by Izaron on Oct 7 2022, 12:01 PM.

Details

Summary

Ignore constrained perfect forwarding constructors.

Diff Detail

Event Timeline

Izaron created this revision.Oct 7 2022, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 12:01 PM
Izaron requested review of this revision.Oct 7 2022, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 12:01 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko added inline comments.
clang-tools-extra/docs/clang-tidy/checks/bugprone/forwarding-reference-overload.rst
53–54

Please follow 80 characters limit.

Izaron updated this revision to Diff 466175.Oct 7 2022, 2:01 PM

Follow 80 characters limit. Thanks to @Eugene.Zelenko!

Izaron marked an inline comment as done.Oct 7 2022, 2:01 PM
Izaron added inline comments.
clang-tools-extra/docs/clang-tidy/checks/bugprone/forwarding-reference-overload.rst
53–54

Thanks! I ran git clang-format HEAD~1 before commiting, but it didn't modify this file. Seems like it doesn't see .rst files.

Eugene.Zelenko added inline comments.
clang-tools-extra/docs/clang-tidy/checks/bugprone/forwarding-reference-overload.rst
53–54

If I my memory is not failing me, @MyDeveloperDay once tried to introduce documentation linter, but I don't think that it reached production.