LGTM! Thank you for the fix!

A big TODO: rename ext_c_label_end_of_compound_statement to something like ext_c_label_free_positioning. Since we found out it is more complete than just the end of statements.

In D144334#4142490, @erichkeane wrote:

Just deliberately not support a part of C++2b. Implementers have veto'ed features in the past exactly that way.

In D144334#4141646, @erichkeane wrote:

I'm on the fence as to whether we want to implement this feature at all. As was discussed extensively during the EWG meetings on this: multiple implementers are against this attribute for a variety of reasons, and at least 1 other implementer has stated they might 'implementer veto' this.

Use the common isInAnonymousNamespace matcher.

If you are not familiar with the [[assume(expr]] concept and want to know more, I wrote a small article about it recently, with a lot of additional links (including to the author of the proposal) - https://izaron.github.io/posts/assume/

More thorough AST test.

A small fix for def FutureAttrs

In D118743#3965423, @Lounarok wrote:

I tried this patch and it's really helpful!

You're welcome!

I'll take __builtin_fmax as an example (but other builtins are fairly similar to it).

Fix GCC tests - some of its functions are already constexpr

Add test for GCC. Thanks to @philnik!

Deal with MSVC where sizeof(long double) == sizeof(double)

Add test for min/max value. Fix comment for ilog.

Could you also add a test for GCC and the global namespace versions of the functions?

Does "test for GCC" mean testing how GCC would compile libc++?

Move to constexpr-cxx2b.pass.cpp, fixed issues. Thanks to @philnik!

A friendly ping 🙂

This patch is similar to __bultin_fmax: https://reviews.llvm.org/D134369

LGTM! I'm sorry that you had to fix CMakeLists.txt. It really "worked on my machine", I was running these commands:

In D136022#3877399, @dyung wrote:

Hi @Izaron, several of our internal tests that run tests using -ftime-trace started crashing when run which I bisected back to your change. I have filed issue #58551 for it, can you take a look?

Get rid of hexfloat, because hexfloat<long double> not working on test machines.

Get rid of C++ earlier that C++2b.
Get rid of GNU compiler.

This is a part of our work on implementing p0533r9:
https://discourse.llvm.org/t/how-do-we-plan-to-make-constexpr-cmath-and-cstdlib/65930

Mention this in the release notes. Thanks to Aaron for reviewing!

Fix optionals with value_or

Fix CMakeLists.txt

The test doesn't cover exactly all new traces though. For example I couldn't write a code that runs into the EvaluateAsInt method 🤔

In D136022#3861245, @jloser wrote:

I'd like to see some tests through before I approve.

Add time profiler test.

It looks like unrelated formatting changes snuck in to this file.

In D136036#3862065, @aaron.ballman wrote:

Can you also add documentation and a release note for the new feature testing macro?

Add more parsing tests. Fix unrelated formatting changes. Add release notes and docs.

Changed llvm_unreachable to just return false. I thought it is more secure.

Slightly changed the test.

A builtin is considered "constexpr" if it has E in its attributes in Builtins.def.

We can use this file as an example: ConstProfiler.cpp https://reviews.llvm.org/P8296
The code does a really big constant evaluation.

Change IgnoreVoidReturnType to RewriteVoidReturn type.
Check the cheaper condition first.

Removed excessive newline.

Rebased onto main (after a long long time).

Removed redundant comment

Hi! A friendly ping =)

Aligned slashes in defines

This is a mirror of my previous patch about builtin max. I promised to make the patch for builtin min =) Here: https://reviews.llvm.org/D134369#3806131

Thanks, will land the patch after Build 288902: pre-merge checks is passed =)

Follow 80 characters limit. Thanks to @Eugene.Zelenko!

In D134369#3843824, @efriedma wrote:

You might need to explicitly specify -std=c++17 in the RUN line. (That bot has a different target triple, and I think with that triple the default C++ standard isn't C++17?)

ASAP fix from previous review request, see comment: https://reviews.llvm.org/D134369#3843824

I've got an email about "Buildbot failure" with this link: https://lab.llvm.org/buildbot/#/builders/216/builds/10955

Line 51: 'static_assert' with no message is a C++17 extension

Why is it failing if pre-merge checks has been passed? =(

Add TODO comment about sNaN. Thanks to @jcranmer-intel!

Fixes https://github.com/llvm/llvm-project/issues/58230

Fix comment wording.