- User Since
- Jan 16 2022, 7:14 AM (98 w, 2 d)
Jul 1 2023
LGTM! Thank you for the fix!
Mar 19 2023
A big TODO: rename ext_c_label_end_of_compound_statement to something like ext_c_label_free_positioning. Since we found out it is more complete than just the end of statements.
Feb 21 2023
Feb 18 2023
Use the common isInAnonymousNamespace matcher.
If you are not familiar with the [[assume(expr]] concept and want to know more, I wrote a small article about it recently, with a lot of additional links (including to the author of the proposal) - https://izaron.github.io/posts/assume/
More thorough AST test.
A small fix for def FutureAttrs
Jan 1 2023
Nov 25 2022
I'll take __builtin_fmax as an example (but other builtins are fairly similar to it).
Oct 31 2022
Fix GCC tests - some of its functions are already constexpr
Oct 30 2022
Add test for GCC. Thanks to @philnik!
Oct 27 2022
Deal with MSVC where sizeof(long double) == sizeof(double)
Oct 26 2022
Add test for min/max value. Fix comment for ilog.
Oct 24 2022
Could you also add a test for GCC and the global namespace versions of the functions?
Does "test for GCC" mean testing how GCC would compile libc++?
Move to constexpr-cxx2b.pass.cpp, fixed issues. Thanks to @philnik!
A friendly ping 🙂
Oct 23 2022
This patch is similar to __bultin_fmax: https://reviews.llvm.org/D134369
LGTM! I'm sorry that you had to fix CMakeLists.txt. It really "worked on my machine", I was running these commands:
Oct 22 2022
Get rid of hexfloat, because hexfloat<long double> not working on test machines.
Get rid of C++ earlier that C++2b.
Get rid of GNU compiler.
This is a part of our work on implementing p0533r9:
Oct 21 2022
Mention this in the release notes. Thanks to Aaron for reviewing!
Oct 20 2022
Fix optionals with value_or
Oct 19 2022
The test doesn't cover exactly all new traces though. For example I couldn't write a code that runs into the EvaluateAsInt method 🤔
Add time profiler test.
Oct 17 2022
It looks like unrelated formatting changes snuck in to this file.
Add more parsing tests. Fix unrelated formatting changes. Add release notes and docs.
Oct 16 2022
Changed llvm_unreachable to just return false. I thought it is more secure.
Slightly changed the test.
A builtin is considered "constexpr" if it has E in its attributes in Builtins.def.
Oct 15 2022
We can use this file as an example: ConstProfiler.cpp https://reviews.llvm.org/P8296
The code does a really big constant evaluation.
Oct 13 2022
Change IgnoreVoidReturnType to RewriteVoidReturn type.
Check the cheaper condition first.
Oct 12 2022
Oct 10 2022
Removed excessive newline.
Rebased onto main (after a long long time).
Oct 8 2022
Removed redundant comment
Oct 7 2022
Hi! A friendly ping =)
Aligned slashes in defines
This is a mirror of my previous patch about builtin max. I promised to make the patch for builtin min =) Here: https://reviews.llvm.org/D134369#3806131
Thanks, will land the patch after Build 288902: pre-merge checks is passed =)
Follow 80 characters limit. Thanks to @Eugene.Zelenko!
ASAP fix from previous review request, see comment: https://reviews.llvm.org/D134369#3843824
I've got an email about "Buildbot failure" with this link: https://lab.llvm.org/buildbot/#/builders/216/builds/10955
Line 51: 'static_assert' with no message is a C++17 extension
Why is it failing if pre-merge checks has been passed? =(
Add TODO comment about sNaN. Thanks to @jcranmer-intel!