Page MenuHomePhabricator

[mlir][NFC] Use structured binding declaration.
Needs RevisionPublic

Authored by jacquesguan on Sep 22 2022, 7:42 PM.

Details

Summary

This patch tries to use structured binding declaration to replace outside decleration.

Event Timeline

jacquesguan created this revision.Sep 22 2022, 7:42 PM
jacquesguan requested review of this revision.Sep 22 2022, 7:42 PM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Mogball requested changes to this revision.Sep 22 2022, 8:13 PM
Mogball added inline comments.
mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
459

This was discussed in a similar patch, but I was brought up was that this isn't necessarily more readable. The types were previously explicit, now they're not.

This is only unambiguously better in cases where the types were not already explicit.

This revision now requires changes to proceed.Sep 22 2022, 8:13 PM