This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Use tbl for truncating vector FPtoUI conversions.
ClosedPublic

Authored by fhahn on Sep 8 2022, 7:58 AM.

Details

Summary

On AArch64, doing the vector truncate separately after the fptoui
conversion can be lowered more efficiently using tbl.4, building on
D133495.

https://alive2.llvm.org/ce/z/T538CC

Depends on D133495

Diff Detail

Event Timeline

fhahn created this revision.Sep 8 2022, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2022, 7:58 AM
fhahn requested review of this revision.Sep 8 2022, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2022, 7:58 AM
t.p.northover accepted this revision.Sep 15 2022, 2:19 AM

One simplification, but otherwise seems OK.

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
13302

VectorType::getInteger(DstTy) is slightly simpler.

This revision is now accepted and ready to land.Sep 15 2022, 2:19 AM
fhahn updated this revision to Diff 460427.Sep 15 2022, 8:41 AM

Thanks Tim, updated to use VectorType::getInteger.

fhahn marked an inline comment as done.Sep 15 2022, 8:42 AM
fhahn added inline comments.
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
13302

Thanks, I didn't know about this helpful utility! Updated to use VectorType::getInteger(SrcTy).

t.p.northover accepted this revision.Sep 16 2022, 1:26 AM

Thanks, looks good.

This revision was landed with ongoing or failed builds.Sep 16 2022, 6:58 AM
This revision was automatically updated to reflect the committed changes.
fhahn marked an inline comment as done.