This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Switch lit tests to %mlir_lib_dir and %mlir_src_dir replacements.
ClosedPublic

Authored by csigg on Sep 4 2022, 1:48 AM.

Details

Summary

The old replacements will be removed soon:

  • %linalg_test_lib_dir
  • %cuda_wrapper_library_dir
  • %spirv_wrapper_library_dir
  • %vulkan_wrapper_library_dir
  • %mlir_runner_utils_dir
  • %mlir_integration_test_dir

Diff Detail

Event Timeline

csigg created this revision.Sep 4 2022, 1:48 AM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
csigg requested review of this revision.Sep 4 2022, 1:48 AM
csigg updated this revision to Diff 457847.Sep 4 2022, 2:56 AM

Remove libmlir_test_spirv_cpu_runner_c_wrappers.so bazel target for now.

The corresponding test package will be added later.

csigg updated this revision to Diff 457848.Sep 4 2022, 4:03 AM

Tag cuda-dependent targets with 'manual'.

herhut added a comment.Sep 5 2022, 1:38 AM

+1 for the direction. Just a bazil question.

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
6485

Why are these aliases needed?

csigg added inline comments.Sep 5 2022, 3:36 AM
utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
6485

They are needed because the shared library name (lib<name>.so) of the cc_library target would otherwise clash with the cc_binary target below.

I will add a comment explaining this.

csigg updated this revision to Diff 457998.Sep 5 2022, 7:43 AM

Add comments why alias are needed.

herhut accepted this revision.Sep 6 2022, 1:02 AM

Thanks for the explanation. My bazil-foo is not as strong as yours.

This revision is now accepted and ready to land.Sep 6 2022, 1:02 AM