Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D131778

[DAGCombine] Replace std::monostate equivalent in DAGCombiner.cpp
ClosedPublic
Actions

Authored by jloser on Aug 12 2022, 7:28 AM.

Tags

Subscribers

Details

Reviewers

niravd
david-arm
craig.topper

Commits

rGb12aa497cdc1: [DAGCombine] Replace std::monostate equivalent in DAGCombiner.cpp

Summary

Remove the UnitT type and operators in favor of using std::monostate
directly.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jloser created this revision.Aug 12 2022, 7:28 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2022, 7:28 AM

Herald added subscribers: StephenFan, ecnelises, hiraditya. · View Herald Transcript

jloser requested review of this revision.Aug 12 2022, 7:28 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2022, 7:28 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B180913: Diff 452179.Aug 12 2022, 8:20 AM

LGTM

This revision is now accepted and ready to land.Aug 12 2022, 9:47 AM

Run git-clang-format HEAD~1. If CI passes, I'll land this.

Harbormaster completed remote builds in B180971: Diff 452264.Aug 12 2022, 12:14 PM

Fix reference to Unit. Use std::monostate{} instead.

Harbormaster completed remote builds in B180997: Diff 452301.Aug 12 2022, 3:24 PM

Fix another use of Unit in favor of std::monostate{}.

Harbormaster completed remote builds in B181015: Diff 452323.Aug 12 2022, 4:58 PM

Closed by commit rGb12aa497cdc1: [DAGCombine] Replace std::monostate equivalent in DAGCombiner.cpp (authored by • joe_loser). · Explain WhyAug 12 2022, 8:43 PM

This revision was automatically updated to reflect the committed changes.

• joe_loser added a commit: rGb12aa497cdc1: [DAGCombine] Replace std::monostate equivalent in DAGCombiner.cpp.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

CodeGen/

SelectionDAG/

DAGCombiner.cpp

17 lines

Diff 452368

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Loading...