Page MenuHomePhabricator

niravd (Nirav Dave)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 1:58 PM (169 w, 1 d)

Recent Activity

Today

niravd committed rG1ce977f94676: Add test case. (authored by niravd).
Add test case.
Wed, Feb 20, 11:08 AM
niravd committed rL354504: Add test case..
Add test case.
Wed, Feb 20, 11:08 AM

Yesterday

niravd accepted D58053: [X86][AVX] EltsFromConsecutiveLoads - Add BROADCAST lowering support.

LGTM.

Tue, Feb 19, 7:15 AM · Restricted Project

Sat, Feb 16

niravd committed rG91ecb69acdf4: [X86] Prevent clang clobber checking for asm flag constraints. (authored by niravd).
[X86] Prevent clang clobber checking for asm flag constraints.
Sat, Feb 16, 7:53 PM
niravd committed rL354211: [X86] Prevent clang clobber checking for asm flag constraints..
[X86] Prevent clang clobber checking for asm flag constraints.
Sat, Feb 16, 7:53 PM
niravd committed rC354211: [X86] Prevent clang clobber checking for asm flag constraints..
[X86] Prevent clang clobber checking for asm flag constraints.
Sat, Feb 16, 7:52 PM

Fri, Feb 15

niravd committed rG78758411217c: [X86] Fix LowerAsmOutputForConstraint. (authored by niravd).
[X86] Fix LowerAsmOutputForConstraint.
Fri, Feb 15, 12:04 PM
niravd committed rL354163: [X86] Fix LowerAsmOutputForConstraint..
[X86] Fix LowerAsmOutputForConstraint.
Fri, Feb 15, 12:03 PM
niravd closed D58283: [X86] Fix LowerAsmOutputForConstraint..
Fri, Feb 15, 12:03 PM · Restricted Project
niravd created D58283: [X86] Fix LowerAsmOutputForConstraint..
Fri, Feb 15, 7:22 AM · Restricted Project

Thu, Feb 14

niravd updated the diff for D49691: [DAGCombine] Allow alias analysis with inline asm calls and GluedNodes..

Rebase, improve comments and minor name cleanup.

Thu, Feb 14, 1:35 PM · Restricted Project
niravd committed rG90868bb0584f: [X86] Add clang support for X86 flag output parameters. (authored by niravd).
[X86] Add clang support for X86 flag output parameters.
Thu, Feb 14, 11:28 AM
niravd committed rC354053: [X86] Add clang support for X86 flag output parameters..
[X86] Add clang support for X86 flag output parameters.
Thu, Feb 14, 11:28 AM
niravd committed rL354053: [X86] Add clang support for X86 flag output parameters..
[X86] Add clang support for X86 flag output parameters.
Thu, Feb 14, 11:28 AM
niravd closed D57394: [X86] Add clang support for X86 flag output parameters..
Thu, Feb 14, 11:28 AM · Restricted Project
niravd committed rG5ffdc43dc9bc: [X86] cleanup inline asm register generation. NFCI. (authored by niravd).
[X86] cleanup inline asm register generation. NFCI.
Thu, Feb 14, 10:12 AM
niravd committed rL354042: [X86] cleanup inline asm register generation. NFCI..
[X86] cleanup inline asm register generation. NFCI.
Thu, Feb 14, 10:05 AM

Wed, Feb 13

Herald added a project to D57394: [X86] Add clang support for X86 flag output parameters.: Restricted Project.

Ping.

Wed, Feb 13, 10:35 AM · Restricted Project

Mon, Feb 11

niravd created D58070: [DAG] Remember nodes added to the worklist for pruning..
Mon, Feb 11, 12:55 PM · Restricted Project
niravd created D58068: [DAG] Avoid smart constructor-based dangling nodes..
Mon, Feb 11, 12:29 PM · Restricted Project

Fri, Feb 8

niravd committed rG97011ccce085: Revert r353416 "[DAG] Cleanup unused nodes on failed store-to-load forward… (authored by niravd).
Revert r353416 "[DAG] Cleanup unused nodes on failed store-to-load forward…
Fri, Feb 8, 7:23 AM
niravd committed rL353527: Revert r353416 "[DAG] Cleanup unused nodes on failed store-to-load forward….
Revert r353416 "[DAG] Cleanup unused nodes on failed store-to-load forward…
Fri, Feb 8, 7:23 AM

Thu, Feb 7

niravd created D57921: [DAG] Cleanup unused node in SimplifySelectCC..
Thu, Feb 7, 1:12 PM · Restricted Project
niravd committed rG9332fc2e1919: Revert "[DAG] Cleanup of unused node in SimplifySelectCC." (authored by niravd).
Revert "[DAG] Cleanup of unused node in SimplifySelectCC."
Thu, Feb 7, 10:31 AM
niravd committed rL353442: Revert "[DAG] Cleanup of unused node in SimplifySelectCC.".
Revert "[DAG] Cleanup of unused node in SimplifySelectCC."
Thu, Feb 7, 10:31 AM
niravd committed rG24e60819f6bb: [DAG] Cleanup of unused node in SimplifySelectCC. (authored by niravd).
[DAG] Cleanup of unused node in SimplifySelectCC.
Thu, Feb 7, 9:14 AM
niravd committed rL353428: [DAG] Cleanup of unused node in SimplifySelectCC..
[DAG] Cleanup of unused node in SimplifySelectCC.
Thu, Feb 7, 9:13 AM
niravd committed rG4b12236f7d7c: [DAG] Cleanup unused node on failed SELECT Combine. (authored by niravd).
[DAG] Cleanup unused node on failed SELECT Combine.
Thu, Feb 7, 8:58 AM
niravd committed rL353426: [DAG] Cleanup unused node on failed SELECT Combine..
[DAG] Cleanup unused node on failed SELECT Combine.
Thu, Feb 7, 8:57 AM
niravd committed rG84e5bf0c9519: [X86] Simplify casing. NFC. (authored by niravd).
[X86] Simplify casing. NFC.
Thu, Feb 7, 7:45 AM
niravd committed rL353417: [X86] Simplify casing. NFC..
[X86] Simplify casing. NFC.
Thu, Feb 7, 7:45 AM
niravd committed rG724b81087d72: [DAG] Cleanup unused nodes on failed store-to-load forward combine. (authored by niravd).
[DAG] Cleanup unused nodes on failed store-to-load forward combine.
Thu, Feb 7, 7:39 AM
niravd committed rL353416: [DAG] Cleanup unused nodes on failed store-to-load forward combine..
[DAG] Cleanup unused nodes on failed store-to-load forward combine.
Thu, Feb 7, 7:38 AM
niravd accepted D57541: [DAGCombiner] Eliminate dead stores to stack..

LGTM, modulo potentially excising the hasOneUse as I've suggested provided you agree with my line of reasoning there.

Thu, Feb 7, 7:06 AM · Restricted Project

Wed, Feb 6

niravd committed rGb3506bf9851a: [DAG] Immediately cleanup unused nodes from extend-based combines. (authored by niravd).
[DAG] Immediately cleanup unused nodes from extend-based combines.
Wed, Feb 6, 12:12 PM
niravd committed rL353338: [DAG] Immediately cleanup unused nodes from extend-based combines..
[DAG] Immediately cleanup unused nodes from extend-based combines.
Wed, Feb 6, 12:11 PM
niravd committed rGc6bfa103a56b: [X86][DAG] Avoid creating dangling bitcast. (authored by niravd).
[X86][DAG] Avoid creating dangling bitcast.
Wed, Feb 6, 11:47 AM
niravd committed rL353333: [X86][DAG] Avoid creating dangling bitcast..
[X86][DAG] Avoid creating dangling bitcast.
Wed, Feb 6, 11:45 AM
niravd closed D57393: [InlineAsm][X86] Add backend support for X86 flag output parameters..

Landed in r353307.

Wed, Feb 6, 10:51 AM · Restricted Project
niravd added inline comments to D57541: [DAGCombiner] Eliminate dead stores to stack..
Wed, Feb 6, 10:48 AM · Restricted Project
niravd committed rGe5c37958f901: [InlineAsm][X86] Add backend support for X86 flag output parameters. (authored by niravd).
[InlineAsm][X86] Add backend support for X86 flag output parameters.
Wed, Feb 6, 7:27 AM
niravd committed rL353307: [InlineAsm][X86] Add backend support for X86 flag output parameters..
[InlineAsm][X86] Add backend support for X86 flag output parameters.
Wed, Feb 6, 7:26 AM
niravd committed rG54511076d428: [SelectionDAGBuilder] Refactor Inline Asm output check. NFCI. (authored by niravd).
[SelectionDAGBuilder] Refactor Inline Asm output check. NFCI.
Wed, Feb 6, 7:14 AM
niravd committed rL353305: [SelectionDAGBuilder] Refactor Inline Asm output check. NFCI..
[SelectionDAGBuilder] Refactor Inline Asm output check. NFCI.
Wed, Feb 6, 7:12 AM

Tue, Feb 5

niravd added a comment to D57367: [DAGCombine] Do several rounds of combine for nodes using SimplifyDemandedBits..

I've been looking at this closely and it's descending in a chain of cleanups, after which I'm hoping we can do this in a more complete way.

Tue, Feb 5, 7:59 AM · Restricted Project
niravd added a comment to D57541: [DAGCombiner] Eliminate dead stores to stack..

Also, you'll need to deal with the additional output from indexed stores.

I think I'm fine because of the hasOneUse() check. I'm not sure how I should test this though, do you have a suggestion for some test IR for an indexed store ?

Tue, Feb 5, 7:30 AM · Restricted Project

Mon, Feb 4

niravd updated the diff for D57393: [InlineAsm][X86] Add backend support for X86 flag output parameters..

Actually do FileCheck and improve comments.

Mon, Feb 4, 1:48 PM · Restricted Project
niravd accepted D57692: [DAG] BaseIndexOffset: FrameIndexSDNodes with the same FrameIndex compare equal..

I'm pretty sure they must be equivalent. I'm not sure if we can generate such a pattern, but the possiblity seems justification enough. Thanks.

Mon, Feb 4, 12:51 PM · Restricted Project
niravd requested changes to D57692: [DAG] BaseIndexOffset: FrameIndexSDNodes with the same FrameIndex compare equal..

Do we have a case where this changes things? because it looks like it should be already handled by the trivial Base == Other.Base check.

Mon, Feb 4, 9:39 AM · Restricted Project
niravd accepted D57692: [DAG] BaseIndexOffset: FrameIndexSDNodes with the same FrameIndex compare equal..

LGTM. Nice catch.

Mon, Feb 4, 8:48 AM · Restricted Project

Fri, Feb 1

niravd added a comment to D57541: [DAGCombiner] Eliminate dead stores to stack..

I just realized that there is nothing that guarantees that an alloca's lifetime is ended in one go, so I'll also have to check that the store is within the lifetime.end base and size.

Fri, Feb 1, 7:19 AM · Restricted Project

Thu, Jan 31

niravd created D57534: [DAG][ARM] Define upwrapAddress for ARM backend..
Thu, Jan 31, 12:04 PM
niravd committed rL352786: [DAG][SystemZ] Define unwrapAddress for PCREL_WRAPPER..
[DAG][SystemZ] Define unwrapAddress for PCREL_WRAPPER.
Thu, Jan 31, 11:58 AM
niravd closed D57407: [DAG][SystemZ] Define unwrapAddress for PCREL_WRAPPER..
Thu, Jan 31, 11:58 AM
niravd committed rL352784: [DAG] Aggressively cleanup dangling node in CombineZExtLogicopShiftLoad..
[DAG] Aggressively cleanup dangling node in CombineZExtLogicopShiftLoad.
Thu, Jan 31, 11:35 AM
niravd closed D57520: [DAG] Aggressively cleanup dangling node in CombineZExtLogicopShiftLoad..
Thu, Jan 31, 11:35 AM
niravd added a comment to D57520: [DAG] Aggressively cleanup dangling node in CombineZExtLogicopShiftLoad..

Hmm , weird. I've been looking at reasons why D57367 is doing so much when I found the case generating dangling node. I _was_ a bit surprised that this causes that regression, but it must be the case that dangling nodes persist to ISel and prevent folding. Presumably your change allowed CombineZExtLogicOpShiftLoad to trigger.

Thu, Jan 31, 11:17 AM
niravd created D57520: [DAG] Aggressively cleanup dangling node in CombineZExtLogicopShiftLoad..
Thu, Jan 31, 9:18 AM

Tue, Jan 29

niravd created D57407: [DAG][SystemZ] Define unwrapAddress for PCREL_WRAPPER..
Tue, Jan 29, 12:10 PM
niravd retitled D57393: [InlineAsm][X86] Add backend support for X86 flag output parameters. from [SelectionDAGBuilder] Refactor Inline Asm output check. NFCI. to [InlineAsm][X86] Add backend support for X86 flag output parameters..
Tue, Jan 29, 9:36 AM · Restricted Project
niravd added a child revision for D57393: [InlineAsm][X86] Add backend support for X86 flag output parameters.: D57394: [X86] Add clang support for X86 flag output parameters..
Tue, Jan 29, 9:36 AM · Restricted Project
niravd added a parent revision for D57394: [X86] Add clang support for X86 flag output parameters.: D57393: [InlineAsm][X86] Add backend support for X86 flag output parameters..
Tue, Jan 29, 9:36 AM · Restricted Project
niravd created D57394: [X86] Add clang support for X86 flag output parameters..
Tue, Jan 29, 9:35 AM · Restricted Project
niravd created D57393: [InlineAsm][X86] Add backend support for X86 flag output parameters..
Tue, Jan 29, 9:32 AM · Restricted Project
niravd committed rL352506: [SelectionDAGBuilder] Remove redundant variable. NFCI..
[SelectionDAGBuilder] Remove redundant variable. NFCI.
Tue, Jan 29, 7:14 AM

Mon, Jan 28

niravd added a comment to D33587: [DAGCombine] Do several rounds of combine..

My concern about this that DAGCombine is a relatively expensive and doing it 3 times will make a nontrivial difference in large vector compute blocks. At the very minimum we'd want to disable the most expensive merge operations for most of the passes (store merge and maybe some vector combines).

Mon, Jan 28, 7:58 AM · Restricted Project

Thu, Jan 24

niravd committed rL352067: [SelectionDAGBuilder] Simplify HasSideEffect calculation. NFC..
[SelectionDAGBuilder] Simplify HasSideEffect calculation. NFC.
Thu, Jan 24, 9:57 AM
niravd committed rL352066: [InlineAsm] Don't calculate registers for inline asm memory operands. NFCI..
[InlineAsm] Don't calculate registers for inline asm memory operands. NFCI.
Thu, Jan 24, 9:48 AM
niravd committed rL352053: [SelectionDAGBuilder] Fuse inline asm input operand loops passes. NFCI..
[SelectionDAGBuilder] Fuse inline asm input operand loops passes. NFCI.
Thu, Jan 24, 7:15 AM
niravd committed rL352051: [X86] Add missing isReg() guards in FixupSetCCs pass..
[X86] Add missing isReg() guards in FixupSetCCs pass.
Thu, Jan 24, 7:05 AM

Tue, Jan 22

niravd committed rL351854: [SelectionDAGBuilder] Defer C_Register Assignments to be in line with.
[SelectionDAGBuilder] Defer C_Register Assignments to be in line with
Tue, Jan 22, 11:01 AM

Jan 18 2019

niravd committed rL351561: Revert "Clang side support for @cc assembly operands.".
Revert "Clang side support for @cc assembly operands."
Jan 18 2019, 8:07 AM
niravd committed rC351561: Revert "Clang side support for @cc assembly operands.".
Revert "Clang side support for @cc assembly operands."
Jan 18 2019, 8:07 AM
niravd committed rL351559: Clang side support for @cc assembly operands..
Clang side support for @cc assembly operands.
Jan 18 2019, 8:01 AM
niravd committed rC351559: Clang side support for @cc assembly operands..
Clang side support for @cc assembly operands.
Jan 18 2019, 8:01 AM
niravd committed rL351558: [SelectionDAGBuilder] Cleanup InlineAsm Output generation. NFCI..
[SelectionDAGBuilder] Cleanup InlineAsm Output generation. NFCI.
Jan 18 2019, 8:01 AM

Jan 15 2019

niravd committed rL351207: [SelectionDAG] Check membership of register in class for single.
[SelectionDAG] Check membership of register in class for single
Jan 15 2019, 9:13 AM
niravd committed rL351206: [X86] Fix register class for assembly constraints to ST(7). NFCI..
[X86] Fix register class for assembly constraints to ST(7). NFCI.
Jan 15 2019, 9:13 AM

Jan 14 2019

niravd accepted D56559: [opaque pointer types] Update GetElementPtr creation APIs to consistently accept a pointee-type argument..

LGTM

Jan 14 2019, 12:10 PM
niravd accepted D56558: [opaque pointer types] Update LoadInst creation APIs to consistently accept a return-type argument..

LGTM

Jan 14 2019, 12:10 PM
niravd accepted D56557: [opaque pointer types] Update InvokeInst creation APIs to consistently accept a callee-type argument..

LGTM.

Jan 14 2019, 12:10 PM
niravd accepted D56556: [opaque pointer types] Update CallInst creation APIs to consistently accept a callee-type argument..

LGTM

Jan 14 2019, 12:10 PM
niravd committed rL351094: [MC][X86] Add test case for invalid use of "(%dx)" operand..
[MC][X86] Add test case for invalid use of "(%dx)" operand.
Jan 14 2019, 10:48 AM
niravd committed rL351074: Reland "Refactor GetRegistersForValue. NFCI.".
Reland "Refactor GetRegistersForValue. NFCI."
Jan 14 2019, 9:13 AM

Jan 11 2019

niravd committed rL350966: [X86] Fix incomplete handling of register-assigned variables in parsing..
[X86] Fix incomplete handling of register-assigned variables in parsing.
Jan 11 2019, 12:21 PM
niravd closed D56287: [X86] Fix incomplete handling of register-assigned variables in parsing..
Jan 11 2019, 12:21 PM
niravd accepted D56573: Remove TypeBuilder.h, and fix the few locations using it..

LGTM.

Jan 11 2019, 12:13 PM

Jan 10 2019

niravd committed rL350841: [SelectionDAGBuilder] Refactor GetRegistersForValue. NFCI..
[SelectionDAGBuilder] Refactor GetRegistersForValue. NFCI.
Jan 10 2019, 8:29 AM
niravd committed rL350839: [SelectionDAGBuilder] Fix formatting. NFC..
[SelectionDAGBuilder] Fix formatting. NFC.
Jan 10 2019, 8:27 AM
niravd committed rL350837: [SelectionDAGBuilder] Refactor visitInlineAsm. NFC..
[SelectionDAGBuilder] Refactor visitInlineAsm. NFC.
Jan 10 2019, 8:22 AM

Jan 8 2019

niravd added inline comments to D56287: [X86] Fix incomplete handling of register-assigned variables in parsing..
Jan 8 2019, 11:19 AM
niravd updated the diff for D56287: [X86] Fix incomplete handling of register-assigned variables in parsing..

Add error tests and do minor reorganization to parseExpression to existant extra invalid token errors.

Jan 8 2019, 11:19 AM

Jan 4 2019

niravd committed rL350406: Undo r350355 "[X86] Remove terrible DX Register parsing hack in parse operand..
Undo r350355 "[X86] Remove terrible DX Register parsing hack in parse operand.
Jan 4 2019, 9:15 AM

Jan 3 2019

niravd updated the diff for D56287: [X86] Fix incomplete handling of register-assigned variables in parsing..

Rebase after unifying (%dx) fixup hack in parseinstruction.

Jan 3 2019, 1:53 PM
niravd committed rL350355: [X86] Remove terrible DX Register parsing hack in parse operand. NFCI..
[X86] Remove terrible DX Register parsing hack in parse operand. NFCI.
Jan 3 2019, 1:50 PM
niravd committed rL350353: [AVR] Update integration/blink.ll as we now generate sbi/cbi instructions..
[AVR] Update integration/blink.ll as we now generate sbi/cbi instructions.
Jan 3 2019, 1:29 PM
niravd created D56287: [X86] Fix incomplete handling of register-assigned variables in parsing..
Jan 3 2019, 12:10 PM

Dec 10 2018

niravd accepted D55511: [TargetLowering] Add UNDEF folding to SimplifyDemandedVectorElts.

LGTM. Removing the insert_subvector nesting transform is especially nice. I think it's fine to go in as is even before the zero forwarding, but I'll defer to others.

Dec 10 2018, 9:55 AM

Dec 4 2018

niravd committed rL348304: [AVR] Silence fallthrough warning. NFC..
[AVR] Silence fallthrough warning. NFC.
Dec 4 2018, 1:44 PM
niravd committed rL348288: [SelectionDAG] Redefine isGAPlusOffset in terms of unwrapAddress. NFCI..
[SelectionDAG] Redefine isGAPlusOffset in terms of unwrapAddress. NFCI.
Dec 4 2018, 10:02 AM