This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
buildbot/osuosl/master/config/
-
osuosl/
-
master/
-
config/
1/2
builders.py

Differential D131697

[clang-ppc64-aix] Switch build compiler to clang
ClosedPublic

Authored by Jake-Egan on Aug 11 2022, 10:32 AM.

Download Raw Diff

Details

Reviewers

gkistanova
hubert.reinterpretcast
daltenty

Commits

rZORGc07753f737a6: [clang-ppc64-aix] Switch build compiler to clang

Summary

When LLVM updated the C++ standards to 17, the AIX bot encountered multiple related build issues because ibm-clang doesn't currently have a release to support C++17. So, this patch switches the build compiler for AIX from ibm-clang to clang as a step to mitigate that.

Diff Detail

Repository

rZORG LLVM Github Zorg

Build Status

Buildable 180715
Build 272122: arc lint + arc unit

Event Timeline

Jake-Egan created this revision.Aug 11 2022, 10:32 AM

Herald added a reviewer: gkistanova. · View Herald TranscriptAug 11 2022, 10:32 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added a subscriber: shchenz. · View Herald Transcript

Jake-Egan requested review of this revision.Aug 11 2022, 10:32 AM

Harbormaster completed remote builds in B180715: Diff 451905.Aug 11 2022, 10:32 AM

Jake-Egan edited the summary of this revision. (Show Details)Aug 11 2022, 10:41 AM

Jake-Egan added reviewers: hubert.reinterpretcast, daltenty.

daltenty added inline comments.Aug 11 2022, 11:08 AM

buildbot/osuosl/master/config/builders.py
711	Maybe it's better to not include the specific release candidate in the path here? That will give more flexibility to update to the final release once it's available without necessitating yet another change.

Removed release candidate from path.

Herald added a reviewer: bollu. · View Herald TranscriptAug 11 2022, 12:00 PM

Herald added a reviewer: jdoerfert. · View Herald Transcript

Herald added a reviewer: sscalpone. · View Herald Transcript

Herald added subscribers: bzcheeseman, sdasgup3, abrachet and 31 others. · View Herald Transcript

Harbormaster completed remote builds in B180743: Diff 451941.Aug 11 2022, 12:00 PM

[clang-ppc64-aix] Switch build compiler to clang

Harbormaster completed remote builds in B180745: Diff 451942.Aug 11 2022, 12:03 PM

Hopefully fix bad arc diff.

Harbormaster completed remote builds in B180746: Diff 451943.Aug 11 2022, 12:05 PM

Jake-Egan marked an inline comment as done.Aug 11 2022, 12:05 PM

Jake-Egan removed reviewers: bollu, jdoerfert, sscalpone.Aug 11 2022, 12:08 PM

hubert.reinterpretcast added inline comments.Aug 11 2022, 12:09 PM

buildbot/osuosl/master/config/builders.py
711–712	Can we check the installation path conventions for AIX deployments? I would think this is `/usr/local` territory.

Jake-Egan removed subscribers: mgorny, hiraditya, javed.absar and 31 others.Aug 11 2022, 12:10 PM

Change path to /usr/local/.

Harbormaster completed remote builds in B180764: Diff 451965.Aug 11 2022, 1:29 PM

LGTM; thanks!

This revision is now accepted and ready to land.Aug 11 2022, 1:44 PM

Closed by commit rZORGc07753f737a6: [clang-ppc64-aix] Switch build compiler to clang (authored by Jake-Egan). · Explain WhyAug 12 2022, 6:32 AM

This revision was automatically updated to reflect the committed changes.

Jake-Egan added a commit: rZORGc07753f737a6: [clang-ppc64-aix] Switch build compiler to clang.

Revision Contents

Path

Size

buildbot/

osuosl/

master/

config/

4 lines

Diff 451905

buildbot/osuosl/master/config/builders.py

	Show First 20 Lines • Show All 702 Lines • ▼ Show 20 Lines		# Clang builders.
	'workernames' : ["aix-ppc64"],			'workernames' : ["aix-ppc64"],
	'builddir': "clang-ppc64-aix",			'builddir': "clang-ppc64-aix",
	'factory' : TestSuiteBuilder.getTestSuiteBuildFactory(			'factory' : TestSuiteBuilder.getTestSuiteBuildFactory(
	depends_on_projects=["llvm", "clang", "compiler-rt"],			depends_on_projects=["llvm", "clang", "compiler-rt"],
	enable_runtimes="auto",			enable_runtimes="auto",
	clean=False,			clean=False,
	extra_configure_args=[			extra_configure_args=[
	"-DLLVM_ENABLE_ASSERTIONS=On",			"-DLLVM_ENABLE_ASSERTIONS=On",
	"-DCMAKE_C_COMPILER=/opt/IBM/openxlC/17.1.0/bin/ibm-clang",			"-DCMAKE_C_COMPILER=/opt/clang/clang-15.0.0-rc1/bin/clang",
				daltentyUnsubmitted Done Reply Inline Actions Maybe it's better to not include the specific release candidate in the path here? That will give more flexibility to update to the final release once it's available without necessitating yet another change. daltenty: Maybe it's better to not include the specific release candidate in the path here? That will…
	"-DCMAKE_CXX_COMPILER=/opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r",			"-DCMAKE_CXX_COMPILER=/opt/clang/clang-15.0.0-rc1/bin/clang++",
				hubert.reinterpretcastUnsubmitted Not Done Reply Inline Actions Can we check the installation path conventions for AIX deployments? I would think this is `/usr/local` territory. hubert.reinterpretcast: Can we check the installation path conventions for AIX deployments? I would think this is…
	"-DPython3_EXECUTABLE:FILEPATH=/opt/freeware/bin/python3_64",			"-DPython3_EXECUTABLE:FILEPATH=/opt/freeware/bin/python3_64",
	"-DLLVM_ENABLE_ZLIB=OFF", "-DLLVM_APPEND_VC_REV=OFF",			"-DLLVM_ENABLE_ZLIB=OFF", "-DLLVM_APPEND_VC_REV=OFF",
	"-DLLVM_PARALLEL_LINK_JOBS=2",			"-DLLVM_PARALLEL_LINK_JOBS=2",
	"-DLLVM_ENABLE_WERROR=ON"]),			"-DLLVM_ENABLE_WERROR=ON"]),
	'env' : {'OBJECT_MODE': '64'}},			'env' : {'OBJECT_MODE': '64'}},

	{'name' : "clang-s390x-linux",			{'name' : "clang-s390x-linux",
	'tags' : ["clang"],			'tags' : ["clang"],
	▲ Show 20 Lines • Show All 1,910 Lines • Show Last 20 Lines