This is an archive of the discontinued LLVM Phabricator instance.

[InstrProf][attempt 2] Add new format for -fprofile-list=
ClosedPublic

Authored by ellis on Aug 4 2022, 12:48 PM.

Details

Summary

In D130807 we added the skipprofile attribute. This commit
changes the format so we can either forbid or skip profiling
functions by adding the noprofile or skipprofile attributes,
respectively. The behavior of the original format remains
unchanged.

Also, add the skipprofile attribute when using
-fprofile-function-groups.

This was originally landed as https://reviews.llvm.org/D130808 but was
reverted due to a Windows test failure.

Diff Detail

Event Timeline

ellis created this revision.Aug 4 2022, 12:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2022, 12:48 PM
ellis published this revision for review.Aug 4 2022, 12:49 PM
ellis added reviewers: phosek, davidxl, thakis.
ellis added inline comments.
clang/test/CodeGen/profile-filter-new.c
14

I think the Windows test from D130808 broke because this sed command was interacting badly with newlines. Using multiple echo commands seems to work.

Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2022, 12:51 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Aug 4 2022, 5:13 PM
This revision was automatically updated to reflect the committed changes.