This is an archive of the discontinued LLVM Phabricator instance.

[InstrProf] Add new format for -fprofile-list=
ClosedPublic

Authored by ellis on Jul 29 2022, 4:39 PM.

Details

Summary

In D130807 we added the skipprofile attribute. This commit
changes the format so we can either forbid or skip profiling
functions by adding the noprofile or skipprofile attributes,
respectively. The behavior of the original format remains
unchanged.

Also, add the skipprofile attribute when using
-fprofile-function-groups.

Diff Detail

Event Timeline

ellis created this revision.Jul 29 2022, 4:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2022, 4:39 PM
ellis edited the summary of this revision. (Show Details)Jul 29 2022, 4:48 PM
ellis added a reviewer: phosek.
ellis edited the summary of this revision. (Show Details)
ellis published this revision for review.Jul 29 2022, 4:53 PM
ellis added a reviewer: davidxl.
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2022, 4:53 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ellis updated this revision to Diff 449469.Aug 2 2022, 4:00 PM

Rebase and rename omitprofile => skipprofile.

ellis edited the summary of this revision. (Show Details)Aug 2 2022, 4:01 PM
phosek accepted this revision.Aug 3 2022, 12:56 AM

LGTM

clang/include/clang/Basic/ProfileList.h
31–38

It's more common in LLVM to use capitalized names for enum values, see https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly

This revision is now accepted and ready to land.Aug 3 2022, 12:56 AM
ellis updated this revision to Diff 449994.Aug 4 2022, 8:35 AM

Fix case.

This revision was landed with ongoing or failed builds.Aug 4 2022, 8:49 AM
This revision was automatically updated to reflect the committed changes.
thakis added a subscriber: thakis.Aug 4 2022, 9:24 AM

Looks like this might break tests on windows: http://45.33.8.238/win/63804/step_7.txt

Please take a look and revert for now if it takes a while to fix.

ellis added a comment.Aug 4 2022, 10:28 AM

Thanks for reverting. I'm looking into it.