This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Precommit test for D130251
ClosedPublic

Authored by pcwang-thead on Jul 21 2022, 4:50 AM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 4:50 AM
pcwang-thead requested review of this revision.Jul 21 2022, 4:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 4:50 AM
RKSimon accepted this revision.Jul 21 2022, 6:18 AM

LGTM with one minor about test names (sorry I just find it difficult to keep test files 'tidy' with names like test1 ... test2 ... test_3 etc.).

llvm/test/CodeGen/RISCV/rotl-rotr.ll
325

for test names - its better to use real numbers based off the mask instead of just iterating the test#

so maybe rotl_32_mask_63_mask_31 ?

This revision is now accepted and ready to land.Jul 21 2022, 6:18 AM

Add tests which use or instruction but won't modify the masked bits.

Rename functions.

This revision was landed with ongoing or failed builds.Jul 26 2022, 6:09 AM
This revision was automatically updated to reflect the committed changes.
RKSimon added inline comments.Jul 21 2023, 6:56 AM
llvm/test/CodeGen/RISCV/rotl-rotr.ll
402

@craig.topper @pcwang-thead You might want to review theses tests as the out of bounds shifts means they generate poison (which is exploited by rGae60706da07a128) - maybe use fshl/fshr intrinsics?

evandro removed a subscriber: evandro.Jul 21 2023, 3:51 PM