Details
Details
- Reviewers
craig.topper RKSimon - Commits
- rG10a7c5b79823: [RISCV] Precommit test for D130251
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM with one minor about test names (sorry I just find it difficult to keep test files 'tidy' with names like test1 ... test2 ... test_3 etc.).
llvm/test/CodeGen/RISCV/rotl-rotr.ll | ||
---|---|---|
325 | for test names - its better to use real numbers based off the mask instead of just iterating the test# so maybe rotl_32_mask_63_mask_31 ? |
llvm/test/CodeGen/RISCV/rotl-rotr.ll | ||
---|---|---|
402 | @craig.topper @pcwang-thead You might want to review theses tests as the out of bounds shifts means they generate poison (which is exploited by rGae60706da07a128) - maybe use fshl/fshr intrinsics? |
for test names - its better to use real numbers based off the mask instead of just iterating the test#
so maybe rotl_32_mask_63_mask_31 ?