Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I've only briefly looked at shouldScalarizeBinop but it sounds like it should theoretically work for scalable vectors (barring an initial check against BUILD_VECTOR) - should we add some scalable-vector tests here too while we're at it? I don't know if you're planning on that change in the future but having consistency sounds desirable to me. Or at least we could make it clear this patch adds fixed-vector tests.
Thanks for advice, I added scalable cases. And yes, it could work on scalable vectors too, I am doing the next patch which changes the DAGCombiner to enable these combinations for scalable vectors.
LGTM w/required changes before commit.
llvm/test/CodeGen/RISCV/rvv/extractelt-fp-rv32.ll | ||
---|---|---|
485 | Naming wise, "ext" makes me think "extend" not "extractelement". I'd suggest extractelt_<type>_<op>_splat. | |
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-extract.ll | ||
653 | Meta comment: "1" and "0" are special edge cases for mul and div. Please use a constant which is not an edge case if you're not testing that behavior. | |
662 | Example of previous comment causing less than helpful test output. |
Naming wise, "ext" makes me think "extend" not "extractelement".
I'd suggest extractelt_<type>_<op>_splat.