This is an archive of the discontinued LLVM Phabricator instance.

[mlir][ods] Replace redundant `Type` instances for interfaces
ClosedPublic

Authored by zero9178 on Jul 6 2022, 8:04 AM.

Details

Summary

This patch makes use of TypeInterface implementing Type to remove instances of Type that simply checked whether a type implemented a given interface.
As part of this refactoring, some changes had to be done in the OpenMP Dialect files. In particular, they assumed that OpenMPOps.td to only ever include OpenMP TypeInterfaces, which did not hold anymore with a moved include in LLVMOpBase.td. For that reason, the type interface defintions were moved into a new file as is convention.

Depends on https://reviews.llvm.org/D129209

Diff Detail

Event Timeline

zero9178 created this revision.Jul 6 2022, 8:04 AM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
zero9178 requested review of this revision.Jul 6 2022, 8:04 AM
Mogball accepted this revision.Jul 6 2022, 8:31 AM
Mogball added inline comments.
mlir/include/mlir/Dialect/OpenMP/OpenMPTypeInterfaces.td
9
This revision is now accepted and ready to land.Jul 6 2022, 8:31 AM