Page MenuHomePhabricator

[AArch64][CodeGen] Add AArch64 support for complex deinterleaving
Needs ReviewPublic

Authored by NickGuy on Jul 4 2022, 2:56 AM.

Details

Reviewers
dmgreen
samtebbs

Diff Detail

Event Timeline

NickGuy created this revision.Jul 4 2022, 2:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 2:56 AM
NickGuy requested review of this revision.Jul 4 2022, 2:56 AM
NickGuy updated this revision to Diff 442050.

Added context missing from initial patch

dmgreen added inline comments.Jul 6 2022, 2:41 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
22036

I think ComplxNum requires NEON, so checking for the first should be enough.

22083

There is quite a lot of debug message left here. I assume it will be removed in the final version?

llvm/test/CodeGen/AArch64/ComplexArithmetic/complex-arithmetic-f16-add.ll
1 ↗(On Diff #442050)

These don't need to be in a "ComplexArithmetic" directory - they are already easy to identify from the file prefix.

6 ↗(On Diff #442050)

Can you try and clean up these newlines too. There are gaps in places, but some of the functions are a little jammed together.

NickGuy updated this revision to Diff 449950.Aug 4 2022, 6:16 AM
NickGuy marked 4 inline comments as done.

Addressed comments, cleaned up debug outputs, and implemented vector splitting