User Details
User Details
- User Since
- Jun 23 2020, 7:14 AM (22 w, 10 h)
Wed, Nov 11
Wed, Nov 11
NickGuy added inline comments to D91255: [AArch64] Rearrange (dup(sext/zext)) to (sext/zext(dup)).
Wed, Nov 11, 8:48 AM · Restricted Project
NickGuy updated the diff for D91255: [AArch64] Rearrange (dup(sext/zext)) to (sext/zext(dup)).
This looks like two separate patches to me.
Wed, Nov 11, 8:48 AM · Restricted Project
NickGuy requested review of D91271: [AArch64] Attempt to sink mul operands.
Wed, Nov 11, 8:47 AM · Restricted Project
NickGuy added inline comments to D91255: [AArch64] Rearrange (dup(sext/zext)) to (sext/zext(dup)).
Wed, Nov 11, 7:05 AM · Restricted Project
NickGuy added inline comments to D91255: [AArch64] Rearrange (dup(sext/zext)) to (sext/zext(dup)).
Wed, Nov 11, 6:27 AM · Restricted Project
NickGuy requested review of D91255: [AArch64] Rearrange (dup(sext/zext)) to (sext/zext(dup)).
Wed, Nov 11, 6:22 AM · Restricted Project
Tue, Nov 3
Tue, Nov 3
NickGuy committed rG54d8627852a6: [AArch64] Redundant masks in downcast long multiply (authored by NickGuy).
[AArch64] Redundant masks in downcast long multiply
Tue, Nov 3, 2:12 AM · Restricted Project
Mon, Nov 2
Mon, Nov 2
NickGuy updated the diff for D89956: [AArch64] Redundant masks in downcast long multiply.
This pattern isn't needed I don't think
Mon, Nov 2, 8:30 AM · Restricted Project
NickGuy updated the diff for D89956: [AArch64] Redundant masks in downcast long multiply.
Mon, Nov 2, 7:32 AM · Restricted Project
NickGuy updated the diff for D89956: [AArch64] Redundant masks in downcast long multiply.
Mon, Nov 2, 2:39 AM · Restricted Project
Thu, Oct 29
Thu, Oct 29
NickGuy committed rGeb9fe24eaf2d: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz (authored by NickGuy).
[ARM] Fix IT block generation after Thumb2SizeReduce with -Oz
[ARM] Add IT block generation test
Thu, Oct 29, 8:17 AM · Restricted Project
Thu, Oct 29, 8:17 AM · Restricted Project
NickGuy requested review of D90398: [ARM] Add IT block generation test.
Thu, Oct 29, 8:07 AM · Restricted Project
NickGuy updated the diff for D88496: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.
I appreciate that the history and context for this has been a bit obscured. Most of it can be gathered on the patch D83667
Thu, Oct 29, 7:03 AM · Restricted Project
NickGuy updated the diff for D88496: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.
I think a MIR test would be better here.
Thu, Oct 29, 5:07 AM · Restricted Project
Mon, Oct 26
Mon, Oct 26
NickGuy added inline comments to D89956: [AArch64] Redundant masks in downcast long multiply.
Mon, Oct 26, 7:09 AM · Restricted Project
NickGuy updated the diff for D89956: [AArch64] Redundant masks in downcast long multiply.
Looks nice to me. Is it worth adding mul (sext_inreg, sext i32) patterns too in case one operand is sext and the other is being masked? mul is commutative so I think it would only be two extra patterns, one for sext and one for zext.
Mon, Oct 26, 7:08 AM · Restricted Project
Oct 22 2020
Oct 22 2020
NickGuy requested review of D89956: [AArch64] Redundant masks in downcast long multiply.
Oct 22 2020, 6:25 AM · Restricted Project
Oct 21 2020
Oct 21 2020
NickGuy committed rG9a2d2bedb730: Add "SkipDead" parameter to TargetInstrInfo::DefinesPredicate (authored by NickGuy).
Add "SkipDead" parameter to TargetInstrInfo::DefinesPredicate
Oct 21 2020, 3:52 AM · Restricted Project
NickGuy updated the diff for D88496: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.
Rebased atop changes to https://reviews.llvm.org/D88494
Oct 21 2020, 3:20 AM · Restricted Project
NickGuy retitled D88494: Add "SkipDead" parameter to TargetInstrInfo::DefinesPredicate from Add "IncludeRemovable" parameter to TargetInstrInfo::DefinesPredicate to Add "SkipDead" parameter to TargetInstrInfo::DefinesPredicate.
Oct 21 2020, 2:24 AM · Restricted Project
Oct 19 2020
Oct 19 2020
NickGuy updated the diff for D88494: Add "SkipDead" parameter to TargetInstrInfo::DefinesPredicate.
I'm a little concerned IfConversion isn't really prepared to deal with the distinction here: in some cases, if conversion doesn't predicate all the instructions in the if-converted block.
Oct 19 2020, 11:02 AM · Restricted Project
Oct 12 2020
Oct 12 2020
NickGuy added a comment to D88494: Add "SkipDead" parameter to TargetInstrInfo::DefinesPredicate.
Do we really need the boolean to default to false? There are only two callers, as far as I can tell.
Oct 12 2020, 3:18 AM · Restricted Project
Sep 29 2020
Sep 29 2020
NickGuy added a reviewer for D88494: Add "SkipDead" parameter to TargetInstrInfo::DefinesPredicate: efriedma.
Sep 29 2020, 8:24 AM · Restricted Project
NickGuy requested review of D88496: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.
Sep 29 2020, 8:23 AM · Restricted Project
NickGuy requested review of D88494: Add "SkipDead" parameter to TargetInstrInfo::DefinesPredicate.
Sep 29 2020, 8:21 AM · Restricted Project
Aug 14 2020
Aug 14 2020
NickGuy added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.
Looks like we've lost access to https://crbug.com/1114852, so can't access the build repro. Is this something you can sort out for us?
Aug 14 2020, 12:32 AM · Restricted Project
Aug 13 2020
Aug 13 2020
NickGuy added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.
Hi @akhuang, thanks for bringing this up.
Aug 13 2020, 1:16 AM · Restricted Project
Aug 10 2020
Aug 10 2020
LGTM, if no one else has any issues.
Aug 10 2020, 5:51 AM · Restricted Project
NickGuy added a comment to D85638: [ARM] Unrestrict Armv8-a IT when at minsize.
Source changes look good to me, just a few test-related points to address.
Aug 10 2020, 5:11 AM · Restricted Project
Aug 3 2020
Aug 3 2020
NickGuy committed rG18279a54b5d3: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz (authored by NickGuy).
[ARM] Fix IT block generation after Thumb2SizeReduce with -Oz
Aug 3 2020, 5:20 AM · Restricted Project
NickGuy updated the diff for D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.
Addressed comments, and rebased to include D84653 (Which handles the IT-block instruction legality)
Aug 3 2020, 1:17 AM · Restricted Project
Jul 13 2020
Jul 13 2020
Jul 13 2020, 3:36 AM · Restricted Project
Jul 2 2020
Jul 2 2020
NickGuy committed rGdc8e4d856615: [ARM] Rearrange SizeReduction when using -Oz (authored by NickGuy).
[ARM] Rearrange SizeReduction when using -Oz
Jul 2 2020, 1:34 AM · Restricted Project
Jul 1 2020
Jul 1 2020
NickGuy updated the diff for D82439: [ARM] Rearrange SizeReduction when using -Oz.
Updates some comments. NFC when compared to prior diffs
Jul 1 2020, 2:07 AM · Restricted Project
Jun 26 2020
Jun 26 2020
NickGuy updated the diff for D82439: [ARM] Rearrange SizeReduction when using -Oz.
Addressing inline comments
Jun 26 2020, 5:24 AM · Restricted Project
Jun 24 2020
Jun 24 2020
NickGuy updated the diff for D82439: [ARM] Rearrange SizeReduction when using -Oz.
Reworded/improved summary, and included full patch context
Jun 24 2020, 5:54 AM · Restricted Project
NickGuy updated the summary of D82439: [ARM] Rearrange SizeReduction when using -Oz.
Jun 24 2020, 1:34 AM · Restricted Project
Jun 24 2020, 1:02 AM · Restricted Project