Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

igor.kirillov (Igor Kirillov)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 10 2021, 3:24 AM (106 w, 1 d)

Recent Activity

Thu, Aug 31

igor.kirillov committed rGac65fb869977: [LoopVectorize] Fix incorrect order of invariant stores when there are multiple… (authored by igor.kirillov).
[LoopVectorize] Fix incorrect order of invariant stores when there are multiple…
Thu, Aug 31, 9:23 AM · Restricted Project, Restricted Project
igor.kirillov closed D157631: [LoopVectorize] Fix incorrect order of invariant stores when there are multiple reductions..
Thu, Aug 31, 9:23 AM · Restricted Project, Restricted Project
igor.kirillov added a comment to D159209: [CodeGen] Fix incorrect insertion point selection for reduction nodes in ComplexDeinterleavingPass.

@danilaml OrderedRoots has Instructions from the same BasicBlock, and they get there one by one during for (auto &I : *B) iteration. So, there is no risk of messing up there unless someone tries to add much more functionality :)

Thu, Aug 31, 3:43 AM · Restricted Project, Restricted Project
igor.kirillov committed rGe2cb07c322e8: [CodeGen] Fix incorrect insertion point selection for reduction nodes in… (authored by igor.kirillov).
[CodeGen] Fix incorrect insertion point selection for reduction nodes in…
Thu, Aug 31, 3:39 AM · Restricted Project, Restricted Project
igor.kirillov closed D159209: [CodeGen] Fix incorrect insertion point selection for reduction nodes in ComplexDeinterleavingPass.
Thu, Aug 31, 3:38 AM · Restricted Project, Restricted Project
igor.kirillov committed rG2df9ed11c51e: [LoopVectorize] Pre-commit tests for D157631 (authored by igor.kirillov).
[LoopVectorize] Pre-commit tests for D157631
Thu, Aug 31, 2:51 AM · Restricted Project, Restricted Project
igor.kirillov closed D157630: [LoopVectorize] Pre-commit tests for D157631.
Thu, Aug 31, 2:51 AM · Restricted Project, Restricted Project

Wed, Aug 30

igor.kirillov added reviewers for D159209: [CodeGen] Fix incorrect insertion point selection for reduction nodes in ComplexDeinterleavingPass: danilaml, NickGuy, mgabka.
Wed, Aug 30, 8:22 AM · Restricted Project, Restricted Project
igor.kirillov added inline comments to D159123: [CodeGen] Properly update insertion point of the builder.
Wed, Aug 30, 8:21 AM · Restricted Project, Restricted Project
igor.kirillov requested review of D159209: [CodeGen] Fix incorrect insertion point selection for reduction nodes in ComplexDeinterleavingPass.
Wed, Aug 30, 8:19 AM · Restricted Project, Restricted Project

Tue, Aug 29

igor.kirillov added inline comments to D157631: [LoopVectorize] Fix incorrect order of invariant stores when there are multiple reductions..
Tue, Aug 29, 7:25 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157631: [LoopVectorize] Fix incorrect order of invariant stores when there are multiple reductions..

Added tests with different store pointers

Tue, Aug 29, 7:23 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157630: [LoopVectorize] Pre-commit tests for D157631.

Add tests with different store pointers

Tue, Aug 29, 7:19 AM · Restricted Project, Restricted Project
igor.kirillov added a comment to D155218: [InstCombine] Optimize addition/subtraction operations of splats of vscale multiplied by a constant.

Ping about the RISC-V conversation and more test requirements

Tue, Aug 29, 7:02 AM · Restricted Project, Restricted Project

Aug 15 2023

igor.kirillov added a comment to D155218: [InstCombine] Optimize addition/subtraction operations of splats of vscale multiplied by a constant.

Please make sure to pre-commit test coverage (https://llvm.org/docs/TestingGuide.html#precommit-workflow-for-tests). This is also missing some tests, in particular multi-use and negative tests.

Aug 15 2023, 4:02 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D155218: [InstCombine] Optimize addition/subtraction operations of splats of vscale multiplied by a constant.
  • Added test with @use applied to nested add
  • Minor fixes
Aug 15 2023, 3:58 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157630: [LoopVectorize] Pre-commit tests for D157631.

Added reference to the github issue

Aug 15 2023, 3:43 AM · Restricted Project, Restricted Project

Aug 11 2023

igor.kirillov added a reviewer for D157631: [LoopVectorize] Fix incorrect order of invariant stores when there are multiple reductions.: fhahn.
Aug 11 2023, 9:55 AM · Restricted Project, Restricted Project
igor.kirillov added reviewers for D157630: [LoopVectorize] Pre-commit tests for D157631: huntergr, david-arm.
Aug 11 2023, 1:47 AM · Restricted Project, Restricted Project
igor.kirillov added reviewers for D157631: [LoopVectorize] Fix incorrect order of invariant stores when there are multiple reductions.: huntergr, david-arm.
Aug 11 2023, 1:46 AM · Restricted Project, Restricted Project

Aug 10 2023

igor.kirillov requested review of D157631: [LoopVectorize] Fix incorrect order of invariant stores when there are multiple reductions..
Aug 10 2023, 9:10 AM · Restricted Project, Restricted Project
igor.kirillov requested review of D157630: [LoopVectorize] Pre-commit tests for D157631.
Aug 10 2023, 9:08 AM · Restricted Project, Restricted Project

Aug 9 2023

igor.kirillov committed rG60e2a849b0a5: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1 (authored by igor.kirillov).
[CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1
Aug 9 2023, 2:34 AM · Restricted Project, Restricted Project
igor.kirillov closed D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1.
Aug 9 2023, 2:34 AM · Restricted Project, Restricted Project

Aug 8 2023

igor.kirillov committed rG84d444f90900: [CodeGen] Fix incorrect pattern FMLA_* pseudo instructions (authored by igor.kirillov).
[CodeGen] Fix incorrect pattern FMLA_* pseudo instructions
Aug 8 2023, 9:35 AM · Restricted Project, Restricted Project
igor.kirillov closed D157095: [CodeGen] Fix incorrect pattern FMLA_* pseudo instructions.
Aug 8 2023, 9:35 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1.

Added a test for neoverse-v1

Aug 8 2023, 6:23 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1.

Remove RUN with -mcpu=neoverse-v1 due to too many changes

Aug 8 2023, 4:48 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157095: [CodeGen] Fix incorrect pattern FMLA_* pseudo instructions.

Rebase after adding extra tests

Aug 8 2023, 4:39 AM · Restricted Project, Restricted Project
igor.kirillov committed rG7542477d5d6e: [CodeGen] Precommit tests for D157095 (authored by igor.kirillov).
[CodeGen] Precommit tests for D157095
Aug 8 2023, 4:39 AM · Restricted Project, Restricted Project
igor.kirillov committed rGb560d5c7e380: [CodeGen] Pre-commit tests showing incorrect pattern FMLA_* pseudo instructions (authored by igor.kirillov).
[CodeGen] Pre-commit tests showing incorrect pattern FMLA_* pseudo instructions
Aug 8 2023, 4:05 AM · Restricted Project, Restricted Project
igor.kirillov closed D157094: [CodeGen] Pre-commit tests showing incorrect pattern FMLA_* pseudo instructions.
Aug 8 2023, 4:05 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1.
  • Add RUN line to sve-ld1r.ll test with -mcpu=neoverse-v1
  • Update feature description
  • Add missing Predicate
Aug 8 2023, 3:50 AM · Restricted Project, Restricted Project

Aug 7 2023

igor.kirillov updated the diff for D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1.

Renaming

Aug 7 2023, 12:08 PM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1.

Update CHECK lines

Aug 7 2023, 8:17 AM · Restricted Project, Restricted Project
igor.kirillov added inline comments to D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1.
Aug 7 2023, 7:59 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1.
  • Rename new feature avoid-ldr1 to no-sve-fp-ld1r
  • Now change is applied only to FP LD1R instructions
  • Some other renaming inside code
Aug 7 2023, 7:57 AM · Restricted Project, Restricted Project
igor.kirillov added reviewers for D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1: paulwalker-arm, mgabka.
Aug 7 2023, 6:15 AM · Restricted Project, Restricted Project
igor.kirillov requested review of D157279: [CodeGen] Disable FP LD1RX instructions generation for Neoverse-V1.
Aug 7 2023, 6:14 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157094: [CodeGen] Pre-commit tests showing incorrect pattern FMLA_* pseudo instructions.

Update CHECK lines

Aug 7 2023, 6:00 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157094: [CodeGen] Pre-commit tests showing incorrect pattern FMLA_* pseudo instructions.

Update test functions names

Aug 7 2023, 5:50 AM · Restricted Project, Restricted Project
igor.kirillov added inline comments to D155218: [InstCombine] Optimize addition/subtraction operations of splats of vscale multiplied by a constant.
Aug 7 2023, 5:36 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D155218: [InstCombine] Optimize addition/subtraction operations of splats of vscale multiplied by a constant.
  • Vscale -> VScale
  • Move foldVScaleSplatAddSub call to visitAdd and visitSub
  • Refactor pattern detection algorithm
Aug 7 2023, 5:32 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157095: [CodeGen] Fix incorrect pattern FMLA_* pseudo instructions.

Rebase

Aug 7 2023, 4:04 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157094: [CodeGen] Pre-commit tests showing incorrect pattern FMLA_* pseudo instructions.

Remove comment. Update tests to match patterns better

Aug 7 2023, 4:03 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D157095: [CodeGen] Fix incorrect pattern FMLA_* pseudo instructions.

Replace AArch64ptrue 31 pattern with SVEAllActive

Aug 7 2023, 3:34 AM · Restricted Project, Restricted Project

Aug 4 2023

igor.kirillov added a comment to D156916: [CodeGen] Improve speed of ComplexDeinterleaving pass.

@NickGuy, it looks like we had O(2**N) complexity there where N is the depth of identifyNode call stack :)

Aug 4 2023, 7:23 AM · Restricted Project, Restricted Project
igor.kirillov committed rG46b2ad0224d3: [CodeGen] Improve speed of ComplexDeinterleaving pass (authored by igor.kirillov).
[CodeGen] Improve speed of ComplexDeinterleaving pass
Aug 4 2023, 7:13 AM · Restricted Project, Restricted Project
igor.kirillov closed D156916: [CodeGen] Improve speed of ComplexDeinterleaving pass.
Aug 4 2023, 7:12 AM · Restricted Project, Restricted Project
igor.kirillov added reviewers for D157095: [CodeGen] Fix incorrect pattern FMLA_* pseudo instructions: mgabka, paulwalker-arm.
Aug 4 2023, 7:05 AM · Restricted Project, Restricted Project
igor.kirillov added reviewers for D157094: [CodeGen] Pre-commit tests showing incorrect pattern FMLA_* pseudo instructions: mgabka, paulwalker-arm.
Aug 4 2023, 7:05 AM · Restricted Project, Restricted Project
igor.kirillov requested review of D157095: [CodeGen] Fix incorrect pattern FMLA_* pseudo instructions.
Aug 4 2023, 7:03 AM · Restricted Project, Restricted Project
igor.kirillov requested review of D157094: [CodeGen] Pre-commit tests showing incorrect pattern FMLA_* pseudo instructions.
Aug 4 2023, 6:53 AM · Restricted Project, Restricted Project

Aug 3 2023

igor.kirillov updated the diff for D156916: [CodeGen] Improve speed of ComplexDeinterleaving pass.

Added link to GitHub issue

Aug 3 2023, 3:42 AM · Restricted Project, Restricted Project

Aug 2 2023

igor.kirillov added reviewers for D156916: [CodeGen] Improve speed of ComplexDeinterleaving pass: NickGuy, mgabka.
Aug 2 2023, 10:15 AM · Restricted Project, Restricted Project
igor.kirillov requested review of D156916: [CodeGen] Improve speed of ComplexDeinterleaving pass.
Aug 2 2023, 10:12 AM · Restricted Project, Restricted Project

Jul 31 2023

igor.kirillov abandoned D156112: [AArch64][LoopVectorize] Improve tail-folding heuristic on neoverse-v1.
Jul 31 2023, 2:51 AM · Restricted Project, Restricted Project

Jul 25 2023

igor.kirillov added inline comments to D156112: [AArch64][LoopVectorize] Improve tail-folding heuristic on neoverse-v1.
Jul 25 2023, 4:20 AM · Restricted Project, Restricted Project

Jul 24 2023

igor.kirillov added reviewers for D156112: [AArch64][LoopVectorize] Improve tail-folding heuristic on neoverse-v1: paulwalker-arm, david-arm.
Jul 24 2023, 3:51 PM · Restricted Project, Restricted Project
igor.kirillov added inline comments to D155218: [InstCombine] Optimize addition/subtraction operations of splats of vscale multiplied by a constant.
Jul 24 2023, 3:49 PM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D155218: [InstCombine] Optimize addition/subtraction operations of splats of vscale multiplied by a constant.

Move code to a separate function and completely refactor it

Jul 24 2023, 3:22 PM · Restricted Project, Restricted Project
igor.kirillov requested review of D156112: [AArch64][LoopVectorize] Improve tail-folding heuristic on neoverse-v1.
Jul 24 2023, 5:28 AM · Restricted Project, Restricted Project

Jul 19 2023

igor.kirillov committed rGc15557d64eb9: [CodeGen] Extend ComplexDeinterleaving pass to recognise patterns using integer… (authored by igor.kirillov).
[CodeGen] Extend ComplexDeinterleaving pass to recognise patterns using integer…
Jul 19 2023, 4:05 AM · Restricted Project, Restricted Project
igor.kirillov closed D153808: [CodeGen] Extend ComplexDeinterleaving pass to recognise patterns using integer types.
Jul 19 2023, 4:05 AM · Restricted Project, Restricted Project

Jul 18 2023

igor.kirillov updated the diff for D153808: [CodeGen] Extend ComplexDeinterleaving pass to recognise patterns using integer types.

Update commit message and some tests comments

Jul 18 2023, 3:35 AM · Restricted Project, Restricted Project

Jul 14 2023

igor.kirillov added reviewers for D155218: [InstCombine] Optimize addition/subtraction operations of splats of vscale multiplied by a constant: paulwalker-arm, huntergr, mgabka.
Jul 14 2023, 1:43 AM · Restricted Project, Restricted Project

Jul 13 2023

igor.kirillov updated the diff for D153808: [CodeGen] Extend ComplexDeinterleaving pass to recognise patterns using integer types.

Move comments from definition to declaration

Jul 13 2023, 9:48 AM · Restricted Project, Restricted Project
igor.kirillov requested review of D155218: [InstCombine] Optimize addition/subtraction operations of splats of vscale multiplied by a constant.
Jul 13 2023, 9:43 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D153808: [CodeGen] Extend ComplexDeinterleaving pass to recognise patterns using integer types.

Address comments

Jul 13 2023, 9:42 AM · Restricted Project, Restricted Project

Jul 10 2023

igor.kirillov committed rG0aecf7ff0d81: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass (authored by igor.kirillov).
[CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass
Jul 10 2023, 5:55 AM · Restricted Project, Restricted Project
igor.kirillov closed D154598: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass.
Jul 10 2023, 5:55 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D154598: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass.

Rebase and update commit message

Jul 10 2023, 4:34 AM · Restricted Project, Restricted Project

Jul 7 2023

igor.kirillov added a comment to D154598: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass.

I adjusted the commit message rather than adding a test. It doesn't matter if vectors are scalable or fixed-width cause code that processes PHINodes does not behave differently. So I think adding a scalable test doesn't add more coverage.

Jul 7 2023, 4:15 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D154598: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass.

Update test and commit message

Jul 7 2023, 4:04 AM · Restricted Project, Restricted Project

Jul 6 2023

igor.kirillov updated the diff for D154598: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass.

Update test and commit message

Jul 6 2023, 8:29 AM · Restricted Project, Restricted Project
igor.kirillov added a comment to D153355: [CodeGen] Add support for Splats in ComplexDeinterleaving pass.

@glandium, thanks. I've reproduced and prepared the solution - https://reviews.llvm.org/D154598

Jul 6 2023, 5:13 AM · Restricted Project, Restricted Project
igor.kirillov added reviewers for D154598: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass: NickGuy, mgabka, glandium.
Jul 6 2023, 5:12 AM · Restricted Project, Restricted Project
igor.kirillov requested review of D154598: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass.
Jul 6 2023, 5:08 AM · Restricted Project, Restricted Project

Jul 5 2023

igor.kirillov committed rG7f20407ceed8: [CodeGen] Add support for Splats in ComplexDeinterleaving pass (authored by igor.kirillov).
[CodeGen] Add support for Splats in ComplexDeinterleaving pass
Jul 5 2023, 10:04 AM · Restricted Project, Restricted Project
igor.kirillov closed D153355: [CodeGen] Add support for Splats in ComplexDeinterleaving pass.
Jul 5 2023, 10:03 AM · Restricted Project, Restricted Project

Jul 4 2023

igor.kirillov committed rGe13582e9e345: [CodeGen] Precommit tests for D153355 (authored by igor.kirillov).
[CodeGen] Precommit tests for D153355
Jul 4 2023, 2:30 AM · Restricted Project, Restricted Project
igor.kirillov closed D153856: [CodeGen] Precommit tests for D153355.
Jul 4 2023, 2:30 AM · Restricted Project, Restricted Project

Jul 3 2023

igor.kirillov committed rGb4f9c3a933e8: [CodeGen] Refactor ComplexDeinterleaving to run identification on Values… (authored by igor.kirillov).
[CodeGen] Refactor ComplexDeinterleaving to run identification on Values…
Jul 3 2023, 3:36 AM · Restricted Project, Restricted Project
igor.kirillov closed D153446: [CodeGen] Refactor ComplexDeinterleaving to run identification on Values instead of Instructions.
Jul 3 2023, 3:36 AM · Restricted Project, Restricted Project

Jun 29 2023

igor.kirillov committed rG17bde328d604: [LV] Add mask support for vectorizing interleaved groups (authored by igor.kirillov).
[LV] Add mask support for vectorizing interleaved groups
Jun 29 2023, 11:11 AM · Restricted Project, Restricted Project
igor.kirillov closed D152258: [LV] Add mask support for vectorizing interleaved groups.
Jun 29 2023, 11:10 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D152258: [LV] Add mask support for vectorizing interleaved groups.

Add argument name

Jun 29 2023, 8:33 AM · Restricted Project, Restricted Project

Jun 28 2023

igor.kirillov accepted D153942: [NFC]Fix possibly derefer nullptr in ComplexDeinterleavingPass.cpp.

Ok, then!

Jun 28 2023, 4:34 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D152258: [LV] Add mask support for vectorizing interleaved groups.

Rebase after pre-commit

Jun 28 2023, 2:51 AM · Restricted Project, Restricted Project
igor.kirillov committed rG7049393a5865: [LV] Precommit masked interleaved access tests (authored by igor.kirillov).
[LV] Precommit masked interleaved access tests
Jun 28 2023, 2:24 AM · Restricted Project, Restricted Project
igor.kirillov closed D153443: [LV] Precommit masked interleaved access tests.
Jun 28 2023, 2:24 AM · Restricted Project, Restricted Project
igor.kirillov added inline comments to D153942: [NFC]Fix possibly derefer nullptr in ComplexDeinterleavingPass.cpp.
Jun 28 2023, 2:00 AM · Restricted Project, Restricted Project

Jun 27 2023

igor.kirillov committed rG1fce8df53a30: Fix the ComplexDeinterleaving bug when handling mixed reductions. (authored by igor.kirillov).
Fix the ComplexDeinterleaving bug when handling mixed reductions.
Jun 27 2023, 7:42 AM · Restricted Project, Restricted Project
igor.kirillov closed D153862: Fix the ComplexDeinterleaving bug when handling mixed reductions..
Jun 27 2023, 7:42 AM · Restricted Project, Restricted Project
igor.kirillov added inline comments to D153808: [CodeGen] Extend ComplexDeinterleaving pass to recognise patterns using integer types.
Jun 27 2023, 6:29 AM · Restricted Project, Restricted Project
igor.kirillov added inline comments to D153808: [CodeGen] Extend ComplexDeinterleaving pass to recognise patterns using integer types.
Jun 27 2023, 6:22 AM · Restricted Project, Restricted Project
igor.kirillov added reviewers for D153862: Fix the ComplexDeinterleaving bug when handling mixed reductions.: NickGuy, mgabka.
Jun 27 2023, 6:09 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D153862: Fix the ComplexDeinterleaving bug when handling mixed reductions..

Forgot to run tests update script

Jun 27 2023, 5:47 AM · Restricted Project, Restricted Project
igor.kirillov requested review of D153862: Fix the ComplexDeinterleaving bug when handling mixed reductions..
Jun 27 2023, 5:38 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D153808: [CodeGen] Extend ComplexDeinterleaving pass to recognise patterns using integer types.
  • IsOperationsupported -> IsOperationSupported
  • Remove some artefacts
Jun 27 2023, 5:11 AM · Restricted Project, Restricted Project