Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D128867

[mlir] Delete ForwardDataFlowAnalysis
ClosedPublic
Actions

Authored by Mogball on Jun 29 2022, 5:11 PM.

Details

Reviewers
sjarus
rriddle
nicolasvasilache
Commits
rGc20a581a8d36: [mlir] Delete ForwardDataFlowAnalysis
Summary

With SCCP and integer range analysis ported to the new framework, this old framework is redundant. Delete it.

Depends on D128866

Diff Detail

Event Timeline

Mogball created this revision.Jun 29 2022, 5:11 PM
Herald added a reviewer: sjarus. · View Herald TranscriptJun 29 2022, 5:11 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 23 others. · View Herald Transcript
Mogball requested review of this revision.Jun 29 2022, 5:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2022, 5:11 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B172907: Diff 441212.Jun 29 2022, 5:12 PM
Mogball added a reviewer: rriddle.Jun 29 2022, 5:12 PM
Mogball added a child revision: D128868: [mlir][dataflow] (WIP) Overhaul analysis state management to support composability.Jun 29 2022, 5:25 PM
rriddle accepted this revision.Jul 6 2022, 2:21 AM
This revision is now accepted and ready to land.Jul 6 2022, 2:21 AM
Herald added a subscriber: anlunx. · View Herald TranscriptJul 6 2022, 2:21 AM
Mogball updated this revision to Diff 443132.Jul 7 2022, 9:08 PM

rebase

This revision was landed with ongoing or failed builds.Jul 7 2022, 9:08 PM
Closed by commit rGc20a581a8d36: [mlir] Delete ForwardDataFlowAnalysis (authored by Mogball). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mogball added a commit: rGc20a581a8d36: [mlir] Delete ForwardDataFlowAnalysis.
Harbormaster completed remote builds in B174307: Diff 443132.Jul 7 2022, 9:25 PM
silvas added a subscriber: silvas.Jul 14 2022, 2:53 PM

I see an empty file after this PR: https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Analysis/DataFlowAnalysis.h

csigg added a subscriber: csigg.Jan 11 2023, 4:21 AM

Could we fix the documentation to no longer refer to ForwardDataFlowAnalysis?

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJan 11 2023, 4:21 AM
Herald added subscribers: Moerafaat, zero9178, jsetoain. · View Herald Transcript

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Analysis/
428 lines
lib/
Analysis/
1 line
818 lines
Dialect/
Tosa/
Transforms/
1 line
Transform/
Transforms/
1 line
test/
Analysis/
lib/
Analysis/
1 line
tools/
mlir-opt/
2 lines

Diff 443133

View Options

mlir/include/mlir/Analysis/DataFlowAnalysis.h

Loading...
View Options

mlir/lib/Analysis/CMakeLists.txt

Loading...
View Options

mlir/lib/Analysis/DataFlowAnalysis.cpp

Loading...
View Options

mlir/lib/Dialect/Tosa/Transforms/TosaInferShapes.cpp

Loading...
View Options

mlir/lib/Dialect/Transform/Transforms/CheckUses.cpp

Loading...
View Options

mlir/test/Analysis/test-data-flow.mlir

Loading...
View Options

mlir/test/lib/Analysis/CMakeLists.txt

Loading...
View Options

mlir/test/lib/Analysis/TestDataFlow.cpp

Loading...
View Options

mlir/tools/mlir-opt/mlir-opt.cpp

Loading...