Page MenuHomePhabricator

JohnTitor (Yuki Okushi)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2019, 1:43 PM (147 w, 2 d)

Recent Activity

Jun 18 2022

JohnTitor committed rG7eb046624f2a: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile` (authored by JohnTitor).
Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`
Jun 18 2022, 7:49 AM · Restricted Project, Restricted Project
JohnTitor closed D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`.
Jun 18 2022, 7:48 AM · Restricted Project, Restricted Project
JohnTitor added a comment to D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`.

Alright, let's go ahead then.

Jun 18 2022, 7:24 AM · Restricted Project, Restricted Project

Jun 17 2022

JohnTitor added a comment to D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`.

I've re-triggered it several times but it shows the same failure, maybe they're valid?

Jun 17 2022, 9:57 AM · Restricted Project, Restricted Project

Jun 12 2022

JohnTitor committed rGe43a85a363cf: [docs][clang] Fix a broken link on the APINotes doc (authored by JohnTitor).
[docs][clang] Fix a broken link on the APINotes doc
Jun 12 2022, 6:54 AM · Restricted Project, Restricted Project
JohnTitor closed D126599: [docs][clang] Fix a broken link on the APINotes doc.
Jun 12 2022, 6:53 AM · Restricted Project, Restricted Project
JohnTitor added a comment to D126599: [docs][clang] Fix a broken link on the APINotes doc.

It seems that other docs are following the GitHub URLs as well. I wish we could do the relative document link instead of embedding the URL, but if that is not possible, then this makes sense to do.

Jun 12 2022, 6:52 AM · Restricted Project, Restricted Project

Jun 10 2022

JohnTitor added reviewers for D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`: tbaeder, rsmith.
Jun 10 2022, 9:44 AM · Restricted Project, Restricted Project
JohnTitor requested review of D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`.
Jun 10 2022, 9:37 AM · Restricted Project, Restricted Project

Jun 9 2022

JohnTitor requested review of D127411: [AST Matchers] Make dump_ast_matchers.py work on Python 3.
Jun 9 2022, 9:02 AM · Restricted Project, Restricted Project
JohnTitor requested review of D127407: [ubsan][docs] Clarify `objc-cast` is not part of `-fsanitize=undefined`.
Jun 9 2022, 8:32 AM · Restricted Project, Restricted Project
JohnTitor committed rGcedfb5462cd8: [docs] Update supported language standards list for C++ (authored by JohnTitor).
[docs] Update supported language standards list for C++
Jun 9 2022, 6:14 AM · Restricted Project, Restricted Project
JohnTitor closed D127065: [docs] Update supported language standards list for C++.
Jun 9 2022, 6:14 AM · Restricted Project, Restricted Project
JohnTitor committed rG074f12e46795: [OpenMP] Fix the build on Windows (authored by JohnTitor).
[OpenMP] Fix the build on Windows
Jun 9 2022, 6:13 AM · Restricted Project, Restricted Project
JohnTitor closed D126873: [OpenMP] Fix the build on Windows.
Jun 9 2022, 6:12 AM · Restricted Project, Restricted Project
JohnTitor added a comment to D126873: [OpenMP] Fix the build on Windows.

I assume you just mentioned them for the next patch, pushing a commit.

Jun 9 2022, 6:12 AM · Restricted Project, Restricted Project
JohnTitor added reviewers for D126607: [docs] Remove some unavailable modindex links: rsmith, sscalpone.
Jun 9 2022, 2:37 AM · Restricted Project, Restricted Project, Restricted Project
JohnTitor added reviewers for D127065: [docs] Update supported language standards list for C++: josemonsalve2, jhuber6.
Jun 9 2022, 2:35 AM · Restricted Project, Restricted Project

Jun 7 2022

JohnTitor added a comment to D126873: [OpenMP] Fix the build on Windows.

FWIW, @tlwilmar is also a good person to tag as reviewer ;)

Jun 7 2022, 3:33 AM · Restricted Project, Restricted Project
JohnTitor retitled D127066: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript` from [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript` to [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`.
Jun 7 2022, 3:31 AM · Restricted Project, Restricted Project
JohnTitor committed rGaa9b3389ffd8: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript` (authored by JohnTitor).
[clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`
Jun 7 2022, 3:30 AM · Restricted Project, Restricted Project
JohnTitor closed D127066: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`.
Jun 7 2022, 3:30 AM · Restricted Project, Restricted Project
JohnTitor added a comment to D127066: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`.

It took me a moment, but this actually removes a 0xC2AD and not a 0x00AD. It's still correct, but I was wondering why no character was printed in the text -- 0xC2AD is not a defined Unicode character.

Jun 7 2022, 3:22 AM · Restricted Project, Restricted Project

Jun 6 2022

JohnTitor added a comment to D127160: Define OpenMP alloc macros before they are used.

Duplicate of https://reviews.llvm.org/D126873

Jun 6 2022, 4:25 PM · Restricted Project, Restricted Project

Jun 4 2022

JohnTitor added a reviewer for D127066: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`: aaron.ballman.
Jun 4 2022, 8:32 PM · Restricted Project, Restricted Project
JohnTitor requested review of D127066: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`.
Jun 4 2022, 8:31 PM · Restricted Project, Restricted Project
JohnTitor updated the summary of D127065: [docs] Update supported language standards list for C++.
Jun 4 2022, 8:22 PM · Restricted Project, Restricted Project
JohnTitor requested review of D127065: [docs] Update supported language standards list for C++.
Jun 4 2022, 8:18 PM · Restricted Project, Restricted Project

Jun 3 2022

JohnTitor committed rGfa7b4cf05e1c: [docs] Remove a link to an outdated Go docs (authored by JohnTitor).
[docs] Remove a link to an outdated Go docs
Jun 3 2022, 7:51 AM · Restricted Project, Restricted Project
JohnTitor closed D126874: [docs] Remove a link to an outdated Go docs.
Jun 3 2022, 7:51 AM · Restricted Project, Restricted Project
JohnTitor added a comment to D126874: [docs] Remove a link to an outdated Go docs.

Looks fine to me, but I have no idea what it would take to get the docs published there either. Maybe that's an easy fix?

Jun 3 2022, 7:48 AM · Restricted Project, Restricted Project

Jun 2 2022

JohnTitor added reviewers for D126874: [docs] Remove a link to an outdated Go docs: durin42, lattner.
Jun 2 2022, 4:56 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126874: [docs] Remove a link to an outdated Go docs.
Jun 2 2022, 4:50 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126873: [OpenMP] Fix the build on Windows.
Jun 2 2022, 4:34 AM · Restricted Project, Restricted Project

May 31 2022

JohnTitor committed rG36c1183c787f: [test] Remove an outdated FIXME (authored by JohnTitor).
[test] Remove an outdated FIXME
May 31 2022, 4:18 PM · Restricted Project, Restricted Project
JohnTitor closed D126528: [test] Remove an outdated FIXME.
May 31 2022, 4:18 PM · Restricted Project, Restricted Project
JohnTitor committed rG5c1494039491: [clangd] Remove a test with a duplicate of FileCacheTests (authored by JohnTitor).
[clangd] Remove a test with a duplicate of FileCacheTests
May 31 2022, 4:16 PM · Restricted Project, Restricted Project
JohnTitor closed D126608: [clangd] Remove a test with a duplicate of FileCacheTests.
May 31 2022, 4:16 PM · Restricted Project, Restricted Project

May 28 2022

JohnTitor added a reviewer for D126608: [clangd] Remove a test with a duplicate of FileCacheTests: sammccall.
May 28 2022, 6:12 PM · Restricted Project, Restricted Project
JohnTitor requested review of D126608: [clangd] Remove a test with a duplicate of FileCacheTests.
May 28 2022, 6:11 PM · Restricted Project, Restricted Project
JohnTitor added reviewers for D126607: [docs] Remove some unavailable modindex links: arphaman, jdoerfert.
May 28 2022, 6:05 PM · Restricted Project, Restricted Project, Restricted Project
JohnTitor requested review of D126607: [docs] Remove some unavailable modindex links.
May 28 2022, 6:04 PM · Restricted Project, Restricted Project, Restricted Project
JohnTitor committed rG41a054ef7885: [clang] Remove `rm` script which is no longer necessary (authored by JohnTitor).
[clang] Remove `rm` script which is no longer necessary
May 28 2022, 4:51 PM · Restricted Project, Restricted Project
JohnTitor closed D126597: [clang] Remove `rm` script which is no longer necessary.
May 28 2022, 4:50 PM · Restricted Project, Restricted Project
JohnTitor accepted D126601: [mlir][NFC] Trivial : Fix typo.

LGTM!

May 28 2022, 4:46 PM · Restricted Project, Restricted Project
JohnTitor added a reviewer for D126599: [docs][clang] Fix a broken link on the APINotes doc: compnerd.
May 28 2022, 10:01 AM · Restricted Project, Restricted Project
JohnTitor updated the summary of D126599: [docs][clang] Fix a broken link on the APINotes doc.
May 28 2022, 10:01 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126599: [docs][clang] Fix a broken link on the APINotes doc.
May 28 2022, 10:00 AM · Restricted Project, Restricted Project
JohnTitor added a reviewer for D126597: [clang] Remove `rm` script which is no longer necessary: thakis.
May 28 2022, 9:27 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126597: [clang] Remove `rm` script which is no longer necessary.
May 28 2022, 9:27 AM · Restricted Project, Restricted Project
JohnTitor committed rGbc08a16d828b: Remove `deplibs` keyword completely (authored by JohnTitor).
Remove `deplibs` keyword completely
May 28 2022, 9:17 AM · Restricted Project, Restricted Project
JohnTitor closed D126527: Remove `deplibs` keyword completely.
May 28 2022, 9:17 AM · Restricted Project, Restricted Project, Restricted Project
JohnTitor committed rG0a2d2eed4321: [docs] Update the label name for new contributors (authored by JohnTitor).
[docs] Update the label name for new contributors
May 28 2022, 7:15 AM · Restricted Project, Restricted Project
JohnTitor closed D126526: [docs] Update the label name for new contributors.
May 28 2022, 7:15 AM · Restricted Project, Restricted Project

May 27 2022

JohnTitor committed rGd3d3e2528e60: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer` (authored by JohnTitor).
[CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`
May 27 2022, 10:59 PM · Restricted Project, Restricted Project
JohnTitor closed D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`.
May 27 2022, 10:59 PM · Restricted Project, Restricted Project
JohnTitor added a reviewer for D126537: [Flang] Use `signalPassFailure` for unsupported targets: awarzynski.
May 27 2022, 6:40 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126537: [Flang] Use `signalPassFailure` for unsupported targets.
May 27 2022, 6:39 AM · Restricted Project, Restricted Project
JohnTitor updated the diff for D126527: Remove `deplibs` keyword completely.
May 27 2022, 6:35 AM · Restricted Project, Restricted Project, Restricted Project
JohnTitor updated the diff for D126527: Remove `deplibs` keyword completely.
May 27 2022, 6:31 AM · Restricted Project, Restricted Project, Restricted Project
JohnTitor updated the diff for D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`.

Fix the indention

May 27 2022, 5:00 AM · Restricted Project, Restricted Project
JohnTitor updated the diff for D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`.

[CompilerInstance] Tweak the condition on createCodeCompletionConsumer

May 27 2022, 4:59 AM · Restricted Project, Restricted Project
JohnTitor added reviewers for D126528: [test] Remove an outdated FIXME: vitalybuka, kstoimenov.
May 27 2022, 3:51 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126528: [test] Remove an outdated FIXME.
May 27 2022, 3:49 AM · Restricted Project, Restricted Project
JohnTitor added reviewers for D126527: Remove `deplibs` keyword completely: compnerd, dexonsmith, lattner.
May 27 2022, 3:24 AM · Restricted Project, Restricted Project, Restricted Project
JohnTitor requested review of D126527: Remove `deplibs` keyword completely.
May 27 2022, 3:22 AM · Restricted Project, Restricted Project, Restricted Project
JohnTitor added a reviewer for D126526: [docs] Update the label name for new contributors: aaron.ballman.
May 27 2022, 2:05 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126526: [docs] Update the label name for new contributors.
May 27 2022, 2:04 AM · Restricted Project, Restricted Project
JohnTitor updated the summary of D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`.
May 27 2022, 1:54 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`.
May 27 2022, 1:43 AM · Restricted Project, Restricted Project

Jun 15 2021

JohnTitor updated subscribers of D68891: Remove unnecessary triple from test.

ping @rnk Seems you added this.

Jun 15 2021, 2:12 AM · Restricted Project

Apr 22 2021

JohnTitor added a comment to D68891: Remove unnecessary triple from test.

Ping @cfe-commits

Apr 22 2021, 7:40 AM · Restricted Project

Oct 18 2019

JohnTitor added a comment to D68891: Remove unnecessary triple from test.

ping @rsmith

Oct 18 2019, 6:15 PM · Restricted Project

Oct 11 2019

JohnTitor created D68891: Remove unnecessary triple from test.
Oct 11 2019, 2:22 PM · Restricted Project