User Details
User Details
- User Since
- Oct 11 2019, 1:43 PM (217 w, 2 d)
Jun 18 2022
Jun 18 2022
JohnTitor committed rG7eb046624f2a: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile` (authored by JohnTitor).
Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`
JohnTitor added a comment to D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`.
Alright, let's go ahead then.
Jun 17 2022
Jun 17 2022
JohnTitor added a comment to D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`.
I've re-triggered it several times but it shows the same failure, maybe they're valid?
Jun 12 2022
Jun 12 2022
JohnTitor committed rGe43a85a363cf: [docs][clang] Fix a broken link on the APINotes doc (authored by JohnTitor).
[docs][clang] Fix a broken link on the APINotes doc
JohnTitor added a comment to D126599: [docs][clang] Fix a broken link on the APINotes doc.
It seems that other docs are following the GitHub URLs as well. I wish we could do the relative document link instead of embedding the URL, but if that is not possible, then this makes sense to do.
Jun 10 2022
Jun 10 2022
JohnTitor added reviewers for D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`: tbaeder, rsmith.
JohnTitor requested review of D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`.
Jun 9 2022
Jun 9 2022
JohnTitor requested review of D127411: [AST Matchers] Make dump_ast_matchers.py work on Python 3.
JohnTitor committed rGcedfb5462cd8: [docs] Update supported language standards list for C++ (authored by JohnTitor).
[docs] Update supported language standards list for C++
[OpenMP] Fix the build on Windows
JohnTitor added a comment to D126873: [OpenMP] Fix the build on Windows.
I assume you just mentioned them for the next patch, pushing a commit.
JohnTitor added reviewers for D126607: [docs] Remove some unavailable modindex links: rsmith, sscalpone.
JohnTitor added reviewers for D127065: [docs] Update supported language standards list for C++: josemonsalve2, jhuber6.
Jun 7 2022
Jun 7 2022
JohnTitor added a comment to D126873: [OpenMP] Fix the build on Windows.
FWIW, @tlwilmar is also a good person to tag as reviewer ;)
JohnTitor retitled D127066: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript` from [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript` to [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`.
JohnTitor committed rGaa9b3389ffd8: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript` (authored by JohnTitor).
[clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`
JohnTitor added a comment to D127066: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`.
It took me a moment, but this actually removes a 0xC2AD and not a 0x00AD. It's still correct, but I was wondering why no character was printed in the text -- 0xC2AD is not a defined Unicode character.
Jun 6 2022
Jun 6 2022
JohnTitor added a comment to D127160: Define OpenMP alloc macros before they are used.
Duplicate of https://reviews.llvm.org/D126873
Jun 4 2022
Jun 4 2022
JohnTitor added a reviewer for D127066: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`: aaron.ballman.
JohnTitor requested review of D127066: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`.
JohnTitor updated the summary of D127065: [docs] Update supported language standards list for C++.
JohnTitor requested review of D127065: [docs] Update supported language standards list for C++.
Jun 3 2022
Jun 3 2022
JohnTitor committed rGfa7b4cf05e1c: [docs] Remove a link to an outdated Go docs (authored by JohnTitor).
[docs] Remove a link to an outdated Go docs
JohnTitor added a comment to D126874: [docs] Remove a link to an outdated Go docs.
Jun 2 2022
Jun 2 2022
JohnTitor added reviewers for D126874: [docs] Remove a link to an outdated Go docs: durin42, lattner.
JohnTitor requested review of D126874: [docs] Remove a link to an outdated Go docs.
JohnTitor requested review of D126873: [OpenMP] Fix the build on Windows.
May 31 2022
May 31 2022
[test] Remove an outdated FIXME
JohnTitor committed rG5c1494039491: [clangd] Remove a test with a duplicate of FileCacheTests (authored by JohnTitor).
[clangd] Remove a test with a duplicate of FileCacheTests
May 28 2022
May 28 2022
JohnTitor added a reviewer for D126608: [clangd] Remove a test with a duplicate of FileCacheTests: sammccall.
JohnTitor requested review of D126608: [clangd] Remove a test with a duplicate of FileCacheTests.
JohnTitor added reviewers for D126607: [docs] Remove some unavailable modindex links: arphaman, jdoerfert.
JohnTitor requested review of D126607: [docs] Remove some unavailable modindex links.
JohnTitor committed rG41a054ef7885: [clang] Remove `rm` script which is no longer necessary (authored by JohnTitor).
[clang] Remove `rm` script which is no longer necessary
LGTM!
JohnTitor added a reviewer for D126599: [docs][clang] Fix a broken link on the APINotes doc: compnerd.
JohnTitor updated the summary of D126599: [docs][clang] Fix a broken link on the APINotes doc.
JohnTitor requested review of D126599: [docs][clang] Fix a broken link on the APINotes doc.
JohnTitor added a reviewer for D126597: [clang] Remove `rm` script which is no longer necessary: thakis.
JohnTitor requested review of D126597: [clang] Remove `rm` script which is no longer necessary.
Remove `deplibs` keyword completely
JohnTitor committed rG0a2d2eed4321: [docs] Update the label name for new contributors (authored by JohnTitor).
[docs] Update the label name for new contributors
May 27 2022
May 27 2022
JohnTitor committed rGd3d3e2528e60: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer` (authored by JohnTitor).
[CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`
JohnTitor added a reviewer for D126537: [Flang] Use `signalPassFailure` for unsupported targets: awarzynski.
JohnTitor requested review of D126537: [Flang] Use `signalPassFailure` for unsupported targets.
JohnTitor updated the diff for D126527: Remove `deplibs` keyword completely.
JohnTitor updated the diff for D126527: Remove `deplibs` keyword completely.
JohnTitor updated the diff for D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`.
Fix the indention
JohnTitor updated the diff for D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`.
[CompilerInstance] Tweak the condition on createCodeCompletionConsumer
JohnTitor requested review of D126528: [test] Remove an outdated FIXME.
JohnTitor added reviewers for D126527: Remove `deplibs` keyword completely: compnerd, dexonsmith, lattner.
JohnTitor requested review of D126527: Remove `deplibs` keyword completely.
JohnTitor added a reviewer for D126526: [docs] Update the label name for new contributors: aaron.ballman.
JohnTitor requested review of D126526: [docs] Update the label name for new contributors.
JohnTitor updated the summary of D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`.
Jun 15 2021
Jun 15 2021
JohnTitor updated subscribers of D68891: Remove unnecessary triple from test.
ping @rnk Seems you added this.
Jun 15 2021, 2:12 AM · Restricted Project
Apr 22 2021
Apr 22 2021
JohnTitor added a comment to D68891: Remove unnecessary triple from test.
Ping @cfe-commits
Apr 22 2021, 7:40 AM · Restricted Project
Oct 18 2019
Oct 18 2019
JohnTitor added a comment to D68891: Remove unnecessary triple from test.
ping @rsmith
Oct 18 2019, 6:15 PM · Restricted Project
Oct 11 2019
Oct 11 2019
Oct 11 2019, 2:22 PM · Restricted Project