Page MenuHomePhabricator

[clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`
ClosedPublic

Authored by JohnTitor on Jun 4 2022, 8:31 PM.

Details

Summary

The Builder.defineMacro("__cpp_multidimensional_subscript", "202110L"); line has
some U+C2ADs that shouldn't necessary here. So removed them.

Diff Detail

Event Timeline

JohnTitor created this revision.Jun 4 2022, 8:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2022, 8:31 PM
JohnTitor requested review of this revision.Jun 4 2022, 8:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2022, 8:31 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.Jun 6 2022, 4:58 AM

It took me a moment, but this actually removes a 0xC2AD and not a 0x00AD. It's still correct, but I was wondering why no character was printed in the text -- 0xC2AD is not a defined Unicode character.

LGTM, but can you correct the patch title + summary when committing?

This revision is now accepted and ready to land.Jun 6 2022, 4:58 AM

It took me a moment, but this actually removes a 0xC2AD and not a 0x00AD. It's still correct, but I was wondering why no character was printed in the text -- 0xC2AD is not a defined Unicode character.

Oh, my editor said it 0x00AD, it's weird. Anyway thanks for clarifying.

can you correct the patch title + summary when committing?

Sure!

JohnTitor retitled this revision from [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript` to [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`.Jun 7 2022, 3:31 AM
JohnTitor edited the summary of this revision. (Show Details)