This is an archive of the discontinued LLVM Phabricator instance.

[RISCV]Precommit test of D127568
AcceptedPublic

Authored by StephenFan on Jun 11 2022, 7:00 AM.

Diff Detail

Event Timeline

StephenFan created this revision.Jun 11 2022, 7:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2022, 7:00 AM
StephenFan requested review of this revision.Jun 11 2022, 7:00 AM

Does this not also work as an asm test rather than an IR test?

craig.topper added a subscriber: craig.topper.

This isn't an MC test. It's a Codegen test. Put in the codegen directory and update the title.

Does this not also work as an asm test rather than an IR test?

The issue is in RISCVTargetObjectFile.h which is part of the CodeGen layer not the MC layer. The MC layer uses RISCVMCObjectFileInfo already.

Move file to CodeGen test

StephenFan retitled this revision from [RISCV][MC] Precommit test of D127568 to [RISCV]Precommit test of D127568.Jun 23 2022, 10:18 PM
StephenFan accepted this revision.Jun 28 2022, 11:05 PM
This revision is now accepted and ready to land.Jun 28 2022, 11:05 PM
MaskRay added inline comments.Jun 28 2022, 11:06 PM
llvm/test/CodeGen/RISCV/unnecessary-code-align.ll
2

Ideally, you just find where -mattr=-c,+relax is tested, add add the +c test there.

6

Add -NEXT whenever applicable.

16

remove trailing blank line

Use CHECK-NEXT is applicable.

StephenFan marked 2 inline comments as done.Jun 29 2022, 7:06 AM
StephenFan added inline comments.Jun 29 2022, 7:11 AM
llvm/test/CodeGen/RISCV/unnecessary-code-align.ll
2

Not ideally, I didn't find test files that testing with -mattr=-c,+relax :(