[flang][OpenMP] Parser support for Target directive and Device clause
AcceptedPublic
Actions

Authored by NimishMishra on May 25 2022, 8:13 PM.

Details

Reviewers

sscalpone
jdoerfert
shraiysh
kiranchandramohan
kiranktp
peixin
MatsPetersson
arnamoy10

Summary

This patch adds parser support for device clause on target directive.

Co-authored-by: Sesha Kalyur <SeshaP.Kalyur@amd.com>

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,530 ms	x64 debian > Clang.Driver::fsanitize.c Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -target x86_64-linux-gnu -fsanitize=undefined -fsanitize-trap=undefined /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/fsanitize.c -### 2>&1 \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/fsanitize.c --check-prefix=CHECK-UNDEFINED-TRAP
	60,540 ms	x64 debian > Clang.OpenMP::target_defaultmap_codegen_01.cpp Script: -- : 'RUN: at line 8'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -no-opaque-pointers -no-enable-noundef-analysis -DCK1 -verify -fopenmp -fopenmp-version=50 -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple powerpc64le-unknown-unknown -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_defaultmap_codegen_01.cpp -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --allow-unused-prefixes -allow-deprecated-dag-overlap /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_defaultmap_codegen_01.cpp --check-prefix CK1
	60,190 ms	x64 debian > Clang.OpenMP::target_parallel_for_simd_codegen.cpp Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -no-opaque-pointers -verify -fopenmp -fopenmp-version=45 -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=powerpc64le-ibm-linux-gnu -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_parallel_for_simd_codegen.cpp -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --allow-unused-prefixes -allow-deprecated-dag-overlap /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_parallel_for_simd_codegen.cpp --check-prefix=CHECK1
	60,170 ms	x64 debian > Clang.OpenMP::target_teams_distribute_parallel_for_simd_codegen_registration.cpp Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -no-opaque-pointers -verify -fopenmp -fopenmp-version=45 -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=powerpc64le-ibm-linux-gnu -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen_registration.cpp -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --allow-unused-prefixes /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen_registration.cpp
	60,410 ms	x64 debian > Clang.OpenMP::target_teams_distribute_simd_codegen.cpp Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -no-opaque-pointers -verify -fopenmp -fopenmp-version=45 -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=powerpc64le-ibm-linux-gnu -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_teams_distribute_simd_codegen.cpp -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --allow-unused-prefixes /var/lib/buildkite-agent/builds/llvm-project/clang/test/OpenMP/target_teams_distribute_simd_codegen.cpp --check-prefix=CHECK1
		View Full Test Results (10 Failed)

Event Timeline

NimishMishra created this revision.May 25 2022, 8:13 PM

Herald added a reviewer: sscalpone. · View Herald TranscriptMay 25 2022, 8:13 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: jdoerfert, guansong, yaxunl. · View Herald Transcript

NimishMishra requested review of this revision.May 25 2022, 8:13 PM

Herald added a reviewer: jdoerfert. · View Herald TranscriptMay 25 2022, 8:13 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, sstefan1. · View Herald Transcript

Harbormaster completed remote builds in B166404: Diff 432178.May 25 2022, 9:06 PM

Debian failure is due to test failures unrelated to this patch.

NimishMishra added reviewers: shraiysh, kiranchandramohan, kiranktp, peixin, MatsPetersson, arnamoy10.May 25 2022, 9:08 PM

raghavendhra added subscribers: raghavendhra, dpalermo.May 31 2022, 6:19 AM

LGTM. Please wait for atleast one more review.

Ping for review!

LGTM.

Can you add some more information to the commit message/summary detailing which revision of the standard the device clause appeared first, and what are the options for this clause.

This revision is now accepted and ready to land.Jul 11 2022, 7:32 AM