This is an archive of the discontinued LLVM Phabricator instance.

Differential D124510

[RISCV] Precommit test for D124509
ClosedPublic

Authored by kito-cheng on Apr 27 2022, 2:32 AM.

Details

Reviewers
asb
luismarques
khchen
HsiangKai
Commits
rG02c7de3a4c32: [RISCV] Precommit test for D124509
Summary

Test case to show the wrong code gen for int16 -> __fp16 conversion,
clang just emit a load and store without did conversion in the case,

and another case used for demonstrate the code gen change of __fp16
-> int16.

Diff Detail

Event Timeline

kito-cheng created this revision.Apr 27 2022, 2:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 2:32 AM
Herald added subscribers: sunshaoce, VincentWu, luke957 and 26 others. · View Herald Transcript
kito-cheng requested review of this revision.Apr 27 2022, 2:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 2:32 AM
Herald added subscribers: cfe-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
kito-cheng added reviewers: asb, luismarques, khchen, HsiangKai.Apr 27 2022, 2:33 AM
Herald added a subscriber: StephenFan. · View Herald TranscriptApr 27 2022, 2:33 AM
kito-cheng added a child revision: D124509: [RISCV] Fix int16 -> __fp16 conversion code gen.Apr 27 2022, 2:34 AM
kito-cheng edited the summary of this revision. (Show Details)Apr 27 2022, 2:38 AM
Harbormaster completed remote builds in B161555: Diff 425451.Apr 27 2022, 3:25 AM
khchen accepted this revision.Apr 29 2022, 8:34 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 29 2022, 8:34 AM
This revision was landed with ongoing or failed builds.Apr 29 2022, 8:09 PM
Closed by commit rG02c7de3a4c32: [RISCV] Precommit test for D124509 (authored by kito-cheng). · Explain Why
This revision was automatically updated to reflect the committed changes.
kito-cheng added a commit: rG02c7de3a4c32: [RISCV] Precommit test for D124509.

Revision Contents

PathSize
clang/
test/
CodeGen/
RISCV/
26 lines

Diff 426206

clang/test/CodeGen/RISCV/__fp16-convert.c

  • This file was added.
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
// RUN: %clang_cc1 -triple riscv64 -emit-llvm %s -o - \
// RUN: | FileCheck %s
__fp16 y;
short z;
// CHECK-LABEL: @bar1(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = load i16, ptr @y, align 2
// CHECK-NEXT: [[TMP1:%.*]] = call float @llvm.convert.from.fp16.f32(i16 [[TMP0]])
// CHECK-NEXT: [[CONV:%.*]] = fptosi float [[TMP1]] to i16
// CHECK-NEXT: store i16 [[CONV]], ptr @z, align 2
// CHECK-NEXT: ret void
//
void bar1(){
z = y;
}
// CHECK-LABEL: @bar2(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = load i16, ptr @z, align 2
// CHECK-NEXT: store i16 [[TMP0]], ptr @y, align 2
// CHECK-NEXT: ret void
//
void bar2(){
y = z;
}