This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Fix alias printing for vmnot.m
ClosedPublic

Authored by craig.topper on Apr 25 2022, 4:53 PM.

Details

Summary

By clearing the HasDummyMask flag from mask register binary operations
and mask load/store.

HasDummyMask was causing an extra operand to get appended when
converting from MachineInstr to MCInst. This extra operand doesn't
appear in the assembly string so was mostly ignored, but it prevented
the alias instruction printing from working correctly.

Diff Detail

Unit TestsFailed

Event Timeline

craig.topper created this revision.Apr 25 2022, 4:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2022, 4:53 PM
craig.topper requested review of this revision.Apr 25 2022, 4:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2022, 4:53 PM

Fix extra operand for VLM and VSM too.

craig.topper edited the summary of this revision. (Show Details)Apr 25 2022, 5:10 PM
craig.topper retitled this revision from [RISCV] Fix alias print for vmnot.m to [RISCV] Fix alias printing for vmnot.m.
arcbbb accepted this revision.Apr 27 2022, 10:32 PM

LGTM. Thanks for the fix!

This revision is now accepted and ready to land.Apr 27 2022, 10:32 PM
This revision was landed with ongoing or failed builds.Apr 28 2022, 8:36 AM
This revision was automatically updated to reflect the committed changes.