This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Remove unused text in the test.
ClosedPublic

Authored by khchen on Apr 21 2022, 8:50 AM.

Details

Summary

In D123418 we removed some RUN line (ex. RV32-ELEN16) but their
expected results still exist there.
Remove them and run update_llc_test_checks again.

Diff Detail

Event Timeline

khchen created this revision.Apr 21 2022, 8:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 8:50 AM
khchen requested review of this revision.Apr 21 2022, 8:50 AM
frasercrmck added inline comments.Apr 21 2022, 10:35 AM
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-mask-buildvec.ll
11

I think I prefer RV32-ELEN32 to RV32-ELEN since it's more descriptive, but RV32-ZVE32F is better still. We have similar check prefixes in other tests.

asb added inline comments.Apr 21 2022, 10:52 AM
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-mask-buildvec.ll
11

+1

craig.topper added inline comments.Apr 21 2022, 11:19 AM
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-mask-buildvec.ll
11

+1

khchen updated this revision to Diff 424376.Apr 21 2022, 9:50 PM

address @frasercrmck's comment. thanks!

frasercrmck accepted this revision.Apr 22 2022, 9:02 AM

LGTM but it looks as though a lot of the RV32-ZVE32F/RV64-ZVE32F checks are identical. I couldn't tell if it was 100% or just the majority. If so, maybe a common ZVE32F prefix would reduce the number of identical checks we're emitting?

This revision is now accepted and ready to land.Apr 22 2022, 9:02 AM
khchen updated this revision to Diff 424519.Apr 22 2022, 10:17 AM

RV32-ZVE32F and RV64-ZVE32F result are identical. Use ZVE32F prefix directly.

This revision was landed with ongoing or failed builds.Apr 22 2022, 7:27 PM
This revision was automatically updated to reflect the committed changes.