In D123418 we removed some RUN line (ex. RV32-ELEN16) but their
expected results still exist there.
Remove them and run update_llc_test_checks again.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-mask-buildvec.ll | ||
---|---|---|
11 | I think I prefer RV32-ELEN32 to RV32-ELEN since it's more descriptive, but RV32-ZVE32F is better still. We have similar check prefixes in other tests. |
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-mask-buildvec.ll | ||
---|---|---|
11 | +1 |
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-mask-buildvec.ll | ||
---|---|---|
11 | +1 |
Comment Actions
LGTM but it looks as though a lot of the RV32-ZVE32F/RV64-ZVE32F checks are identical. I couldn't tell if it was 100% or just the majority. If so, maybe a common ZVE32F prefix would reduce the number of identical checks we're emitting?
I think I prefer RV32-ELEN32 to RV32-ELEN since it's more descriptive, but RV32-ZVE32F is better still. We have similar check prefixes in other tests.