[Mips] support "sp" named register
ClosedPublic
Actions

Authored by nickdesaulniers on Mar 3 2022, 11:24 AM.

Details

Reviewers

atanasyan
sstankovic
vmedic
dsanders

Commits

rGe0adc3be1329: [Mips] support "sp" named register

Summary

After Linux kernel commit
commit 200ed341b864 ("mips: Implement "current_stack_pointer"")
We observe the following build error when compiling the Linux kernel
targeting Mips:
fatal error: error in backend: Invalid register name global variable

Fixes: https://github.com/llvm/llvm-project/issues/54174
Link: https://github.com/ClangBuiltLinux/linux/issues/1608

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,180 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +zfh -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c
	60,190 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +zfh -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg.c
	60,170 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vloxseg.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxseg.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxseg.c
	60,170 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vluxseg.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxseg.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxseg.c
	60,370 ms	x64 debian > Clang.Driver::aarch64-cpus.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -target aarch64 -### -c /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/aarch64-cpus.c 2>&1 \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -check-prefix=GENERIC /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/aarch64-cpus.c
		View Full Test Results (8 Failed)

Event Timeline

nickdesaulniers created this revision.Mar 3 2022, 11:24 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 11:24 AM

Herald added subscribers: jrtc27, hiraditya, arichardson, sdardis. · View Herald Transcript

nickdesaulniers requested review of this revision.Mar 3 2022, 11:24 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 11:24 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B152425: Diff 412783.Mar 3 2022, 12:35 PM

I can build malta_defconfig on next-20220303 with this patch. I enabled CONFIG_DEBUG_STACKOVERFLOW and CONFIG_HARDENED_USERCOPY, which both use current_stack_pointer, and did not see any warnings/errors.

llvm/test/CodeGen/Mips/named-register-n64.ll
26	Should this be `!llvm.named.register.$sp = !{!1}`?

atanasyan accepted this revision.Mar 3 2022, 1:36 PM

This revision is now accepted and ready to land.Mar 3 2022, 1:36 PM

Do you have commit access?

fix named register metadata in n64 test, as per @nathanchance

In D120926#3358183, @atanasyan wrote:

Do you have commit access?

Yep.

In D120926#3358178, @nathanchance wrote:

I can build malta_defconfig on next-20220303 with this patch. I enabled CONFIG_DEBUG_STACKOVERFLOW and CONFIG_HARDENED_USERCOPY, which both use current_stack_pointer, and did not see any warnings/errors.

I appreciate it!