Page MenuHomePhabricator

vmedic (Vladimir Medic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2014, 3:12 AM (296 w, 4 d)

Recent Activity

Feb 26 2015

vmedic committed rL230628: Replace obsolete -mattr=n64 command line option with -target-abi=n64. No….
Replace obsolete -mattr=n64 command line option with -target-abi=n64. No…
Feb 26 2015, 4:32 AM

Feb 25 2015

vmedic closed D7749: [Mips][Assembler]Enable multiple and add instructions for mips64 target.

Command line options committed revision 230482.
Other changes committed revision 230500.

Feb 25 2015, 7:27 AM
vmedic committed rL230500: [MIPS]Multiple and add instructions for Mips are currently available in….
[MIPS]Multiple and add instructions for Mips are currently available in…
Feb 25 2015, 7:26 AM
vmedic committed rL230482: Replace obsolete -mattr=n64 command line option with -target-abi=n64. No….
Replace obsolete -mattr=n64 command line option with -target-abi=n64. No…
Feb 25 2015, 3:45 AM
vmedic closed D6681: [MIPS][Disassembler][Test]Add missing disassembler tests for mips32 platform.

Committed r226408

Feb 25 2015, 3:20 AM

Feb 24 2015

vmedic added a parent revision for D7849: [Mips][AsmBackend] Use MCTargetOptions to decide between elf32/64 based on ABI: D6476: [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple..
Feb 24 2015, 1:54 AM
vmedic retitled D7849: [Mips][AsmBackend] Use MCTargetOptions to decide between elf32/64 based on ABI from to [Mips][AsmBackend] Use MCTargetOptions to decide between elf32/64 based on ABI.
Feb 24 2015, 1:53 AM
vmedic updated the diff for D6476: [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple..

The previous patch is split into two parts. This one contains changes to all targets and common code. Mips specific part will be moved to a separate patch.

Feb 24 2015, 1:49 AM
vmedic updated the diff for D7747: [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend.

MCTargetOptions instance is not initiated anymore using InitMCTargetOptionsFromFlags but newly defined method which uses AssemblerInvocation structure to populate fields from clang driver options.

Feb 24 2015, 1:47 AM

Feb 23 2015

vmedic added a comment to D7747: [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend.

Could we do that in a separate patch? I would prefer to submit this one without initialization with old fixme comment and commit it in order to get the abi working. In the next patch we can initialize MCtargetOptions from AssemblerInvocation(adding the fields we need in the structure).


From: Eric Christopher [echristo@gmail.com]
Sent: Friday, February 20, 2015 6:54 PM
To: reviews+D7747+public+d517a63d5c1d02a4@reviews.llvm.org; Vladimir Medic; Daniel Sanders
Cc: llvm-commits@cs.uiuc.edu
Subject: Re: [PATCH] [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend

Feb 23 2015, 9:31 AM

Feb 20 2015

vmedic added inline comments to D7747: [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend.
Feb 20 2015, 6:09 AM

Feb 19 2015

vmedic retitled D7749: [Mips][Assembler]Enable multiple and add instructions for mips64 target from to [Mips][Assembler]Enable multiple and add instructions for mips64 target.
Feb 19 2015, 4:06 AM
vmedic added a parent revision for D7747: [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend: D6476: [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple..
Feb 19 2015, 3:56 AM
vmedic retitled D7747: [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend from to [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend.
Feb 19 2015, 3:56 AM
vmedic updated the diff for D6476: [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple..

As suggested by Eric, ABI info is taken from MCTargetOptions which is passed to createAsmBackend method. Definitions of these methods for all targets have been extended with this parameter to keep the build sanity. For the Mips target ABI info is extracted to create elf32/64 object file. Also, the way that extracts the target triple information from ELF header is changed for Mips platform. This patch is followed with a necessary change in clang driver.

Feb 19 2015, 3:52 AM

Feb 18 2015

vmedic accepted D7381: [mips] Add backend support for Mips32r[35] and Mips64r[35]..

LGTM

Feb 18 2015, 7:49 AM

Feb 11 2015

vmedic abandoned D7461: [Mips][Disassembler] Add r6 tables to Mips64Disassembler checks.

Change abandoned as different approach has been implemented using http://reviews.llvm.org/D7498.

Feb 11 2015, 5:41 AM
vmedic accepted D7498: [mips] Merge disassemblers into a single implementation..

It makes sense to put triples as you did, it just wasn't clear without a comment. LGTM.

Feb 11 2015, 12:46 AM

Feb 10 2015

vmedic added inline comments to D7498: [mips] Merge disassemblers into a single implementation..
Feb 10 2015, 5:24 AM

Feb 6 2015

vmedic retitled D7461: [Mips][Disassembler] Add r6 tables to Mips64Disassembler checks from to [Mips][Disassembler] Add r6 tables to Mips64Disassembler checks.
Feb 6 2015, 2:11 AM

Feb 4 2015

vmedic requested review of D4776: Add fcc registers to c.cond.fmt instruction definition..
Feb 4 2015, 6:08 AM
vmedic abandoned D6092: The ELF container needs to depend on the ABI rather than the target triple..

Discussion moved to http://reviews.llvm.org/D6476

Feb 4 2015, 5:47 AM
vmedic accepted D7376: [mips] Remove unused check prefix from tests. NFC..

LGTM

Feb 4 2015, 5:45 AM
vmedic accepted D7377: [mips] Make MipsSubtarget::hasMips*() functions consistent. NFC..

LGTM

Feb 4 2015, 1:55 AM

Jan 30 2015

vmedic updated subscribers of D6091: Change clang driver to pass -target-abi option.
Jan 30 2015, 7:56 AM
vmedic requested review of D6091: Change clang driver to pass -target-abi option.

Please review the updated patch.

Jan 30 2015, 7:55 AM
vmedic updated the diff for D6091: Change clang driver to pass -target-abi option.

Patch is rebased to the TOT. Passing -target-feature o32,n32,n64 options is disabled to remove warnings.

Jan 30 2015, 7:46 AM
vmedic planned changes to D6091: Change clang driver to pass -target-abi option.
Jan 30 2015, 7:43 AM

Jan 29 2015

vmedic closed D6810: [Mips][Disassembler][R6] Disassembler crashes on cache/pref instructions for r6.

Suggested changes applied. Committed revision 227430.

Jan 29 2015, 3:35 AM
vmedic committed rL227430: [Mips][Disassembler] When disassembler meets cache/pref instructions for r6 it….
[Mips][Disassembler] When disassembler meets cache/pref instructions for r6 it…
Jan 29 2015, 3:35 AM

Jan 28 2015

vmedic updated the diff for D4776: Add fcc registers to c.cond.fmt instruction definition..

A bug in the previous version of the patch has been fixed. Disassembler tests are added, and corresponding cases from xfailed tests removed.

Jan 28 2015, 8:39 AM

Jan 26 2015

vmedic planned changes to D4776: Add fcc registers to c.cond.fmt instruction definition..

Revision reverted, changes required.

Jan 26 2015, 9:20 AM
vmedic closed D6817: [Mips][Disassembler][R6] Disassembler crashes on compact jump instructions for r6.

Trailing spaces removed. Committed revision 227084.

Jan 26 2015, 2:48 AM
vmedic committed rL227084: When disassembler meets compact jump instructions for r6 it crashes as the….
When disassembler meets compact jump instructions for r6 it crashes as the…
Jan 26 2015, 2:35 AM

Jan 21 2015

vmedic updated the diff for D6817: [Mips][Disassembler][R6] Disassembler crashes on compact jump instructions for r6.

Commented line removed.

Jan 21 2015, 3:38 AM
vmedic updated the diff for D6817: [Mips][Disassembler][R6] Disassembler crashes on compact jump instructions for r6.

Removed dedicated decoder method as suggested.

Jan 21 2015, 3:35 AM
vmedic closed D6816: [Mips][Disassembler][R6] Disassembler crashes on load/store from coprocessor 2 instructions for r6.

Committed revision 226652.

Jan 21 2015, 2:49 AM
vmedic committed rL226652: [Mips][Disassembler]When disassembler meets load/store from coprocessor 2….
[Mips][Disassembler]When disassembler meets load/store from coprocessor 2…
Jan 21 2015, 2:49 AM

Jan 15 2015

vmedic accepted D6997: [mips] Fix a typo in the compare patterns for MIPS32r6/MIPS64r6..

LGTM

Jan 15 2015, 6:31 AM
vmedic closed D6809: [MIPS][Disassembler][Test]Add missing disassembler tests for mips64r6 platform.

Committed revision 226166.

Jan 15 2015, 6:19 AM
vmedic committed rL226166: Add disassembler tests for mips64r6 platform. There are no functional changes..
Add disassembler tests for mips64r6 platform. There are no functional changes.
Jan 15 2015, 6:19 AM
vmedic committed rL226165: Add disassembler tests for mips32r6 platform. There are no functional changes..
Add disassembler tests for mips32r6 platform. There are no functional changes.
Jan 15 2015, 6:13 AM
vmedic closed D6782: [MIPS][Disassembler][Test]Add missing disassembler tests for mips32r6 platform.

Committed revision 226165.

Jan 15 2015, 6:13 AM
vmedic committed rL226164: Add disassembler tests for mips64r2 platform. There are no functional changes..
Add disassembler tests for mips64r2 platform. There are no functional changes.
Jan 15 2015, 6:08 AM
vmedic closed D6784: [MIPS][Disassembler][Test]Add missing disassembler tests for mips64r2 platform.

Committed revision 226164.

Jan 15 2015, 6:08 AM
vmedic closed D6783: [MIPS][Disassembler][Test]Add missing disassembler tests for mips64 platform.

Committed revision 226151.

Jan 15 2015, 12:51 AM
vmedic committed rL226151: Add disassembler tests for mips64 platform. There are no functional changes..
Add disassembler tests for mips64 platform. There are no functional changes.
Jan 15 2015, 12:51 AM

Jan 14 2015

vmedic closed D6641: [MIPS][Disassembler][Test]Add missing disassembler tests for mips3 platform.

Submitted revision r224253.

Jan 14 2015, 5:42 AM
vmedic committed rL225980: Add disassembler tests for mips32r2 platform. There are no functional changes..
Add disassembler tests for mips32r2 platform. There are no functional changes.
Jan 14 2015, 3:36 AM
vmedic updated the diff for D6681: [MIPS][Disassembler][Test]Add missing disassembler tests for mips32 platform.

Format changed as suggested.

Jan 14 2015, 2:34 AM
vmedic committed rL225967: Add disassembler tests for mips32r2 platform. There are no functional changes..
Add disassembler tests for mips32r2 platform. There are no functional changes.
Jan 14 2015, 2:20 AM
vmedic closed D6706: [MIPS][Disassembler][Test]Add missing disassembler tests for mips32r2 platform.

Committed revision 225980.

Jan 14 2015, 2:20 AM

Jan 13 2015

vmedic accepted D6610: [mips] Fix assertion on i128 addition/subtraction on MIPS64.

LGTM

Jan 13 2015, 6:32 AM

Jan 12 2015

vmedic added inline comments to D6476: [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple..
Jan 12 2015, 6:30 AM

Dec 31 2014

vmedic retitled D6817: [Mips][Disassembler][R6] Disassembler crashes on compact jump instructions for r6 from to [Mips][Disassembler][R6] Disassembler crashes on compact jump instructions for r6.
Dec 31 2014, 2:27 AM
vmedic retitled D6816: [Mips][Disassembler][R6] Disassembler crashes on load/store from coprocessor 2 instructions for r6 from to [Mips][Disassembler][R6] Disassembler crashes on load/store from coprocessor 2 instructions for r6.
Dec 31 2014, 1:45 AM

Dec 30 2014

vmedic retitled D6810: [Mips][Disassembler][R6] Disassembler crashes on cache/pref instructions for r6 from to [Mips][Disassembler][R6] Disassembler crashes on cache/pref instructions for r6.
Dec 30 2014, 4:55 AM
vmedic retitled D6809: [MIPS][Disassembler][Test]Add missing disassembler tests for mips64r6 platform from to [MIPS][Disassembler][Test]Add missing disassembler tests for mips64r6 platform.
Dec 30 2014, 12:29 AM

Dec 26 2014

vmedic retitled D6784: [MIPS][Disassembler][Test]Add missing disassembler tests for mips64r2 platform from to [MIPS][Disassembler][Test]Add missing disassembler tests for mips64r2 platform.
Dec 26 2014, 8:50 AM
vmedic retitled D6783: [MIPS][Disassembler][Test]Add missing disassembler tests for mips64 platform from to [MIPS][Disassembler][Test]Add missing disassembler tests for mips64 platform.
Dec 26 2014, 8:49 AM
vmedic retitled D6782: [MIPS][Disassembler][Test]Add missing disassembler tests for mips32r6 platform from to [MIPS][Disassembler][Test]Add missing disassembler tests for mips32r6 platform.
Dec 26 2014, 8:48 AM

Dec 25 2014

vmedic updated the diff for D6476: [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple..

Patch refactored according to previous comments.

Dec 25 2014, 3:24 AM

Dec 17 2014

vmedic retitled D6706: [MIPS][Disassembler][Test]Add missing disassembler tests for mips32r2 platform from to [MIPS][Disassembler][Test]Add missing disassembler tests for mips32r2 platform.
Dec 17 2014, 7:40 AM
vmedic closed D6662: [Mips] Move MipsABIInfo class to LLVMMipsDesc library.

Committed revision 224427.

Dec 17 2014, 3:51 AM
vmedic committed rL224427: MipsABIInfo class is used in different libraries. Moving the files to….
MipsABIInfo class is used in different libraries. Moving the files to…
Dec 17 2014, 3:51 AM

Dec 16 2014

vmedic retitled D6681: [MIPS][Disassembler][Test]Add missing disassembler tests for mips32 platform from to [MIPS][Disassembler][Test]Add missing disassembler tests for mips32 platform.
Dec 16 2014, 9:26 AM
vmedic closed D6660: [Mips][Disassembler] Disassembler checking N64 feature instead of GP64.

Committed revision 224339.

Dec 16 2014, 7:30 AM
vmedic committed rL224339: The single check for N64 inside MipsDisassemblerBase's subclasses is actually….
The single check for N64 inside MipsDisassemblerBase's subclasses is actually…
Dec 16 2014, 7:30 AM
vmedic closed D6658: [Mips][Disassembler][Test] mips4 disassembler tests.

Committed revision 224335.

Dec 16 2014, 5:03 AM
vmedic committed rL224335: Add disassembler tests for mips4 platform. There are no functional changes..
Add disassembler tests for mips4 platform. There are no functional changes.
Dec 16 2014, 5:03 AM

Dec 15 2014

vmedic retitled D6662: [Mips] Move MipsABIInfo class to LLVMMipsDesc library from to [Mips] Move MipsABIInfo class to LLVMMipsDesc library.
Dec 15 2014, 9:28 AM
vmedic retitled D6660: [Mips][Disassembler] Disassembler checking N64 feature instead of GP64 from to [Mips][Disassembler] Disassembler checking N64 feature instead of GP64.
Dec 15 2014, 9:20 AM
vmedic retitled D6658: [Mips][Disassembler][Test] mips4 disassembler tests from to [Mips][Disassembler][Test] mips4 disassembler tests.
Dec 15 2014, 8:45 AM
vmedic committed rL224253: Add disassembler tests for mips3 platform. There are no functional changes..
Add disassembler tests for mips3 platform. There are no functional changes.
Dec 15 2014, 8:20 AM
vmedic closed D6640: [MIPS][Disassembler][Test]Add missing disassembler tests for mips2 platform.

Committed revision 224252.

Dec 15 2014, 7:59 AM
vmedic committed rL224252: Add disassembler tests for mips2 platform. There are no functional changes..
Add disassembler tests for mips2 platform. There are no functional changes.
Dec 15 2014, 7:59 AM
vmedic closed D6639: [MIPS][Disassembler][Test]Add missing disassembler tests for mips1 platform.

Committed revision 224251.

Dec 15 2014, 7:23 AM
vmedic committed rL224251: This is the first in a series of patches that add missing disassembler tests….
This is the first in a series of patches that add missing disassembler tests…
Dec 15 2014, 7:23 AM

Dec 12 2014

vmedic updated subscribers of D6639: [MIPS][Disassembler][Test]Add missing disassembler tests for mips1 platform.
Dec 12 2014, 7:06 AM
vmedic added a parent revision for D6641: [MIPS][Disassembler][Test]Add missing disassembler tests for mips3 platform: D6640: [MIPS][Disassembler][Test]Add missing disassembler tests for mips2 platform.
Dec 12 2014, 7:05 AM
vmedic retitled D6641: [MIPS][Disassembler][Test]Add missing disassembler tests for mips3 platform from to [MIPS][Disassembler][Test]Add missing disassembler tests for mips3 platform.
Dec 12 2014, 7:05 AM
vmedic added a parent revision for D6640: [MIPS][Disassembler][Test]Add missing disassembler tests for mips2 platform: D6639: [MIPS][Disassembler][Test]Add missing disassembler tests for mips1 platform.
Dec 12 2014, 7:03 AM
vmedic retitled D6640: [MIPS][Disassembler][Test]Add missing disassembler tests for mips2 platform from to [MIPS][Disassembler][Test]Add missing disassembler tests for mips2 platform.
Dec 12 2014, 7:02 AM
vmedic retitled D6639: [MIPS][Disassembler][Test]Add missing disassembler tests for mips1 platform from to [MIPS][Disassembler][Test]Add missing disassembler tests for mips1 platform.
Dec 12 2014, 7:01 AM

Dec 2 2014

vmedic added a comment to D6476: [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple..

Daniel's comments from original issue(6092):
Thanks for working on this. It's very important that we stop our triples from affecting our targets behaviour (except in so far as they affect default option values).

Dec 2 2014, 1:15 AM
vmedic retitled D6476: [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple. from to [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple..
Dec 2 2014, 1:15 AM
vmedic accepted D6463: [mips] Fix passing of small structures for big-endian O32 ..

LGTM

Dec 2 2014, 1:06 AM

Dec 1 2014

vmedic closed D3338: Change subtract with immediate instruction alias to use existing instruction definition..
Dec 1 2014, 7:43 AM
vmedic closed D6413: Add disassembler support for micromips16 andi16, addiusp, jraddiusp instructions..

Committed revision 223006.

Dec 1 2014, 3:13 AM

Nov 27 2014

vmedic updated the diff for D6413: Add disassembler support for micromips16 andi16, addiusp, jraddiusp instructions..

Bug in DecodeSimm9SP code fixed, style remarks applied. Test cases for specific values added for both assembler and disassembler.

Nov 27 2014, 5:51 AM

Nov 26 2014

vmedic retitled D6413: Add disassembler support for micromips16 andi16, addiusp, jraddiusp instructions. from to Add disassembler support for micromips16 andi16, addiusp, jraddiusp instructions..
Nov 26 2014, 2:50 AM

Nov 21 2014

vmedic accepted D6213: [mips] Add Mips-specific CCIf's for accessing the MipsCCState. NFC..

LGTM

Nov 21 2014, 2:33 AM

Nov 20 2014

vmedic accepted D5815: [mips] Remove redundant code in RetCC_MipsN..

LGTM

Nov 20 2014, 4:12 AM
vmedic accepted D5814: [mips] For N32/N64, structs must be passed in the upper bits of a register..

LGTM

Nov 20 2014, 4:11 AM

Nov 19 2014

vmedic updated the diff for D6092: The ELF container needs to depend on the ABI rather than the target triple..

This is the patch that has been updated to the top of the tree with no functional changes. It is still missing the test files, but we'd like to keep it short at the time until the remaining issues are solved. We still looking where would it be the best to initialize and store the ABI info value so that it's accessible from codegen, the integrated assembler, and the disassembler. Also, selectMipsCPU is currently a member of MipsABIInfo class which is not a best logical place for it, but it is placed there to be visible to all calling classes to avoid code multiplication.

Nov 19 2014, 4:05 AM

Nov 17 2014

vmedic updated the diff for D6091: Change clang driver to pass -target-abi option.

Removed ABI field from AssemblerInvocation class. Added test cases for integrated assembler launch.

Nov 17 2014, 8:07 AM

Nov 13 2014

vmedic added inline comments to D6091: Change clang driver to pass -target-abi option.
Nov 13 2014, 6:38 AM
vmedic updated the diff for D6091: Change clang driver to pass -target-abi option.

A new method ClangAs::AddMIPSTargetArgs with -target-abi handling has been created. This method is called from ClangAs::ConstructJob to handle this particular task.

Nov 13 2014, 1:40 AM

Nov 6 2014

vmedic accepted D6083: [mips] Removed IsSoftFloat from MipsISelLowering::analyzeCallOperands(). NFC.

LGTM

Nov 6 2014, 7:58 AM
vmedic accepted D6081: [mips] Removed MipsISelLowering::analyzeFormalArguments() in favour of CCState::AnalyzeFormalArguments().

LGTM

Nov 6 2014, 7:42 AM