- User Since
- Feb 14 2014, 3:12 AM (296 w, 4 d)
Feb 26 2015
Feb 25 2015
Command line options committed revision 230482.
Other changes committed revision 230500.
Feb 24 2015
The previous patch is split into two parts. This one contains changes to all targets and common code. Mips specific part will be moved to a separate patch.
MCTargetOptions instance is not initiated anymore using InitMCTargetOptionsFromFlags but newly defined method which uses AssemblerInvocation structure to populate fields from clang driver options.
Feb 23 2015
Could we do that in a separate patch? I would prefer to submit this one without initialization with old fixme comment and commit it in order to get the abi working. In the next patch we can initialize MCtargetOptions from AssemblerInvocation(adding the fields we need in the structure).
From: Eric Christopher [email@example.com]
Sent: Friday, February 20, 2015 6:54 PM
To: reviews+D7747firstname.lastname@example.org; Vladimir Medic; Daniel Sanders
Subject: Re: [PATCH] [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend
Feb 20 2015
Feb 19 2015
As suggested by Eric, ABI info is taken from MCTargetOptions which is passed to createAsmBackend method. Definitions of these methods for all targets have been extended with this parameter to keep the build sanity. For the Mips target ABI info is extracted to create elf32/64 object file. Also, the way that extracts the target triple information from ELF header is changed for Mips platform. This patch is followed with a necessary change in clang driver.
Feb 18 2015
Feb 11 2015
Change abandoned as different approach has been implemented using http://reviews.llvm.org/D7498.
It makes sense to put triples as you did, it just wasn't clear without a comment. LGTM.
Feb 10 2015
Feb 6 2015
Feb 4 2015
Discussion moved to http://reviews.llvm.org/D6476
Jan 30 2015
Please review the updated patch.
Patch is rebased to the TOT. Passing -target-feature o32,n32,n64 options is disabled to remove warnings.
Jan 29 2015
Suggested changes applied. Committed revision 227430.
Jan 28 2015
A bug in the previous version of the patch has been fixed. Disassembler tests are added, and corresponding cases from xfailed tests removed.
Jan 26 2015
Revision reverted, changes required.
Trailing spaces removed. Committed revision 227084.
Jan 21 2015
Commented line removed.
Removed dedicated decoder method as suggested.
Committed revision 226652.
Jan 15 2015
Committed revision 226166.
Committed revision 226165.
Committed revision 226164.
Committed revision 226151.
Jan 14 2015
Submitted revision r224253.
Format changed as suggested.
Committed revision 225980.
Jan 13 2015
Jan 12 2015
Dec 31 2014
Dec 30 2014
Dec 26 2014
Dec 25 2014
Patch refactored according to previous comments.
Dec 17 2014
Committed revision 224427.
Dec 16 2014
Committed revision 224339.
Committed revision 224335.
Dec 15 2014
Committed revision 224252.
Committed revision 224251.
Dec 12 2014
Dec 2 2014
Daniel's comments from original issue(6092):
Thanks for working on this. It's very important that we stop our triples from affecting our targets behaviour (except in so far as they affect default option values).
Dec 1 2014
Committed revision 223006.
Nov 27 2014
Bug in DecodeSimm9SP code fixed, style remarks applied. Test cases for specific values added for both assembler and disassembler.
Nov 26 2014
Nov 21 2014
Nov 20 2014
Nov 19 2014
This is the patch that has been updated to the top of the tree with no functional changes. It is still missing the test files, but we'd like to keep it short at the time until the remaining issues are solved. We still looking where would it be the best to initialize and store the ABI info value so that it's accessible from codegen, the integrated assembler, and the disassembler. Also, selectMipsCPU is currently a member of MipsABIInfo class which is not a best logical place for it, but it is placed there to be visible to all calling classes to avoid code multiplication.
Nov 17 2014
Removed ABI field from AssemblerInvocation class. Added test cases for integrated assembler launch.
Nov 13 2014
A new method ClangAs::AddMIPSTargetArgs with -target-abi handling has been created. This method is called from ClangAs::ConstructJob to handle this particular task.
Nov 6 2014