User Details
User Details
- User Since
- Jan 20 2014, 12:15 AM (487 w, 5 d)
Mar 18 2015
Mar 18 2015
sstankovic updated the diff for D5209: [mips] Fix the position of the .loc prologue_end directive in cases when the generated code contains DBG_VALUE instruction..
Is there anything else that needs to be done for this patch?
Feb 27 2015
Feb 27 2015
sstankovic added a comment to D7934: [mips][microMIPS] Change register class for GP register.
LGTM
Feb 25 2015
Feb 25 2015
sstankovic added a comment to D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue.
LGTM
Feb 19 2015
Feb 19 2015
sstankovic added a comment to D7672: [mips] Honour -mno-odd-spreg for vector insert/extract when MSA is enabled..
LGTM
Feb 18 2015
Feb 18 2015
sstankovic added a comment to D5047: [mips][microMIPS] Implement JALX instruction.
LGTM
Feb 12 2015
Feb 12 2015
sstankovic updated the diff for D5209: [mips] Fix the position of the .loc prologue_end directive in cases when the generated code contains DBG_VALUE instruction..
Removed the unnecessary cast.
Feb 6 2015
Feb 6 2015
sstankovic updated the diff for D5209: [mips] Fix the position of the .loc prologue_end directive in cases when the generated code contains DBG_VALUE instruction..
Rebased the patch. Created new method MipsInstrInfo::getDebugLoc().
Feb 4 2015
Feb 4 2015
sstankovic added a comment to D6581: [mips][microMIPS] Implement CodeGen support for SW16 and LW16 instructions.
LGTM, with additional comment.
Jan 28 2015
Jan 28 2015
sstankovic added a comment to D6650: [mips][microMIPS] Implement LWGP instruction.
LGTM
Jan 27 2015
Jan 27 2015
sstankovic added inline comments to D6650: [mips][microMIPS] Implement LWGP instruction.
Jan 26 2015
Jan 26 2015
sstankovic added a comment to D5820: [mips][microMIPS] Implement SWM and LWM aliases.
LGTM
Jan 22 2015
Jan 22 2015
sstankovic added inline comments to D5820: [mips][microMIPS] Implement SWM and LWM aliases.
Jan 20 2015
Jan 20 2015
sstankovic added a comment to D6582: [mips][microMIPS] Implement ADDIUPC instruction.
LGTM, with a change.
sstankovic added a comment to D3514: MicroMIPS 16-bit unconditional branch instruction B.
LGTM
Jan 13 2015
Jan 13 2015
sstankovic added a comment to D6815: [mips][microMIPS] Fix issue with 16b instructions in jr instruction delay slot.
LGTM
Jan 12 2015
Jan 12 2015
sstankovic added a comment to D5271: [mips][microMIPS] Implement BEQZ16 and BNEZ16 instructions.
LGTM
Dec 30 2014
Dec 30 2014
sstankovic added inline comments to D5271: [mips][microMIPS] Implement BEQZ16 and BNEZ16 instructions.
sstankovic added a comment to D6796: [mips][microMIPS] Relocate with symbol for micromips function symbols.
LGTM, with a change.
sstankovic added inline comments to D6796: [mips][microMIPS] Relocate with symbol for micromips function symbols.
Dec 26 2014
Dec 26 2014
sstankovic added inline comments to D3514: MicroMIPS 16-bit unconditional branch instruction B.
Dec 23 2014
Dec 23 2014
sstankovic added a comment to D5204: [mips][microMIPS] Implement CACHE, PREF, SSNOP, EHB and PAUSE instructions.
LGTM
sstankovic added a comment to D6416: [mips][microMIPS] Implement LWSP and SWSP instructions.
LGTM
sstankovic added a comment to D5204: [mips][microMIPS] Implement CACHE, PREF, SSNOP, EHB and PAUSE instructions.
Please include disassembler tests in the patch.
sstankovic added a comment to D6416: [mips][microMIPS] Implement LWSP and SWSP instructions.
This patch doesn't correctly handle the case when (offset % 4) != 0. For example, for the following instruction
Dec 22 2014
Dec 22 2014
sstankovic added a comment to D6718: [mips] Don't emit redundant mask instructions if the mask is already present..
Is there a MIPS breakpoint/trap instruction that would work here?
Dec 18 2014
Dec 18 2014
sstankovic added a comment to D6718: [mips] Don't emit redundant mask instructions if the mask is already present..
Yes. Currently two tests fail because of the redundant sandboxing - syscall_return_sandboxing_test and exception_test. For syscall_return_sandboxing_test, to make the test pass we can either remove sandboxing from the assembly, or apply this patch. For exception test, neither removing the sandboxing nor applying the patch will work. Here is the problematic inline assembly from exception_test.c file:
sstankovic added a comment to D6659: [mips][microMIPS] Fix bugs related to atomic SC/LL instructions.
LGTM
sstankovic retitled D6718: [mips] Don't emit redundant mask instructions if the mask is already present. from to [mips] Don't emit redundant mask instructions if the mask is already present..
Dec 16 2014
Dec 16 2014
sstankovic added a comment to D5667: [mips][microMIPS] Implement SWP and LWP instructions.
LGTM
Dec 11 2014
Dec 11 2014
sstankovic added a comment to D5840: [mips][microMIPS] Implement CodeGen support for LI16 instruction.
LGTM
Nov 28 2014
Nov 28 2014
sstankovic added a comment to D6440: [mips][microMIPS] Implement NOP aliases.
LGTM
sstankovic added inline comments to D6416: [mips][microMIPS] Implement LWSP and SWSP instructions.
Nov 27 2014
Nov 27 2014
sstankovic added a comment to D6413: Add disassembler support for micromips16 andi16, addiusp, jraddiusp instructions..
LGTM, with two changes.
sstankovic added a comment to D5579: [mips][microMIPS] Implement SWM16 and LWM16 instructions.
LGTM, with two changes.
sstankovic added a comment to D6419: [mips][microMIPS] Implement disassembler support for 16-bit instructions LI16, ADDIUR1SP, ADDIUR2 and ADDIUS5.
LGTM
sstankovic added inline comments to D6413: Add disassembler support for micromips16 andi16, addiusp, jraddiusp instructions..
Nov 26 2014
Nov 26 2014
sstankovic added a comment to D6405: [mips][microMIPS] Implement disassembler support for 16-bit instructions LBU16, LHU16, LW16, SB16, SH16 and SW16.
LGTM
Nov 25 2014
Nov 25 2014
sstankovic added inline comments to D5667: [mips][microMIPS] Implement SWP and LWP instructions.
Nov 24 2014
Nov 24 2014
sstankovic added a comment to D6365: [mips][microMIPS] Fix JRADDIUSP instruction.
LGTM
sstankovic added a comment to D5122: [mips][microMIPS] Implement LBU16, LHU16, LW16, SB16, SH16 and SW16 instructions.
LGTM, with 2 changes.
sstankovic added a comment to D6149: [mips][microMIPS] Implement disassembler support for 16-bit instructions.
LGTM, with 3 changes.
Nov 21 2014
Nov 21 2014
sstankovic added a comment to D6338: [mips][microMIPS] Use call instructions with short delay slots.
LGTM, with two changes.
Nov 18 2014
Nov 18 2014
sstankovic added a comment to D5579: [mips][microMIPS] Implement SWM16 and LWM16 instructions.
For the following illegal instructions the error is not reported:
sstankovic added a comment to D5519: [mips][microMIPS] Implement SWM32 and LWM32 instructions.
LGTM
Nov 17 2014
Nov 17 2014
sstankovic added inline comments to D6149: [mips][microMIPS] Implement disassembler support for 16-bit instructions.
Nov 14 2014
Nov 14 2014
sstankovic added inline comments to D5295: [mips][microMIPS] Implement ADDIUPC instruction.
Nov 13 2014
Nov 13 2014
sstankovic added a comment to D5048: [mips][microMIPS] Implement BREAK16 and SDBBP16 instructions.
LGTM
Nov 12 2014
Nov 12 2014
sstankovic added a comment to D5407: [mips][microMIPS] Implement LWXS instruction.
LGTM
sstankovic added a comment to D6169: [mips][microMIPS] Fix opcodes of MFHC1 and MTHC1 instructions.
LGTM, with two changes.
sstankovic added a comment to D5240: [mips][microMIPS] Implement SDBBP and RDHWR instructions.
LGTM
sstankovic added a comment to D6198: [mips][micromips] Add predicate 'InMicroMips' at CodeGen patterns for microMIPS instructions.
LGTM. You may optionally add a comment in the test file that this test checks that encoding for srl is correct when fast-isel for mips32 is used.
Nov 10 2014
Nov 10 2014
sstankovic added inline comments to D5579: [mips][microMIPS] Implement SWM16 and LWM16 instructions.
sstankovic added a comment to D6193: Fix issue with delay slot filler and microMIPS.
LGTM
Nov 6 2014
Nov 6 2014
sstankovic closed D4903: [mips] Add the following MIPS options that control gp-relative addressing of small data items: -mgpopt, -mlocal-sdata, -mextern-sdata..
Closed by commit rL221450 (authored by @sstankovic).
sstankovic added inline comments to D5519: [mips][microMIPS] Implement SWM32 and LWM32 instructions.
Nov 5 2014
Nov 5 2014
sstankovic added a comment to D6039: [mips][microMIPS] Mark symbols as microMIPS if necessary.
LGTM, with two changes.
Nov 4 2014
Nov 4 2014
sstankovic abandoned D4069: Don't access items in .sdata section using gp-relative addressing when target is NaCl..
Implemented in D4903.
Oct 30 2014
Oct 30 2014
sstankovic added inline comments to D3789: [mips][microMIPS] Mark symbols as microMIPS if necessary.
Oct 28 2014
Oct 28 2014