Page MenuHomePhabricator

sstankovic (Sasa Stankovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2014, 12:15 AM (287 w, 1 d)

Recent Activity

Mar 18 2015

sstankovic updated the diff for D5209: [mips] Fix the position of the .loc prologue_end directive in cases when the generated code contains DBG_VALUE instruction..

Is there anything else that needs to be done for this patch?

Mar 18 2015, 4:12 AM

Feb 27 2015

sstankovic accepted D7934: [mips][microMIPS] Change register class for GP register.
Feb 27 2015, 1:48 AM
sstankovic added a comment to D7934: [mips][microMIPS] Change register class for GP register.

LGTM

Feb 27 2015, 1:48 AM

Feb 25 2015

sstankovic accepted D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue.
Feb 25 2015, 10:51 PM
sstankovic added a comment to D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue.

LGTM

Feb 25 2015, 10:51 PM

Feb 19 2015

sstankovic accepted D7672: [mips] Honour -mno-odd-spreg for vector insert/extract when MSA is enabled..
Feb 19 2015, 6:06 AM
sstankovic added a comment to D7672: [mips] Honour -mno-odd-spreg for vector insert/extract when MSA is enabled..

LGTM

Feb 19 2015, 6:06 AM

Feb 18 2015

sstankovic accepted D5047: [mips][microMIPS] Implement JALX instruction.
Feb 18 2015, 8:47 AM
sstankovic added a comment to D5047: [mips][microMIPS] Implement JALX instruction.

LGTM

Feb 18 2015, 8:47 AM

Feb 12 2015

sstankovic updated the diff for D5209: [mips] Fix the position of the .loc prologue_end directive in cases when the generated code contains DBG_VALUE instruction..

Removed the unnecessary cast.

Feb 12 2015, 1:11 AM

Feb 6 2015

sstankovic updated the diff for D5209: [mips] Fix the position of the .loc prologue_end directive in cases when the generated code contains DBG_VALUE instruction..

Rebased the patch. Created new method MipsInstrInfo::getDebugLoc().

Feb 6 2015, 3:30 AM

Feb 4 2015

sstankovic accepted D6581: [mips][microMIPS] Implement CodeGen support for SW16 and LW16 instructions.
Feb 4 2015, 2:10 AM
sstankovic added a comment to D6581: [mips][microMIPS] Implement CodeGen support for SW16 and LW16 instructions.

LGTM, with additional comment.

Feb 4 2015, 2:10 AM

Jan 28 2015

sstankovic accepted D6650: [mips][microMIPS] Implement LWGP instruction.
Jan 28 2015, 7:58 AM
sstankovic added a comment to D6650: [mips][microMIPS] Implement LWGP instruction.

LGTM

Jan 28 2015, 7:58 AM

Jan 27 2015

sstankovic added inline comments to D6650: [mips][microMIPS] Implement LWGP instruction.
Jan 27 2015, 1:04 AM

Jan 26 2015

sstankovic accepted D5820: [mips][microMIPS] Implement SWM and LWM aliases.
Jan 26 2015, 8:44 AM
sstankovic added a comment to D5820: [mips][microMIPS] Implement SWM and LWM aliases.

LGTM

Jan 26 2015, 8:44 AM

Jan 22 2015

sstankovic added inline comments to D5820: [mips][microMIPS] Implement SWM and LWM aliases.
Jan 22 2015, 5:38 AM

Jan 20 2015

sstankovic accepted D6582: [mips][microMIPS] Implement ADDIUPC instruction.
Jan 20 2015, 8:24 AM
sstankovic added a comment to D6582: [mips][microMIPS] Implement ADDIUPC instruction.

LGTM, with a change.

Jan 20 2015, 8:24 AM
sstankovic accepted D3514: MicroMIPS 16-bit unconditional branch instruction B.
Jan 20 2015, 6:31 AM
sstankovic added a comment to D3514: MicroMIPS 16-bit unconditional branch instruction B.

LGTM

Jan 20 2015, 6:30 AM

Jan 13 2015

sstankovic accepted D6815: [mips][microMIPS] Fix issue with 16b instructions in jr instruction delay slot.
Jan 13 2015, 7:12 AM
sstankovic added a comment to D6815: [mips][microMIPS] Fix issue with 16b instructions in jr instruction delay slot.

LGTM

Jan 13 2015, 7:11 AM

Jan 12 2015

sstankovic accepted D5271: [mips][microMIPS] Implement BEQZ16 and BNEZ16 instructions.
Jan 12 2015, 3:05 AM
sstankovic added a comment to D5271: [mips][microMIPS] Implement BEQZ16 and BNEZ16 instructions.

LGTM

Jan 12 2015, 3:05 AM

Dec 30 2014

sstankovic added inline comments to D5271: [mips][microMIPS] Implement BEQZ16 and BNEZ16 instructions.
Dec 30 2014, 8:41 AM
sstankovic accepted D6796: [mips][microMIPS] Relocate with symbol for micromips function symbols.
Dec 30 2014, 7:23 AM
sstankovic added a comment to D6796: [mips][microMIPS] Relocate with symbol for micromips function symbols.

LGTM, with a change.

Dec 30 2014, 7:22 AM
sstankovic added inline comments to D6796: [mips][microMIPS] Relocate with symbol for micromips function symbols.
Dec 30 2014, 5:35 AM

Dec 26 2014

sstankovic added inline comments to D3514: MicroMIPS 16-bit unconditional branch instruction B.
Dec 26 2014, 7:05 AM
sstankovic abandoned D6718: [mips] Don't emit redundant mask instructions if the mask is already present..
Dec 26 2014, 5:08 AM

Dec 23 2014

sstankovic accepted D5204: [mips][microMIPS] Implement CACHE, PREF, SSNOP, EHB and PAUSE instructions.
Dec 23 2014, 9:35 AM
sstankovic added a comment to D5204: [mips][microMIPS] Implement CACHE, PREF, SSNOP, EHB and PAUSE instructions.

LGTM

Dec 23 2014, 9:34 AM
sstankovic accepted D6416: [mips][microMIPS] Implement LWSP and SWSP instructions.
Dec 23 2014, 7:22 AM
sstankovic added a comment to D6416: [mips][microMIPS] Implement LWSP and SWSP instructions.

LGTM

Dec 23 2014, 7:21 AM
sstankovic added a comment to D5204: [mips][microMIPS] Implement CACHE, PREF, SSNOP, EHB and PAUSE instructions.

Please include disassembler tests in the patch.

Dec 23 2014, 3:56 AM
sstankovic added a comment to D6416: [mips][microMIPS] Implement LWSP and SWSP instructions.

This patch doesn't correctly handle the case when (offset % 4) != 0. For example, for the following instruction

Dec 23 2014, 3:06 AM

Dec 22 2014

sstankovic added a comment to D6718: [mips] Don't emit redundant mask instructions if the mask is already present..

Is there a MIPS breakpoint/trap instruction that would work here?

Dec 22 2014, 3:46 AM

Dec 18 2014

sstankovic added a comment to D6718: [mips] Don't emit redundant mask instructions if the mask is already present..

Yes. Currently two tests fail because of the redundant sandboxing - syscall_return_sandboxing_test and exception_test. For syscall_return_sandboxing_test, to make the test pass we can either remove sandboxing from the assembly, or apply this patch. For exception test, neither removing the sandboxing nor applying the patch will work. Here is the problematic inline assembly from exception_test.c file:

Dec 18 2014, 1:49 PM
sstankovic accepted D6659: [mips][microMIPS] Fix bugs related to atomic SC/LL instructions.
Dec 18 2014, 8:01 AM
sstankovic added a comment to D6659: [mips][microMIPS] Fix bugs related to atomic SC/LL instructions.

LGTM

Dec 18 2014, 8:00 AM
sstankovic retitled D6718: [mips] Don't emit redundant mask instructions if the mask is already present. from to [mips] Don't emit redundant mask instructions if the mask is already present..
Dec 18 2014, 3:14 AM

Dec 16 2014

sstankovic accepted D5667: [mips][microMIPS] Implement SWP and LWP instructions.
Dec 16 2014, 3:52 AM
sstankovic added a comment to D5667: [mips][microMIPS] Implement SWP and LWP instructions.

LGTM

Dec 16 2014, 3:52 AM

Dec 11 2014

sstankovic accepted D5840: [mips][microMIPS] Implement CodeGen support for LI16 instruction.
Dec 11 2014, 5:13 AM
sstankovic added a comment to D5840: [mips][microMIPS] Implement CodeGen support for LI16 instruction.

LGTM

Dec 11 2014, 5:13 AM

Nov 28 2014

sstankovic accepted D6440: [mips][microMIPS] Implement NOP aliases.
Nov 28 2014, 1:52 PM
sstankovic added a comment to D6440: [mips][microMIPS] Implement NOP aliases.

LGTM

Nov 28 2014, 1:52 PM
sstankovic added inline comments to D6416: [mips][microMIPS] Implement LWSP and SWSP instructions.
Nov 28 2014, 4:39 AM

Nov 27 2014

sstankovic accepted D6413: Add disassembler support for micromips16 andi16, addiusp, jraddiusp instructions..
Nov 27 2014, 7:56 AM
sstankovic added a comment to D6413: Add disassembler support for micromips16 andi16, addiusp, jraddiusp instructions..

LGTM, with two changes.

Nov 27 2014, 7:56 AM
sstankovic accepted D5579: [mips][microMIPS] Implement SWM16 and LWM16 instructions.
Nov 27 2014, 6:28 AM
sstankovic added a comment to D5579: [mips][microMIPS] Implement SWM16 and LWM16 instructions.

LGTM, with two changes.

Nov 27 2014, 6:27 AM
sstankovic accepted D6419: [mips][microMIPS] Implement disassembler support for 16-bit instructions LI16, ADDIUR1SP, ADDIUR2 and ADDIUS5.
Nov 27 2014, 5:55 AM
sstankovic added a comment to D6419: [mips][microMIPS] Implement disassembler support for 16-bit instructions LI16, ADDIUR1SP, ADDIUR2 and ADDIUS5.

LGTM

Nov 27 2014, 5:55 AM
sstankovic added inline comments to D6419: [mips][microMIPS] Implement disassembler support for 16-bit instructions LI16, ADDIUR1SP, ADDIUR2 and ADDIUS5.
Nov 27 2014, 4:43 AM
sstankovic added inline comments to D6413: Add disassembler support for micromips16 andi16, addiusp, jraddiusp instructions..
Nov 27 2014, 2:41 AM

Nov 26 2014

sstankovic accepted D6405: [mips][microMIPS] Implement disassembler support for 16-bit instructions LBU16, LHU16, LW16, SB16, SH16 and SW16.
Nov 26 2014, 9:56 AM
sstankovic added a comment to D6405: [mips][microMIPS] Implement disassembler support for 16-bit instructions LBU16, LHU16, LW16, SB16, SH16 and SW16.

LGTM

Nov 26 2014, 9:56 AM
sstankovic added inline comments to D6405: [mips][microMIPS] Implement disassembler support for 16-bit instructions LBU16, LHU16, LW16, SB16, SH16 and SW16.
Nov 26 2014, 8:27 AM

Nov 25 2014

sstankovic added inline comments to D5667: [mips][microMIPS] Implement SWP and LWP instructions.
Nov 25 2014, 8:07 AM

Nov 24 2014

sstankovic accepted D6365: [mips][microMIPS] Fix JRADDIUSP instruction.
Nov 24 2014, 7:36 AM
sstankovic added a comment to D6365: [mips][microMIPS] Fix JRADDIUSP instruction.

LGTM

Nov 24 2014, 7:36 AM
sstankovic accepted D5122: [mips][microMIPS] Implement LBU16, LHU16, LW16, SB16, SH16 and SW16 instructions.
Nov 24 2014, 6:05 AM
sstankovic added a comment to D5122: [mips][microMIPS] Implement LBU16, LHU16, LW16, SB16, SH16 and SW16 instructions.

LGTM, with 2 changes.

Nov 24 2014, 6:05 AM
sstankovic accepted D6149: [mips][microMIPS] Implement disassembler support for 16-bit instructions.
Nov 24 2014, 4:30 AM
sstankovic added a comment to D6149: [mips][microMIPS] Implement disassembler support for 16-bit instructions.

LGTM, with 3 changes.

Nov 24 2014, 4:30 AM

Nov 21 2014

sstankovic accepted D6338: [mips][microMIPS] Use call instructions with short delay slots.
Nov 21 2014, 9:03 AM
sstankovic added a comment to D6338: [mips][microMIPS] Use call instructions with short delay slots.

LGTM, with two changes.

Nov 21 2014, 9:02 AM

Nov 18 2014

sstankovic added a comment to D5579: [mips][microMIPS] Implement SWM16 and LWM16 instructions.

For the following illegal instructions the error is not reported:

Nov 18 2014, 4:39 AM
sstankovic accepted D5519: [mips][microMIPS] Implement SWM32 and LWM32 instructions.
Nov 18 2014, 3:03 AM
sstankovic added a comment to D5519: [mips][microMIPS] Implement SWM32 and LWM32 instructions.

LGTM

Nov 18 2014, 3:03 AM

Nov 17 2014

sstankovic added inline comments to D6149: [mips][microMIPS] Implement disassembler support for 16-bit instructions.
Nov 17 2014, 9:51 AM

Nov 14 2014

sstankovic accepted D5413: [mips][microMIPS] Disassembler tests for LWXS, BGEZALS, BLTZALS, BEQZC, BNEZC, JALS and JALRS instructions.
Nov 14 2014, 9:50 AM
sstankovic added inline comments to D5413: [mips][microMIPS] Disassembler tests for LWXS, BGEZALS, BLTZALS, BEQZC, BNEZC, JALS and JALRS instructions.
Nov 14 2014, 9:49 AM
sstankovic added inline comments to D5413: [mips][microMIPS] Disassembler tests for LWXS, BGEZALS, BLTZALS, BEQZC, BNEZC, JALS and JALRS instructions.
Nov 14 2014, 9:43 AM
sstankovic added a reviewer for D5295: [mips][microMIPS] Implement ADDIUPC instruction: sstankovic.
Nov 14 2014, 5:49 AM
sstankovic added inline comments to D5295: [mips][microMIPS] Implement ADDIUPC instruction.
Nov 14 2014, 5:45 AM

Nov 13 2014

sstankovic accepted D5048: [mips][microMIPS] Implement BREAK16 and SDBBP16 instructions.
Nov 13 2014, 4:53 AM
sstankovic added a comment to D5048: [mips][microMIPS] Implement BREAK16 and SDBBP16 instructions.

LGTM

Nov 13 2014, 4:53 AM

Nov 12 2014

sstankovic accepted D5407: [mips][microMIPS] Implement LWXS instruction.
Nov 12 2014, 9:33 AM
sstankovic added a comment to D5407: [mips][microMIPS] Implement LWXS instruction.

LGTM

Nov 12 2014, 9:32 AM
sstankovic accepted D6169: [mips][microMIPS] Fix opcodes of MFHC1 and MTHC1 instructions.
Nov 12 2014, 7:38 AM
sstankovic added a comment to D6169: [mips][microMIPS] Fix opcodes of MFHC1 and MTHC1 instructions.

LGTM, with two changes.

Nov 12 2014, 7:38 AM
sstankovic accepted D5240: [mips][microMIPS] Implement SDBBP and RDHWR instructions.
Nov 12 2014, 6:24 AM
sstankovic added a comment to D5240: [mips][microMIPS] Implement SDBBP and RDHWR instructions.

LGTM

Nov 12 2014, 6:23 AM
sstankovic accepted D6198: [mips][micromips] Add predicate 'InMicroMips' at CodeGen patterns for microMIPS instructions.
Nov 12 2014, 4:29 AM
sstankovic added a comment to D6198: [mips][micromips] Add predicate 'InMicroMips' at CodeGen patterns for microMIPS instructions.

LGTM. You may optionally add a comment in the test file that this test checks that encoding for srl is correct when fast-isel for mips32 is used.

Nov 12 2014, 4:29 AM

Nov 10 2014

sstankovic added inline comments to D5579: [mips][microMIPS] Implement SWM16 and LWM16 instructions.
Nov 10 2014, 9:56 AM
sstankovic accepted D6193: Fix issue with delay slot filler and microMIPS.
Nov 10 2014, 8:46 AM
sstankovic added a comment to D6193: Fix issue with delay slot filler and microMIPS.

LGTM

Nov 10 2014, 8:45 AM

Nov 6 2014

sstankovic closed D4903: [mips] Add the following MIPS options that control gp-relative addressing of small data items: -mgpopt, -mlocal-sdata, -mextern-sdata..

Closed by commit rL221450 (authored by @sstankovic).

Nov 6 2014, 5:31 AM
sstankovic added inline comments to D5519: [mips][microMIPS] Implement SWM32 and LWM32 instructions.
Nov 6 2014, 3:06 AM

Nov 5 2014

sstankovic accepted D6039: [mips][microMIPS] Mark symbols as microMIPS if necessary.
Nov 5 2014, 4:13 AM
sstankovic added a comment to D6039: [mips][microMIPS] Mark symbols as microMIPS if necessary.

LGTM, with two changes.

Nov 5 2014, 4:13 AM

Nov 4 2014

sstankovic abandoned D4069: Don't access items in .sdata section using gp-relative addressing when target is NaCl..

Implemented in D4903.

Nov 4 2014, 3:34 PM

Oct 30 2014

sstankovic added inline comments to D3789: [mips][microMIPS] Mark symbols as microMIPS if necessary.
Oct 30 2014, 1:17 AM

Oct 28 2014

sstankovic accepted D5933: [mips][microMIPS] Implement CodeGen support for SLL16 and SRL16 instructions.
Oct 28 2014, 9:06 AM