This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Revert "Protect users from relying on detail headers" & related changes
ClosedPublic

Authored by ldionne on Feb 28 2022, 1:47 PM.

Details

Reviewers
jdoerfert
Group Reviewers
Restricted Project
Restricted Project
Commits
rG368faacac752: [libc++] Revert "Protect users from relying on detail headers" & related changes
Summary

This commit reverts 5aaefa51 (and also partly 7f285f48e77 and b6d75682f9,
which were related to the original commit). As landed, 5aaefa51 had
unintended consequences on some downstream bots and didn't have proper
coverage upstream due to a few subtle things. Implementing this is
something we should do in libc++, however we'll first need to address
a few issues listed in https://reviews.llvm.org/D106124#3349710.

Diff Detail

Event Timeline

ldionne created this revision.Feb 28 2022, 1:47 PM
ldionne requested review of this revision.Feb 28 2022, 1:47 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision as: Restricted Project, Restricted Project.Feb 28 2022, 1:47 PM

I'll land this if CI is green.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2022, 5:21 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
libcxx/utils/generate_private_header_tests.py